List Info

Thread: CR: These changes are needed to get the HEAD (Atlas) code to work on Symbian 9.1 AR




CR: These changes are needed to get the HEAD (Atlas) code to work on Symbian 9.1 AR
country flaguser name
India
2007-02-27 06:04:52
Synopsis:
Changes are required to remove build errors.

Overview:
These changes are needed to get the HEAD (Atlas) code to
work on Symbian 
9.1 ARM Device

Files Added:
None

Files Modified:
symbiancommon/pub/chxavutil.h
symbiancommon/pub/chxsmartptr.h
symbiancommon/pub/comptr.h
symbianplayer/symbian.pcf
symbianplayer/platform/symbian/chxavaccesspointdb.cpp
symbianplayer/platform/symbian/chxaveditplaylistdialog.cpp
symbianplayer/platform/symbian/chxavfileviewpageinfo.cpp
symbianplayer/platform/symbian/chxavnavipanecontrol.cpp
symbianplayer/platform/symbian/chxavplayerui.cpp
symbianplayer/platform/symbian/chxavsettingsviewwindow.cpp
symbianplayer/platform/symbian/chxclientenginemanager.cpp
symbianplayer/platform/symbian/file/chxavfileutil.cpp
symbianplayer/platform/symbian/file/pub/chxavfileutil.h

Image Size and Heap Use impact (Client -Only):
None.

Platforms and Profiles Affected:
symbian-91

Distribution Libraries Affected:
None

Distribution library impact and planned action:
None

Platforms and Profiles Build Verified:

BIF branch  -> helix_restricted
Target(s) -> symbianinst
Profile -> helix-client-s60-advanced
SYSTEM_ID-> symbian-91-armv5-gcce

Branch:
HEAD

Files Attached:
clientapps.diff

Regards,
Gurpreet

_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev

  
RE: CR: These changes are needed to get the HEAD (Atlas) code to work on Symbian 9.
country flaguser name
United States
2007-02-27 08:58:35
--- symbiancommon/pub/comptr.h	4 Feb 2004 01:47:09
-0000	1.10
+++ symbiancommon/pub/comptr.h	27 Feb 2007 10:56:30 -0000
 -37,7
+37,7 
 struct IIDTraits
 {
     // missing #include "comptr_traits.h"?
missing trait in
"comptr_traits.h"?
-    static inline IID_RETTYPE riid() { return
missing_trait_definition; }
+    static inline IID_RETTYPE riid() { return IID_NULL; }
 };
 

What will this do? Will not having this guid
cause anything not to work? Or are you going
to deal with that later?


Rest looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: clientapps-dev-bounceshelixcommunity.org 
> [mailto:clientapps-dev-bounceshelixcommunity.org] On
Behalf 
> Of Gurpreet
> Sent: Tuesday, February 27, 2007 7:05 AM
> To: porting-symbianhelixcommunity.org
> Cc: clientapps-dev
> Subject: [Clientapps-dev] CR: These changes are needed
to get 
> the HEAD (Atlas) code to work on Symbian 9.1 ARM Device

> 
> Synopsis:
> Changes are required to remove build errors.
> 
> Overview:
> These changes are needed to get the HEAD (Atlas) code
to work 
> on Symbian 
> 9.1 ARM Device
> 
> Files Added:
> None
> 
> Files Modified:
> symbiancommon/pub/chxavutil.h
> symbiancommon/pub/chxsmartptr.h
> symbiancommon/pub/comptr.h
> symbianplayer/symbian.pcf
> symbianplayer/platform/symbian/chxavaccesspointdb.cpp
>
symbianplayer/platform/symbian/chxaveditplaylistdialog.cpp
>
symbianplayer/platform/symbian/chxavfileviewpageinfo.cpp
>
symbianplayer/platform/symbian/chxavnavipanecontrol.cpp
> symbianplayer/platform/symbian/chxavplayerui.cpp
>
symbianplayer/platform/symbian/chxavsettingsviewwindow.cpp
>
symbianplayer/platform/symbian/chxclientenginemanager.cpp
> symbianplayer/platform/symbian/file/chxavfileutil.cpp
>
symbianplayer/platform/symbian/file/pub/chxavfileutil.h
> 
> Image Size and Heap Use impact (Client -Only):
> None.
> 
> Platforms and Profiles Affected:
> symbian-91
> 
> Distribution Libraries Affected:
> None
> 
> Distribution library impact and planned action:
> None
> 
> Platforms and Profiles Build Verified:
> 
> BIF branch  -> helix_restricted
> Target(s) -> symbianinst
> Profile -> helix-client-s60-advanced
> SYSTEM_ID-> symbian-91-armv5-gcce
> 
> Branch:
> HEAD
> 
> Files Attached:
> clientapps.diff
> 
> Regards,
> Gurpreet
> 


_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev

Re: CR: These changes are needed to get the HEAD (Atlas) code to work on Symbian 9.
country flaguser name
India
2007-02-28 00:37:06
Hi Eric,
I was getting undefined symbol error
(missing_trait_definition) when 
compiling the below code using GCCE.
Thats why I had replaced missing_trait_definition with
IID_NULL.
Player is compiling now and I have played rm and mp3 data
type successfully.

I have checked in the rest of the changes except the
mentioned one.

Best Regards,
Gurpreet


Eric Hyche wrote:
> --- symbiancommon/pub/comptr.h	4 Feb 2004 01:47:09
-0000	1.10
> +++ symbiancommon/pub/comptr.h	27 Feb 2007 10:56:30
-0000
>  -37,7 +37,7 
>  struct IIDTraits
>  {
>      // missing #include "comptr_traits.h"?
missing trait in
> "comptr_traits.h"?
> -    static inline IID_RETTYPE riid() { return
missing_trait_definition; }
> +    static inline IID_RETTYPE riid() { return
IID_NULL; }
>  };
>  
>
> What will this do? Will not having this guid
> cause anything not to work? Or are you going
> to deal with that later?
>
>
> Rest looks good.
>
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
>
>   
>> -----Original Message-----
>> From: clientapps-dev-bounceshelixcommunity.org 
>> [mailto:clientapps-dev-bounceshelixcommunity.org] On Behalf 
>> Of Gurpreet
>> Sent: Tuesday, February 27, 2007 7:05 AM
>> To: porting-symbianhelixcommunity.org
>> Cc: clientapps-dev
>> Subject: [Clientapps-dev] CR: These changes are
needed to get 
>> the HEAD (Atlas) code to work on Symbian 9.1 ARM
Device 
>>
>> Synopsis:
>> Changes are required to remove build errors.
>>
>> Overview:
>> These changes are needed to get the HEAD (Atlas)
code to work 
>> on Symbian 
>> 9.1 ARM Device
>>
>> Files Added:
>> None
>>
>> Files Modified:
>> symbiancommon/pub/chxavutil.h
>> symbiancommon/pub/chxsmartptr.h
>> symbiancommon/pub/comptr.h
>> symbianplayer/symbian.pcf
>>
symbianplayer/platform/symbian/chxavaccesspointdb.cpp
>>
symbianplayer/platform/symbian/chxaveditplaylistdialog.cpp
>>
symbianplayer/platform/symbian/chxavfileviewpageinfo.cpp
>>
symbianplayer/platform/symbian/chxavnavipanecontrol.cpp
>> symbianplayer/platform/symbian/chxavplayerui.cpp
>>
symbianplayer/platform/symbian/chxavsettingsviewwindow.cpp
>>
symbianplayer/platform/symbian/chxclientenginemanager.cpp
>>
symbianplayer/platform/symbian/file/chxavfileutil.cpp
>>
symbianplayer/platform/symbian/file/pub/chxavfileutil.h
>>
>> Image Size and Heap Use impact (Client -Only):
>> None.
>>
>> Platforms and Profiles Affected:
>> symbian-91
>>
>> Distribution Libraries Affected:
>> None
>>
>> Distribution library impact and planned action:
>> None
>>
>> Platforms and Profiles Build Verified:
>>
>> BIF branch  -> helix_restricted
>> Target(s) -> symbianinst
>> Profile -> helix-client-s60-advanced
>> SYSTEM_ID-> symbian-91-armv5-gcce
>>
>> Branch:
>> HEAD
>>
>> Files Attached:
>> clientapps.diff
>>
>> Regards,
>> Gurpreet
>>
>>     
>
>
>   


_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev

Re: CR: These changes are needed to get the HEAD (Atlas) code to work on Symbian 9.
country flaguser name
India
2007-02-28 04:37:57
Hi Eric,
when compiling clientappssymbiancommon/pub/comptr.h  using
GCCE.
I get unresolved symbol error. unresolved symbol is 
missing_trait_definition
To resolve this, I believe following is a good solution.

RCS file: /cvsroot/clientapps/symbiancommon/pub/comptr.h,v
retrieving revision 1.10
diff -u -r1.10 comptr.h
--- comptr.h    4 Feb 2004 01:47:09 -0000    1.10
+++ comptr.h    28 Feb 2007 10:35:18 -0000
 -25,6
+25,10 
     }
 }
 
+#if defined(__GCCE__)
+#define missing_trait_definition IID_NULL
+#endif
+
 #if defined(HELIX_FEATURE_FULLGUID)
 typedef REFIID IID_RETTYPE;
 #else

Regards,
Gurpreet

Eric Hyche wrote:
> --- symbiancommon/pub/comptr.h	4 Feb 2004 01:47:09
-0000	1.10
> +++ symbiancommon/pub/comptr.h	27 Feb 2007 10:56:30
-0000
>  -37,7 +37,7 
>  struct IIDTraits
>  {
>      // missing #include "comptr_traits.h"?
missing trait in
> "comptr_traits.h"?
> -    static inline IID_RETTYPE riid() { return
missing_trait_definition; }
> +    static inline IID_RETTYPE riid() { return
IID_NULL; }
>  };
>  
>
> What will this do? Will not having this guid
> cause anything not to work? Or are you going
> to deal with that later?
>
>
> Rest looks good.
>
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
>
>   
>> -----Original Message-----
>> From: clientapps-dev-bounceshelixcommunity.org 
>> [mailto:clientapps-dev-bounceshelixcommunity.org] On Behalf 
>> Of Gurpreet
>> Sent: Tuesday, February 27, 2007 7:05 AM
>> To: porting-symbianhelixcommunity.org
>> Cc: clientapps-dev
>> Subject: [Clientapps-dev] CR: These changes are
needed to get 
>> the HEAD (Atlas) code to work on Symbian 9.1 ARM
Device 
>>
>> Synopsis:
>> Changes are required to remove build errors.
>>
>> Overview:
>> These changes are needed to get the HEAD (Atlas)
code to work 
>> on Symbian 
>> 9.1 ARM Device
>>
>> Files Added:
>> None
>>
>> Files Modified:
>> symbiancommon/pub/chxavutil.h
>> symbiancommon/pub/chxsmartptr.h
>> symbiancommon/pub/comptr.h
>> symbianplayer/symbian.pcf
>>
symbianplayer/platform/symbian/chxavaccesspointdb.cpp
>>
symbianplayer/platform/symbian/chxaveditplaylistdialog.cpp
>>
symbianplayer/platform/symbian/chxavfileviewpageinfo.cpp
>>
symbianplayer/platform/symbian/chxavnavipanecontrol.cpp
>> symbianplayer/platform/symbian/chxavplayerui.cpp
>>
symbianplayer/platform/symbian/chxavsettingsviewwindow.cpp
>>
symbianplayer/platform/symbian/chxclientenginemanager.cpp
>>
symbianplayer/platform/symbian/file/chxavfileutil.cpp
>>
symbianplayer/platform/symbian/file/pub/chxavfileutil.h
>>
>> Image Size and Heap Use impact (Client -Only):
>> None.
>>
>> Platforms and Profiles Affected:
>> symbian-91
>>
>> Distribution Libraries Affected:
>> None
>>
>> Distribution library impact and planned action:
>> None
>>
>> Platforms and Profiles Build Verified:
>>
>> BIF branch  -> helix_restricted
>> Target(s) -> symbianinst
>> Profile -> helix-client-s60-advanced
>> SYSTEM_ID-> symbian-91-armv5-gcce
>>
>> Branch:
>> HEAD
>>
>> Files Attached:
>> clientapps.diff
>>
>> Regards,
>> Gurpreet
>>
>>     
>
>
>   


_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev

RE: CR: These changes are needed to get the HEAD (Atlas) code to work on Symbian 9.
country flaguser name
United States
2007-02-28 08:50:23
Is missing_trait_definition something in Symbian
code that changed from Symbian 6.x to 9.1? Or is
it something in Helix code? What is its purpose?

If you can't find the answers to this, don't hold
up the check in for it. Just comment out the
missing_trait_definition line and add a comment
saying why it's commented out.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Gurpreet [mailto:gahluwaliareal.com] 
> Sent: Wednesday, February 28, 2007 1:37 AM
> To: ehychereal.com
> Cc: porting-symbianhelixcommunity.org;
'clientapps-dev'
> Subject: Re: [Clientapps-dev] CR: These changes are
needed to 
> get the HEAD (Atlas) code to work on Symbian 9.1 ARM
Device
> 
> Hi Eric,
> I was getting undefined symbol error
(missing_trait_definition) when 
> compiling the below code using GCCE.
> Thats why I had replaced missing_trait_definition with
IID_NULL.
> Player is compiling now and I have played rm and mp3
data 
> type successfully.
> 
> I have checked in the rest of the changes except the
mentioned one.
> 
> Best Regards,
> Gurpreet
> 
> 
> Eric Hyche wrote:
> > --- symbiancommon/pub/comptr.h	4 Feb 2004 01:47:09

> -0000	1.10
> > +++ symbiancommon/pub/comptr.h	27 Feb 2007
10:56:30 -0000
> >  -37,7 +37,7 
> >  struct IIDTraits
> >  {
> >      // missing #include
"comptr_traits.h"? missing trait in
> > "comptr_traits.h"?
> > -    static inline IID_RETTYPE riid() { return 
> missing_trait_definition; }
> > +    static inline IID_RETTYPE riid() { return
IID_NULL; }
> >  };
> >  
> >
> > What will this do? Will not having this guid
> > cause anything not to work? Or are you going
> > to deal with that later?
> >
> >
> > Rest looks good.
> >
> > =============================================
> > Eric Hyche (ehychereal.com)
> > Technical Lead
> > RealNetworks, Inc.  
> >
> >   
> >> -----Original Message-----
> >> From: clientapps-dev-bounceshelixcommunity.org 
> >> [mailto:clientapps-dev-bounceshelixcommunity.org] On Behalf 
> >> Of Gurpreet
> >> Sent: Tuesday, February 27, 2007 7:05 AM
> >> To: porting-symbianhelixcommunity.org
> >> Cc: clientapps-dev
> >> Subject: [Clientapps-dev] CR: These changes
are needed to get 
> >> the HEAD (Atlas) code to work on Symbian 9.1
ARM Device 
> >>
> >> Synopsis:
> >> Changes are required to remove build errors.
> >>
> >> Overview:
> >> These changes are needed to get the HEAD
(Atlas) code to work 
> >> on Symbian 
> >> 9.1 ARM Device
> >>
> >> Files Added:
> >> None
> >>
> >> Files Modified:
> >> symbiancommon/pub/chxavutil.h
> >> symbiancommon/pub/chxsmartptr.h
> >> symbiancommon/pub/comptr.h
> >> symbianplayer/symbian.pcf
> >>
symbianplayer/platform/symbian/chxavaccesspointdb.cpp
> >>
symbianplayer/platform/symbian/chxaveditplaylistdialog.cpp
> >>
symbianplayer/platform/symbian/chxavfileviewpageinfo.cpp
> >>
symbianplayer/platform/symbian/chxavnavipanecontrol.cpp
> >>
symbianplayer/platform/symbian/chxavplayerui.cpp
> >>
symbianplayer/platform/symbian/chxavsettingsviewwindow.cpp
> >>
symbianplayer/platform/symbian/chxclientenginemanager.cpp
> >>
symbianplayer/platform/symbian/file/chxavfileutil.cpp
> >>
symbianplayer/platform/symbian/file/pub/chxavfileutil.h
> >>
> >> Image Size and Heap Use impact (Client
-Only):
> >> None.
> >>
> >> Platforms and Profiles Affected:
> >> symbian-91
> >>
> >> Distribution Libraries Affected:
> >> None
> >>
> >> Distribution library impact and planned
action:
> >> None
> >>
> >> Platforms and Profiles Build Verified:
> >>
> >> BIF branch  -> helix_restricted
> >> Target(s) -> symbianinst
> >> Profile -> helix-client-s60-advanced
> >> SYSTEM_ID-> symbian-91-armv5-gcce
> >>
> >> Branch:
> >> HEAD
> >>
> >> Files Attached:
> >> clientapps.diff
> >>
> >> Regards,
> >> Gurpreet
> >>
> >>     
> >
> >
> >   
> 


_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev

[1-5]

about | contact  Other archives ( Real Estate discussion Medical topics )