|
List Info
Thread: RESEND: CR: Progressive Download - Handle failure case for
|
|
| RESEND: CR: Progressive Download -
Handle failure case for |
|
2007-06-21 10:49:42 |
|
_____________________________________________
From: Periquet Arnel (Nokia-TP-MSW/Dallas)
Sent: ; Wednesday, June 20, 2007 11:15 AM
To: clientapps-dev helixcommunity.org
Subject: ; [ClientApps-dev] [Rarvcode-formprot-dev] CR: Progressive Download - Handle failure case for multi-rate RM files on linear file systems
______________________________________________
From: Periquet Arnel (Nokia-TP-MSW/Dallas)
Sent: ; Wednesday, June 20, 2007 9:54 AM
To: 'rarvcode-formprot-devhelixcommunity.org'
Subject: ; [Rarvcode-formprot-dev] CR: Progressive Download - Handle failure case for multi-rate RM files on linear file systems
"Nokia submits this code under the terms of a commercial contribution agreement with RealNetworks, and I am authorized to contribute this code under said agreement."
Modified by: : Arnel.Periquetnokia.com
Reviewed by:
Date: 06-19-2007
Project: clientapps/symbianMmf, datatype-restricted/rm
ErrorId: EOVL-73ATMR
Synopsis: Series60 Progressive Download - Handle failure case for multi-rate RM files on linear file systems.
Under Series 60 Progressive Download, the error message "Invalid Clip" occurs for a multi-rate RM file. This is caused by the RM file format determining that the file system is 'linear' in which case multi-rate files for RM are not supported. However, we would like the message to be something like "Full download needed" in the case of progressive download.
A change to the returned error code in the Real Media File Format (datatype-restrictedrmfileformatrmffplin.cpp) is proposed.
In the case where HELIX_FEATURE_RMFF_MULTIRATE is defined, the following should be returned:
; HXR_NOT_SUPPORTED_FOR_LINEAR_FILE_SYSTEMS.
In the case where RMFF MULTIRATE is not supported, the following should be returned:
; HXR_NOT_SUPPORTED.
Right now, both cases result in HXR_BAD_FORMAT which I don't believe is as appropriate.
For the case of Series 60 Progressive Download, which uses a linear file system, our TLC would then map the returned Helix error code to result in a message like "Full downloaded needed".
Root Cause: Implementation
Files Modified:
Datatype-restricted/rm/fileformat/rmffplin.cpp
Common/include/hxresult.cpp
Clientapps/symbianMmf/common/hxmmfbasectrl.cpp
Image Size and Heap Use Impact: no major impact
Module Release Testing (STIF): All local cases pass.
Test case(s) Added: No. PDL test cases to be added in the future.
Memory leak check performed. Yes. No new leaks are introduced by this work.
Platforms and Profiles Build Verified: helix-client-s60-32-mmf-mdf-dsp
Platforms and Profiles Functionality Verified: armv5, winscw
Branch: Head & 210CayS
Index: rmffplin.cpp
===================================================================
RCS file: /cvsroot/rarvcode-formprot/fileformat/rmffplin.cpp,v
retrieving revision 1.49.6.3
diff -w -u -b -r1.49.6.3 rmffplin.cpp
--- rmffplin.cpp 5 Feb 2007 07:04:03 -0000 ; 1.49.6.3
+++ rmffplin.cpp 19 Jun 2007 20:38:02 -0000
-3538,14 +3538,15
pFilename = " ";
}
- pnr = HXR_BAD_FORMAT;
pErrorString = "RealMedia File Format: File "";
pErrorString += pFilename;
#if defined(HELIX_FEATURE_RMFF_MULTIRATE)
pErrorString += "" does not support playback over linear file systems (e.g. HTTP 1.0).";;
+ pnr = HXR_NOT_SUPPORTED_FOR_LINEAR_FILE_SYSTEMS;
#else // HELIX_FEATURE_RMFF_MULTIRATE
pErrorString += "" is unsupported multirate file.";;
+ pnr = HXR_NOT_SUPPORTED;
#endif // HELIX_FEATURE_RMFF_MULTIRATE
m_pErrorMessages->Report(HXLOG_ALERT, pnr, 0,
Index: hxresult.h
===================================================================
RCS file: /cvsroot/common/include/hxresult.h,v
retrieving revision 1.37.2.7
diff -w -u -b -r1.37.2.7 hxresult.h
--- hxresult.h 28 Mar 2007 03:52:43 -0000 ; 1.37.2.7
+++ hxresult.h 19 Jun 2007 20:36:41 -0000
-173,6 +173,7
#define HXR_DEVVIDEO_FATAL_ERROR ; MAKE_HX_RESULT(1,SS_GLO,38) ; ; // 80040026
#define HXR_DEVVIDEO_RESOURCE_LOST ; MAKE_HX_RESULT(1,SS_GLO,39) ; ; // 80040027
#define HXR_DEVVIDEO_RESOURCE_RESTORED MAKE_HX_RESULT(1,SS_GLO,40) ; ; // 80040028
+#define HXR_NOT_SUPPORTED_FOR_LINEAR_FILE_SYSTEMS MAKE_HX_RESULT(1,SS_GLO,41) ; // 80040029
#define HXR_BUFFERING ; ; MAKE_HX_RESULT(0,SS_NET,0) ; ; // 00040040
#define HXR_PAUSED ; ; MAKE_HX_RESULT(0,SS_NET,1) ; ; // 00040041
Index: hxmmfbasectrl.cpp
===================================================================
RCS file: /cvsroot/clientapps/symbianMmf/common/hxmmfbasectrl.cpp,v
retrieving revision 1.1.2.23
diff -w -u -b -r1.1.2.23 hxmmfbasectrl.cpp
--- hxmmfbasectrl.cpp 18 Jun 2007 21:50:10 -0000 ; 1.1.2.23
+++ hxmmfbasectrl.cpp 19 Jun 2007 20:35:48 -0000
-115,6 +115,7
{ HXR_PARTIALPLAYBACK, ; KErrMMPartialPlayback ; },
{ HXR_NO_FILESYSTEM, ; KErrGeneral ; },
{ HXR_NOT_SUPPORTED, ; KErrNotSupported ; },
+ { HXR_NOT_SUPPORTED_FOR_LINEAR_FILE_SYSTEMS, KErrAbort ; },
{ HXR_MSG_TOOLARGE, ; KErrOverflow ; },
{ HXR_LOADTEST_NOT_SUPPORTED, ; KErrNotSupported ; },
{ HXR_UNEXPECTED_STREAM_END, ; KErrGeneral ; },
|
| RE: RESEND: CR: ProgressiveDownload -
Handle failure case f |
 
United States |
2007-06-21 11:41:38 |
Looks good. Is HXR_NOT_SUPPORTED_FOR_LINEAR_FILE_SYSTEMS
already defined in common/include/hxresult.h?
Eric
=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: clientapps-dev-bounceshelixcommunity.org
> [mailto:clientapps-dev-bounceshelixcommunity.org] On
Behalf
> Of Arnel.Periquetnokia.com
> Sent: Thursday, June 21, 2007 11:50 AM
> To: clientapps-devhelixcommunity.org;
> rarvcode-formprot-devhelixcommunity.org
> Subject: RESEND: [ClientApps-dev]
[Rarvcode-formprot-dev] CR:
> ProgressiveDownload - Handle failure case for
multi-rate RM
> files onlinear file systems
>
>
>
> _____________________________________________
> From: Periquet Arnel (Nokia-TP-MSW/Dallas)
> Sent: Wednesday, June 20, 2007 11:15 AM
> To: clientapps-devhelixcommunity.org
> Subject: [ClientApps-dev]
> [Rarvcode-formprot-dev] CR: Progressive Download -
Handle
> failure case for multi-rate RM files on linear file
systems
>
>
>
> ______________________________________________
> From: Periquet Arnel (Nokia-TP-MSW/Dallas)
> Sent: Wednesday, June 20, 2007 9:54 AM
> To: 'rarvcode-formprot-devhelixcommunity.org'
> Subject: [Rarvcode-formprot-dev] CR:
> Progressive Download - Handle failure case for
multi-rate RM
> files on linear file systems
>
>
>
> "Nokia submits this code under the
> terms of a commercial contribution agreement with
> RealNetworks, and I am authorized to contribute this
code
> under said agreement."
>
> Modified by: : Arnel.Periquetnokia.com
>
> Reviewed by:
>
> Date: 06-19-2007
>
> Project: clientapps/symbianMmf,
> datatype-restricted/rm
>
> ErrorId: EOVL-73ATMR
>
> Synopsis: Series60 Progressive Download
> - Handle failure case for multi-rate RM files on linear
file systems.
>
> Under Series 60 Progressive Download,
> the error message "Invalid Clip" occurs for a
multi-rate RM
> file. This is caused by the RM file format determining
that
> the file system is 'linear' in which case multi-rate
files
> for RM are not supported. However, we would like the
message
> to be something like "Full download needed"
in the case of
> progressive download.
>
> A change to the returned error code in
> the Real Media File Format
> (datatype-restrictedrmfileformatrmffplin.cpp) is
proposed.
>
> In the case where
> HELIX_FEATURE_RMFF_MULTIRATE is defined, the following
should
> be returned:
>
> HXR_NOT_SUPPORTED_FOR_LINEAR_FILE_SYSTEMS.
> In the case where RMFF MULTIRATE is not
> supported, the following should be returned:
> HXR_NOT_SUPPORTED.
>
> Right now, both cases result in
> HXR_BAD_FORMAT which I don't believe is as appropriate.
>
> For the case of Series 60 Progressive
> Download, which uses a linear file system, our TLC
would then
> map the returned Helix error code to result in a
message like
> "Full downloaded needed".
>
> Root Cause: Implementation
>
> Files Modified:
>
> Datatype-restricted/rm/fileformat/rmffplin.cpp
> Common/include/hxresult.cpp
> Clientapps/symbianMmf/common/hxmmfbasectrl.cpp
>
> Image Size and Heap Use Impact: no major impact
>
> Module Release Testing (STIF): All
> local cases pass.
>
> Test case(s) Added: No. PDL test cases
> to be added in the future.
>
> Memory leak check performed. Yes. No
> new leaks are introduced by this work.
>
> Platforms and Profiles Build Verified:
> helix-client-s60-32-mmf-mdf-dsp
>
> Platforms and Profiles Functionality
> Verified: armv5, winscw
>
> Branch: Head & 210CayS
>
> Index: rmffplin.cpp
>
>
============================================================
=======
> RCS file:
> /cvsroot/rarvcode-formprot/fileformat/rmffplin.cpp,v
> retrieving revision 1.49.6.3
> diff -w -u -b -r1.49.6.3 rmffplin.cpp
> --- rmffplin.cpp 5 Feb 2007
> 07:04:03 -0000 1.49.6.3
> +++ rmffplin.cpp 19 Jun 2007
> 20:38:02 -0000
> -3538,14 +3538,15
>
> pFilename = " ";
> }
>
> - pnr
> = HXR_BAD_FORMAT;
>
>
> pErrorString = "RealMedia File Format: File
"";
>
> pErrorString += pFilename;
> #if defined(HELIX_FEATURE_RMFF_MULTIRATE)
>
> pErrorString += "" does not support playback
over linear
> file systems (e.g. HTTP 1.0).";
>
> + pnr
> = HXR_NOT_SUPPORTED_FOR_LINEAR_FILE_SYSTEMS;
> #else // HELIX_FEATURE_RMFF_MULTIRATE
>
> pErrorString += "" is unsupported multirate
file.";
> + pnr
> = HXR_NOT_SUPPORTED;
> #endif // HELIX_FEATURE_RMFF_MULTIRATE
>
>
> m_pErrorMessages->Report(HXLOG_ALERT, pnr, 0,
>
> Index: hxresult.h
>
>
============================================================
=======
> RCS file: /cvsroot/common/include/hxresult.h,v
> retrieving revision 1.37.2.7
> diff -w -u -b -r1.37.2.7 hxresult.h
> --- hxresult.h 28 Mar 2007 03:52:43
> -0000 1.37.2.7
> +++ hxresult.h 19 Jun 2007 20:36:41 -0000
> -173,6 +173,7
> #define HXR_DEVVIDEO_FATAL_ERROR
> MAKE_HX_RESULT(1,SS_GLO,38) //
80040026
> #define HXR_DEVVIDEO_RESOURCE_LOST
> MAKE_HX_RESULT(1,SS_GLO,39) //
80040027
> #define HXR_DEVVIDEO_RESOURCE_RESTORED
> MAKE_HX_RESULT(1,SS_GLO,40) //
80040028
> +#define
> HXR_NOT_SUPPORTED_FOR_LINEAR_FILE_SYSTEMS
> MAKE_HX_RESULT(1,SS_GLO,41) // 80040029
>
> #define HXR_BUFFERING
> MAKE_HX_RESULT(0,SS_NET,0) //
00040040
> #define HXR_PAUSED
> MAKE_HX_RESULT(0,SS_NET,1) //
00040041
>
>
> Index: hxmmfbasectrl.cpp
>
>
============================================================
=======
> RCS file:
>
/cvsroot/clientapps/symbianMmf/common/hxmmfbasectrl.cpp,v
> retrieving revision 1.1.2.23
> diff -w -u -b -r1.1.2.23 hxmmfbasectrl.cpp
> --- hxmmfbasectrl.cpp 18 Jun 2007
> 21:50:10 -0000 1.1.2.23
> +++ hxmmfbasectrl.cpp 19 Jun 2007
> 20:35:48 -0000
> -115,6 +115,7
> { HXR_PARTIALPLAYBACK,
> KErrMMPartialPlayback },
> { HXR_NO_FILESYSTEM,
> KErrGeneral },
> { HXR_NOT_SUPPORTED,
> KErrNotSupported },
> + {
> HXR_NOT_SUPPORTED_FOR_LINEAR_FILE_SYSTEMS, KErrAbort
},
> { HXR_MSG_TOOLARGE,
> KErrOverflow },
> { HXR_LOADTEST_NOT_SUPPORTED,
> KErrNotSupported },
> { HXR_UNEXPECTED_STREAM_END,
> KErrGeneral },
>
>
_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
|
|
[1-2]
|
|