|
List Info
Thread: CR-Client: Removing HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to allow a single build
|
|
| CR-Client: Removing
HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to
allow a single build |

|
2007-07-23 19:14:43 |
"Nokia submits this code under the terms of a
commercial contribution
agreement with RealNetworks, and I am authorized to
contribute this code
under said agreement."
Modified by: anshuman.tewari nokia.com
Reviewed by:
Date: 4/23/2007
Project: SymbianMmf
ErrorId: 101-36687
Synopsis: Removing HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to
allow a single
build for creating SISX install files and ROM image.
Description:
Currently to create a Helix SISX package,the flag
HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY has to be commented out
and the
sources rebuilt. Helix can be installed on the phones as
after market
update. In such cases it should not be necassary to rebuild
the sources
to create a sisx package. It should be possible to create
the SISX
packages by simply the prebuilt binaries from the
Build/Release Team.
1) Removed the flag HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY from
the
helix-client-s60-mmf-common.pfi
Similar changes are done for the
helix-s60-metadataengine.pf.
In /build/umakecf/symbian.cf Changes made so that the
copyDlls.bat
will always be run at the end of the build.
2) GetShadowPath returns the drive letter and the directory
where the
Operator Config file is present.
The Operator config file will be present either burned in
ROM [Z:] or
be a part of the installation package.
i.e. installed either on C: drive or the MMC Card. The
rest of the
config files will be searched in the same
directory. GetFullPath() and GetInstallDrive() are
replaced with
GetShadowPath. This function searches for the
Operator config file across drives.
3) Removed
KHXDefaultMMFCtrlDrive/EMMFCtrlPath/EShadowFilePath from
the
audio+video controllers
4) Removed HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY from
clientappssymbianMmf[audio|video]controllerMmfSis
to allow for CopyDlls.bat to be created.
6) Removed the ROM_ONLY flag from the RSS files.
Root Cause of the problem: New Requirement
Files Modified:
umakepf/helix-client-s60-mmf-common.pfi
umakepf/helix-s60-metadataengine.pf
umakecf/symbian.cf
M symbianMmf/audiocontroller/10207B64.rss
M symbianMmf/audiocontroller/controllersis
M symbianMmf/audiocontroller/hxmmfaudioctrl.cpp
M symbianMmf/common/hxmmfbasectrl.cpp
M symbianMmf/common/hxmmfbasectrl.h
M symbianMmf/common/hxmmfbasedefines.h
M symbianMmf/videocontroller/101F8513.rss
M symbianMmf/videocontroller/MmfSis
M symbianMmf/videocontroller/hxmmfctrlimpl.cpp
Files Added: None
Image Size and Heap Use impact: None
Module Release testing (STIF) : Yes
Test case(s) Added : N/A
Memory leak check performed : Yes no leaks introduced.
Platforms and Profiles Build Verified:
helix-client-s60-32-mmf-mdf-arm
Platforms and Profiles Functionality verified: armv5, winscw
Branch: Head & 210CayS
cvs diff: Diffing umakepf
Index: umakepf/helix-client-s60-mmf-common.pfi
============================================================
=======
RCS file:
/cvsroot/ribosome/build/umakepf/helix-client-s60-mmf-common.
pfi,v
retrieving revision 1.18
diff -w -u -b -r1.18 helix-client-s60-mmf-common.pfi
--- umakepf/helix-client-s60-mmf-common.pfi 3 Apr 2007
18:57:54
-0000 1.18
+++ umakepf/helix-client-s60-mmf-common.pfi 23 Jul 2007
21:24:36
-0000
 -80,9
+80,6 
if not project.IsDefined('HELIX_FEATURE_LOGLEVEL_NONE'):
project.AddDefines('HELIX_FEATURE_CORE_LOG')
-# ROM ONLY FLAG is used to build MMF controller as a part
of Phone
image.
-# This flag has to commented to build MMF Controller as SIS
package
-project.AddDefines('HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY')
# This flag to set link option to ALL -tcb
project.AddDefines('HELIX_CONFIG_SYMBIAN_CAP_ECOM_PLUGIN')
Index: umakepf/helix-s60-metadataengine.pf
============================================================
=======
RCS file:
/cvsroot/ribosome/build/umakepf/helix-s60-metadataengine.pf,
v
retrieving revision 1.1
diff -w -u -b -r1.1 helix-s60-metadataengine.pf
--- umakepf/helix-s60-metadataengine.pf 19 Sep 2006 21:54:10
-0000
1.1
+++ umakepf/helix-s60-metadataengine.pf 23 Jul 2007 21:24:36
-0000
 -79,5
+79,5 
project.AddDefines('HELIX_CONFIG_DTDR_DISABLE_LOGGING')
project.AddDefines('HELIX_FEATURE_MINI_SMPLFSYS')
-project.AddDefines('HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY')
+
Index: umakecf/symbian.cf
============================================================
=======
RCS file: /cvsroot/ribosome/build/umakecf/symbian.cf,v
retrieving revision 1.59
diff -w -u -b -r1.59 symbian.cf
--- umakecf/symbian.cf 13 Jun 2007 01:12:50 -0000
1.59
+++ umakecf/symbian.cf 23 Jul 2007 21:24:36 -0000
 -605,7
+605,7 
# output makefile instructions to build the .sis
project.writeln("all: %s" % sisname)
- if
project.IsDefined("HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY&qu
ot;):
+ if
project.IsDefined("HELIX_FEATURE_SYMBIAN_MMF"):
project.writeln("t %s" %
"copyDlls.bat" )
project.writeln("n")
_______________________________________________
Clientapps-dev mailing list
Clientapps-dev helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
|
|
|
| RESEND : CR-Client:
RemovingHELIX_CONFIG_SYMBIAN_MMF_ROM_ONL
Y to allow a single bui |

|
2007-07-24 19:05:32 |
-----Original Message-----
From: clientapps-dev-bounces helixcommunity.org
[mailto:clientapps-dev-bounces helixcommunity.org]
Sent: Monday, July 23, 2007 7:15 PM
To: clientapps-dev helixcommunity.org
Subject: [Clientapps-dev] CR-Client:
RemovingHELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to allow a single
build
"Nokia submits this code under the terms of a
commercial contribution
agreement with RealNetworks, and I am authorized to
contribute this code
under said agreement."
Modified by: anshuman.tewari nokia.com
Reviewed by:
Date: 4/23/2007
Project: SymbianMmf
ErrorId: 101-36687
Synopsis: Removing HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to
allow a single
build for creating SISX install files and ROM image.
Description:
Currently to create a Helix SISX package,the flag
HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY has to be commented out
and the
sources rebuilt. Helix can be installed on the phones as
after market
update. In such cases it should not be necassary to rebuild
the sources
to create a sisx package. It should be possible to create
the SISX
packages by simply the prebuilt binaries from the
Build/Release Team.
1) Removed the flag HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY from
the
helix-client-s60-mmf-common.pfi
Similar changes are done for the
helix-s60-metadataengine.pf.
In /build/umakecf/symbian.cf Changes made so that the
copyDlls.bat
will always be run at the end of the build.
2) GetShadowPath returns the drive letter and the directory
where the
Operator Config file is present.
The Operator config file will be present either burned in
ROM [Z:] or
be a part of the installation package.
i.e. installed either on C: drive or the MMC Card. The
rest of the
config files will be searched in the same
directory. GetFullPath() and GetInstallDrive() are
replaced with
GetShadowPath. This function searches for the
Operator config file across drives.
3) Removed
KHXDefaultMMFCtrlDrive/EMMFCtrlPath/EShadowFilePath from
the
audio+video controllers
4) Removed HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY from
clientappssymbianMmf[audio|video]controllerMmfSis
to allow for CopyDlls.bat to be created.
6) Removed the ROM_ONLY flag from the RSS files.
Root Cause of the problem: New Requirement
Files Modified:
umakepf/helix-client-s60-mmf-common.pfi
umakepf/helix-s60-metadataengine.pf
umakecf/symbian.cf
M symbianMmf/audiocontroller/10207B64.rss
M symbianMmf/audiocontroller/controllersis
M symbianMmf/audiocontroller/hxmmfaudioctrl.cpp
M symbianMmf/common/hxmmfbasectrl.cpp
M symbianMmf/common/hxmmfbasectrl.h
M symbianMmf/common/hxmmfbasedefines.h
M symbianMmf/videocontroller/101F8513.rss
M symbianMmf/videocontroller/MmfSis
M symbianMmf/videocontroller/hxmmfctrlimpl.cpp
Files Added: None
Image Size and Heap Use impact: None
Module Release testing (STIF) : Yes
Test case(s) Added : N/A
Memory leak check performed : Yes no leaks introduced.
Platforms and Profiles Build Verified:
helix-client-s60-32-mmf-mdf-arm
Platforms and Profiles Functionality verified: armv5, winscw
Branch: Head & 210CayS
cvs diff: Diffing umakepf
Index: umakepf/helix-client-s60-mmf-common.pfi
============================================================
=======
RCS file:
/cvsroot/ribosome/build/umakepf/helix-client-s60-mmf-common.
pfi,v
retrieving revision 1.18
diff -w -u -b -r1.18 helix-client-s60-mmf-common.pfi
--- umakepf/helix-client-s60-mmf-common.pfi 3 Apr 2007
18:57:54
-0000 1.18
+++ umakepf/helix-client-s60-mmf-common.pfi 23 Jul 2007
21:24:36
-0000
 -80,9
+80,6 
if not project.IsDefined('HELIX_FEATURE_LOGLEVEL_NONE'):
project.AddDefines('HELIX_FEATURE_CORE_LOG')
-# ROM ONLY FLAG is used to build MMF controller as a part
of Phone
image.
-# This flag has to commented to build MMF Controller as SIS
package
-project.AddDefines('HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY')
# This flag to set link option to ALL -tcb
project.AddDefines('HELIX_CONFIG_SYMBIAN_CAP_ECOM_PLUGIN')
Index: umakepf/helix-s60-metadataengine.pf
============================================================
=======
RCS file:
/cvsroot/ribosome/build/umakepf/helix-s60-metadataengine.pf,
v
retrieving revision 1.1
diff -w -u -b -r1.1 helix-s60-metadataengine.pf
--- umakepf/helix-s60-metadataengine.pf 19 Sep 2006 21:54:10
-0000
1.1
+++ umakepf/helix-s60-metadataengine.pf 23 Jul 2007 21:24:36
-0000
 -79,5
+79,5 
project.AddDefines('HELIX_CONFIG_DTDR_DISABLE_LOGGING')
project.AddDefines('HELIX_FEATURE_MINI_SMPLFSYS')
-project.AddDefines('HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY')
+
Index: umakecf/symbian.cf
============================================================
=======
RCS file: /cvsroot/ribosome/build/umakecf/symbian.cf,v
retrieving revision 1.59
diff -w -u -b -r1.59 symbian.cf
--- umakecf/symbian.cf 13 Jun 2007 01:12:50 -0000
1.59
+++ umakecf/symbian.cf 23 Jul 2007 21:24:36 -0000
 -605,7
+605,7 
# output makefile instructions to build the .sis
project.writeln("all: %s" % sisname)
- if
project.IsDefined("HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY&qu
ot;):
+ if
project.IsDefined("HELIX_FEATURE_SYMBIAN_MMF"):
project.writeln("t %s" %
"copyDlls.bat" )
project.writeln("n")
_______________________________________________
Clientapps-dev mailing list
Clientapps-dev helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
|
|
| RE: RESEND :
CR-Client:RemovingHELIX_CONFIG_SYMBIAN_M
MF_ROM_ONLY to allow a single |

|
2007-07-25 11:00:40 |
Hi
Could someone please take a look at this CR.
I would like to check this in today so that these changes
make it to the
next release.
- Thanks
Anshuman
-----Original Message-----
From: clientapps-dev-bounces helixcommunity.org
[mailto:clientapps-dev-bounces helixcommunity.org]
Sent: Tuesday, July 24, 2007 7:06 PM
To: clientapps-dev-bounces helixcommunity.org;
clientapps-dev helixcommunity.org
Subject: RESEND : [Clientapps-dev]
CR-Client:RemovingHELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to allow
a single
build
-----Original Message-----
From: clientapps-dev-bounces helixcommunity.org
[mailto:clientapps-dev-bounces helixcommunity.org]
Sent: Monday, July 23, 2007 7:15 PM
To: clientapps-dev helixcommunity.org
Subject: [Clientapps-dev] CR-Client:
RemovingHELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to allow a single
build
"Nokia submits this code under the terms of a
commercial contribution
agreement with RealNetworks, and I am authorized to
contribute this code
under said agreement."
Modified by: anshuman.tewari nokia.com
Reviewed by:
Date: 4/23/2007
Project: SymbianMmf
ErrorId: 101-36687
Synopsis: Removing HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to
allow a single
build for creating SISX install files and ROM image.
Description:
Currently to create a Helix SISX package,the flag
HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY has to be commented out
and the
sources rebuilt. Helix can be installed on the phones as
after market
update. In such cases it should not be necassary to rebuild
the sources
to create a sisx package. It should be possible to create
the SISX
packages by simply the prebuilt binaries from the
Build/Release Team.
1) Removed the flag HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY from
the
helix-client-s60-mmf-common.pfi
Similar changes are done for the
helix-s60-metadataengine.pf.
In /build/umakecf/symbian.cf Changes made so that the
copyDlls.bat
will always be run at the end of the build.
2) GetShadowPath returns the drive letter and the directory
where the
Operator Config file is present.
The Operator config file will be present either burned in
ROM [Z:] or
be a part of the installation package.
i.e. installed either on C: drive or the MMC Card. The
rest of the
config files will be searched in the same
directory. GetFullPath() and GetInstallDrive() are
replaced with
GetShadowPath. This function searches for the
Operator config file across drives.
3) Removed
KHXDefaultMMFCtrlDrive/EMMFCtrlPath/EShadowFilePath from
the
audio+video controllers
4) Removed HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY from
clientappssymbianMmf[audio|video]controllerMmfSis
to allow for CopyDlls.bat to be created.
6) Removed the ROM_ONLY flag from the RSS files.
Root Cause of the problem: New Requirement
Files Modified:
umakepf/helix-client-s60-mmf-common.pfi
umakepf/helix-s60-metadataengine.pf
umakecf/symbian.cf
M symbianMmf/audiocontroller/10207B64.rss
M symbianMmf/audiocontroller/controllersis
M symbianMmf/audiocontroller/hxmmfaudioctrl.cpp
M symbianMmf/common/hxmmfbasectrl.cpp
M symbianMmf/common/hxmmfbasectrl.h
M symbianMmf/common/hxmmfbasedefines.h
M symbianMmf/videocontroller/101F8513.rss
M symbianMmf/videocontroller/MmfSis
M symbianMmf/videocontroller/hxmmfctrlimpl.cpp
Files Added: None
Image Size and Heap Use impact: None
Module Release testing (STIF) : Yes
Test case(s) Added : N/A
Memory leak check performed : Yes no leaks introduced.
Platforms and Profiles Build Verified:
helix-client-s60-32-mmf-mdf-arm
Platforms and Profiles Functionality verified: armv5, winscw
Branch: Head & 210CayS
cvs diff: Diffing umakepf
Index: umakepf/helix-client-s60-mmf-common.pfi
============================================================
=======
RCS file:
/cvsroot/ribosome/build/umakepf/helix-client-s60-mmf-common.
pfi,v
retrieving revision 1.18
diff -w -u -b -r1.18 helix-client-s60-mmf-common.pfi
--- umakepf/helix-client-s60-mmf-common.pfi 3 Apr 2007
18:57:54
-0000 1.18
+++ umakepf/helix-client-s60-mmf-common.pfi 23 Jul 2007
21:24:36
-0000
 -80,9
+80,6 
if not project.IsDefined('HELIX_FEATURE_LOGLEVEL_NONE'):
project.AddDefines('HELIX_FEATURE_CORE_LOG')
-# ROM ONLY FLAG is used to build MMF controller as a part
of Phone
image.
-# This flag has to commented to build MMF Controller as SIS
package
-project.AddDefines('HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY')
# This flag to set link option to ALL -tcb
project.AddDefines('HELIX_CONFIG_SYMBIAN_CAP_ECOM_PLUGIN')
Index: umakepf/helix-s60-metadataengine.pf
============================================================
=======
RCS file:
/cvsroot/ribosome/build/umakepf/helix-s60-metadataengine.pf,
v
retrieving revision 1.1
diff -w -u -b -r1.1 helix-s60-metadataengine.pf
--- umakepf/helix-s60-metadataengine.pf 19 Sep 2006 21:54:10
-0000
1.1
+++ umakepf/helix-s60-metadataengine.pf 23 Jul 2007 21:24:36
-0000
 -79,5
+79,5 
project.AddDefines('HELIX_CONFIG_DTDR_DISABLE_LOGGING')
project.AddDefines('HELIX_FEATURE_MINI_SMPLFSYS')
-project.AddDefines('HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY')
+
Index: umakecf/symbian.cf
============================================================
=======
RCS file: /cvsroot/ribosome/build/umakecf/symbian.cf,v
retrieving revision 1.59
diff -w -u -b -r1.59 symbian.cf
--- umakecf/symbian.cf 13 Jun 2007 01:12:50 -0000
1.59
+++ umakecf/symbian.cf 23 Jul 2007 21:24:36 -0000
 -605,7
+605,7 
# output makefile instructions to build the .sis
project.writeln("all: %s" % sisname)
- if
project.IsDefined("HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY&qu
ot;):
+ if
project.IsDefined("HELIX_FEATURE_SYMBIAN_MMF"):
project.writeln("t %s" %
"copyDlls.bat" )
project.writeln("n")
_______________________________________________
Clientapps-dev mailing list
Clientapps-dev helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
_______________________________________________
Clientapps-dev mailing list
Clientapps-dev helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
|
|
| RE:
CR-Client:RemovingHELIX_CONFIG_SYMBIAN_M
MF_ROM_ONLY to |
  United States |
2007-07-25 14:10:49 |
Looks good.
=============================================
Eric Hyche (ehyche real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: client-dev-bounces helixcommunity.org
> [mailto:client-dev-bounces helixcommunity.org] On
Behalf Of
> anshuman.tewari nokia.com
> Sent: Wednesday, July 25, 2007 12:01 PM
> To: clientapps-dev-bounces helixcommunity.org;
> clientapps-dev helixcommunity.org; client-dev helixcommunity.org
> Subject: [Client-dev] RE: RESEND :
>
[Clientapps-dev]CR-Client:RemovingHELIX_CONFIG_SYMBIAN_MMF_R
OM
> _ONLY to allowa single build
>
>
> Hi
> Could someone please take a look at this CR.
> I would like to check this in today so that these
changes
> make it to the
>
> next release.
>
> - Thanks
> Anshuman
>
>
> -----Original Message-----
> From: clientapps-dev-bounces helixcommunity.org
> [mailto:clientapps-dev-bounces helixcommunity.org]
> Sent: Tuesday, July 24, 2007 7:06 PM
> To: clientapps-dev-bounces helixcommunity.org;
> clientapps-dev helixcommunity.org
> Subject: RESEND : [Clientapps-dev]
> CR-Client:RemovingHELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to
allow a single
> build
>
>
>
> -----Original Message-----
> From: clientapps-dev-bounces helixcommunity.org
> [mailto:clientapps-dev-bounces helixcommunity.org]
> Sent: Monday, July 23, 2007 7:15 PM
> To: clientapps-dev helixcommunity.org
> Subject: [Clientapps-dev] CR-Client:
> RemovingHELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to allow a
single build
>
>
> "Nokia submits this code under the terms of a
commercial contribution
> agreement with RealNetworks, and I am authorized to
> contribute this code
> under said agreement."
>
> Modified by: anshuman.tewari nokia.com
>
> Reviewed by:
>
> Date: 4/23/2007
>
> Project: SymbianMmf
>
> ErrorId: 101-36687
>
> Synopsis: Removing HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to
allow a single
> build for creating SISX install files and ROM image.
>
>
> Description:
>
> Currently to create a Helix SISX package,the flag
> HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY has to be commented
out and the
> sources rebuilt. Helix can be installed on the phones
as after market
> update. In such cases it should not be necassary to
rebuild
> the sources
> to create a sisx package. It should be possible to
create the SISX
> packages by simply the prebuilt binaries from the
Build/Release Team.
>
> 1) Removed the flag HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY
from the
> helix-client-s60-mmf-common.pfi
> Similar changes are done for the
helix-s60-metadataengine.pf.
> In /build/umakecf/symbian.cf Changes made so that
the copyDlls.bat
> will always be run at the end of the build.
>
> 2) GetShadowPath returns the drive letter and the
directory where the
> Operator Config file is present.
> The Operator config file will be present either
burned in
> ROM [Z:] or
> be a part of the installation package.
> i.e. installed either on C: drive or the MMC Card.
The rest of the
> config files will be searched in the same
> directory. GetFullPath() and GetInstallDrive() are
replaced with
> GetShadowPath. This function searches for the
> Operator config file across drives.
>
>
> 3) Removed
> KHXDefaultMMFCtrlDrive/EMMFCtrlPath/EShadowFilePath
from the
> audio+video controllers
>
> 4) Removed HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY from
> clientappssymbianMmf[audio|video]controllerMmfSis
> to allow for CopyDlls.bat to be created.
>
> 6) Removed the ROM_ONLY flag from the RSS files.
>
>
>
>
> Root Cause of the problem: New Requirement
>
>
> Files Modified:
> umakepf/helix-client-s60-mmf-common.pfi
> umakepf/helix-s60-metadataengine.pf
> umakecf/symbian.cf
>
> M symbianMmf/audiocontroller/10207B64.rss
> M symbianMmf/audiocontroller/controllersis
> M symbianMmf/audiocontroller/hxmmfaudioctrl.cpp
> M symbianMmf/common/hxmmfbasectrl.cpp
> M symbianMmf/common/hxmmfbasectrl.h
> M symbianMmf/common/hxmmfbasedefines.h
> M symbianMmf/videocontroller/101F8513.rss
> M symbianMmf/videocontroller/MmfSis
> M symbianMmf/videocontroller/hxmmfctrlimpl.cpp
>
>
> Files Added: None
>
>
> Image Size and Heap Use impact: None
>
> Module Release testing (STIF) : Yes
>
> Test case(s) Added : N/A
>
> Memory leak check performed : Yes no leaks introduced.
>
> Platforms and Profiles Build Verified:
helix-client-s60-32-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5,
winscw
>
> Branch: Head & 210CayS
>
>
>
> cvs diff: Diffing umakepf
> Index: umakepf/helix-client-s60-mmf-common.pfi
>
============================================================
=======
> RCS file:
>
/cvsroot/ribosome/build/umakepf/helix-client-s60-mmf-common.
pfi,v
> retrieving revision 1.18
> diff -w -u -b -r1.18 helix-client-s60-mmf-common.pfi
> --- umakepf/helix-client-s60-mmf-common.pfi 3 Apr
2007 18:57:54
> -0000 1.18
> +++ umakepf/helix-client-s60-mmf-common.pfi 23 Jul
2007 21:24:36
> -0000
>  -80,9 +80,6 
> if not
project.IsDefined('HELIX_FEATURE_LOGLEVEL_NONE'):
> project.AddDefines('HELIX_FEATURE_CORE_LOG')
>
> -# ROM ONLY FLAG is used to build MMF controller as a
part of Phone
> image.
> -# This flag has to commented to build MMF Controller
as SIS package
>
-project.AddDefines('HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY')
>
> # This flag to set link option to ALL -tcb
>
project.AddDefines('HELIX_CONFIG_SYMBIAN_CAP_ECOM_PLUGIN')
> Index: umakepf/helix-s60-metadataengine.pf
>
============================================================
=======
> RCS file:
>
/cvsroot/ribosome/build/umakepf/helix-s60-metadataengine.pf,
v
> retrieving revision 1.1
> diff -w -u -b -r1.1 helix-s60-metadataengine.pf
> --- umakepf/helix-s60-metadataengine.pf 19 Sep 2006
21:54:10 -0000
> 1.1
> +++ umakepf/helix-s60-metadataengine.pf 23 Jul 2007
21:24:36 -0000
>  -79,5 +79,5 
>
project.AddDefines('HELIX_CONFIG_DTDR_DISABLE_LOGGING')
> project.AddDefines('HELIX_FEATURE_MINI_SMPLFSYS')
>
>
-project.AddDefines('HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY')
> +
>
> Index: umakecf/symbian.cf
>
============================================================
=======
> RCS file: /cvsroot/ribosome/build/umakecf/symbian.cf,v
> retrieving revision 1.59
> diff -w -u -b -r1.59 symbian.cf
> --- umakecf/symbian.cf 13 Jun 2007 01:12:50 -0000
1.59
> +++ umakecf/symbian.cf 23 Jul 2007 21:24:36 -0000
>  -605,7 +605,7 
>
> # output makefile instructions to build the
.sis
> project.writeln("all: %s" %
sisname)
> - if
project.IsDefined("HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY&qu
ot;):
> + if
project.IsDefined("HELIX_FEATURE_SYMBIAN_MMF"):
> project.writeln("t %s" %
"copyDlls.bat" )
> project.writeln("n")
>
>
>
> _______________________________________________
> Clientapps-dev mailing list
> Clientapps-dev helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
>
> _______________________________________________
> Client-dev mailing list
> Client-dev helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/clie
nt-dev
>
_______________________________________________
Clientapps-dev mailing list
Clientapps-dev helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
|
|
| CN-Client:Removing
HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to
allow asingle build |

|
2007-07-25 19:20:41 |
Thanks Eric
This has been checked into 210CaysS and HEAD
- Br
Anshuman
-----Original Message-----
From: clientapps-dev-bounces helixcommunity.org
[mailto:clientapps-dev-bounces helixcommunity.org]
Sent: Wednesday, July 25, 2007 11:01 AM
To: clientapps-dev-bounces helixcommunity.org;
clientapps-dev helixcommunity.org; client-dev helixcommunity.org
Subject: RE: RESEND :
[Clientapps-dev]CR-Client:RemovingHELIX_CONFIG_SYMBIAN_MMF_R
OM_ONLY to
allow asingle build
Hi
Could someone please take a look at this CR.
I would like to check this in today so that these changes
make it to the
next release.
- Thanks
Anshuman
-----Original Message-----
From: clientapps-dev-bounces helixcommunity.org
[mailto:clientapps-dev-bounces helixcommunity.org]
Sent: Tuesday, July 24, 2007 7:06 PM
To: clientapps-dev-bounces helixcommunity.org;
clientapps-dev helixcommunity.org
Subject: RESEND : [Clientapps-dev]
CR-Client:RemovingHELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to allow
a single
build
-----Original Message-----
From: clientapps-dev-bounces helixcommunity.org
[mailto:clientapps-dev-bounces helixcommunity.org]
Sent: Monday, July 23, 2007 7:15 PM
To: clientapps-dev helixcommunity.org
Subject: [Clientapps-dev] CR-Client:
RemovingHELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to allow a single
build
"Nokia submits this code under the terms of a
commercial contribution
agreement with RealNetworks, and I am authorized to
contribute this code
under said agreement."
Modified by: anshuman.tewari nokia.com
Reviewed by:
Date: 4/23/2007
Project: SymbianMmf
ErrorId: 101-36687
Synopsis: Removing HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY to
allow a single
build for creating SISX install files and ROM image.
Description:
Currently to create a Helix SISX package,the flag
HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY has to be commented out
and the
sources rebuilt. Helix can be installed on the phones as
after market
update. In such cases it should not be necassary to rebuild
the sources
to create a sisx package. It should be possible to create
the SISX
packages by simply the prebuilt binaries from the
Build/Release Team.
1) Removed the flag HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY from
the
helix-client-s60-mmf-common.pfi
Similar changes are done for the
helix-s60-metadataengine.pf.
In /build/umakecf/symbian.cf Changes made so that the
copyDlls.bat
will always be run at the end of the build.
2) GetShadowPath returns the drive letter and the directory
where the
Operator Config file is present.
The Operator config file will be present either burned in
ROM [Z:] or
be a part of the installation package.
i.e. installed either on C: drive or the MMC Card. The
rest of the
config files will be searched in the same
directory. GetFullPath() and GetInstallDrive() are
replaced with
GetShadowPath. This function searches for the
Operator config file across drives.
3) Removed
KHXDefaultMMFCtrlDrive/EMMFCtrlPath/EShadowFilePath from
the
audio+video controllers
4) Removed HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY from
clientappssymbianMmf[audio|video]controllerMmfSis
to allow for CopyDlls.bat to be created.
6) Removed the ROM_ONLY flag from the RSS files.
Root Cause of the problem: New Requirement
Files Modified:
umakepf/helix-client-s60-mmf-common.pfi
umakepf/helix-s60-metadataengine.pf
umakecf/symbian.cf
M symbianMmf/audiocontroller/10207B64.rss
M symbianMmf/audiocontroller/controllersis
M symbianMmf/audiocontroller/hxmmfaudioctrl.cpp
M symbianMmf/common/hxmmfbasectrl.cpp
M symbianMmf/common/hxmmfbasectrl.h
M symbianMmf/common/hxmmfbasedefines.h
M symbianMmf/videocontroller/101F8513.rss
M symbianMmf/videocontroller/MmfSis
M symbianMmf/videocontroller/hxmmfctrlimpl.cpp
Files Added: None
Image Size and Heap Use impact: None
Module Release testing (STIF) : Yes
Test case(s) Added : N/A
Memory leak check performed : Yes no leaks introduced.
Platforms and Profiles Build Verified:
helix-client-s60-32-mmf-mdf-arm
Platforms and Profiles Functionality verified: armv5, winscw
Branch: Head & 210CayS
cvs diff: Diffing umakepf
Index: umakepf/helix-client-s60-mmf-common.pfi
============================================================
=======
RCS file:
/cvsroot/ribosome/build/umakepf/helix-client-s60-mmf-common.
pfi,v
retrieving revision 1.18
diff -w -u -b -r1.18 helix-client-s60-mmf-common.pfi
--- umakepf/helix-client-s60-mmf-common.pfi 3 Apr 2007
18:57:54
-0000 1.18
+++ umakepf/helix-client-s60-mmf-common.pfi 23 Jul 2007
21:24:36
-0000
 -80,9
+80,6 
if not project.IsDefined('HELIX_FEATURE_LOGLEVEL_NONE'):
project.AddDefines('HELIX_FEATURE_CORE_LOG')
-# ROM ONLY FLAG is used to build MMF controller as a part
of Phone
image.
-# This flag has to commented to build MMF Controller as SIS
package
-project.AddDefines('HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY')
# This flag to set link option to ALL -tcb
project.AddDefines('HELIX_CONFIG_SYMBIAN_CAP_ECOM_PLUGIN')
Index: umakepf/helix-s60-metadataengine.pf
============================================================
=======
RCS file:
/cvsroot/ribosome/build/umakepf/helix-s60-metadataengine.pf,
v
retrieving revision 1.1
diff -w -u -b -r1.1 helix-s60-metadataengine.pf
--- umakepf/helix-s60-metadataengine.pf 19 Sep 2006 21:54:10
-0000
1.1
+++ umakepf/helix-s60-metadataengine.pf 23 Jul 2007 21:24:36
-0000
 -79,5
+79,5 
project.AddDefines('HELIX_CONFIG_DTDR_DISABLE_LOGGING')
project.AddDefines('HELIX_FEATURE_MINI_SMPLFSYS')
-project.AddDefines('HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY')
+
Index: umakecf/symbian.cf
============================================================
=======
RCS file: /cvsroot/ribosome/build/umakecf/symbian.cf,v
retrieving revision 1.59
diff -w -u -b -r1.59 symbian.cf
--- umakecf/symbian.cf 13 Jun 2007 01:12:50 -0000
1.59
+++ umakecf/symbian.cf 23 Jul 2007 21:24:36 -0000
 -605,7
+605,7 
# output makefile instructions to build the .sis
project.writeln("all: %s" % sisname)
- if
project.IsDefined("HELIX_CONFIG_SYMBIAN_MMF_ROM_ONLY&qu
ot;):
+ if
project.IsDefined("HELIX_FEATURE_SYMBIAN_MMF"):
project.writeln("t %s" %
"copyDlls.bat" )
project.writeln("n")
_______________________________________________
Clientapps-dev mailing list
Clientapps-dev helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
_______________________________________________
Clientapps-dev mailing list
Clientapps-dev helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
_______________________________________________
Clientapps-dev mailing list
Clientapps-dev helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
|
|
[1-5]
|
|