CN: Flag out ReleaseLogSystem() for building with Log level 0

 Thanks Greg, change committed to HEAD and
hxclient_2_1_0_cayennes

-----Original Message-----
From: ext Greg Wright [mailto:gwrightreal.com] 
Sent: Monday, September 17, 2007 12:30 PM
To: Chen Carol.I (Nokia-TP-MSW/Dallas)
Cc: clientapps-devhelixcommunity.org
Subject: Re: [Clientapps-dev] CR: Flag out
ReleaseLogSystem() for
building with Log level 0

Looks good.
--greg.

Carol.i.Chennokia.com wrote:
>> "Nokia submits this code under the terms of a
commercial contribution

>> agreement with RealNetworks, and I am authorized to
contribute this 
>> code under said agreement."
>>
>> Modified by:
>>     carol.i.chennokia.com
>>
>> Reviewed by:
>>
>> Date: 
>>     September 14, 2007
>>
>> Error ID:
>>     TBD
>>
>> Project: 
>>     SymbianMmf_Rel
>>
>>
>> Synopsis: 
>>
>> Found a build break when rebuilding Helix with log
level 0, caused by

>> the function ReleaseLogSystem() not being excluded
with appropriate 
>> flags.
>>
>> Root Cause of the problem: Implementation
>>
>>
>> Files Modified:
>>     clientapps/symbianMmf/hxmmfcontext.cpp
>>
>> Image Size and Heap Use impact: 
>>     none
>>
>> Module Release testing (STIF):
>>     ran and passed
>>
>> Test case(s) Added:
>>     none
>>
>> Memory leak check performed:
>>     Yes, no new leaks introduced.
>>
>> Platforms and Profiles Build Verified: 
>>     armv5 / helix-client-s60-32-mmf-mdf-arm
>>     winscw / helix-client-s60-32-mmf-mdf-arm
>>
>> Platforms and Profiles Functionality verified: 
>>     armv5 / helix-client-s60-32-mmf-mdf-arm
>>
>> Branch: 
>>     HEAD and hxclient_2_1_0_cayennes
>>
>>
>>
>>
>> Index: hxmmfcontext.cpp
>>
============================================================
=======
>> RCS file:
/cvsroot/clientapps/symbianMmf/hxmmfcontext.cpp,v
>> retrieving revision 1.1.2.1
>> diff -u -w -r1.1.2.1 hxmmfcontext.cpp
>> --- hxmmfcontext.cpp    28 Aug 2007 19:58:28 -0000 
    1.1.2.1
>> +++ hxmmfcontext.cpp    14 Sep 2007 20:32:31 -0000
>>  -151,6 +151,7 
>>  }
>>
>>
>> +#if !defined(HELIX_FEATURE_LOGLEVEL_NONE)
&&
>> defined(HELIX_FEATURE_CORE_LOG)
>>  //
>>  // HXMMFContext::ReleaseLogSystem()
>>  // Static function used for GlobalMgr installation
 -160,6
+161,7 
>> 
>>      IHXTLogSystem* pLog = (IHXTLogSystem*)
pLogSystem;
>>      HX_RELEASE(pLog);
>>  }
>> +#endif
>>
>>  //
>>  // HXMMFContext::Close()
>>
>>
> 
> 
>
------------------------------------------------------------
----------
> --
> 
> _______________________________________________
> Clientapps-dev mailing list
> Clientapps-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev


_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev