|
List Info
Thread: CR: Log tracing setting
|
|
| CR: Log tracing setting |
|
2007-09-27 12:19:14 |
Nokia submits this code under the terms of a commercial
contribution
agreement with RealNetworks, and I am authorized to
contribute this code
under said agreement."
Modified by: john.wei nokia.com
Reviewed by:
Date: 27-Sept-2007
Project: SymbianMmf_Rel
TSW: MTVN-76YDSU
Synopsis: Log tracing setting
In current codes, log is disabled by default in both udeb
and urel
environment. User needs to override this setting in the
configuration
file.
This CR proposes a solution that sets log tracing enabled by
default in
udeb image and disabled by default in urel image.
Files Modified:
/cvsroot/common/log/logobserverfile/hxtlogobserver.cpp
/cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Facto
ry.cfg
Index: R1_Mobile_4_0_Factory.cfg
============================================================
=======
RCS file:
/cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Facto
ry.cfg,v
retrieving revision 1.26.2.17
diff -u -w -b -r1.26.2.17 R1_Mobile_4_0_Factory.cfg
--- R1_Mobile_4_0_Factory.cfg 16 Aug 2007 16:24:04 -0000
1.26.2.17
+++ R1_Mobile_4_0_Factory.cfg 27 Sep 2007 17:02:31 -0000
-75,7
+75,8
LoggingFileFileName=console
LoggingFileLevelFilter=2
LoggingFileAreaFilter=SMMF,ADEV,CORE,VIDE,NSRC,NETW,RTSP,
SXPS
-LoggingFileEnabled=0
+#Default: LoggingFileEnabled=1 in Udeb and
LoggingFileEnabled=0 in
Urel
+#LoggingFileEnabled=0
#### Value for enabling/disabling video rebuffer
# 0 = do not rebuffer on video
# 1 = rebuffer on video
Index: hxtlogobserver.cpp
============================================================
=======
RCS file:
/cvsroot/common/log/logobserverfile/hxtlogobserver.cpp,v
retrieving revision 1.13.2.1
diff -u -w -b -r1.13.2.1 hxtlogobserver.cpp
--- hxtlogobserver.cpp 19 Jul 2006 13:34:24 -0000 1.13.2.1
+++ hxtlogobserver.cpp 27 Sep 2007 17:01:59 -0000
-1119,8
+1119,13
{
// DPRINTF_INIT(pPrefs);
// Read the enabled pref
- HXBOOL bEnabled = TRUE;
- ReadPrefBOOL(pPrefs,
"Logging\File\Enabled", bEnabled);
+ HXBOOL bEnabled = FALSE;
+ if( ReadPrefBOOL(pPrefs,
"Logging\File\Enabled",
bEnabled) != HXR_OK )
+ {
+# if defined( _DEBUG )
+ bEnabled = TRUE;
+#endif
+ }
// Are we using queue/delivery thread mode?
m_bEnableDeliveryThread =
HXLOG_ENABLE_DELIVERY_THREAD_PREFVAL_DEFAULT;
======================================================
Image Size and Heap Use impact: minor
Module Release testing (STIF) : N/A
Test case(s) Added : yes
Memory leak check performed : Yes. No new leaks introduced.
Platforms and Profiles Build Verified:
helix-client-s60-32-mmf-mdf-arm
Platforms and Profiles Functionality verified: armv5, winscw
Branch: Head & 210CayS
_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
|
|
| Re: CR: Log tracing setting |
 
United States |
2007-09-27 13:25:50 |
Looks good.
--greg.
john.weinokia.com wrote:
> Nokia submits this code under the terms of a commercial
contribution
> agreement with RealNetworks, and I am authorized to
contribute this code
> under said agreement."
>
> Modified by: john.weinokia.com
>
> Reviewed by:
>
> Date: 27-Sept-2007
>
> Project: SymbianMmf_Rel
>
> TSW: MTVN-76YDSU
>
> Synopsis: Log tracing setting
>
> In current codes, log is disabled by default in both
udeb and urel
> environment. User needs to override this setting in the
configuration
> file.
>
> This CR proposes a solution that sets log tracing
enabled by default in
> udeb image and disabled by default in urel image.
>
> Files Modified:
>
> /cvsroot/common/log/logobserverfile/hxtlogobserver.cpp
>
/cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Facto
ry.cfg
>
> Index: R1_Mobile_4_0_Factory.cfg
>
============================================================
=======
> RCS file:
>
/cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Facto
ry.cfg,v
> retrieving revision 1.26.2.17
> diff -u -w -b -r1.26.2.17 R1_Mobile_4_0_Factory.cfg
> --- R1_Mobile_4_0_Factory.cfg 16 Aug 2007 16:24:04
-0000
> 1.26.2.17
> +++ R1_Mobile_4_0_Factory.cfg 27 Sep 2007 17:02:31
-0000
> -75,7 +75,8
> LoggingFileFileName=console
> LoggingFileLevelFilter=2
>
LoggingFileAreaFilter=SMMF,ADEV,CORE,VIDE,NSRC,NETW,RTSP,S
XPS
> -LoggingFileEnabled=0
> +#Default: LoggingFileEnabled=1 in Udeb and
LoggingFileEnabled=0 in
> Urel
> +#LoggingFileEnabled=0
> #### Value for enabling/disabling video rebuffer
> # 0 = do not rebuffer on video
> # 1 = rebuffer on video
>
> Index: hxtlogobserver.cpp
>
============================================================
=======
> RCS file:
/cvsroot/common/log/logobserverfile/hxtlogobserver.cpp,v
> retrieving revision 1.13.2.1
> diff -u -w -b -r1.13.2.1 hxtlogobserver.cpp
> --- hxtlogobserver.cpp 19 Jul 2006 13:34:24
-0000 1.13.2.1
> +++ hxtlogobserver.cpp 27 Sep 2007 17:01:59 -0000
> -1119,8 +1119,13
> {
> // DPRINTF_INIT(pPrefs);
> // Read the enabled pref
> - HXBOOL bEnabled = TRUE;
> - ReadPrefBOOL(pPrefs,
"Logging\File\Enabled", bEnabled);
> + HXBOOL bEnabled = FALSE;
> + if( ReadPrefBOOL(pPrefs,
"Logging\File\Enabled",
> bEnabled) != HXR_OK )
> + {
> +# if defined( _DEBUG )
> + bEnabled = TRUE;
> +#endif
> + }
>
> // Are we using queue/delivery thread
mode?
> m_bEnableDeliveryThread =
> HXLOG_ENABLE_DELIVERY_THREAD_PREFVAL_DEFAULT;
>
> ======================================================
> Image Size and Heap Use impact: minor
>
> Module Release testing (STIF) : N/A
>
> Test case(s) Added : yes
>
> Memory leak check performed : Yes. No new leaks
introduced.
>
> Platforms and Profiles Build Verified:
helix-client-s60-32-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5,
winscw
>
> Branch: Head & 210CayS
_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
|
|
| RE: CR: Log tracing setting |
|
2007-09-27 14:27:52 |
Hi, Greg,
Thanks. Changes have been checked into both Head and
Cayes210 in CVS.
Br,
--john
-----Original Message-----
From: ext Greg Wright [mailto:gwrightreal.com]
Sent: Thursday, September 27, 2007 1:26 PM
To: Wei John (Nokia-TP-MSW/Dallas)
Cc: common-devhelixcommunity.org; clientapps-devhelixcommunity.org;
ehychereal.com
Subject: Re: CR: Log tracing setting
Looks good.
--greg.
john.weinokia.com wrote:
> Nokia submits this code under the terms of a commercial
contribution
> agreement with RealNetworks, and I am authorized to
contribute this
> code under said agreement."
>
> Modified by: john.weinokia.com
>
> Reviewed by:
>
> Date: 27-Sept-2007
>
> Project: SymbianMmf_Rel
>
> TSW: MTVN-76YDSU
>
> Synopsis: Log tracing setting
>
> In current codes, log is disabled by default in both
udeb and urel
> environment. User needs to override this setting in the
configuration
> file.
>
> This CR proposes a solution that sets log tracing
enabled by default
> in udeb image and disabled by default in urel image.
>
> Files Modified:
>
> /cvsroot/common/log/logobserverfile/hxtlogobserver.cpp
>
/cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Facto
ry.cfg
>
> Index: R1_Mobile_4_0_Factory.cfg
>
============================================================
=======
> RCS file:
>
/cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Facto
ry.cfg,v
> retrieving revision 1.26.2.17
> diff -u -w -b -r1.26.2.17 R1_Mobile_4_0_Factory.cfg
> --- R1_Mobile_4_0_Factory.cfg 16 Aug 2007 16:24:04
-0000
> 1.26.2.17
> +++ R1_Mobile_4_0_Factory.cfg 27 Sep 2007 17:02:31
-0000
> -75,7 +75,8
> LoggingFileFileName=console
> LoggingFileLevelFilter=2
>
LoggingFileAreaFilter=SMMF,ADEV,CORE,VIDE,NSRC,NETW,RTSP,S
XPS
> -LoggingFileEnabled=0
> +#Default: LoggingFileEnabled=1 in Udeb and
LoggingFileEnabled=0
> +in
> Urel
> +#LoggingFileEnabled=0
> #### Value for enabling/disabling video rebuffer # 0
= do not
> rebuffer on video # 1 = rebuffer on video
>
> Index: hxtlogobserver.cpp
>
============================================================
=======
> RCS file:
/cvsroot/common/log/logobserverfile/hxtlogobserver.cpp,v
> retrieving revision 1.13.2.1
> diff -u -w -b -r1.13.2.1 hxtlogobserver.cpp
> --- hxtlogobserver.cpp 19 Jul 2006 13:34:24
-0000 1.13.2.1
> +++ hxtlogobserver.cpp 27 Sep 2007 17:01:59 -0000
> -1119,8 +1119,13
> {
> // DPRINTF_INIT(pPrefs);
> // Read the enabled pref
> - HXBOOL bEnabled = TRUE;
> - ReadPrefBOOL(pPrefs,
"Logging\File\Enabled", bEnabled);
> + HXBOOL bEnabled = FALSE;
> + if( ReadPrefBOOL(pPrefs,
"Logging\File\Enabled",
> bEnabled) != HXR_OK )
> + {
> +# if defined( _DEBUG )
> + bEnabled = TRUE;
> +#endif
> + }
>
> // Are we using queue/delivery thread
mode?
> m_bEnableDeliveryThread =
> HXLOG_ENABLE_DELIVERY_THREAD_PREFVAL_DEFAULT;
>
> ======================================================
> Image Size and Heap Use impact: minor
>
> Module Release testing (STIF) : N/A
>
> Test case(s) Added : yes
>
> Memory leak check performed : Yes. No new leaks
introduced.
>
> Platforms and Profiles Build Verified:
helix-client-s60-32-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified: armv5,
winscw
>
> Branch: Head & 210CayS
_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
|
|
[1-3]
|
|