Thanks Greg. I have moved the check so that it doesn't read
the volume
settings if "RememberVolumeSettings" is FALSE.
This change is checked in to 210Cays and HEAD.
Thanks
Ashish
-----Original Message-----
From: ext Greg Wright [mailto:gwright real.com]
Sent: Thursday, October 18, 2007 4:27 PM
To: Gupta Ashish.As (Nokia-TP-MSW/Dallas)
Cc: clientapps-devhelixcommunity.org; client-devhelixcommunity.org
Subject: Re: [Client-dev] CR: Don't remember volume
settings
Ashish.As.Guptanokia.com wrote:
> Do not remember volume settings
>
> Nokia submits this code under the terms of a commercial
contribution
> agreement with RealNetworks, and I am authorized to
contribute this
> code under said agreement."
>
> Modified by: ashish.as.guptanokia.com
>
> Reviewed by:
>
> Date: 17-Oct-2007
>
> Project: SymbianMmf_Rel
>
> TSW: MKUN-776FC8
>
> Synopsis: Do not remember volume settings
>
> It is required that controllers don't remember the
volume settings
> (Mute and Volume). A new pref,
"RemeberVolumeSettings" is added to
> control this. If this pref is not defined, helix core
will remember
> the last volume Settings.
> Config file for Symbian is modified so that helix core
doesn't
> remember the volume settings.
>
> Files Modified:
>
> client/audiosvc/hxaudses.cpp
>
clientapps/symbiancommon/config/R1_Mobile_4_0_Factory.cfg
>
> Image Size and Heap Use impact: very minor.
>
> Module Release testing (STIF): Yes, all test cases
passed.
>
> Test case(s) Added: none
>
> Memory leak check performed: Yes, no new leaks
introduced.
>
> Platforms and Profiles Build Verified:
> armv5 / helix-client-s60-32-mmf-mdf-arm
> winscw / helix-client-s60-32-mmf-mdf-arm
>
> Platforms and Profiles Functionality verified:
> armv5 / helix-client-s60-32-mmf-mdf-arm, winscw /
> helix-client-s60-32-mmf-mdf-arm
>
> Branch:
> HEAD and hxclient_2_1_0_cayennes
>
>
>
> Index: R1_Mobile_4_0_Factory.cfg
>
============================================================
=======
> RCS file:
>
/cvsroot/clientapps/symbiancommon/config/R1_Mobile_4_0_Facto
ry.cfg,v
> retrieving revision 1.26.2.18
> diff -u -w -r1.26.2.18 R1_Mobile_4_0_Factory.cfg
> --- R1_Mobile_4_0_Factory.cfg 27 Sep 2007 19:20:54
-0000
> 1.26.2.18
> +++ R1_Mobile_4_0_Factory.cfg 17 Oct 2007 22:59:19
-0000
> -71,6 +71,7
> HorizontalAlignment=0
> VerticalAlignment=0
> PrebufferOnSeek=1
> +RememberVolumeSettings=0
> #Log values
> LoggingFileFileName=console
> LoggingFileLevelFilter=2
>
>
> Index: hxaudses.cpp
>
============================================================
=======
> RCS file: /cvsroot/client/audiosvc/hxaudses.cpp,v
> retrieving revision 1.64.2.3
> diff -u -w -r1.64.2.3 hxaudses.cpp
> --- hxaudses.cpp 7 Jun 2007 18:02:07 -0000 1.64.2.3
> +++ hxaudses.cpp 17 Oct 2007 22:16:27 -0000
> -385,9 +385,15
> HX_RELEASE(m_pInterruptState);
>
> #if defined(HELIX_FEATURE_PREFERENCES)
> +
> if (m_pPreferences)
> {
> + HXBOOL bRememberVolumeSettings = TRUE;
> + ReadPrefBOOL(m_pPreferences,
"RememberVolumeSettings",
> bRememberVolumeSettings);
> +
> /* Store the last volume setting */
> + if (bRememberVolumeSettings)
> + {
> IHXBuffer* pBuffer = new CHXBuffer;
> pBuffer->AddRef();
> pBuffer->SetSize(16);
> -404,6 +410,7
> m_pPreferences->WritePref("Mute",
pMuteBuffer);
> pMuteBuffer->Release();
> #endif /* HELIX_FEATURE_MUTE_PREFERENCE */
> + }
I am thinking that it would make more sense to prevent the
reading of
the "mute" and "volume" preference
rather then prevent the writing of
them. Because, if for any reason, a "mute" or
"volume" pref did get
written, by another Helix bases application for example, the
player
would all of a sudden start 'remembering' those settings
again. If you
prevent the reading of the prefs then it doesn't matter what
happens to
the prefs file they won't be used. Somewhere around here:
if (m_pPreferences)
{
if (ReadPrefUINT16(m_pPreferences,
"Volume", m_uVolume) !=
HXR_OK)
{
BOOL bUseDS = TRUE;
ReadPrefBOOL(m_pPreferences,
"UseDirectSound", bUseDS);
if(bUseDS)
{
m_uVolume = HX_MAX_VOLUME;
}
}
#if defined(HELIX_FEATURE_MUTE_PREFERENCE )
ReadPrefBOOL(m_pPreferences, "Mute",
m_bMute); #endif /*
HELIX_FEATURE_MUTE_PREFERENCE */
--greg.
>
> HX_RELEASE(m_pPreferences);
> #ifdef _UNIX
>
>
>
>
>
------------------------------------------------------------
----------
> --
>
> _______________________________________________
> Client-dev mailing list
> Client-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/clie
nt-dev
_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev
|
