CR: Video playback got "General: System Error", when play video to the end after

"Nokia submits this code under the terms of a commercial contribution agreement
with RealNetworks, and I am authorized to contribute this code under said agreement."

Modified by: arnold.jiaunokia.com
 
Reviewed by: 

Date: 20-March-2008
 
Project: SymbianMmf_Rel

TSW: AJIU-7CVSQH

Synopsis: Fix to show the normal information instead of showing "General: System Error";, when the normal resource restoring event happens.

Overview: Helix engine failure to store the last error number causes the incorrect error message "system error"; sent to media player. Made changes as given in the diff file.

 
Files Modified:
clientappssymbianMmfvideocontrollerhxmmfctrlimpl.cpp
clientappssymbianMmfcommonhxmmfbasectrl.cpp

Image Size and Heap Use impact: None
 
Module Release testing (STIF) : Pass
 
Test case(s) Added ; :  No

Memory leak check performed : No new leaks introduced. 

Platforms and Profiles Build Verified:
Profile -> helix-client-s60-32-mmf-mdf-arm
BIF branch  -> helix_restricted
SYSTEM_ID -> symbian-91-armv5
Target -> symbianMmf_rel
 
Platforms and Profiles Functionality verified: armv5, winscw
 
Branch: 210CayS,  221CayS& head

Index: hxmmfctrlimpl.cpp
===================================================================
RCS file: /cvsroot/clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp,v
retrieving revision 1.12.2.58.2.1
diff -u -w -r1.12.2.58.2.1 hxmmfctrlimpl.cpp
--- hxmmfctrlimpl.cpp   11 Feb 2008 18:32:58 -0000 ;     1.12.2.58.2.1
+++ hxmmfctrlimpl.cpp   20 Mar 2008 16:23:19 -0000
-1146,10 +1146,7
           ;  }
           ;  else if (ulHXCode_local == HXR_DEVVIDEO_RESOURCE_RESTORED)
           ;  {
-         ;       //Once a sutiable error code from Symbian is available this will put back in
-         ;       // to notify clients. It still works without the event at this time
-
-         ;       //SendEvent(VideoDeviceRestored, ulHXCode_local);
+         ;       SendEvent(VideoDeviceRestored, ulHXCode_local);
           ;  }
           ;  else
           ;  {

Index: hxmmfbasectrl.cpp
===================================================================
RCS file: /cvsroot/clientapps/symbianMmf/common/hxmmfbasectrl.cpp,v
retrieving revision 1.1.2.35.2.2
diff -u -w -r1.1.2.35.2.2 hxmmfbasectrl.cpp
--- hxmmfbasectrl.cpp   28 Feb 2008 14:21:34 -0000 ;     1.1.2.35.2.2
+++ hxmmfbasectrl.cpp   20 Mar 2008 16:24:57 -0000
-330,7 +330,9
         mmfEvent = KMMFEventCategoryVideoPlayerGeneralError;
         break;
     case VideoDeviceRestored:
-        mmfEvent = KMMFEventCategoryVideoPlayerGeneralError;
+        // mmfEvent = New Event Mapping needed here.
+        // provide the correct mapping for VideoDeviceRestored
+        status = false;
         break;
     default:
         status = false;

---

From: clientapps-dev-bounceshelixcommunity.org [mailto:clientapps-dev-bounceshelixcommunity.org]
Sent: Thursday, March 20, 2008 12:47 PM
To: clientapps-devhelixcommunity.org
Subject: [Clientapps-dev] CR: Video playback got "General: System Error",when play video to the end after terminating the incoming call

"Nokia submits this code under the terms of a commercial contribution agreement
with RealNetworks, and I am authorized to contribute this code under said agreement."

Modified by: arnold.jiaunokia.com
 
Reviewed by: 

Date: 20-March-2008
 
Project: SymbianMmf_Rel

TSW: AJIU-7CVSQH

Synopsis: Fix to show the normal information instead of showing "General: System Error", when the normal resource restoring event happens.

Overview: Helix engine failure to store the last error number causes the incorrect error message "system error" sent to media player. Made changes as given in the diff file.


Files Modified:
clientappssymbianMmfvideocontrollerhxmmfctrlimpl.cpp
clientappssymbianMmfcommonhxmmfbasectrl.cpp

Image Size and Heap Use impact: None
 
Module Release testing (STIF) : Pass
 
Test case(s) Added ; :  No

Memory leak check performed : No new leaks introduced. 

Platforms and Profiles Build Verified:
Profile -> helix-client-s60-32-mmf-mdf-arm
BIF branch  -> helix_restricted
SYSTEM_ID -> symbian-91-armv5
Target -> symbianMmf_rel
 
Platforms and Profiles Functionality verified: armv5, winscw
 
Branch: 210CayS,  221CayS& head

Index: hxmmfctrlimpl.cpp
===================================================================
RCS file: /cvsroot/clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp,v
retrieving revision 1.12.2.58.2.1
diff -u -w -r1.12.2.58.2.1 hxmmfctrlimpl.cpp
--- hxmmfctrlimpl.cpp   11 Feb 2008 18:32:58 -0000 ;     1.12.2.58.2.1
+++ hxmmfctrlimpl.cpp   20 Mar 2008 16:23:19 -0000
-1146,10 +1146,7
           ;  }
           ;  else if (ulHXCode_local == HXR_DEVVIDEO_RESOURCE_RESTORED)
           ;  {
-         ;       //Once a sutiable error code from Symbian is available this will put back in
-         ;       // to notify clients. It still works without the event at this time
-
-         ;       //SendEvent(VideoDeviceRestored, ulHXCode_local);
+         ;       SendEvent(VideoDeviceRestored, ulHXCode_local);
           ;  }
           ;  else
           ;  {

Index: hxmmfbasectrl.cpp
===================================================================
RCS file: /cvsroot/clientapps/symbianMmf/common/hxmmfbasectrl.cpp,v
retrieving revision 1.1.2.35.2.2
diff -u -w -r1.1.2.35.2.2 hxmmfbasectrl.cpp
--- hxmmfbasectrl.cpp   28 Feb 2008 14:21:34 -0000 ;     1.1.2.35.2.2
+++ hxmmfbasectrl.cpp   20 Mar 2008 16:24:57 -0000
-330,7 +330,9
         mmfEvent = KMMFEventCategoryVideoPlayerGeneralError;
         break;
     case VideoDeviceRestored:
-        mmfEvent = KMMFEventCategoryVideoPlayerGeneralError;
+        // mmfEvent = New Event Mapping needed here.
+        // provide the correct mapping for VideoDeviceRestored
+        status = false;
         break;
     default:
         status = false;