CR: Fix to correct failure to pass file read failure to application layer

This looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: nokia-private-dev-bounceshelixcommunity.org 
> [mailto:nokia-private-dev-bounceshelixcommunity.org] On 
> Behalf Of saleem.adookkattilnokia.com
> Sent: Wednesday, April 09, 2008 4:30 PM
> To: clientapps-devhelixcommunity.org; 
> nokia-private-devhelixcommunity.org
> Subject: [Nokia-private-dev] CR: Fix to correct failure
to 
> pass file readfailure to application layer
> 
> "Nokia submits this code under the terms of a
commercial 
> contribution agreement 
> with RealNetworks, and I am authorized to contribute
this 
> code under said agreement." 
> 
> Modified by: saleem.adookkattilnokia.com 
>   
> Reviewed by:  
> 
> Date: 09-April-2008 
>   
> Project: SymbianMmf_Rel 
> 
> TSW: ECTN-7BZUR4 
> 
> Synopsis: Fix to correct failure to pass file read
failure to 
> application layer. 
> 
> Overview: Upon file read failure
CHXDataSourceMMFClip::Read 
> method sets the last error to HXR_READ_ERROR. Then 
> HXFileSource and CHXMiniFileObject instances failed to
pass 
> failure to application layer. Fix made to correct them
as 
> given in the diff files.
> 
>   
> Files Modified: 
>   
> /cvsroot/filesystem/local/mini/minifileobj.cpp 
> /cvsroot/client/core/hxflsrc.cpp 
> 
> Image Size and Heap Use impact: None 
>   
> Module Release testing (STIF) : Pass 
>   
> Test case(s) Added  :  No 
> 
> Memory leak check performed : No new leaks introduced. 

> 
> Platforms and Profiles Build Verified: 
> Profile -> helix-client-s60-32-mmf-mdf-arm 
> BIF branch  -> helix_restricted 
> SYSTEM_ID -> symbian-91-armv5 
> Target -> symbianMmf_rel 
>   
> Platforms and Profiles Functionality verified: armv5,
winscw 
>   
> Branch: 210CayS& head 
> 
> Index: hxflsrc.cpp 
>
============================================================
======= 
> RCS file: /cvsroot/client/core/hxflsrc.cpp,v 
> retrieving revision 1.96.2.7 
> diff -u -w -r1.96.2.7 hxflsrc.cpp 
> --- hxflsrc.cpp 22 Jan 2008 16:01:05 -0000     
1.96.2.7 
> +++ hxflsrc.cpp 9 Apr 2008 16:45:20 -0000 
>  -713,7 +713,7  
>                          
>                          if (m_pMimeFinderResponse) 
>                          { 
> -                            
> m_pFileRecognizer->GetMimeType(m_pFileObject, 
> +                            mLastError = 
> m_pFileRecognizer->GetMimeType(m_pFileObject, 
>                                  
> (IHXFileRecognizerResponse*)m_pMimeFinderResponse); 
>                              return; 
>                          } 
> 
> Index: minifileobj.cpp 
>
============================================================
======= 
> RCS file:
/cvsroot/filesystem/local/mini/minifileobj.cpp,v 
> retrieving revision 1.23.2.9 
> diff -u -w -r1.23.2.9 minifileobj.cpp 
> --- minifileobj.cpp     14 Mar 2008 18:25:12 -0000     
1.23.2.9 
> +++ minifileobj.cpp     9 Apr 2008 16:49:43 -0000 
>  -490,7 +490,10  
>      m_FileAccessMode = fileAccessMode; 
>   
>      HX_RESULT fileOpenResult =
OpenFile(fileAccessMode); 
> -    m_pFileResponse->InitDone(fileOpenResult); 
> +    if (fileOpenResult == HXR_OK ) 
> +    { 
> +       fileOpenResult =
m_pFileResponse->InitDone(fileOpenResult); 
> +    } 
>   
>      return fileOpenResult; 
>  } 
> 
> 


_______________________________________________
Clientapps-dev mailing list
Clientapps-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
clientapps-dev