List Info

Thread: CR: VideoFrameSizeL is returningzerovalueforstreaming MPEG4 3gp format
CR: VideoFrameSizeL is returningzerovalueforstreaming MPEG4 3gp format
user name
 2006-05-25 14:48:22 

  


  

    Milko,

 


Do you want this in 1_5_0_cayenne as 
well?


 


Thanks,


 Carol.






From: Chen Carol.I (Nokia-TP-MSW/Dallas) 

Sent: Wednesday, May 24, 2006 5:45 PM
To: 
clientapps-devhelixcommunity.org
Subject: RE: [Clientapps-dev] CR: 
VideoFrameSizeL is returningzerovalueforstreaming MPEG4 3gp 
format





I will commit with Ashish's suggestion if there are no more 
comments.


 


Thanks,


 Carol.






From: clientapps-dev-bounceshelixcommunity.org 
[mailto:clientapps-dev-bounceshelixcommunity.org] 
Sent: Wednesday, 
May 24, 2006 4:01 PM
To: clientapps-dev-bounceshelixcommunity.org; 
clientapps-devhelixcommunity.org
Subject: RE: [Clientapps-dev] CR: 
VideoFrameSizeL is returningzerovalueforstreaming MPEG4 3gp 
format





Yeah but we can still handle the error like 
that


 


        if(m_pMetaData 
!= NULL)
    {
     // Frame size has 
been set in CachePresentationInfo and stored in member 
data
    aVideoFrameSize.iWidth = 
m_lFrameWidth;
 ;   aVideoFrameSize.iHeight = 
m_lFrameHeight;
    }
    
else
    {
       ; 
HXLOGL1(HXLOG_SMMF, "HXMMFCtrlImpl::MvcGetVideoFrameSizeL ERROR LEAVE: 
KErrNotReady");
        
User::Leave(KErrNotReady);
    
}
    


Ashish




  

  

  From: 
  clientapps-dev-bounceshelixcommunity.org 
  [mailto:clientapps-dev-bounceshelixcommunity.org] 
Sent: Wednesday, 
  May 24, 2006 3:41 PM
To: 
  clientapps-devhelixcommunity.org
Subject: RE: [Clientapps-dev] CR: 
  VideoFrameSizeL is returning zerovalueforstreaming MPEG4 3gp 
  format


  

  
Hi 
  Ashish,

  
 

  
This 
  is because we're not parsing info from HXMMFMetaData anymore in 
  MvcGetVideoFrameSizeL. The logic is now in CachePresentationInfo outside of 
  the HELIX_FEATURE_MMF_SITE_CONTROL flag and error is handled there 
  accordingly.

  
 

  
Thanks,

  
 Carol.

  
 

  
-----Original Message-----
From: 
  clientapps-dev-bounceshelixcommunity.org 
  [mailto:clientapps-dev-bounceshelixcommunity.org]
Sent: Wednesday, 
  24 May, 2006 2:31 PM
To: clientapps-dev-bounceshelixcommunity.org; 
  clientapps-devhelixcommunity.org
Subject: RE: [Clientapps-dev] CR: 
  VideoFrameSizeL is returning zero valueforstreaming MPEG4 3gp 
  format


  
Hi Carol,

  
This change removes the error ;handling that leaves 
  with KErrNotReady case.

  
 

  
Thanks

  
Ashish

  
 


  

    

    

    From: 
    clientapps-dev-bounceshelixcommunity.org 
    [mailto:clientapps-dev-bounceshelixcommunity.org] 
Sent: 
    Wednesday, May 24, 2006 12:22 PM
To: 
    clientapps-devhelixcommunity.org
Subject: [Clientapps-dev] CR: 
    VideoFrameSizeL is returning zero value forstreaming MPEG4 3gp 
    format


    

    
"Nokia submits this code under the terms 
    of a commercial contribution agreement 
with RealNetworks, and I am authorized to contribute this code under 
    said agreement." 

    
Modified by: 
    carol.i.chennokia.com 
    

    
Reviewed by: 

    
Date: 
    5-24-2006 

    
Error ID: 
    TSW ID=EOVL-6PFUEZ 

    
Project: 
    Helix plugin for Symbian 
    

    
Synopsis: 
When streaming certain 3GP clips, 
    GetVideoFrameSizeL will return zero. This is because the a=framesize 
    attribute is missing from the SDP. When this happens, the "FrameWidth" and 
    "FrameHeight" values are not set. The fix is to add check for this situation 
    of missing frame size, then assume the track size values of "Width" and 
    "Height" and return those instead of zero.

    
Additionally, since the Frame size check 
    is already in CachePresentationInfo (which is always called), the values are 
    stored in member variables so they can be used in GetVideoFrameSizeL instead 
    of having to parse the header again to obtain the same info.

    
Files Modified: 
    
    clientapps\symbianMmf\hxmmfctrlimpl.h 
    clientapps\symbianMmf\hxmmfctrlimpl.cpp 


    
Files Added: 
    none 

    
Image Size and Heap Use impact: 
    
    minor 
    

    
Platforms and Profiles Build Verified: 
    
    armv5 / 
    helix-client-s60-mmf-mdf-dsp, helix-client-s60-mmf-basic 

    
Platforms and Profiles Functionality 
    verified: 
    
    armv5 / helix-client-s60-mmf-mdf-dsp 

    
Branch: 
    hxclient_2_1_0_cayennes, 
    head 

    
<<clientapps.diff>> 
    

  

  
  
   
     
    






 [1]











   
 





about | contact  Other archives ( Real Estate discussion Medical topics )