List Info

Thread: CR: Helix engine side changes for optimizing videoaspect ratio to t




CR: Helix engine side changes for optimizing videoaspect ratio to t
country flaguser name
United States
2007-08-13 17:41:04
My comment:

I see you added two methods to IHXSurfaceControl. Once
you've
shipped a product with a certain interface, it's generally
bad practice to change the interface. So... a couple of
questions: a) is IHXSurfaceControl a Symbian-specific
interface
(it looks like it *is* to me);  b) have any Symbian products
shipped
with the current version of IHXSurfaceControl?

Rest looks good.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: clientapps-dev-bounceshelixcommunity.org 
> [mailto:clientapps-dev-bounceshelixcommunity.org] On
Behalf 
> Of Praveen.Thimmashettynokia.com
> Sent: Monday, August 13, 2007 4:43 PM
> To: clientapps-devhelixcommunity.org; 
> Datatype-devhelixcommunity.org; 
> Client-devhelixcommunity.org; Video-devhelixcommunity.org; 
> common-devhelixcommunity.org
> Subject: [Clientapps-dev] CR: Helix engine side changes
for 
> optimizing videoaspect ratio to the display aspect
ratio
> 
> "Nokia submits this code under the terms of a
commercial 
> contribution agreement with RealNetworks, and I am
authorized 
> to contribute this code under said agreement."
> 
> Modified by:  praveen.thimmashettynokia.com

> 
> Reviewed by: 
> 
> Date: 13-Aug-2007 
> 
> Project: SymbianMmf_Rel 
> 
> Req ID: 101-30829 
> 
> Synopsis: This requirement adds the support for viewing
video 
> in three different modes. 
> 
> 		                Natural: keeping original video 
> aspect (auto up-scaling as today) 
> 		                Zoom: blow up the picture zoom 
> both X and Y direction and crop to fill the screen 
> 
>                 Stretch: stretch bottom/top or
left/right to 
> fill the screen 
>                 New Custom Interface has been added to
pass 
> Scaling value from client. 
> 
> Files Modified:         client/include/hxsite3.h 
>                
clientapps/symbianMmf/hxmmfsitesupplier.cpp 
>                
clientapps/symbianMmf/hxmmfsitesupplier.h 
>                 
> clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp

>                
clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.h 
>                 
>
common/system/platform/symbian/symbianglobalvideoparameters.
cpp 
>                 
>
common/system/pub/platform/symbian/symbianglobalvideoparamet
ers.h 
>                
datatype/mdf/video/renderer/mdfvideoadapter.cpp 
>                
datatype/mdf/video/renderer/pub/mdfvideoadapter.h 
>                
video/sitelib/platform/symbian/minisymbiansite.cpp 
>                
video/sitelib/pub/platform/symbian/minisymbiansite.h 
> 
> Files Added: 
>                         
>
common/system/pub/platform/symbian/MMFScalingCustomCommandCo
nstants.h 
> 
> ======================================================

> Image Size and Heap Use impact: minor 
> 
> Module Release testing (STIF) :  Passed 
> 
> Test case(s) Added  :  None 
> 
> Memory leak check performed : Yes.  No new leaks
introduced.  
> 
> Platforms and Profiles Build Verified: 
> helix-client-s60-32-mmf-mdf-arm 
> 
> Platforms and Profiles Functionality verified: armv5,
winscw 
> 
> Branch: Head & 210CayS 
> 
> <<src.zip>> <<diff.txt>> 
> 
> 


_______________________________________________
Video-dev mailing list
Video-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/video
-dev

CR: Helix engine side changesfor optimizing vide
user name
2007-08-14 17:24:28
Hi Eric,

Yes it is Symbian MMF specific interface. We are aware about
this and it
should not have such problem due to absence of plugin
updates.


Thanks
Ashish

-----Original Message-----
From: datatype-dev-bounceshelixcommunity.org
[mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of ext Eric
Hyche
Sent: Monday, August 13, 2007 5:41 PM
To: Thimmashetty Praveen (Nokia-TP-MSW/Dallas);
clientapps-devhelixcommunity.org; Datatype-devhelixcommunity.org;
Client-devhelixcommunity.org; Video-devhelixcommunity.org;
common-devhelixcommunity.org
Subject: [datatype-dev] RE: [Clientapps-dev] CR: Helix
engine side
changesfor optimizing videoaspect ratio to the display
aspect ratio


My comment:

I see you added two methods to IHXSurfaceControl. Once
you've shipped a
product with a certain interface, it's generally bad
practice to change
the interface. So... a couple of
questions: a) is IHXSurfaceControl a Symbian-specific
interface (it
looks like it *is* to me);  b) have any Symbian products
shipped with
the current version of IHXSurfaceControl?

Rest looks good.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: clientapps-dev-bounceshelixcommunity.org
> [mailto:clientapps-dev-bounceshelixcommunity.org] On
Behalf Of 
> Praveen.Thimmashettynokia.com
> Sent: Monday, August 13, 2007 4:43 PM
> To: clientapps-devhelixcommunity.org;
> Datatype-devhelixcommunity.org;
> Client-devhelixcommunity.org; Video-devhelixcommunity.org; 
> common-devhelixcommunity.org
> Subject: [Clientapps-dev] CR: Helix engine side changes
for optimizing

> videoaspect ratio to the display aspect ratio
> 
> "Nokia submits this code under the terms of a
commercial contribution 
> agreement with RealNetworks, and I am authorized to
contribute this 
> code under said agreement."
> 
> Modified by:  praveen.thimmashettynokia.com
> 
> Reviewed by: 
> 
> Date: 13-Aug-2007
> 
> Project: SymbianMmf_Rel
> 
> Req ID: 101-30829
> 
> Synopsis: This requirement adds the support for viewing
video in three

> different modes.
> 
> 		                Natural: keeping original video
aspect
(auto 
> up-scaling as today)
> 		                Zoom: blow up the picture zoom both
X
and Y 
> direction and crop to fill the screen
> 
>                 Stretch: stretch bottom/top or
left/right to fill the 
> screen
>                 New Custom Interface has been added to
pass Scaling 
> value from client.
> 
> Files Modified:         client/include/hxsite3.h 
>                
clientapps/symbianMmf/hxmmfsitesupplier.cpp 
>                
clientapps/symbianMmf/hxmmfsitesupplier.h
>                 
> clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp

>                
clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.h
>                 
>
common/system/platform/symbian/symbianglobalvideoparameters.
cpp
>                 
>
common/system/pub/platform/symbian/symbianglobalvideoparamet
ers.h 
>                
datatype/mdf/video/renderer/mdfvideoadapter.cpp 
>                
datatype/mdf/video/renderer/pub/mdfvideoadapter.h 
>                
video/sitelib/platform/symbian/minisymbiansite.cpp 
>                
video/sitelib/pub/platform/symbian/minisymbiansite.h
> 
> Files Added: 
>                         
>
common/system/pub/platform/symbian/MMFScalingCustomCommandCo
nstants.h
> 
> ======================================================
> Image Size and Heap Use impact: minor
> 
> Module Release testing (STIF) :  Passed
> 
> Test case(s) Added  :  None
> 
> Memory leak check performed : Yes.  No new leaks
introduced.  
> 
> Platforms and Profiles Build Verified: 
> helix-client-s60-32-mmf-mdf-arm
> 
> Platforms and Profiles Functionality verified: armv5,
winscw
> 
> Branch: Head & 210CayS
> 
> <<src.zip>> <<diff.txt>>
> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

_______________________________________________
Video-dev mailing list
Video-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/video
-dev

CR: Helix engine side changesfor optimizing vide
country flaguser name
United States
2007-08-16 10:27:08
Ok - sounds good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Ashish.As.Guptanokia.com
[mailto:Ashish.As.Guptanokia.com] 
> Sent: Tuesday, August 14, 2007 6:24 PM
> To: ehychereal.com; Praveen.Thimmashettynokia.com; 
> clientapps-devhelixcommunity.org; 
> Datatype-devhelixcommunity.org; 
> Client-devhelixcommunity.org; Video-devhelixcommunity.org; 
> common-devhelixcommunity.org
> Subject: RE: [datatype-dev] RE: [Clientapps-dev] CR:
Helix 
> engine side changesfor optimizing videoaspect ratio to
the 
> display aspect ratio
> 
> Hi Eric,
> 
> Yes it is Symbian MMF specific interface. We are aware
about 
> this and it
> should not have such problem due to absence of plugin
updates.
> 
> 
> Thanks
> Ashish
> 
> -----Original Message-----
> From: datatype-dev-bounceshelixcommunity.org
> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of ext Eric
> Hyche
> Sent: Monday, August 13, 2007 5:41 PM
> To: Thimmashetty Praveen (Nokia-TP-MSW/Dallas);
> clientapps-devhelixcommunity.org; Datatype-devhelixcommunity.org;
> Client-devhelixcommunity.org; Video-devhelixcommunity.org;
> common-devhelixcommunity.org
> Subject: [datatype-dev] RE: [Clientapps-dev] CR: Helix
engine side
> changesfor optimizing videoaspect ratio to the display
aspect ratio
> 
> 
> My comment:
> 
> I see you added two methods to IHXSurfaceControl. Once
you've 
> shipped a
> product with a certain interface, it's generally bad
practice 
> to change
> the interface. So... a couple of
> questions: a) is IHXSurfaceControl a Symbian-specific
interface (it
> looks like it *is* to me);  b) have any Symbian
products shipped with
> the current version of IHXSurfaceControl?
> 
> Rest looks good.
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: clientapps-dev-bounceshelixcommunity.org
> > [mailto:clientapps-dev-bounceshelixcommunity.org] On Behalf Of 
> > Praveen.Thimmashettynokia.com
> > Sent: Monday, August 13, 2007 4:43 PM
> > To: clientapps-devhelixcommunity.org;
> > Datatype-devhelixcommunity.org;
> > Client-devhelixcommunity.org; Video-devhelixcommunity.org; 
> > common-devhelixcommunity.org
> > Subject: [Clientapps-dev] CR: Helix engine side
changes for 
> optimizing
> 
> > videoaspect ratio to the display aspect ratio
> > 
> > "Nokia submits this code under the terms of a
commercial 
> contribution 
> > agreement with RealNetworks, and I am authorized
to contribute this 
> > code under said agreement."
> > 
> > Modified by:  praveen.thimmashettynokia.com
> > 
> > Reviewed by: 
> > 
> > Date: 13-Aug-2007
> > 
> > Project: SymbianMmf_Rel
> > 
> > Req ID: 101-30829
> > 
> > Synopsis: This requirement adds the support for
viewing 
> video in three
> 
> > different modes.
> > 
> > 		                Natural: keeping original video
aspect
> (auto 
> > up-scaling as today)
> > 		                Zoom: blow up the picture zoom
both X
> and Y 
> > direction and crop to fill the screen
> > 
> >                 Stretch: stretch bottom/top or
left/right 
> to fill the 
> > screen
> >                 New Custom Interface has been
added to pass Scaling 
> > value from client.
> > 
> > Files Modified:         client/include/hxsite3.h 
> >                
clientapps/symbianMmf/hxmmfsitesupplier.cpp 
> >                
clientapps/symbianMmf/hxmmfsitesupplier.h
> >                 
> >
clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp 
> >                 
> clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.h
> >                 
> >
common/system/platform/symbian/symbianglobalvideoparameters.
cpp
> >                 
> >
common/system/pub/platform/symbian/symbianglobalvideoparamet
ers.h 
> >                
datatype/mdf/video/renderer/mdfvideoadapter.cpp 
> >                
datatype/mdf/video/renderer/pub/mdfvideoadapter.h 
> >                
video/sitelib/platform/symbian/minisymbiansite.cpp 
> >                
video/sitelib/pub/platform/symbian/minisymbiansite.h
> > 
> > Files Added: 
> >                         
> > 
>
common/system/pub/platform/symbian/MMFScalingCustomCommandCo
nstants.h
> > 
> >
======================================================
> > Image Size and Heap Use impact: minor
> > 
> > Module Release testing (STIF) :  Passed
> > 
> > Test case(s) Added  :  None
> > 
> > Memory leak check performed : Yes.  No new leaks
introduced.  
> > 
> > Platforms and Profiles Build Verified: 
> > helix-client-s60-32-mmf-mdf-arm
> > 
> > Platforms and Profiles Functionality verified:
armv5, winscw
> > 
> > Branch: Head & 210CayS
> > 
> > <<src.zip>> <<diff.txt>>
> > 
> > 
> 
> 
> _______________________________________________
> Datatype-dev mailing list
> Datatype-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
> 


_______________________________________________
Video-dev mailing list
Video-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/video
-dev

[1-3]

about | contact  Other archives ( Real Estate discussion Medical topics )