CR:Changes in video/sitelib for porting Atlas for Windows Mobile 5.0

anshuman wrote:
> Synopsis:
> Multiple changes for porting Atlas for Windows Mobile
5.0
> 
> Overview:
> 
> - Use GAPI for wince-420-ppc-arm and DirectDraw for
wince-500-ppc-arm .
> - Added feature HELIX_FEATURE_AUTOROTATE 
> - Added feature HELIX_FEATURE_PPC_KEEP_BACKLIGHT_ON
> - Enable full screen playback 
> - Updated minisite with full screen and autororate
support 
> - Added HXTRACES for debugging 



  STDMETHODIMP CMiniBaseSite::ForceRedrawAll()
  {
      HX_RESULT retVal = HXR_OK;
+    CheckDisplayMode(NULL);
      _ForceRedrawAll();
      return retVal;
  }

Please add a newline to the end of the .pcf file.


  STDMETHODIMP CMiniBaseSite::ForceRedrawAll()
  {
      HX_RESULT retVal = HXR_OK;
+    CheckDisplayMode(NULL);
      _ForceRedrawAll();
      return retVal;
  }

ForceRedrawAll() can be called quite often and
CheckDisplayMode()
can be pretty expensive on some platforms. Why do you need
to call
it here, can we move it to somewhere that is called less
often?

+void CMiniBaseSite::_ForceRedrawAll()
+{
+    if( (IsSiteVisible() && m_Region &&
!HXEmptyRegion(m_Region)))
+    {
+        ForceRedraw();
+    }
+}
+

We already have a ForceRedrawAll(). We should just add
#ifdefs
inside of the existing one to encapsulate the child site
stuff.

I think you need to wrap some of the new member vars in the
appropriate helix_feature #defines.

Can you also make sure to compile with and without the
SMIL_SITE helix feature and make sure there are no build
busters and that it runs.

The other comment I have is that we are adding a lot of
code
to a site that is suppose to be very very small. Could you
build the site in release mode, both with and without your
changes and show me the size difference in the .dll? If the
size
difference is large, then I would suggest that you wrap all
of this new code in a (new) #define; perhaps
HELIX_FEATURE_AUTOROTATE
if that is the main purpose of the changes. This applies
only
to the minisite and minisurf. I am not worried about the
changes
in the platform/win files.


Thanks,
--greg.


> 
> Files Added:
> 1.wince-420-ppc-arm.pcf
> 2.wince-500-ppc-arm.pcf
> 
> Files Modified:
> 
> 1. video/sitelib/minisite.cpp
> 2. video/sitelib/minisurf.cpp
> 3. video/sitelib/platform/win/bltobjfact.cpp
> 4. video/sitelib/platform/win/ddblt.cpp
> 5. video/sitelib/platform/win/mwinsite.cpp
> 6. video/sitelib/platform/wince/wingapiblt.cpp
> 7. video/sitelib/pub/minisite.h
> 8. video/sitelib/pub/minisurf.h
> 9. video/sitelib/pub/platform/win/ddblt.h
> 10. video/sitelib/pub/platform/win/mwinsite.h
> 11.video/sitelib/pub/platform/wince/wingapiblt.h
> 
> Image Size and Heap Use impact (Client -Only):
> None.
> 
> Platforms and Profiles Affected:
> platform : wince-500-ppc-arm
> profile    : helix-client-wince-wm50 (new profile)
> 
> Distribution Libraries Affected:
> None
> 
> Distribution library impact and planned action:
> None
> 
> Platforms and Profiles Build Verified:
> 
> BIF branch   -> helix_restricted
> Target(s)      -> wince_wm50_play(new target)
> Profile          -> helix-client-wince-wm50(new
profile)
> System ID   -> wince-500-ppc-arm
> 
> 
> Branch:
> HEAD, hxclient_310_atlas.
> 
> 
> Files Attached
> video_sitelib.diff.txt
> wince-500-ppc-arm.pcf
> wince-420-ppc-arm.pcf
> minisite.cpp
> 
> 
> Thanks & Regards
> Anshuman
> 
> 
>
------------------------------------------------------------
------------
> 
> This body part will be downloaded on demand.


_______________________________________________
Video-dev mailing list
Video-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/video
-dev

Hi Greg,

I have checked the size of sitelib.lib and sitecreatelib.lib
with and 
without the changes in minisite.cpp and minisurf.cpp

With changes:
sitelib.lib         --> 176 KB
sitecreatelib.lib -> 72 KB

Without changes:
sitelib.lib         --> 171 KB
sitecreatelib.lib -> 72 KB

whether the code needs to be wrapped in
HELIX_FEATURE_AUTOROTATE define.

Thanks & Regards
Anshuman

----- Original Message ----- 
From: "Greg Wright" <gwrightreal.com>
To: "anshuman" <asinghadroit-inc.com>
Cc: "video-dev" <video-devhelixcommunity.org>
Sent: Friday, September 14, 2007 5:36 AM
Subject: Re: [Video-dev] [RESEND] CR:Changes in
video/sitelib for porting 
Atlas for Windows Mobile 5.0


> anshuman wrote:
>> Synopsis:
>> Multiple changes for porting Atlas for Windows
Mobile 5.0
>>
>> Overview:
>>
>> - Use GAPI for wince-420-ppc-arm and DirectDraw for
wince-500-ppc-arm .
>> - Added feature HELIX_FEATURE_AUTOROTATE - Added
feature 
>> HELIX_FEATURE_PPC_KEEP_BACKLIGHT_ON
>> - Enable full screen playback - Updated minisite
with full screen and 
>> autororate support - Added HXTRACES for debugging
>
>
>
>  STDMETHODIMP CMiniBaseSite::ForceRedrawAll()
>  {
>      HX_RESULT retVal = HXR_OK;
> +    CheckDisplayMode(NULL);
>      _ForceRedrawAll();
>      return retVal;
>  }
>
> Please add a newline to the end of the .pcf file.
>
>
>  STDMETHODIMP CMiniBaseSite::ForceRedrawAll()
>  {
>      HX_RESULT retVal = HXR_OK;
> +    CheckDisplayMode(NULL);
>      _ForceRedrawAll();
>      return retVal;
>  }
>
> ForceRedrawAll() can be called quite often and
CheckDisplayMode()
> can be pretty expensive on some platforms. Why do you
need to call
> it here, can we move it to somewhere that is called
less often?
>
> +void CMiniBaseSite::_ForceRedrawAll()
> +{
> +    if( (IsSiteVisible() && m_Region
&& !HXEmptyRegion(m_Region)))
> +    {
> +        ForceRedraw();
> +    }
> +}
> +
>
> We already have a ForceRedrawAll(). We should just add
#ifdefs
> inside of the existing one to encapsulate the child
site stuff.
>
> I think you need to wrap some of the new member vars in
the
> appropriate helix_feature #defines.
>
> Can you also make sure to compile with and without the
> SMIL_SITE helix feature and make sure there are no
build
> busters and that it runs.
>
> The other comment I have is that we are adding a lot of
code
> to a site that is suppose to be very very small. Could
you
> build the site in release mode, both with and without
your
> changes and show me the size difference in the .dll? If
the size
> difference is large, then I would suggest that you wrap
all
> of this new code in a (new) #define; perhaps
HELIX_FEATURE_AUTOROTATE
> if that is the main purpose of the changes. This
applies only
> to the minisite and minisurf. I am not worried about
the changes
> in the platform/win files.
>
>
> Thanks,
> --greg.
>
>
>>
>> Files Added:
>> 1.wince-420-ppc-arm.pcf
>> 2.wince-500-ppc-arm.pcf
>>
>> Files Modified:
>>
>> 1. video/sitelib/minisite.cpp
>> 2. video/sitelib/minisurf.cpp
>> 3. video/sitelib/platform/win/bltobjfact.cpp
>> 4. video/sitelib/platform/win/ddblt.cpp
>> 5. video/sitelib/platform/win/mwinsite.cpp
>> 6. video/sitelib/platform/wince/wingapiblt.cpp
>> 7. video/sitelib/pub/minisite.h
>> 8. video/sitelib/pub/minisurf.h
>> 9. video/sitelib/pub/platform/win/ddblt.h
>> 10. video/sitelib/pub/platform/win/mwinsite.h
>> 11.video/sitelib/pub/platform/wince/wingapiblt.h
>>
>> Image Size and Heap Use impact (Client -Only):
>> None.
>>
>> Platforms and Profiles Affected:
>> platform : wince-500-ppc-arm
>> profile    : helix-client-wince-wm50 (new profile)
>>
>> Distribution Libraries Affected:
>> None
>>
>> Distribution library impact and planned action:
>> None
>>
>> Platforms and Profiles Build Verified:
>>
>> BIF branch   -> helix_restricted
>> Target(s)      -> wince_wm50_play(new target)
>> Profile          -> helix-client-wince-wm50(new
profile)
>> System ID   -> wince-500-ppc-arm
>>
>>
>> Branch:
>> HEAD, hxclient_310_atlas.
>>
>>
>> Files Attached
>> video_sitelib.diff.txt
>> wince-500-ppc-arm.pcf
>> wince-420-ppc-arm.pcf
>> minisite.cpp
>>
>>
>> Thanks & Regards
>> Anshuman
>>
>>
>>
------------------------------------------------------------
------------
>>
>> This body part will be downloaded on demand.
>
> 


_______________________________________________
Video-dev mailing list
Video-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/video
-dev

Hi Greg ,

Please find the diff attached.

I have checked the size of vidsite.dll in release build with
and without the 
changes.

 With changes:
 vidsite.dll   --->121 KB

 Without changes:
 vidsite.dll   --->68 KB

I have wrapped the new code in #ifdef 
HELIX_FEATURE_AUTOROTATE.


Thanks & Regards
Anshuman

----- Original Message ----- 
From: "Greg Wright" <gwrightreal.com>
To: "anshuman" <asinghadroit-inc.com>
Cc: "video-dev" <video-devhelixcommunity.org>
Sent: Friday, September 14, 2007 11:40 PM
Subject: Re: [Video-dev] [RESEND] CR:Changes in
video/sitelib for porting 
Atlas for Windows Mobile 5.0


> anshuman wrote:
>> Hi Greg,
>>
>> I have checked the size of sitelib.lib and
sitecreatelib.lib with and 
>> without the changes in minisite.cpp and
minisurf.cpp
>>
>> With changes:
>> sitelib.lib         --> 176 KB
>> sitecreatelib.lib -> 72 KB
>>
>> Without changes:
>> sitelib.lib         --> 171 KB
>> sitecreatelib.lib -> 72 KB
>
> can you please tell me the size of the *release* *DLL*,
not the .lib;
> videosite.dll.
>
> Either way though, I think we should wrap the new code
in a #define.
> It should be pretty easy to do since most all of it is
all together.
> Again, we only care about minisite.cpp and
minisurf.cpp, not any
> of the platform specific code unless there are compile
issues.
>
> --greg.
>
>
>>
>> whether the code needs to be wrapped in
HELIX_FEATURE_AUTOROTATE define.
>>
>> Thanks & Regards
>> Anshuman
>>
>> ----- Original Message ----- From: "Greg
Wright" <gwrightreal.com>
>> To: "anshuman" <asinghadroit-inc.com>
>> Cc: "video-dev" <video-devhelixcommunity.org>
>> Sent: Friday, September 14, 2007 5:36 AM
>> Subject: Re: [Video-dev] [RESEND] CR:Changes in
video/sitelib for porting 
>> Atlas for Windows Mobile 5.0
>>
>>
>>> anshuman wrote:
>>>> Synopsis:
>>>> Multiple changes for porting Atlas for
Windows Mobile 5.0
>>>>
>>>> Overview:
>>>>
>>>> - Use GAPI for wince-420-ppc-arm and
DirectDraw for wince-500-ppc-arm .
>>>> - Added feature HELIX_FEATURE_AUTOROTATE -
Added feature 
>>>> HELIX_FEATURE_PPC_KEEP_BACKLIGHT_ON
>>>> - Enable full screen playback - Updated
minisite with full screen and 
>>>> autororate support - Added HXTRACES for
debugging
>>>
>>>
>>>
>>>  STDMETHODIMP CMiniBaseSite::ForceRedrawAll()
>>>  {
>>>      HX_RESULT retVal = HXR_OK;
>>> +    CheckDisplayMode(NULL);
>>>      _ForceRedrawAll();
>>>      return retVal;
>>>  }
>>>
>>> Please add a newline to the end of the .pcf
file.
>>>
>>>
>>>  STDMETHODIMP CMiniBaseSite::ForceRedrawAll()
>>>  {
>>>      HX_RESULT retVal = HXR_OK;
>>> +    CheckDisplayMode(NULL);
>>>      _ForceRedrawAll();
>>>      return retVal;
>>>  }
>>>
>>> ForceRedrawAll() can be called quite often and
CheckDisplayMode()
>>> can be pretty expensive on some platforms. Why
do you need to call
>>> it here, can we move it to somewhere that is
called less often?
>>>
>>> +void CMiniBaseSite::_ForceRedrawAll()
>>> +{
>>> +    if( (IsSiteVisible() && m_Region
&& !HXEmptyRegion(m_Region)))
>>> +    {
>>> +        ForceRedraw();
>>> +    }
>>> +}
>>> +
>>>
>>> We already have a ForceRedrawAll(). We should
just add #ifdefs
>>> inside of the existing one to encapsulate the
child site stuff.
>>>
>>> I think you need to wrap some of the new member
vars in the
>>> appropriate helix_feature #defines.
>>>
>>> Can you also make sure to compile with and
without the
>>> SMIL_SITE helix feature and make sure there are
no build
>>> busters and that it runs.
>>>
>>> The other comment I have is that we are adding
a lot of code
>>> to a site that is suppose to be very very
small. Could you
>>> build the site in release mode, both with and
without your
>>> changes and show me the size difference in the
.dll? If the size
>>> difference is large, then I would suggest that
you wrap all
>>> of this new code in a (new) #define; perhaps
HELIX_FEATURE_AUTOROTATE
>>> if that is the main purpose of the changes.
This applies only
>>> to the minisite and minisurf. I am not worried
about the changes
>>> in the platform/win files.
>>>
>>>
>>> Thanks,
>>> --greg.
>>>
>>>
>>>>
>>>> Files Added:
>>>> 1.wince-420-ppc-arm.pcf
>>>> 2.wince-500-ppc-arm.pcf
>>>>
>>>> Files Modified:
>>>>
>>>> 1. video/sitelib/minisite.cpp
>>>> 2. video/sitelib/minisurf.cpp
>>>> 3.
video/sitelib/platform/win/bltobjfact.cpp
>>>> 4. video/sitelib/platform/win/ddblt.cpp
>>>> 5. video/sitelib/platform/win/mwinsite.cpp
>>>> 6.
video/sitelib/platform/wince/wingapiblt.cpp
>>>> 7. video/sitelib/pub/minisite.h
>>>> 8. video/sitelib/pub/minisurf.h
>>>> 9. video/sitelib/pub/platform/win/ddblt.h
>>>> 10.
video/sitelib/pub/platform/win/mwinsite.h
>>>>
11.video/sitelib/pub/platform/wince/wingapiblt.h
>>>>
>>>> Image Size and Heap Use impact (Client
-Only):
>>>> None.
>>>>
>>>> Platforms and Profiles Affected:
>>>> platform : wince-500-ppc-arm
>>>> profile    : helix-client-wince-wm50 (new
profile)
>>>>
>>>> Distribution Libraries Affected:
>>>> None
>>>>
>>>> Distribution library impact and planned
action:
>>>> None
>>>>
>>>> Platforms and Profiles Build Verified:
>>>>
>>>> BIF branch   -> helix_restricted
>>>> Target(s)      -> wince_wm50_play(new
target)
>>>> Profile          ->
helix-client-wince-wm50(new profile)
>>>> System ID   -> wince-500-ppc-arm
>>>>
>>>>
>>>> Branch:
>>>> HEAD, hxclient_310_atlas.
>>>>
>>>>
>>>> Files Attached
>>>> video_sitelib.diff.txt
>>>> wince-500-ppc-arm.pcf
>>>> wince-420-ppc-arm.pcf
>>>> minisite.cpp
>>>>
>>>>
>>>> Thanks & Regards
>>>> Anshuman
>>>>
>>>>
>>>>
------------------------------------------------------------
------------
>>>>
>>>> This body part will be downloaded on
demand.
>>>
>>>
>>
>
> 

_______________________________________________
Video-dev mailing list
Video-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/video
-dev

anshuman wrote:
> Hi Greg ,
> 
> Please find the diff attached.
> 
> I have checked the size of vidsite.dll in release build
with and without 
> the changes.
> 
> With changes:
> vidsite.dll   --->121 KB
> 
> Without changes:
> vidsite.dll   --->68 KB
> 
> I have wrapped the new code in #ifdef 
HELIX_FEATURE_AUTOROTATE.

Yeah, that is a big change in the size. But, your wrapped
the
code so its all good.

Looks good.
--greg.

> 
> 
> Thanks & Regards
> Anshuman
> 
> ----- Original Message ----- From: "Greg
Wright" <gwrightreal.com>
> To: "anshuman" <asinghadroit-inc.com>
> Cc: "video-dev" <video-devhelixcommunity.org>
> Sent: Friday, September 14, 2007 11:40 PM
> Subject: Re: [Video-dev] [RESEND] CR:Changes in
video/sitelib for 
> porting Atlas for Windows Mobile 5.0
> 
> 
>> anshuman wrote:
>>> Hi Greg,
>>>
>>> I have checked the size of sitelib.lib and
sitecreatelib.lib with and 
>>> without the changes in minisite.cpp and
minisurf.cpp
>>>
>>> With changes:
>>> sitelib.lib         --> 176 KB
>>> sitecreatelib.lib -> 72 KB
>>>
>>> Without changes:
>>> sitelib.lib         --> 171 KB
>>> sitecreatelib.lib -> 72 KB
>>
>> can you please tell me the size of the *release*
*DLL*, not the .lib;
>> videosite.dll.
>>
>> Either way though, I think we should wrap the new
code in a #define.
>> It should be pretty easy to do since most all of it
is all together.
>> Again, we only care about minisite.cpp and
minisurf.cpp, not any
>> of the platform specific code unless there are
compile issues.
>>
>> --greg.
>>
>>
>>>
>>> whether the code needs to be wrapped in
HELIX_FEATURE_AUTOROTATE define.
>>>
>>> Thanks & Regards
>>> Anshuman
>>>
>>> ----- Original Message ----- From: "Greg
Wright" <gwrightreal.com>
>>> To: "anshuman" <asinghadroit-inc.com>
>>> Cc: "video-dev" <video-devhelixcommunity.org>
>>> Sent: Friday, September 14, 2007 5:36 AM
>>> Subject: Re: [Video-dev] [RESEND] CR:Changes in
video/sitelib for 
>>> porting Atlas for Windows Mobile 5.0
>>>
>>>
>>>> anshuman wrote:
>>>>> Synopsis:
>>>>> Multiple changes for porting Atlas for
Windows Mobile 5.0
>>>>>
>>>>> Overview:
>>>>>
>>>>> - Use GAPI for wince-420-ppc-arm and
DirectDraw for 
>>>>> wince-500-ppc-arm .
>>>>> - Added feature
HELIX_FEATURE_AUTOROTATE - Added feature 
>>>>> HELIX_FEATURE_PPC_KEEP_BACKLIGHT_ON
>>>>> - Enable full screen playback - Updated
minisite with full screen 
>>>>> and autororate support - Added HXTRACES
for debugging
>>>>
>>>>
>>>>
>>>>  STDMETHODIMP
CMiniBaseSite::ForceRedrawAll()
>>>>  {
>>>>      HX_RESULT retVal = HXR_OK;
>>>> +    CheckDisplayMode(NULL);
>>>>      _ForceRedrawAll();
>>>>      return retVal;
>>>>  }
>>>>
>>>> Please add a newline to the end of the .pcf
file.
>>>>
>>>>
>>>>  STDMETHODIMP
CMiniBaseSite::ForceRedrawAll()
>>>>  {
>>>>      HX_RESULT retVal = HXR_OK;
>>>> +    CheckDisplayMode(NULL);
>>>>      _ForceRedrawAll();
>>>>      return retVal;
>>>>  }
>>>>
>>>> ForceRedrawAll() can be called quite often
and CheckDisplayMode()
>>>> can be pretty expensive on some platforms.
Why do you need to call
>>>> it here, can we move it to somewhere that
is called less often?
>>>>
>>>> +void CMiniBaseSite::_ForceRedrawAll()
>>>> +{
>>>> +    if( (IsSiteVisible() &&
m_Region && !HXEmptyRegion(m_Region)))
>>>> +    {
>>>> +        ForceRedraw();
>>>> +    }
>>>> +}
>>>> +
>>>>
>>>> We already have a ForceRedrawAll(). We
should just add #ifdefs
>>>> inside of the existing one to encapsulate
the child site stuff.
>>>>
>>>> I think you need to wrap some of the new
member vars in the
>>>> appropriate helix_feature #defines.
>>>>
>>>> Can you also make sure to compile with and
without the
>>>> SMIL_SITE helix feature and make sure there
are no build
>>>> busters and that it runs.
>>>>
>>>> The other comment I have is that we are
adding a lot of code
>>>> to a site that is suppose to be very very
small. Could you
>>>> build the site in release mode, both with
and without your
>>>> changes and show me the size difference in
the .dll? If the size
>>>> difference is large, then I would suggest
that you wrap all
>>>> of this new code in a (new) #define;
perhaps HELIX_FEATURE_AUTOROTATE
>>>> if that is the main purpose of the changes.
This applies only
>>>> to the minisite and minisurf. I am not
worried about the changes
>>>> in the platform/win files.
>>>>
>>>>
>>>> Thanks,
>>>> --greg.
>>>>
>>>>
>>>>>
>>>>> Files Added:
>>>>> 1.wince-420-ppc-arm.pcf
>>>>> 2.wince-500-ppc-arm.pcf
>>>>>
>>>>> Files Modified:
>>>>>
>>>>> 1. video/sitelib/minisite.cpp
>>>>> 2. video/sitelib/minisurf.cpp
>>>>> 3.
video/sitelib/platform/win/bltobjfact.cpp
>>>>> 4.
video/sitelib/platform/win/ddblt.cpp
>>>>> 5.
video/sitelib/platform/win/mwinsite.cpp
>>>>> 6.
video/sitelib/platform/wince/wingapiblt.cpp
>>>>> 7. video/sitelib/pub/minisite.h
>>>>> 8. video/sitelib/pub/minisurf.h
>>>>> 9.
video/sitelib/pub/platform/win/ddblt.h
>>>>> 10.
video/sitelib/pub/platform/win/mwinsite.h
>>>>>
11.video/sitelib/pub/platform/wince/wingapiblt.h
>>>>>
>>>>> Image Size and Heap Use impact (Client
-Only):
>>>>> None.
>>>>>
>>>>> Platforms and Profiles Affected:
>>>>> platform : wince-500-ppc-arm
>>>>> profile    : helix-client-wince-wm50
(new profile)
>>>>>
>>>>> Distribution Libraries Affected:
>>>>> None
>>>>>
>>>>> Distribution library impact and planned
action:
>>>>> None
>>>>>
>>>>> Platforms and Profiles Build Verified:
>>>>>
>>>>> BIF branch   -> helix_restricted
>>>>> Target(s)      ->
wince_wm50_play(new target)
>>>>> Profile          ->
helix-client-wince-wm50(new profile)
>>>>> System ID   -> wince-500-ppc-arm
>>>>>
>>>>>
>>>>> Branch:
>>>>> HEAD, hxclient_310_atlas.
>>>>>
>>>>>
>>>>> Files Attached
>>>>> video_sitelib.diff.txt
>>>>> wince-500-ppc-arm.pcf
>>>>> wince-420-ppc-arm.pcf
>>>>> minisite.cpp
>>>>>
>>>>>
>>>>> Thanks & Regards
>>>>> Anshuman
>>>>>
>>>>>
>>>>>
------------------------------------------------------------
------------ 
>>>>>
>>>>>
>>>>> This body part will be downloaded on
demand.
>>>>
>>>>
>>>
>>
>>


_______________________________________________
Video-dev mailing list
Video-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/video
-dev

Thanks Greg,

Changes are checked into HEAD and hxclient_310_atlas.

Thanks & Regards
Anshuman

_______________________________________________
Video-dev mailing list
Video-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/video
-dev