RE: CR: Fixed the build buster for wm/fileformat

Moving this to wmcode-protocol-dev, and I'll review this
there.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: helix-client-dev-bounceshelixcommunity.org 
> [mailto:helix-client-dev-bounceshelixcommunity.org] On 
> Behalf Of Lovish Dhawan
> Sent: Wednesday, September 05, 2007 2:11 AM
> To: datatype-dev
> Cc: helix-client-devhelixcommunity.org
> Subject: [Helix-client-dev] CR: Fixed the build buster
for 
> wm/fileformat
> 
> Could not found any list named wmcode-protocol or
something.
>  
> Synopsis:
> Fixed the build buster on Linux Platform for wm.
>  
> Overview:
> 
> CWMSStringT::AppendVariant() (defined in 
>
datatype-restricted/wm/rtsp/import/wmrtsp-porting-kit/networ
k/
> client/include/wmsstring.h)
> uses VARIANT structure. 
>  
> The signature of this function is 
> template <class T, int Fixed, int Chunk, BOOL
OptAppend>
> HRESULT CWMSStringT< T, Fixed, Chunk,
OptAppend>::AppendVariant(
>     VARIANT *pVal,
>     UINT CodePage
>     )
> 
> Windows has VARIANT defined. 
> For any other platform like UNIX, Linux not all the
members 
> of this structure are defined like BSTR bstrVal
> and so it gives compilation errors on these platforms
>  
> Fix could be to #if 0 this out.
> AppendVariant() is not used anywhere in the WM-RTSP
> codebase. So just comment (or #if 0) it out does not
harm anything.
>  
> Files Added:
> 
> None
>  
> Files Modified:
> 
> wmsstring.h 
>
(datatype-restricted/wm/rtsp/import/wmrtsp-porting-kit/netwo
rk
> /client/include)
> 
> 
> Image Size and Heap Use impact (Client -Only):
> None.
> 
> Platforms and Profiles Affected:
> platform : linux-2.2-libc6-gcc32-i586
> profile    : helix-client-all-defines
>  
> Distribution Libraries Affected:
> None
> 
> Distribution library impact and planned action:
> None
> 
> Platforms and Profiles Build Verified:
> 
> BIF branch   -> hxclient_3_1_0_atlas_restricted
> Target(s)      -> splay all_wm_plugins
> Profile          -> helix-client-all-defines
> System ID   -> linux-2.2-libc6-gcc32-i586
> 
>  
> Branch:
> HEAD,  hxclient_3_1_0_atlas
>  
> Files Attached:
> wmsstring_h.diff.txt
>  
> Thanks & Regards
> Lovish
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev