RE: helixplayer for ppc can play nothing

Hi Christina

       I find one of your changes for /client/core/hxsrc.cpp
cause error on
other platform, such as wince 5.0. Could you describe why
the codes are and make
some changes? Thanks!

The changes are between revision 1.122.2.3 and 1.122.2.4.
Code:
#if defined(HELIX_FEATURE_EMBEDDED_UI) &&
defined(HELIX_FEATURE_DRM)
...
...
#else
	hr = HXR_FAIL;
	ReportError(hr);
#endif // HELIX_FEATURE_EMBEDDED_UI

If HELIX_FEATURE_EMBEDDED_UI isn't defined, the function
always return HXR_FAIL.
This will make the play fail.

Best Regards

Eric Li (李军)
 

>-----Original Message-----
>From: Lovish Dhawan [mailto:ldhawanreal.com]
>Sent: Monday, January 21, 2008 9:18 PM
>To: ljunreal.com
>Cc: 'Rishi Mathew'; 'Rahul Agarwal'; 'Leina Tani';
asinghreal.com
>Subject: Re: helixplayer for ppc can play nothing
>
>We haven't changed any thing in clientapps/ppcplayer
these days.
>and as the issue is not specific to a single datatype,
so most likely the
>modules to look at is client/core, media platform. Could
you check that we
>are getting the player up ?
>Also what did you find when tried to debug ?
>
>----- Original Message -----
>From: "lijun" <ljunreal.com>
>To: "'Lovish Dhawan'" <ldhawanreal.com>
>Cc: "'Rishi Mathew'" <rmathewreal.com>; "'Rahul Agarwal'"
<rahulreal.com>;
>"'Leina Tani'" <ltanireal.com>;
<asinghreal.com>
>Sent: Monday, January 21, 2008 6:21 PM
>Subject: RE: helixplayer for ppc can play nothing
>
>
>Sorry, my env for win32 is broken. Could please check
it?
>I am looking into the files changed these days to get
some ideas.
>Also I tried to print logs from code, no tracks found
yet. I can open the
>UI,
>can select a file to open, after that, nothing happens.
The time scroll
>doesn't
>move.
>
>Best Regards
>
>Eric Li (李军)
>
>
>>-----Original Message-----
>>From: Lovish Dhawan [mailto:ldhawanreal.com]
>>Sent: Monday, January 21, 2008 8:53 PM
>>To: Lovish Dhawan; ljunreal.com
>>Cc: 'Rishi Mathew'; 'Rahul Agarwal'; 'Leina Tani';
asinghreal.com
>>Subject: Re: helixplayer for ppc can play nothing
>>
>>Eric,
>>
>>Could you also check the latest Win32 splay build
for Atlas 310 restricted
>>?
>>Still debugging will be the best option. Are you
getting the UI of helix
>>player ?
>>
>>Thanks,
>>Lovish
>>----- Original Message -----
>>From: "Lovish Dhawan" <ldhawanreal.com>
>>To: <ljunreal.com>
>>Cc: "'Rishi Mathew'" <rmathewreal.com>; "'Rahul Agarwal'"
>><rahulreal.com>;
>>"'Leina Tani'" <ltanireal.com>; <asinghreal.com>
>>Sent: Monday, January 21, 2008 4:51 PM
>>Subject: Re: helixplayer for ppc can play nothing
>>
>>
>>> Hi Eric,
>>>
>>> What error do u get when you play. Please try
the debug version of
>>> helixplayer and see what is happening.
>>> I'll look at this tomm or day after tomm.
>>>
>>> Anshuman, could you please help Eric.
>>>
>>> Thanks,
>>> Lovish
>>>
>>> ----- Original Message -----
>>> From: "lijun" <ljunreal.com>
>>> To: "'Lovish Dhawan'" <ldhawanreal.com>
>>> Cc: "'Rishi Mathew'" <rmathewreal.com>; "'Rahul Agarwal'"
>>> <rahulreal.com>; "'Leina Tani'"
<ltanireal.com>
>>> Sent: Monday, January 21, 2008 3:48 PM
>>> Subject: helixplayer for ppc can play nothing
>>>
>>>
>>> Hi Lovish
>>>
>>>         Do you notice that helixplayer for ppc
can play nothing now? The
>>> branch
>>> I use is atlas310. I think the build before Jan
10, 2008 is OK. But today
>>> my new
>>> build can play nothing. Maybe some new checked
in files cause this issue.
>>> Can
>>> you check it?
>>>         Thanks.
>>>
>>> Best Regards
>>>
>>>
-------------------------------------------------------
>>> Eric Li (李军)
>>> www.realnetworks.com
>>> www.helixcommunity.org
>>>
-------------------------------------------------------
>>>
>>>
>>>


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

Hi Eric,

That's a bug. The intention was that embedded UI content
would fail
if the embedded UI feature was not defined. Below is the
fix, to
be reviewed by Henry or Qiang.

--christina

Index: hxsrc.cpp
============================================================
=======
RCS file: /cvsroot/client/core/hxsrc.cpp,v
retrieving revision 1.122.2.9
diff -w -u -5 -r1.122.2.9 hxsrc.cpp
--- hxsrc.cpp    15 Jan 2008 23:41:53 -0000    1.122.2.9
+++ hxsrc.cpp    21 Jan 2008 20:52:33 -0000
 -3868,12
+3868,14 
     {
         m_pDRM->GetLicenseInfo(pLicenseInfo);
     }
 #endif

-    if (m_pFileHeader)
+    IHXBuffer* pBuffer = NULL;
+    if (m_pFileHeader &&
SUCCEEDED(m_pFileHeader->GetPropertyBuffer("DRM_UIDe
scription", pBuffer)))
     {
+    HX_RELEASE(pBuffer);
 #if defined(HELIX_FEATURE_EMBEDDED_UI) &&
defined(HELIX_FEATURE_DRM)
     // Send the file header and the DRM object
     IHXEmbeddedUI* pEmbeddedUI=NULL;
     if (m_pPlayer &&
SUCCEEDED(m_pPlayer->QueryInterface(IID_IHXEmbeddedUI,
(void**)
&pEmbeddedUI)))
     {


lijun wrote:
> Hi Christina
>
>        I find one of your changes for
/client/core/hxsrc.cpp cause error on
> other platform, such as wince 5.0. Could you describe
why the codes are and make
> some changes? Thanks!
>
> The changes are between revision 1.122.2.3 and
1.122.2.4.
> Code:
> #if defined(HELIX_FEATURE_EMBEDDED_UI) &&
defined(HELIX_FEATURE_DRM)
> ...
> ...
> #else
> 	hr = HXR_FAIL;
> 	ReportError(hr);
> #endif // HELIX_FEATURE_EMBEDDED_UI
>
> If HELIX_FEATURE_EMBEDDED_UI isn't defined, the
function always return HXR_FAIL.
> This will make the play fail.
>
> Best Regards
>
> Eric Li (李军)
>
>
>
>> -----Original Message-----
>> From: Lovish Dhawan [mailto:ldhawanreal.com]
>> Sent: Monday, January 21, 2008 9:18 PM
>> To: ljunreal.com
>> Cc: 'Rishi Mathew'; 'Rahul Agarwal'; 'Leina Tani';
asinghreal.com
>> Subject: Re: helixplayer for ppc can play nothing
>>
>> We haven't changed any thing in
clientapps/ppcplayer these days.
>> and as the issue is not specific to a single
datatype, so most likely the
>> modules to look at is client/core, media platform.
Could you check that we
>> are getting the player up ?
>> Also what did you find when tried to debug ?
>>
>> ----- Original Message -----
>> From: "lijun" <ljunreal.com>
>> To: "'Lovish Dhawan'" <ldhawanreal.com>
>> Cc: "'Rishi Mathew'" <rmathewreal.com>; "'Rahul Agarwal'"
<rahulreal.com>;
>> "'Leina Tani'" <ltanireal.com>; <asinghreal.com>
>> Sent: Monday, January 21, 2008 6:21 PM
>> Subject: RE: helixplayer for ppc can play nothing
>>
>>
>> Sorry, my env for win32 is broken. Could please
check it?
>> I am looking into the files changed these days to
get some ideas.
>> Also I tried to print logs from code, no tracks
found yet. I can open the
>> UI,
>> can select a file to open, after that, nothing
happens. The time scroll
>> doesn't
>> move.
>>
>> Best Regards
>>
>> Eric Li (李军)
>>
>>
>>
>>> -----Original Message-----
>>> From: Lovish Dhawan [mailto:ldhawanreal.com]
>>> Sent: Monday, January 21, 2008 8:53 PM
>>> To: Lovish Dhawan; ljunreal.com
>>> Cc: 'Rishi Mathew'; 'Rahul Agarwal'; 'Leina
Tani'; asinghreal.com
>>> Subject: Re: helixplayer for ppc can play
nothing
>>>
>>> Eric,
>>>
>>> Could you also check the latest Win32 splay
build for Atlas 310 restricted
>>> ?
>>> Still debugging will be the best option. Are
you getting the UI of helix
>>> player ?
>>>
>>> Thanks,
>>> Lovish
>>> ----- Original Message -----
>>> From: "Lovish Dhawan" <ldhawanreal.com>
>>> To: <ljunreal.com>
>>> Cc: "'Rishi Mathew'" <rmathewreal.com>; "'Rahul Agarwal'"
>>> <rahulreal.com>;
>>> "'Leina Tani'" <ltanireal.com>; <asinghreal.com>
>>> Sent: Monday, January 21, 2008 4:51 PM
>>> Subject: Re: helixplayer for ppc can play
nothing
>>>
>>>
>>>
>>>> Hi Eric,
>>>>
>>>> What error do u get when you play. Please
try the debug version of
>>>> helixplayer and see what is happening.
>>>> I'll look at this tomm or day after tomm.
>>>>
>>>> Anshuman, could you please help Eric.
>>>>
>>>> Thanks,
>>>> Lovish
>>>>
>>>> ----- Original Message -----
>>>> From: "lijun" <ljunreal.com>
>>>> To: "'Lovish Dhawan'"
<ldhawanreal.com>
>>>> Cc: "'Rishi Mathew'"
<rmathewreal.com>; "'Rahul Agarwal'"
>>>> <rahulreal.com>; "'Leina
Tani'" <ltanireal.com>
>>>> Sent: Monday, January 21, 2008 3:48 PM
>>>> Subject: helixplayer for ppc can play
nothing
>>>>
>>>>
>>>> Hi Lovish
>>>>
>>>>         Do you notice that helixplayer for
ppc can play nothing now? The
>>>> branch
>>>> I use is atlas310. I think the build before
Jan 10, 2008 is OK. But today
>>>> my new
>>>> build can play nothing. Maybe some new
checked in files cause this issue.
>>>> Can
>>>> you check it?
>>>>         Thanks.
>>>>
>>>> Best Regards
>>>>
>>>>
-------------------------------------------------------
>>>> Eric Li (李军)
>>>> www.realnetworks.com
>>>> www.helixcommunity.org
>>>>
-------------------------------------------------------
>>>>
>>>>
>>>>
>>>>
>
>
>

_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

I've checked in the below fix to HEAD and Atlas310.

--christina

Index: hxsrc.cpp
============================================================
=======
RCS file: /cvsroot/client/core/hxsrc.cpp,v
retrieving revision 1.122.2.9
diff -w -u -5 -r1.122.2.9 hxsrc.cpp
--- hxsrc.cpp    15 Jan 2008 23:41:53 -0000    1.122.2.9
+++ hxsrc.cpp    21 Jan 2008 22:36:18 -0000
 -3888,12
+3888,19 
             HX_DELETE(uiInfo);
         HX_RELEASE(pUnknown);
     }
     HX_RELEASE(pEmbeddedUI);
 #else
+    IHXBuffer* pBuffer = NULL;
+    HXBOOL bEmbeddedUI=
SUCCEEDED(m_pFileHeader->GetPropertyBuffer("DRM_UIDe
scription", pBuffer));
+    HX_RELEASE(pBuffer);
+
+    if (bEmbeddedUI)
+    {
     hr = HXR_FAIL;
     ReportError(hr);
+    }
 #endif // HELIX_FEATURE_EMBEDDED_UI
     }


 #if defined(HELIX_FEATURE_STATS) &&
defined(HELIX_FEATURE_REGISTRY)

lijun wrote:
> Hi Christina
>
>        I find one of your changes for
/client/core/hxsrc.cpp cause error on
> other platform, such as wince 5.0. Could you describe
why the codes are and make
> some changes? Thanks!
>
> The changes are between revision 1.122.2.3 and
1.122.2.4.
> Code:
> #if defined(HELIX_FEATURE_EMBEDDED_UI) &&
defined(HELIX_FEATURE_DRM)
> ...
> ...
> #else
> 	hr = HXR_FAIL;
> 	ReportError(hr);
> #endif // HELIX_FEATURE_EMBEDDED_UI
>
> If HELIX_FEATURE_EMBEDDED_UI isn't defined, the
function always return HXR_FAIL.
> This will make the play fail.
>
> Best Regards
>
> Eric Li (李军)
>
>
>
>> -----Original Message-----
>> From: Lovish Dhawan [mailto:ldhawanreal.com]
>> Sent: Monday, January 21, 2008 9:18 PM
>> To: ljunreal.com
>> Cc: 'Rishi Mathew'; 'Rahul Agarwal'; 'Leina Tani';
asinghreal.com
>> Subject: Re: helixplayer for ppc can play nothing
>>
>> We haven't changed any thing in
clientapps/ppcplayer these days.
>> and as the issue is not specific to a single
datatype, so most likely the
>> modules to look at is client/core, media platform.
Could you check that we
>> are getting the player up ?
>> Also what did you find when tried to debug ?
>>
>> ----- Original Message -----
>> From: "lijun" <ljunreal.com>
>> To: "'Lovish Dhawan'" <ldhawanreal.com>
>> Cc: "'Rishi Mathew'" <rmathewreal.com>; "'Rahul Agarwal'"
<rahulreal.com>;
>> "'Leina Tani'" <ltanireal.com>; <asinghreal.com>
>> Sent: Monday, January 21, 2008 6:21 PM
>> Subject: RE: helixplayer for ppc can play nothing
>>
>>
>> Sorry, my env for win32 is broken. Could please
check it?
>> I am looking into the files changed these days to
get some ideas.
>> Also I tried to print logs from code, no tracks
found yet. I can open the
>> UI,
>> can select a file to open, after that, nothing
happens. The time scroll
>> doesn't
>> move.
>>
>> Best Regards
>>
>> Eric Li (李军)
>>
>>
>>
>>> -----Original Message-----
>>> From: Lovish Dhawan [mailto:ldhawanreal.com]
>>> Sent: Monday, January 21, 2008 8:53 PM
>>> To: Lovish Dhawan; ljunreal.com
>>> Cc: 'Rishi Mathew'; 'Rahul Agarwal'; 'Leina
Tani'; asinghreal.com
>>> Subject: Re: helixplayer for ppc can play
nothing
>>>
>>> Eric,
>>>
>>> Could you also check the latest Win32 splay
build for Atlas 310 restricted
>>> ?
>>> Still debugging will be the best option. Are
you getting the UI of helix
>>> player ?
>>>
>>> Thanks,
>>> Lovish
>>> ----- Original Message -----
>>> From: "Lovish Dhawan" <ldhawanreal.com>
>>> To: <ljunreal.com>
>>> Cc: "'Rishi Mathew'" <rmathewreal.com>; "'Rahul Agarwal'"
>>> <rahulreal.com>;
>>> "'Leina Tani'" <ltanireal.com>; <asinghreal.com>
>>> Sent: Monday, January 21, 2008 4:51 PM
>>> Subject: Re: helixplayer for ppc can play
nothing
>>>
>>>
>>>
>>>> Hi Eric,
>>>>
>>>> What error do u get when you play. Please
try the debug version of
>>>> helixplayer and see what is happening.
>>>> I'll look at this tomm or day after tomm.
>>>>
>>>> Anshuman, could you please help Eric.
>>>>
>>>> Thanks,
>>>> Lovish
>>>>
>>>> ----- Original Message -----
>>>> From: "lijun" <ljunreal.com>
>>>> To: "'Lovish Dhawan'"
<ldhawanreal.com>
>>>> Cc: "'Rishi Mathew'"
<rmathewreal.com>; "'Rahul Agarwal'"
>>>> <rahulreal.com>; "'Leina
Tani'" <ltanireal.com>
>>>> Sent: Monday, January 21, 2008 3:48 PM
>>>> Subject: helixplayer for ppc can play
nothing
>>>>
>>>>
>>>> Hi Lovish
>>>>
>>>>         Do you notice that helixplayer for
ppc can play nothing now? The
>>>> branch
>>>> I use is atlas310. I think the build before
Jan 10, 2008 is OK. But today
>>>> my new
>>>> build can play nothing. Maybe some new
checked in files cause this issue.
>>>> Can
>>>> you check it?
>>>>         Thanks.
>>>>
>>>> Best Regards
>>>>
>>>>
-------------------------------------------------------
>>>> Eric Li (李军)
>>>> www.realnetworks.com
>>>> www.helixcommunity.org
>>>>
-------------------------------------------------------
>>>>
>>>>
>>>>
>>>>
>
>
>

_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev