CR: add dtdriver based thumbnail support in dbus-server for Linux

These changes look good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: player-dev-bounceshelixcommunity.org 
> [mailto:player-dev-bounceshelixcommunity.org] On
Behalf Of 
> Chen, Weian
> Sent: Tuesday, February 26, 2008 12:56 AM
> To: helix-client-devhelixcommunity.org
> Cc: Shen, Cathy; player-devhelixcommunity.org
> Subject: [Player-dev] [Helix-Client-dev][Re-Send] CR:
add 
> dtdriver basedthumbnailsupport in dbus-server for
Linux
> 
>  
> 
> No comments yet.
> 
>  
> 
> If there is still no comment tomorrow, I will commit
that to 
> helix cvs.
> 
>  
> 
> Thanks a lot
> 
> Weian
> 
> ________________________________
> 
> From: player-dev-bounceshelixcommunity.org 
> [mailto:player-dev-bounceshelixcommunity.org] On
Behalf Of 
> Chen, Weian
> Sent: 2008$BG/(B2$B7n(B25$BF|(B 16:41
> To: helix-client-devhelixcommunity.org
> Cc: Shen, Cathy; player-devhelixcommunity.org
> Subject: [Player-dev] [Helix-Client-dev] CR: add
dtdriver 
> based thumbnailsupport in dbus-server for Linux
> 
>  
> 
> Synopsis: 
> 
>   Add dtdriver based thumbnail support in dbus-server
for Linux
> 
>  
> 
> Overview: 
> 
>   We added dtdriver based thumbnail functionality into
the 
> dbus-server, and export an API name GetVideoFrame()
> 
>  
> 
> Files Added:
> 
>   CHXClientThumbnailUnix.cpp
(playerhxclientkitsrcplatformunix)
> 
>   CHXClientThumbnailUnix.h
(playerhxclientkitsrcplatformunix)
> 
>  
> 
> Files Modified:
> 
>   player/kit/dbus-server/pub/hxplayer.h
> 
>   player/kit/dbus-server/src/helix-dbus-server.cpp
> 
>   player/kit/dbus-server/src/hxplayer.cpp
> 
>   player/hxclientkit/UmakefilKit_common_unix
> 
>   player/hxclientkit/pub/HXClientCFuncs.h
> 
>   player/hxclientkit/pub/HXClientCallbacks.h
> 
>   player/hxclientkit/src/HXClientCFuncs.cpp
> 
>   player/hxclientkit/src/HXClientGuidIncludes.h
> 
>  
player/hxclientkit/src/platform/unix/CHXClientEngineUnix.cpp

> 
>  
> 
> Image Size and Heap Use impact (Client -Only):
> 
>   Little
> 
>  
> 
> Platforms and Profiles Affected:
> 
>   platform:   linux-2.2-libc6-gcc32-i586
> 
>   profile:     helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>   <libhxclient.a> <helix-dbus-server.bin>
> 
>  
> 
> Distribution library impact and planned action:
> 
>   <None>
> 
>  
> 
> Platforms and Profiles Build Verified:
> 
>   Set BIF branch   -> hxdbus_3_1_0_atlas
> 
>   Set Target(s)     -> dbus_server_with_video
> 
>   Set Profile       -> helix-client-all-defines
> 
>   System ID       -> linux-2.2-libc6-gcc32-i586
> 
>  
> 
> Branch: 
> 
>   HEAD, hxclient_3_1_0_atlas
> 
>  
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>  
> 
> 2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>  
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>  
> 
>            agreement was received. 
> 
>  
> 
> Files Attached:
> 
>   hxclientkit-thumbnail.diff
> 
>   dbus-server-thumbnail.diff
> 
>  
> 
> Weian
> 
>  
> 
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

Commit to HEAD & Atlas310

Weian
-----Original Message-----
From: Eric Hyche [mailto:ehychereal.com] 
Sent: 2008年2月27日 12:23
To: Chen, Weian; helix-client-devhelixcommunity.org
Cc: Shen, Cathy; player-devhelixcommunity.org
Subject: RE: [Player-dev] [Helix-Client-dev][Re-Send] CR:
add dtdriver basedthumbnailsupport in dbus-server for Linux


These changes look good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: player-dev-bounceshelixcommunity.org 
> [mailto:player-dev-bounceshelixcommunity.org] On
Behalf Of 
> Chen, Weian
> Sent: Tuesday, February 26, 2008 12:56 AM
> To: helix-client-devhelixcommunity.org
> Cc: Shen, Cathy; player-devhelixcommunity.org
> Subject: [Player-dev] [Helix-Client-dev][Re-Send] CR:
add 
> dtdriver basedthumbnailsupport in dbus-server for
Linux
> 
>  
> 
> No comments yet.
> 
>  
> 
> If there is still no comment tomorrow, I will commit
that to 
> helix cvs.
> 
>  
> 
> Thanks a lot
> 
> Weian
> 
> ________________________________
> 
> From: player-dev-bounceshelixcommunity.org 
> [mailto:player-dev-bounceshelixcommunity.org] On
Behalf Of 
> Chen, Weian
> Sent: 2008年2月25日 16:41
> To: helix-client-devhelixcommunity.org
> Cc: Shen, Cathy; player-devhelixcommunity.org
> Subject: [Player-dev] [Helix-Client-dev] CR: add
dtdriver 
> based thumbnailsupport in dbus-server for Linux
> 
>  
> 
> Synopsis: 
> 
>   Add dtdriver based thumbnail support in dbus-server
for Linux
> 
>  
> 
> Overview: 
> 
>   We added dtdriver based thumbnail functionality into
the 
> dbus-server, and export an API name GetVideoFrame()
> 
>  
> 
> Files Added:
> 
>   CHXClientThumbnailUnix.cpp
(playerhxclientkitsrcplatformunix)
> 
>   CHXClientThumbnailUnix.h
(playerhxclientkitsrcplatformunix)
> 
>  
> 
> Files Modified:
> 
>   player/kit/dbus-server/pub/hxplayer.h
> 
>   player/kit/dbus-server/src/helix-dbus-server.cpp
> 
>   player/kit/dbus-server/src/hxplayer.cpp
> 
>   player/hxclientkit/UmakefilKit_common_unix
> 
>   player/hxclientkit/pub/HXClientCFuncs.h
> 
>   player/hxclientkit/pub/HXClientCallbacks.h
> 
>   player/hxclientkit/src/HXClientCFuncs.cpp
> 
>   player/hxclientkit/src/HXClientGuidIncludes.h
> 
>  
player/hxclientkit/src/platform/unix/CHXClientEngineUnix.cpp

> 
>  
> 
> Image Size and Heap Use impact (Client -Only):
> 
>   Little
> 
>  
> 
> Platforms and Profiles Affected:
> 
>   platform:   linux-2.2-libc6-gcc32-i586
> 
>   profile:     helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>   <libhxclient.a> <helix-dbus-server.bin>
> 
>  
> 
> Distribution library impact and planned action:
> 
>   <None>
> 
>  
> 
> Platforms and Profiles Build Verified:
> 
>   Set BIF branch   -> hxdbus_3_1_0_atlas
> 
>   Set Target(s)     -> dbus_server_with_video
> 
>   Set Profile       -> helix-client-all-defines
> 
>   System ID       -> linux-2.2-libc6-gcc32-i586
> 
>  
> 
> Branch: 
> 
>   HEAD, hxclient_3_1_0_atlas
> 
>  
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>  
> 
> 2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>  
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>  
> 
>            agreement was received. 
> 
>  
> 
> Files Attached:
> 
>   hxclientkit-thumbnail.diff
> 
>   dbus-server-thumbnail.diff
> 
>  
> 
> Weian
> 
>  
> 
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

My comments:

1) We should not call the variable g_pThumbnailEngineUnix
   if it is no longer a pointer.

2) I think a good longer-term change would be to avoid
   using globals for this at all. When the user calls
   InitThumbnailEngine(), it could return an opaque pointer
   as an out parameter, which the user would then need to
pass
   back into CreateThumbnail() and
ReleaseThumbnailEngine().

   I'm OK with not making this change now, but I think this
   is something we should think about doing in the future.
   The lifetime of module-level globals such as these is
   managed by when the shared library is unloaded, and 
   in my experience, this creates many more headaches (and
   strange bugs) down the road.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: player-dev-bounceshelixcommunity.org 
> [mailto:player-dev-bounceshelixcommunity.org] On
Behalf Of 
> Chen, Weian
> Sent: Wednesday, March 26, 2008 3:07 AM
> To: helix-client-devhelixcommunity.org
> Cc: Shen, Cathy; player-devhelixcommunity.org
> Subject: [Player-dev] [Helix-Client-dev] CR: refine the

> source code forthumbnail feature
> 
> Synopsis: 
> 
>  Refine the source code for thumbnail 
> 
>  
> 
> Overview: 
> 
>   We refine the source code for thumbnail feature, such
as 
> the initialization, function call etc.  
> 
>  
> 
> Files Added:
> 
>   None
> 
>  
> 
> Files Modified:
> 
>   helix-dbus-server.cpp (playerkitdbus-serversrc)
> 
>   CHXClientThumbnailUnix.cpp
(playerhxclientkitsrcplatformunix)
> 
>   CHXClientThumbnailUnix.h
(playerhxclientkitsrcplatformunix)
> 
>  
> 
> Image Size and Heap Use impact (Client -Only):
> 
>   Little
> 
>  
> 
> Platforms and Profiles Affected:
> 
>   platform:   linux-2.2-libc6-gcc32-i586
> 
>   profile:     helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>   <libhxclient.a> <helix-dbus-server.bin>
> 
>  
> 
> Distribution library impact and planned action:
> 
>   <None>
> 
>  
> 
> Platforms and Profiles Build Verified:
> 
>   Set BIF branch   -> hxdbus_3_1_0_atlas
> 
>   Set Target(s)     -> dbus_server_with_video
> 
>   Set Profile       -> helix-client-all-defines
> 
>   System ID       -> linux-2.2-libc6-gcc32-i586
> 
>  
> 
> Branch: 
> 
>   HEAD, hxclient_3_1_0_atlas
> 
>  
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>  
> 
> 2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>  
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>  
> 
>            agreement was received. 
> 
>  
> 
> Files Attached:
> 
>   hxclient-thumbnail.diff
> 
>   dbus-server-thumbnail.diff
> 
>  
> 
> Weian
> 
>  
> 
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

Eric:

I will change comments 1) and commit to branch.

For foments 2), I will prepare another patch due to the
schedule issue.

Weian
-----Original Message-----
From: Eric Hyche [mailto:ehychereal.com] 
Sent: 2008年3月27日 0:24
To: Chen, Weian; helix-client-devhelixcommunity.org
Cc: Shen, Cathy; player-devhelixcommunity.org
Subject: RE: [Player-dev] [Helix-Client-dev] CR: refine the
source code forthumbnail feature


My comments:

1) We should not call the variable g_pThumbnailEngineUnix
   if it is no longer a pointer.

2) I think a good longer-term change would be to avoid
   using globals for this at all. When the user calls
   InitThumbnailEngine(), it could return an opaque pointer
   as an out parameter, which the user would then need to
pass
   back into CreateThumbnail() and
ReleaseThumbnailEngine().

   I'm OK with not making this change now, but I think this
   is something we should think about doing in the future.
   The lifetime of module-level globals such as these is
   managed by when the shared library is unloaded, and 
   in my experience, this creates many more headaches (and
   strange bugs) down the road.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: player-dev-bounceshelixcommunity.org 
> [mailto:player-dev-bounceshelixcommunity.org] On
Behalf Of 
> Chen, Weian
> Sent: Wednesday, March 26, 2008 3:07 AM
> To: helix-client-devhelixcommunity.org
> Cc: Shen, Cathy; player-devhelixcommunity.org
> Subject: [Player-dev] [Helix-Client-dev] CR: refine the

> source code forthumbnail feature
> 
> Synopsis: 
> 
>  Refine the source code for thumbnail 
> 
>  
> 
> Overview: 
> 
>   We refine the source code for thumbnail feature, such
as 
> the initialization, function call etc.  
> 
>  
> 
> Files Added:
> 
>   None
> 
>  
> 
> Files Modified:
> 
>   helix-dbus-server.cpp (playerkitdbus-serversrc)
> 
>   CHXClientThumbnailUnix.cpp
(playerhxclientkitsrcplatformunix)
> 
>   CHXClientThumbnailUnix.h
(playerhxclientkitsrcplatformunix)
> 
>  
> 
> Image Size and Heap Use impact (Client -Only):
> 
>   Little
> 
>  
> 
> Platforms and Profiles Affected:
> 
>   platform:   linux-2.2-libc6-gcc32-i586
> 
>   profile:     helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>   <libhxclient.a> <helix-dbus-server.bin>
> 
>  
> 
> Distribution library impact and planned action:
> 
>   <None>
> 
>  
> 
> Platforms and Profiles Build Verified:
> 
>   Set BIF branch   -> hxdbus_3_1_0_atlas
> 
>   Set Target(s)     -> dbus_server_with_video
> 
>   Set Profile       -> helix-client-all-defines
> 
>   System ID       -> linux-2.2-libc6-gcc32-i586
> 
>  
> 
> Branch: 
> 
>   HEAD, hxclient_3_1_0_atlas
> 
>  
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>  
> 
> 2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>  
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>  
> 
>            agreement was received. 
> 
>  
> 
> Files Attached:
> 
>   hxclient-thumbnail.diff
> 
>   dbus-server-thumbnail.diff
> 
>  
> 
> Weian
> 
>  
> 
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

Commit to head and atlas branch after change comment 1)

Comment 2 will be changed later.

Thanks!
Weian

-----Original Message-----
From: Eric Hyche [mailto:ehychereal.com] 
Sent: 2008年3月27日 0:24
To: Chen, Weian; helix-client-devhelixcommunity.org
Cc: Shen, Cathy; player-devhelixcommunity.org
Subject: RE: [Player-dev] [Helix-Client-dev] CR: refine the
source code forthumbnail feature


My comments:

1) We should not call the variable g_pThumbnailEngineUnix
   if it is no longer a pointer.

2) I think a good longer-term change would be to avoid
   using globals for this at all. When the user calls
   InitThumbnailEngine(), it could return an opaque pointer
   as an out parameter, which the user would then need to
pass
   back into CreateThumbnail() and
ReleaseThumbnailEngine().

   I'm OK with not making this change now, but I think this
   is something we should think about doing in the future.
   The lifetime of module-level globals such as these is
   managed by when the shared library is unloaded, and 
   in my experience, this creates many more headaches (and
   strange bugs) down the road.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: player-dev-bounceshelixcommunity.org 
> [mailto:player-dev-bounceshelixcommunity.org] On
Behalf Of 
> Chen, Weian
> Sent: Wednesday, March 26, 2008 3:07 AM
> To: helix-client-devhelixcommunity.org
> Cc: Shen, Cathy; player-devhelixcommunity.org
> Subject: [Player-dev] [Helix-Client-dev] CR: refine the

> source code forthumbnail feature
> 
> Synopsis: 
> 
>  Refine the source code for thumbnail 
> 
>  
> 
> Overview: 
> 
>   We refine the source code for thumbnail feature, such
as 
> the initialization, function call etc.  
> 
>  
> 
> Files Added:
> 
>   None
> 
>  
> 
> Files Modified:
> 
>   helix-dbus-server.cpp (playerkitdbus-serversrc)
> 
>   CHXClientThumbnailUnix.cpp
(playerhxclientkitsrcplatformunix)
> 
>   CHXClientThumbnailUnix.h
(playerhxclientkitsrcplatformunix)
> 
>  
> 
> Image Size and Heap Use impact (Client -Only):
> 
>   Little
> 
>  
> 
> Platforms and Profiles Affected:
> 
>   platform:   linux-2.2-libc6-gcc32-i586
> 
>   profile:     helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>   <libhxclient.a> <helix-dbus-server.bin>
> 
>  
> 
> Distribution library impact and planned action:
> 
>   <None>
> 
>  
> 
> Platforms and Profiles Build Verified:
> 
>   Set BIF branch   -> hxdbus_3_1_0_atlas
> 
>   Set Target(s)     -> dbus_server_with_video
> 
>   Set Profile       -> helix-client-all-defines
> 
>   System ID       -> linux-2.2-libc6-gcc32-i586
> 
>  
> 
> Branch: 
> 
>   HEAD, hxclient_3_1_0_atlas
> 
>  
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>  
> 
> 2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>  
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>  
> 
>            agreement was received. 
> 
>  
> 
> Files Attached:
> 
>   hxclient-thumbnail.diff
> 
>   dbus-server-thumbnail.diff
> 
>  
> 
> Weian
> 
>  
> 
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

Looks good to me.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: player-dev-bounceshelixcommunity.org 
> [mailto:player-dev-bounceshelixcommunity.org] On
Behalf Of 
> Chen, Weian
> Sent: Thursday, March 27, 2008 3:06 AM
> To: helix-client-devhelixcommunity.org
> Cc: Shen, Cathy; player-devhelixcommunity.org
> Subject: [Player-dev] [Helix-Client-dev] CR: Work round
the 
> problem that whensetting ProcessTimeUnits to a large 
> value,the performance will be impacted very much in
application level
> 
> Synopsis: 
> 
>   Work round the problem that when setting
ProcessTimeUnits 
> to a large value, the performance will be impacted very
much 
> at application level
> 
>     
> 
> Overview: 
> 
> When setting ProcessTimeUnits =1, thumbnail feature
will not 
> always work, so we should set ProcessTimeUnits to a
large 
> value, but for some streams, it will blt several times,
and 
> impact performance much, so we work round this problem
by 
> stopping the dtdriver at application level.
> 
>  
> 
> Files Added:
> 
>   None
> 
>  
> 
> Files Modified:
> 
>   CHXClientThumbnailUnix.cpp
(playerhxclientkitsrcplatformunix)
> 
>  
> 
> Image Size and Heap Use impact (Client -Only):
> 
>   Little
> 
>  
> 
> Platforms and Profiles Affected:
> 
>   platform:   linux-2.2-libc6-gcc32-i586
> 
>   profile:     helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>   <libhxclient.a> <helix-dbus-server.bin>
> 
>  
> 
> Distribution library impact and planned action:
> 
>   <None>
> 
>  
> 
> Platforms and Profiles Build Verified:
> 
>   Set BIF branch   -> hxdbus_3_1_0_atlas
> 
>   Set Target(s)      -> dbus_server_with_video
> 
>   Set Profile        -> helix-client-all-defines
> 
>   System ID        -> linux-2.2-libc6-gcc32-i586
> 
>  
> 
> Branch: 
> 
>   HEAD, hxclient_3_1_0_atlas
> 
>  
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
> 2.            Intel has signed and delivered a Joint 
> Copyright Assignment
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>            agreement was received. 
> 
>  
> 
> Files Attached:
> 
> hxclientkit-thumb-stopearly.diff
> 
>  
> 
> Weian
> 
>  
> 
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev