List Info

Thread: CR:Add chinese character rendering support into rtrender, supports GB2312




CR:Add chinese character rendering support into rtrender, supports GB2312
user name
2008-03-11 01:37:06

Modified by: <huan.zhengintel.com&gt;

Date: <;03:11:08&gt;

Project: [Datatype-dev] CR: Add simplified chinese character rendering support into rtrender

Synopsis:

Add Simplified Chinese character rendering support into rtrender.

Overview:

Add simplified Chinese character rendering support into rtrender, supports GB2312 charset.

Original rtrender didn't support i18n, this patch retains original rendering code by introducing new struct which includes both original

XFontStruct,XDrawString and new XFontSet,Xutf8DrawString which support i18n.

This patch also leaves some places for other charset to translate into UTF-8, so that supporting for other charset becomes easier.

Files Added: &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ;  &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp; 

Files Modified:

 &nbsp;  rtwin.cpp (datatype/text/realtext/renderer/platform/unix/rtwin.cpp)

Image Size and Heap Use impact (Client -Only):

 &nbsp;  little

Platforms and Profiles Affected:

 &nbsp;  platform:&nbsp;  linux-2.2-libc6-gcc32-i586

 &nbsp;  profile:&nbsp; &nbsp; helix-client-all-defines

Distribution Libraries Affected:

 &nbsp;  &lt;rtrender.so>

Distribution library impact and planned action:

 &nbsp;  &lt;None>

Platforms and Profiles Build Verified:

 &nbsp;  Set BIF branch&nbsp; -> hxclient_3_1_0_atlas_restricted

 &nbsp;  Set Target(s)&nbsp;  -> datatype_text_realtext_renderer

 &nbsp;  Set Profile&nbsp; &nbsp;  -> helix-client-all-defines

 &nbsp;  System ID &nbsp; &nbsp;   -> linux-2.2-libc6-gcc32-i586

Branch:

 &nbsp;  HEAD, hxclient_3_1_0_atlas

Copyright assignment: <MUST be one of the following statements >

  2.  ; &nbsp;  Intel has signed and delivered a Joint Copyright Assignment

 &nbsp; &nbsp; &nbsp; &nbsp;   to RealNetworks, and received acknowledgment that the

 &nbsp; &nbsp; &nbsp; &nbsp;   agreement was received.

Files Attached:

rtrender.diff

 

 

Best Regards, Zheng, Huan(ZBT)

OTC/SSD/SSG

Intel Aisa-Pacific Research & Developement Ltd

Tel: 021-6116 6435

Inet: 8821 6435

Cub: 3W035

 

  
Re: CR:Add chinese character rendering support into rtrender, supports GB2312
country flaguser name
United States
2008-03-11 13:56:10
Make sure there are no leaks with the new fontstructs (fs).
I
can't really follow it from the diff.

Please also add {} around single line if/for/while
statements.
It is the coding standard we use in that code (should be
anyway).

Please set variables to NULL after calling free (or just
use
HX_FREE();

rest looks good.
--greg.


Zheng, Huan wrote:
> Modified by: <huan.zhengintel.com>
> 
> Date: <03:11:08>
> 
> Project: [Datatype-dev] CR: Add simplified chinese
character rendering 
> support into rtrender
> 
> Synopsis:
> 
> Add Simplified Chinese character rendering support into
rtrender.
> 
> Overview:
> 
> Add simplified Chinese character rendering support into
rtrender, 
> supports GB2312 charset.
> 
> Original rtrender didn't support i18n, this patch
retains original 
> rendering code by introducing new struct which includes
both original
> 
> XFontStruct,XDrawString and new
XFontSet,Xutf8DrawString which support i18n.
> 
> This patch also leaves some places for other charset to
translate into 
> UTF-8, so that supporting for other charset becomes
easier.
> 
> Files 
> Added:                                                 
                        
>                                       
> 
> Files Modified:
> 
>     rtwin.cpp
(datatype/text/realtext/renderer/platform/unix/rtwin.cpp)
> 
> Image Size and Heap Use impact (Client -Only):
> 
>     little
> 
> Platforms and Profiles Affected:
> 
>     platform:   linux-2.2-libc6-gcc32-i586
> 
>     profile:    helix-client-all-defines
> 
> Distribution Libraries Affected:
> 
>     <rtrender.so>
> 
> Distribution library impact and planned action:
> 
>     <None>
> 
> Platforms and Profiles Build Verified:
> 
>     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> 
>     Set Target(s)   ->
datatype_text_realtext_renderer
> 
>     Set Profile     -> helix-client-all-defines
> 
>     System ID       -> linux-2.2-libc6-gcc32-i586
> 
> Branch:
> 
>     HEAD, hxclient_3_1_0_atlas
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>   2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>            to RealNetworks, and received acknowledgment
that the
> 
>            agreement was received.
> 
> Files Attached:
> 
> rtrender.diff
> 
>  
> 
>  
> 
> Best Regards, Zheng, Huan(ZBT)
> 
> OTC/SSD/SSG
> 
> Intel Aisa-Pacific Research & Developement Ltd
> 
> Tel: 021-6116 6435
> 
> Inet: 8821 6435
> 
> Cub: 3W035
> 
>  
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

CR:Add chinese character rendering support intortrender, suppo
country flaguser name
United States
2008-03-11 13:53:45
If you have tested this on the default iso8859-1
character set and you're sure this change hasn't broken
anything, then this looks good to me.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounceshelixcommunity.org 
> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> Zheng, Huan
> Sent: Tuesday, March 11, 2008 2:37 AM
> To: Greg Wright; datatype-devhelixcommunity.org
> Cc: Shen, Cathy; helix-client-devhelixcommunity.org; Guo, 
> Young; Zheng, Huan
> Subject: [datatype-dev] CR:Add chinese character
rendering 
> support intortrender, supports GB2312
> 
> Modified by: <huan.zhengintel.com>
> 
> Date: <03:11:08>
> 
> Project: [Datatype-dev] CR: Add simplified chinese
character 
> rendering support into rtrender
> 
> Synopsis:
> 
> Add Simplified Chinese character rendering support into
rtrender.
> 
> Overview: 
> 
> Add simplified Chinese character rendering support into

> rtrender, supports GB2312 charset.
> 
> Original rtrender didn't support i18n, this patch
retains 
> original rendering code by introducing new struct which

> includes both original
> 
> XFontStruct,XDrawString and new
XFontSet,Xutf8DrawString 
> which support i18n.
> 
> This patch also leaves some places for other charset to

> translate into UTF-8, so that supporting for other
charset 
> becomes easier.
> 
> Files Added:                                           
      
>                                                        
      
> 
> Files Modified:
> 
>     rtwin.cpp 
>
(datatype/text/realtext/renderer/platform/unix/rtwin.cpp)
> 
> Image Size and Heap Use impact (Client -Only):
> 
>     little
> 
> Platforms and Profiles Affected:
> 
>     platform:   linux-2.2-libc6-gcc32-i586
> 
>     profile:    helix-client-all-defines
> 
> Distribution Libraries Affected:
> 
>     <rtrender.so>
> 
> Distribution library impact and planned action:
> 
>     <None>
> 
> Platforms and Profiles Build Verified:
> 
>     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> 
>     Set Target(s)   ->
datatype_text_realtext_renderer
> 
>     Set Profile     -> helix-client-all-defines
> 
>     System ID       -> linux-2.2-libc6-gcc32-i586
> 
> Branch: 
> 
>     HEAD, hxclient_3_1_0_atlas
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>   2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>            agreement was received. 
> 
> Files Attached:
> 
> rtrender.diff
> 
>  
> 
>  
> 
> Best Regards, Zheng, Huan(ZBT)
> 
> OTC/SSD/SSG
> 
> Intel Aisa-Pacific Research & Developement Ltd
> 
> Tel: 021-6116 6435
> 
> Inet: 8821 6435
> 
> Cub: 3W035
> 
>  
> 
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

CR:Add chinese character rendering support intortrender, suppo
user name
2008-03-11 20:15:48
It has not impact to iso-8859-1, I have tested it.
For iso-8859-1, code will go into original path. 

Best Regards, Zheng, Huan(ZBT)
OTC/SSD/SSG
Intel Aisa-Pacific Research & Developement Ltd
Tel: 021-6116 6435
Inet: 8821 6435
Cub: 3W035
-----Original Message-----
From: Eric Hyche [mailto:ehychereal.com] 
Sent: 2008年3月12日 2:54
To: Zheng, Huan; 'Greg Wright'; datatype-devhelixcommunity.org
Cc: Shen, Cathy; helix-client-devhelixcommunity.org; Guo,
Young
Subject: RE: [datatype-dev] CR:Add chinese character
rendering support intortrender, supports GB2312


If you have tested this on the default iso8859-1
character set and you're sure this change hasn't broken
anything, then this looks good to me.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounceshelixcommunity.org 
> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> Zheng, Huan
> Sent: Tuesday, March 11, 2008 2:37 AM
> To: Greg Wright; datatype-devhelixcommunity.org
> Cc: Shen, Cathy; helix-client-devhelixcommunity.org; Guo, 
> Young; Zheng, Huan
> Subject: [datatype-dev] CR:Add chinese character
rendering 
> support intortrender, supports GB2312
> 
> Modified by: <huan.zhengintel.com>
> 
> Date: <03:11:08>
> 
> Project: [Datatype-dev] CR: Add simplified chinese
character 
> rendering support into rtrender
> 
> Synopsis:
> 
> Add Simplified Chinese character rendering support into
rtrender.
> 
> Overview: 
> 
> Add simplified Chinese character rendering support into

> rtrender, supports GB2312 charset.
> 
> Original rtrender didn't support i18n, this patch
retains 
> original rendering code by introducing new struct which

> includes both original
> 
> XFontStruct,XDrawString and new
XFontSet,Xutf8DrawString 
> which support i18n.
> 
> This patch also leaves some places for other charset to

> translate into UTF-8, so that supporting for other
charset 
> becomes easier.
> 
> Files Added:                                           
      
>                                                        
      
> 
> Files Modified:
> 
>     rtwin.cpp 
>
(datatype/text/realtext/renderer/platform/unix/rtwin.cpp)
> 
> Image Size and Heap Use impact (Client -Only):
> 
>     little
> 
> Platforms and Profiles Affected:
> 
>     platform:   linux-2.2-libc6-gcc32-i586
> 
>     profile:    helix-client-all-defines
> 
> Distribution Libraries Affected:
> 
>     <rtrender.so>
> 
> Distribution library impact and planned action:
> 
>     <None>
> 
> Platforms and Profiles Build Verified:
> 
>     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> 
>     Set Target(s)   ->
datatype_text_realtext_renderer
> 
>     Set Profile     -> helix-client-all-defines
> 
>     System ID       -> linux-2.2-libc6-gcc32-i586
> 
> Branch: 
> 
>     HEAD, hxclient_3_1_0_atlas
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>   2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>            agreement was received. 
> 
> Files Attached:
> 
> rtrender.diff
> 
>  
> 
>  
> 
> Best Regards, Zheng, Huan(ZBT)
> 
> OTC/SSD/SSG
> 
> Intel Aisa-Pacific Research & Developement Ltd
> 
> Tel: 021-6116 6435
> 
> Inet: 8821 6435
> 
> Cub: 3W035
> 
>  
> 
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

RE: CR:Add chinese character rendering support into rtrender, supports GB2312
user name
2008-03-11 20:46:03

Make sure there are no leaks with the new fontstructs (fs). I

can't really follow it from the diff.

[huan] original code also didn't free fontstruct in this cpp file. Fontstructs are stored in dictionary which may handle resource free.

Please also add {} around single line if/for/while statements.

It is the coding standard we use in that code (should be

anyway).

[huan] done

Please set variables to NULL after calling free (or just use

HX_FREE();

[huan] done

Best Regards, Zheng, Huan(ZBT)

OTC/SSD/SSG

Intel Aisa-Pacific Research & Developement Ltd

Tel: 021-6116 6435

Inet: 8821 6435

Cub: 3W035

 

-----Original Message-----
From: Greg Wright [mailto:gwrightreal.com]
Sent: 2008
312 2:56
To: Zheng, Huan
Cc: datatype-devhelixcommunity.org; helix-client-devhelixcommunity.org; Guo, Young; Shen, Cathy; Zhao, Halley; Daniel Yek
Subject: Re: CR:Add chinese character rendering support into rtrender, supports GB2312

 

Make sure there are no leaks with the new fontstructs (fs). I

can't really follow it from the diff.

 

Please also add {} around single line if/for/while statements.

It is the coding standard we use in that code (should be

anyway).

 

Please set variables to NULL after calling free (or just use

HX_FREE();

 

rest looks good.

--greg.

 

 

Zheng, Huan wrote:

> Modified by: <huan.zhengintel.com&gt;

>

> Date: <03:11:08>

>

> Project: [Datatype-dev] CR: Add simplified chinese character rendering

> support into rtrender

>

> Synopsis:

>

> Add Simplified Chinese character rendering support into rtrender.

>

> Overview:

>

> Add simplified Chinese character rendering support into rtrender,

> supports GB2312 charset.

>

> Original rtrender didn't support i18n, this patch retains original

> rendering code by introducing new struct which includes both original

>

> XFontStruct,XDrawString and new XFontSet,Xutf8DrawString which support i18n.

>

> This patch also leaves some places for other charset to translate into

> UTF-8, so that supporting for other charset becomes easier.

>

> Files

> Added:&nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp;   &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   

  ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp; &nbsp; &nbsp; &nbsp;   ; &nbsp;

>

> Files Modified:

>

  ;  rtwin.cpp (datatype/text/realtext/renderer/platform/unix/rtwin.cpp)

>

> Image Size and Heap Use impact (Client -Only):

>

  ;  little

>

> Platforms and Profiles Affected:

>

  ;  platform:&nbsp;  linux-2.2-libc6-gcc32-i586

>

  ;  profile:&nbsp; &nbsp; helix-client-all-defines

>

> Distribution Libraries Affected:

>

  ;  <rtrender.so>

>

> Distribution library impact and planned action:

>

  ;  <None&gt;

>

> Platforms and Profiles Build Verified:

>

  ;  Set BIF branch&nbsp; -> hxclient_3_1_0_atlas_restricted

>

  ;  Set Target(s)&nbsp;  -> datatype_text_realtext_renderer

>

  ;  Set Profile&nbsp; &nbsp;  -> helix-client-all-defines

>

  ;  System ID &nbsp; &nbsp;  &nbsp;-> linux-2.2-libc6-gcc32-i586

>

> Branch:

>

  ;  HEAD, hxclient_3_1_0_atlas

>

> Copyright assignment: <MUST be one of the following statements >

>

  2. &nbsp; &nbsp;  Intel has signed and delivered a Joint Copyright Assignment

>

  ; &nbsp; &nbsp; &nbsp; &nbsp; to RealNetworks, and received acknowledgment that the

>

  ; &nbsp; &nbsp; &nbsp; &nbsp; agreement was received.

>

> Files Attached:

>

> rtrender.diff

>

>

>

> Best Regards, Zheng, Huan(ZBT)

>

> OTC/SSD/SSG

>

> Intel Aisa-Pacific Research & Developement Ltd

>

> Tel: 021-6116 6435

>

> Inet: 8821 6435

>

> Cub: 3W035

>

>

 

CR:Add chinese character rendering support intortrender, suppo
country flaguser name
United States
2008-03-12 10:39:25
Ok - then it looks good to me.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Zheng, Huan [mailto:huan.zhengintel.com] 
> Sent: Tuesday, March 11, 2008 9:16 PM
> To: ehychereal.com; Greg Wright; datatype-devhelixcommunity.org
> Cc: Shen, Cathy; helix-client-devhelixcommunity.org; Guo,
Young
> Subject: RE: [datatype-dev] CR:Add chinese character 
> rendering support intortrender, supports GB2312
> 
> It has not impact to iso-8859-1, I have tested it.
> For iso-8859-1, code will go into original path. 
> 
> Best Regards, Zheng, Huan(ZBT)
> OTC/SSD/SSG
> Intel Aisa-Pacific Research & Developement Ltd
> Tel: 021-6116 6435
> Inet: 8821 6435
> Cub: 3W035
> -----Original Message-----
> From: Eric Hyche [mailto:ehychereal.com] 
> Sent: 2008$BG/(B3$B7n(B12$BF|(B 2:54
> To: Zheng, Huan; 'Greg Wright'; datatype-devhelixcommunity.org
> Cc: Shen, Cathy; helix-client-devhelixcommunity.org; Guo,
Young
> Subject: RE: [datatype-dev] CR:Add chinese character 
> rendering support intortrender, supports GB2312
> 
> 
> If you have tested this on the default iso8859-1
> character set and you're sure this change hasn't
broken
> anything, then this looks good to me.
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: datatype-dev-bounceshelixcommunity.org 
> > [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> > Zheng, Huan
> > Sent: Tuesday, March 11, 2008 2:37 AM
> > To: Greg Wright; datatype-devhelixcommunity.org
> > Cc: Shen, Cathy; helix-client-devhelixcommunity.org; Guo, 
> > Young; Zheng, Huan
> > Subject: [datatype-dev] CR:Add chinese character
rendering 
> > support intortrender, supports GB2312
> > 
> > Modified by: <huan.zhengintel.com>
> > 
> > Date: <03:11:08>
> > 
> > Project: [Datatype-dev] CR: Add simplified chinese
character 
> > rendering support into rtrender
> > 
> > Synopsis:
> > 
> > Add Simplified Chinese character rendering support
into rtrender.
> > 
> > Overview: 
> > 
> > Add simplified Chinese character rendering support
into 
> > rtrender, supports GB2312 charset.
> > 
> > Original rtrender didn't support i18n, this patch
retains 
> > original rendering code by introducing new struct
which 
> > includes both original
> > 
> > XFontStruct,XDrawString and new
XFontSet,Xutf8DrawString 
> > which support i18n.
> > 
> > This patch also leaves some places for other
charset to 
> > translate into UTF-8, so that supporting for other
charset 
> > becomes easier.
> > 
> > Files Added:                                      
           
> >                                                   
           
> > 
> > Files Modified:
> > 
> >     rtwin.cpp 
> >
(datatype/text/realtext/renderer/platform/unix/rtwin.cpp)
> > 
> > Image Size and Heap Use impact (Client -Only):
> > 
> >     little
> > 
> > Platforms and Profiles Affected:
> > 
> >     platform:   linux-2.2-libc6-gcc32-i586
> > 
> >     profile:    helix-client-all-defines
> > 
> > Distribution Libraries Affected:
> > 
> >     <rtrender.so>
> > 
> > Distribution library impact and planned action:
> > 
> >     <None>
> > 
> > Platforms and Profiles Build Verified:
> > 
> >     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> > 
> >     Set Target(s)   ->
datatype_text_realtext_renderer
> > 
> >     Set Profile     ->
helix-client-all-defines
> > 
> >     System ID       ->
linux-2.2-libc6-gcc32-i586
> > 
> > Branch: 
> > 
> >     HEAD, hxclient_3_1_0_atlas
> > 
> > Copyright assignment: <MUST be one of the
following statements >
> > 
> >   2.      Intel has signed and delivered a Joint
Copyright 
> Assignment
> > 
> >            to RealNetworks, and received
acknowledgment that the 
> > 
> >            agreement was received. 
> > 
> > Files Attached:
> > 
> > rtrender.diff
> > 
> >  
> > 
> >  
> > 
> > Best Regards, Zheng, Huan(ZBT)
> > 
> > OTC/SSD/SSG
> > 
> > Intel Aisa-Pacific Research & Developement
Ltd
> > 
> > Tel: 021-6116 6435
> > 
> > Inet: 8821 6435
> > 
> > Cub: 3W035
> > 
> >  
> > 
> > 
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

CN:Add chinese character rendering support intortrender, supports GB2312
user name
2008-03-12 20:10:50
Committed to atlas.
Thanks for advice. 

Best Regards, Zheng, Huan(ZBT)
OTC/SSD/SSG
Intel Aisa-Pacific Research & Developement Ltd
Tel: 021-6116 6435
Inet: 8821 6435
Cub: 3W035
-----Original Message-----
From: Eric Hyche [mailto:ehychereal.com] 
Sent: 2008年3月12日 23:39
To: Zheng, Huan; 'Greg Wright'; datatype-devhelixcommunity.org
Cc: Shen, Cathy; helix-client-devhelixcommunity.org; Guo,
Young
Subject: RE: [datatype-dev] CR:Add chinese character
rendering support intortrender, supports GB2312


Ok - then it looks good to me.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Zheng, Huan [mailto:huan.zhengintel.com] 
> Sent: Tuesday, March 11, 2008 9:16 PM
> To: ehychereal.com; Greg Wright; datatype-devhelixcommunity.org
> Cc: Shen, Cathy; helix-client-devhelixcommunity.org; Guo,
Young
> Subject: RE: [datatype-dev] CR:Add chinese character 
> rendering support intortrender, supports GB2312
> 
> It has not impact to iso-8859-1, I have tested it.
> For iso-8859-1, code will go into original path. 
> 
> Best Regards, Zheng, Huan(ZBT)
> OTC/SSD/SSG
> Intel Aisa-Pacific Research & Developement Ltd
> Tel: 021-6116 6435
> Inet: 8821 6435
> Cub: 3W035
> -----Original Message-----
> From: Eric Hyche [mailto:ehychereal.com] 
> Sent: 2008年3月12日 2:54
> To: Zheng, Huan; 'Greg Wright'; datatype-devhelixcommunity.org
> Cc: Shen, Cathy; helix-client-devhelixcommunity.org; Guo,
Young
> Subject: RE: [datatype-dev] CR:Add chinese character 
> rendering support intortrender, supports GB2312
> 
> 
> If you have tested this on the default iso8859-1
> character set and you're sure this change hasn't
broken
> anything, then this looks good to me.
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: datatype-dev-bounceshelixcommunity.org 
> > [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> > Zheng, Huan
> > Sent: Tuesday, March 11, 2008 2:37 AM
> > To: Greg Wright; datatype-devhelixcommunity.org
> > Cc: Shen, Cathy; helix-client-devhelixcommunity.org; Guo, 
> > Young; Zheng, Huan
> > Subject: [datatype-dev] CR:Add chinese character
rendering 
> > support intortrender, supports GB2312
> > 
> > Modified by: <huan.zhengintel.com>
> > 
> > Date: <03:11:08>
> > 
> > Project: [Datatype-dev] CR: Add simplified chinese
character 
> > rendering support into rtrender
> > 
> > Synopsis:
> > 
> > Add Simplified Chinese character rendering support
into rtrender.
> > 
> > Overview: 
> > 
> > Add simplified Chinese character rendering support
into 
> > rtrender, supports GB2312 charset.
> > 
> > Original rtrender didn't support i18n, this patch
retains 
> > original rendering code by introducing new struct
which 
> > includes both original
> > 
> > XFontStruct,XDrawString and new
XFontSet,Xutf8DrawString 
> > which support i18n.
> > 
> > This patch also leaves some places for other
charset to 
> > translate into UTF-8, so that supporting for other
charset 
> > becomes easier.
> > 
> > Files Added:                                      
           
> >                                                   
           
> > 
> > Files Modified:
> > 
> >     rtwin.cpp 
> >
(datatype/text/realtext/renderer/platform/unix/rtwin.cpp)
> > 
> > Image Size and Heap Use impact (Client -Only):
> > 
> >     little
> > 
> > Platforms and Profiles Affected:
> > 
> >     platform:   linux-2.2-libc6-gcc32-i586
> > 
> >     profile:    helix-client-all-defines
> > 
> > Distribution Libraries Affected:
> > 
> >     <rtrender.so>
> > 
> > Distribution library impact and planned action:
> > 
> >     <None>
> > 
> > Platforms and Profiles Build Verified:
> > 
> >     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> > 
> >     Set Target(s)   ->
datatype_text_realtext_renderer
> > 
> >     Set Profile     ->
helix-client-all-defines
> > 
> >     System ID       ->
linux-2.2-libc6-gcc32-i586
> > 
> > Branch: 
> > 
> >     HEAD, hxclient_3_1_0_atlas
> > 
> > Copyright assignment: <MUST be one of the
following statements >
> > 
> >   2.      Intel has signed and delivered a Joint
Copyright 
> Assignment
> > 
> >            to RealNetworks, and received
acknowledgment that the 
> > 
> >            agreement was received. 
> > 
> > Files Attached:
> > 
> > rtrender.diff
> > 
> >  
> > 
> >  
> > 
> > Best Regards, Zheng, Huan(ZBT)
> > 
> > OTC/SSD/SSG
> > 
> > Intel Aisa-Pacific Research & Developement
Ltd
> > 
> > Tel: 021-6116 6435
> > 
> > Inet: 8821 6435
> > 
> > Cub: 3W035
> > 
> >  
> > 
> > 
> 


_______________________________________________
Helix-client-dev mailing list
Helix-client-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinf
o/helix-client-dev

[1-7]

about | contact  Other archives ( Real Estate discussion Medical topics )