List Info

Thread: CN: Fix async timers....




CN: Fix async timers....
user name
2006-07-25 17:58:35
Now in HEAD.

--greg.


Eric Hyche wrote:
> Looks good. 
> 
>> -----Original Message-----
>> From: common-dev-bounceshelixcommunity.org 
>> [mailto:common-dev-bounceshelixcommunity.org] On
Behalf Of 
>> Greg Wright
>> Sent: Monday, July 24, 2006 8:16 PM
>> To: common-dev
>> Subject: [Common-dev] CR: Fix async timers....
>>
>> Took a while to find this, but the player on HEAD
could not
>> play more then 1 clip in a row without hanging. The
hanging
>> came from HXPlayer::SetupAudioPlayer() never
completing. It
>> would just get called from scheduler over and over
again. Turns
>> out it wants to be called on a certain thread. This
thread
>> was never getting time in the scheduler. The
problem was our
>> scheduler was only being driven by the
EventOccured() calls
>> from splay, the other thread was not pumping out
OnTimeSync()
>> calls. This was happening because the timer that
was suppose
>> to generate our HXMSG_ASYNC_TIMER messages was
being killed
>> by another thread. If you look at the diff you will
see that
>> the timer id member var was static, so all timers
shared the
>> same ID and the first time kill was called (from a
timeline
>> pause) it deleted all timers.
>>
>> Fix is simple, just don't make it static.
>>
>> For HEAD only.
>>
>> --greg.
>>
>>
>> Index: pub/hxthread.h
>>
============================================================
=======
>> RCS file: /cvsroot/common/system/pub/hxthread.h,v
>> retrieving revision 1.14
>> diff -u -w -r1.14 hxthread.h
>> --- pub/hxthread.h      21 Jul 2006 01:43:34 -0000 
    1.14
>> +++ pub/hxthread.h      25 Jul 2006 00:09:13 -0000
>>  -192,7 +192,7 
>>       HXAsyncTimer();
>>
>>   private:
>> -    static UINT32 m_ulTimerID;
>> +    UINT32 m_ulTimerID;
>>   };
>>
>> _______________________________________________
>> Common-dev mailing list
>> Common-devhelixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev
>>
> 
> 

_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev
[1]

about | contact  Other archives ( Real Estate discussion Medical topics )