Thanks Eric,
These changes have been checked in Head.
Gurpreet
Eric Hyche wrote:
> Looks good.
>
> =============================================
> Eric Hyche (ehyche real.com)
> Technical Lead
> RealNetworks, Inc.
>
>
>> -----Original Message-----
>> From: Gurpreet [mailto:gahluwaliareal.com]
>> Sent: Thursday, December 07, 2006 9:38 AM
>> To: ehychereal.com
>> Cc: client-devhelixcommunity.org;
>> porting-symbianhelixcommunity.org;
common-dev
>> Subject: Re: [Client-dev] CR: changes for removing
build
>> errors in head clientmodule for Symbian.
>>
>> Hi,
>> I have fixed the logObserver plugin.
>> Diffs are attached with the message.
>>
>> Regards,
>> Gurpreet
>>
>> Eric Hyche wrote:
>>
>>> As far as you know, is logobserverfile.dll the
only
>>> plugin for which this happens? If so, then
>>> let's fix logobserverfile.dll rather than
putting
>>> special-case code like this in the media
platform.
>>>
>>> Eric
>>>
>>> =============================================
>>> Eric Hyche (ehychereal.com)
>>> Technical Lead
>>> RealNetworks, Inc.
>>>
>>>
>>>> -----Original Message-----
>>>> From: Gurpreet [mailto:gahluwaliareal.com]
>>>> Sent: Wednesday, December 06, 2006 7:27 AM
>>>> To: ehychereal.com
>>>> Cc: client-devhelixcommunity.org;
>>>>
>> porting-symbianhelixcommunity.org
>>
>>>> Subject: Re: [Client-dev] CR: changes for
removing build
>>>> errors in head clientmodule for Symbian.
>>>>
>>>> +#else//HELIX_INIT_PLUGIN_ONLY_ONCE
>>>> + pUnk->AddRef();
>>>> +
m_pLoadAtStartupPlugins->AddTail((void*)
>>>> pUnk);
>>>> +#endif//HELIX_INIT_PLUGIN_ONLY_ONCE
>>>> }
>>>>
HX_RELEASE(pUnk);
>>>> }
>>>>
>>>> What does HELIX_INIT_PLUGIN_ONLY_ONCE mean?
Is this
>>>> the only place it is used in the codebase?
Is there some problem
>>>> with calling InitPlugin() more than once
with some plugins? If
>>>> so, which ones?
>>>>
>>>> HELIX_INIT_PLUGIN_ONLY_ONCE is used so
that startup plugins are
>>>> initialized only once. This is the only
place where its used.
>>>> Assert Fails when InitPlugin() tries to
create m_pFileMutex second
>>>> time, because its already created in first
call. This happens with
>>>> startup plugins. i.e. logobserverfile.dll.
>>>>
>>>>
>>>> commonutilpckunpck.cpp 2802
>>>> HX_RESULT
>>>> CreateInstanceCCF(REFCLSID clsid, void**
ppObject,
>>>>
>> IUnknown* pContext)
>>
>>>> {
>>>> HX_RESULT hr = HXR_FAIL;
>>>> HX_ASSERT(NULL == *ppObject); <<
---------- Assert Fails
>>>> HX_ASSERT(pContext);
>>>>
>>>>
>>>>
>>>> +if project.IsDefined('_SYMBIAN_81_'):
>>>> +
>>>>
>>
project.AddModuleLibraries("protocol/common/util[protut
illib]",
>>
>>>> "protocol/http[httplib]")
>>>> Why are these only needed for Symbian 8.1
and no other
>>>> symbian version?
>>>>
>>>> I was not sure of their use on Symbian 9.0,
thats why I had
>>>> put this in
>>>> Symbian 8.1 define.
>>>>
>>>>
>>>>
>>>> Regards,
>>>> Gurpreet
>>>>
>>>>
>>>>
>>>> Eric Hyche wrote:
>>>>
>>>>> I didn't see any kind of change here:
>>>>>
>>>>> Index: core/hxdll.cpp
>>>>>
>>>>>
>>
============================================================
=======
>>
>>>>> RCS file:
/cvsroot/client/core/hxdll.cpp,v
>>>>> retrieving revision 1.7
>>>>> diff -u -r1.7 hxdll.cpp
>>>>> --- core/hxdll.cpp 19 Jul 2006 14:11:29
-0000 1.7
>>>>> +++ core/hxdll.cpp 5 Dec 2006 13:08:50
-0000
>>>>> -151,7 +151,7
>>>>> {
>>>>> #if defined(HELIX_CONFIG_NOSTATICS)
>>>>> UINT16& g_uNumEngines =
>>>>>
>>>>
(UINT16&)HXGlobalInt16::Get(&::g_uNumEngines);
>>>>
>>>>> - HXClientEngine*& g_pEngine =
>>>>>
(HXClientEngine*&)HXGlobalPtr::Get(&::g_pEngine);
>>>>> + HXClientEngine*& g_pEngine =
>>>>>
(HXClientEngine*&)HXGlobalPtr::Get(&::g_pEngine);
>>>>> #endif
>>>>>
>>>>> If it's just a whitespace change, you
can eliminate
>>>>> those from showing up in the diff by
using the
>>>>> -w option when you do "cvs
diff".
>>>>>
>>>>> In this change:
>>>>>
>>>>> Index: medpltfm/chxmedpltfm.cpp
>>>>>
>>>>>
>>
============================================================
=======
>>
>>>>> RCS file:
/cvsroot/client/medpltfm/chxmedpltfm.cpp,v
>>>>> retrieving revision 1.38
>>>>> diff -u -r1.38 chxmedpltfm.cpp
>>>>> --- medpltfm/chxmedpltfm.cpp 20 Oct
2006 00:12:37
>>>>>
>>>> -0000 1.38
>>>>
>>>>> +++ medpltfm/chxmedpltfm.cpp 5 Dec 2006
13:08:50 -0000
>>>>> -739,6 +739,7
>>>>> if
(SUCCEEDED(retVal))
>>>>> {
>>>>> // Get
the IHXPlugin interface
>>>>> +#ifndef HELIX_INIT_PLUGIN_ONLY_ONCE //
Plugin is already
>>>>>
>>>> initialized in
>>>>
>>>>> GetPluginAt
>>>>>
IHXPlugin* pPlugin = NULL;
>>>>> retVal
=
>>>>> pUnk->QueryInterface(IID_IHXPlugin,
(void**) &pPlugin);
>>>>> if
(SUCCEEDED(retVal))
>>>>> -754,6 +755,10
>>>>> }
>>>>> }
>>>>>
HX_RELEASE(pPlugin);
>>>>> +#else//HELIX_INIT_PLUGIN_ONLY_ONCE
>>>>> + pUnk->AddRef();
>>>>>
+ m_pLoadAtStartupPlugins->AddTail((void*)
>>>>> pUnk);
>>>>> +#endif//HELIX_INIT_PLUGIN_ONLY_ONCE
>>>>> }
>>>>>
HX_RELEASE(pUnk);
>>>>> }
>>>>>
>>>>> What does HELIX_INIT_PLUGIN_ONLY_ONCE
mean? Is this
>>>>> the only place it is used in the
codebase? Is there some problem
>>>>> with calling InitPlugin() more than
once with some plugins? If
>>>>> so, which ones?
>>>>>
>>>>>
>>>>> Here:
>>>>>
>>>>> +if project.IsDefined('_SYMBIAN_81_'):
>>>>>
+ project.AddModuleLibraries("protocol/common/util[prot
utillib]",
>>>>> "protocol/http[httplib]")
>>>>>
>>>>> Why are these only needed for Symbian
8.1 and no other
>>>>>
>>>> symbian version?
>>>>
>>>>> Rest looks good.
>>>>>
>>>>> Eric
>>>>>
>>>>>
=============================================
>>>>> Eric Hyche (ehychereal.com)
>>>>> Technical Lead
>>>>> RealNetworks, Inc.
>>>>>
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: client-dev-bounceshelixcommunity.org
>>>>>> [mailto:client-dev-bounceshelixcommunity.org] On Behalf
>>>>>>
>>>> Of Gurpreet
>>>>
>>>>>> Sent: Tuesday, December 05, 2006
9:04 AM
>>>>>> To: client-devhelixcommunity.org
>>>>>> Cc: porting-symbianhelixcommunity.org
>>>>>> Subject: [Client-dev] CR: changes
for removing build errors
>>>>>> in head clientmodule for Symbian.
>>>>>>
>>>>>> Synopsis:
>>>>>> Changes are required to remove
build errors and playback
>>>>>>
>>>> problems on
>>>>
>>>>>> symbian emalutor.
>>>>>> Socket buffers have been changed
from normal buffer to
>>>>>> timestamp buffer.
>>>>>> timestamp buffers are required for
auto bandwidth detection.
>>>>>>
>>>>>> Overview:
>>>>>> These changes are needed to get the
HEAD (Atlas) code to work
>>>>>> on Symbian 8.1
>>>>>>
>>>>>> Files Added:
>>>>>> None
>>>>>>
>>>>>> Files Modified:
>>>>>>
common/system/hxsched.cpphxsched.cpp
>>>>>> common/util/Umakefil
>>>>>>
common/util/hxpreferencesenumerator.cpp
>>>>>> core/hxdll.cpp
>>>>>> medpltfm/chxmedpltfm.cpp
>>>>>> medpltfm/hxdll.cpp
>>>>>> medpltfm/hxmedpltfmdll_symbian.pcf
>>>>>> netwksvc/hxnetwksvcpln_symbian.pcf
>>>>>> netwksvc/symbian.pcf
>>>>>>
netwksvc/platform/symbian/hxsymbianapman.cpp
>>>>>>
netwksvc/platform/symbian/hxsymbiansockhlp.cpp
>>>>>>
netwksvc/platform/symbian/hxsymbiantcpsock.cpp
>>>>>>
netwksvc/platform/symbian/hxsymbianudpsock.cpp
>>>>>> common/netio/shim_net_services.cpp
>>>>>>
>>>>>>
>>>>>> Image Size and Heap Use impact
(Client -Only):
>>>>>> None.
>>>>>>
>>>>>> Platforms and Profiles Affected:
>>>>>> symbian-81
>>>>>>
>>>>>> Distribution Libraries Affected:
>>>>>> None
>>>>>>
>>>>>> Distribution library impact and
planned action:
>>>>>> None
>>>>>>
>>>>>> Platforms and Profiles Build
Verified:
>>>>>>
>>>>>> BIF branch -> helix_restricted
>>>>>> Target(s) -> symbianinst
>>>>>> Profile ->
helix-client-s60-advanced
>>>>>> SYSTEM_ID->
symbian-81-winscw-emulator
>>>>>>
>>>>>>
>>>>>> Branch:
>>>>>> HEAD
>>>>>>
>>>>>> Files Attached:
>>>>>> client.zip containing the diff file
client.diff
>>>>>>
>>>>>> Regards,
>>>>>> Gurpreet
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>
>>
>
>
>
_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev
|