CR: Add Symbian Video Parameters to Global Store for MDF startup

Is any synchronization (mutex) needed between those reading
and
writing this global data?

Looks good.

--greg.


Shy.Wardnokia.com wrote:
> "Nokia submits this code under the terms of a
commercial contribution
> agreement with RealNetworks, and I am authorized to
contribute this code
> under said agreement."
> 
> 	Modified by:  shy.wardnokia.com
> 
> 	Reviewed by: 
> 
> 	Date: 14-Dec-2006
> 
> 	Project: SymbianMmf
> 
> 	ErrorId:  ESIA-6VEFFU
> 	                 EOVL-6P3TWP
> 
> 	Synopsis:  CR: Add Symbian Video Parameters to Global
Store for
> MDF startup
> 
> 	    Display Region & DSA status given to the MMF
controller were
> not properly stored and passed down to the MDF upon
it's creation. This
> would cause the MDF to improperly blit over areas that
were not owed by
> them. This is solved by saving all display related
parameters in the
> global store. The MDF reads the needed values during
it's creation. At
> no other time does the MDF use the global store.
> 
> 	It was discussed to not use the IHXRegistry due to
concerns of
> timing and the complexity of extending the Registry to
meet our needs.
> 
> 	Root Cause of the problem: Design: during the design
phase the
> storing of video parameters between MMF creation and
MDF creation was
> not taken into consideration
> 	  
> 	Files Modified:
> 
> 	common/system/symbian.pcf
> 	common/system/platform/pub/symbian/symbian_gm_inst.h
> 	datatype/mdf/video/renderer/pub/mdfvideoadapter.h
> 	datatype/mdf/video/renderer/umakelib
> 	datatype/mdf/video/renderer/umakedll
> 	datatype/mdf/video/renderer/mdfvideoadapter.cpp
> 	clientapps/symbianMmf/hxmmfsitesupplier.cpp
> 	clientapps/symbianMmf/hxmmfsitesupplier.h
> 
> 
> 	Files Added:
> 
>
	common/system/platform/symbian/symbianglobalvideoparameters
.cpp
> 	
>
common/system/pub/platform/symbian/symbianglobalvideoparamet
ers.h
> 
> 
> 	Image Size and Heap Use impact: no major impact
> 
> 	Module Release testing (STIF) : PASS
> 
> 	Other Testing performed: I tested video playback
against:
> TestRMPlayer, Java, Mediaplayer, SMIL, VideoPlugin
> 
> 	Test case(s) Added  :  No, I know of now way to add
stif cases
> that measure and/or test if scaling, rotation, window
size, display
> region, LOOK correctly. This requires manual testing
and observation.
> 
> 	Memory leak check performed : Yes.  No new leaks
introduced.
> 
> 	Platforms and Profiles Build Verified:
> helix-client-s60-32-mmf-mdf-arm
> 
> 	Platforms and Profiles Functionality verified: armv5,
winscw 
> 
>       Branch: Head & 210CayS
> 
> 
>  <<symbianglobalvideoparameters.cpp>> 
<<datatypediff.txt>>  
> <<clientapps_diff.txt>> 
<<common_system_diff.txt>>  
> <<symbianglobalvideoparameters.h>> 
> 
> 
> 
>
------------------------------------------------------------
------------
> 
> _______________________________________________
> Common-dev mailing list
> Common-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

Greg,

No synchronization is needed due to fact we are single
threaded. Also
the way this being used:
the values are read only during MDF creation and written to
by the MMF.
The time between
these events are quite far apart. 

I will revisit this issue if it becomes necessary in the
future. I'm
going to assume this is okay to check 
this in, as sent, please let me know otherwise.

Thanks - Shy;

-----Original Message-----
From: ext Greg Wright [mailto:gwrightreal.com] 
Sent: Thursday, December 14, 2006 5:15 PM
To: Ward Shy (Nokia-TP-MSW/Dallas)
Cc: common-devhelixcommunity.org
Subject: Re: [Common-dev] CR: Add Symbian Video Parameters
to Global
Store for MDF startup

Is any synchronization (mutex) needed between those reading
and writing
this global data?

Looks good.

--greg.


Shy.Wardnokia.com wrote:
> "Nokia submits this code under the terms of a
commercial contribution 
> agreement with RealNetworks, and I am authorized to
contribute this 
> code under said agreement."
> 
> 	Modified by:  shy.wardnokia.com
> 
> 	Reviewed by: 
> 
> 	Date: 14-Dec-2006
> 
> 	Project: SymbianMmf
> 
> 	ErrorId:  ESIA-6VEFFU
> 	                 EOVL-6P3TWP
> 
> 	Synopsis:  CR: Add Symbian Video Parameters to Global
Store for
MDF 
> startup
> 
> 	    Display Region & DSA status given to the MMF
controller were
not 
> properly stored and passed down to the MDF upon it's
creation. This 
> would cause the MDF to improperly blit over areas that
were not owed 
> by them. This is solved by saving all display related
parameters in 
> the global store. The MDF reads the needed values
during it's 
> creation. At no other time does the MDF use the global
store.
> 
> 	It was discussed to not use the IHXRegistry due to
concerns of
timing 
> and the complexity of extending the Registry to meet
our needs.
> 
> 	Root Cause of the problem: Design: during the design
phase the 
> storing of video parameters between MMF creation and
MDF creation was 
> not taken into consideration
> 	  
> 	Files Modified:
> 
> 	common/system/symbian.pcf
> 	common/system/platform/pub/symbian/symbian_gm_inst.h
> 	datatype/mdf/video/renderer/pub/mdfvideoadapter.h
> 	datatype/mdf/video/renderer/umakelib
> 	datatype/mdf/video/renderer/umakedll
> 	datatype/mdf/video/renderer/mdfvideoadapter.cpp
> 	clientapps/symbianMmf/hxmmfsitesupplier.cpp
> 	clientapps/symbianMmf/hxmmfsitesupplier.h
> 
> 
> 	Files Added:
> 
>
	common/system/platform/symbian/symbianglobalvideoparameters
.cpp
> 	
>
common/system/pub/platform/symbian/symbianglobalvideoparamet
ers.h
> 
> 
> 	Image Size and Heap Use impact: no major impact
> 
> 	Module Release testing (STIF) : PASS
> 
> 	Other Testing performed: I tested video playback
against:
> TestRMPlayer, Java, Mediaplayer, SMIL, VideoPlugin
> 
> 	Test case(s) Added  :  No, I know of now way to add
stif cases
that 
> measure and/or test if scaling, rotation, window size,
display region,

> LOOK correctly. This requires manual testing and
observation.
> 
> 	Memory leak check performed : Yes.  No new leaks
introduced.
> 
> 	Platforms and Profiles Build Verified:
> helix-client-s60-32-mmf-mdf-arm
> 
> 	Platforms and Profiles Functionality verified: armv5,
winscw
> 
>       Branch: Head & 210CayS
> 
> 
>  <<symbianglobalvideoparameters.cpp>> 
<<datatypediff.txt>> 
> <<clientapps_diff.txt>> 
<<common_system_diff.txt>> 
> <<symbianglobalvideoparameters.h>>
> 
> 
> 
>
------------------------------------------------------------
------------
> 
> _______________________________________________
> Common-dev mailing list
> Common-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

Thanks Greg.

Checked into HEAD & Cays210

Shy; 

>-----Original Message-----
>From: ext Greg Wright [mailto:gwrightreal.com]

>Sent: Thursday, December 14, 2006 5:15 PM
>To: Ward Shy (Nokia-TP-MSW/Dallas)
>Cc: common-devhelixcommunity.org
>Subject: Re: [Common-dev] CR: Add Symbian Video
Parameters to 
>Global Store for MDF startup
>
>Is any synchronization (mutex) needed between those
reading 
>and writing this global data?
>
>Looks good.
>
>--greg.
>
>
>Shy.Wardnokia.com wrote:
>> "Nokia submits this code under the terms of a
commercial 
>contribution 
>> agreement with RealNetworks, and I am authorized to
contribute this 
>> code under said agreement."
>> 
>> 	Modified by:  shy.wardnokia.com
>> 
>> 	Reviewed by: 
>> 
>> 	Date: 14-Dec-2006
>> 
>> 	Project: SymbianMmf
>> 
>> 	ErrorId:  ESIA-6VEFFU
>> 	                 EOVL-6P3TWP
>> 
>> 	Synopsis:  CR: Add Symbian Video Parameters to
Global 
>Store for MDF 
>> startup
>> 
>> 	    Display Region & DSA status given to the
MMF 
>controller were not 
>> properly stored and passed down to the MDF upon
it's creation. This 
>> would cause the MDF to improperly blit over areas
that were not owed 
>> by them. This is solved by saving all display
related parameters in 
>> the global store. The MDF reads the needed values
during it's 
>> creation. At no other time does the MDF use the
global store.
>> 
>> 	It was discussed to not use the IHXRegistry due to

>concerns of timing 
>> and the complexity of extending the Registry to
meet our needs.
>> 
>> 	Root Cause of the problem: Design: during the
design phase the 
>> storing of video parameters between MMF creation
and MDF 
>creation was 
>> not taken into consideration
>> 	  
>> 	Files Modified:
>> 
>> 	common/system/symbian.pcf
>>
	common/system/platform/pub/symbian/symbian_gm_inst.h
>> 	datatype/mdf/video/renderer/pub/mdfvideoadapter.h
>> 	datatype/mdf/video/renderer/umakelib
>> 	datatype/mdf/video/renderer/umakedll
>> 	datatype/mdf/video/renderer/mdfvideoadapter.cpp
>> 	clientapps/symbianMmf/hxmmfsitesupplier.cpp
>> 	clientapps/symbianMmf/hxmmfsitesupplier.h
>> 
>> 
>> 	Files Added:
>> 
>>
	common/system/platform/symbian/symbianglobalvideoparameters
.cpp
>> 	
>>
common/system/pub/platform/symbian/symbianglobalvideoparamet
ers.h
>> 
>> 
>> 	Image Size and Heap Use impact: no major impact
>> 
>> 	Module Release testing (STIF) : PASS
>> 
>> 	Other Testing performed: I tested video playback
against:
>> TestRMPlayer, Java, Mediaplayer, SMIL, VideoPlugin
>> 
>> 	Test case(s) Added  :  No, I know of now way to
add 
>stif cases that 
>> measure and/or test if scaling, rotation, window
size, 
>display region, 
>> LOOK correctly. This requires manual testing and
observation.
>> 
>> 	Memory leak check performed : Yes.  No new leaks
introduced.
>> 
>> 	Platforms and Profiles Build Verified:
>> helix-client-s60-32-mmf-mdf-arm
>> 
>> 	Platforms and Profiles Functionality verified:
armv5, winscw
>> 
>>       Branch: Head & 210CayS
>> 
>> 
>>  <<symbianglobalvideoparameters.cpp>> 
<<datatypediff.txt>> 
>> <<clientapps_diff.txt>> 
<<common_system_diff.txt>> 
>> <<symbianglobalvideoparameters.h>>
>> 
>> 
>> 
>> 
>--------------------------------------------------------
-------
>---------
>> 
>> _______________________________________________
>> Common-dev mailing list
>> Common-devhelixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev
>
>

_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev