CR: Changes in common/fileio for porting Atlas for Windows Mobile 5.0

-    if (mode & O_RDONLY)
+    if (mode & _O_RDONLY)

So for all these changes, you are sure
both O_RDONLY and _O_RDONLY are defined
on all versions of Windows? Also, instead
of changing it every time it is used, you
might just do the following in some header file:

#if defined(_WINCE)

#if !defined(O_RDONLY)
#define O_RDONLY _O_RDONLY
#endif

#endif

Then you only have to change it once instead
of a bunch of places.

+#if !defined(WIN32_PLATFORM_PSPC) || (_WIN32_WCE >=
211)

Can you refresh my memory on when WIN32_PLATFORM_PSPC and
_WIN32_WCE are defined and what they are defined as?
If I remember correctly, WIN32_PLATFORM_PSPC is defined
when you building for PocketPC (as opposed to Smartphone,
for which there is a different define).

Rest looks good.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: common-dev-bounceshelixcommunity.org 
> [mailto:common-dev-bounceshelixcommunity.org] On
Behalf Of anshuman
> Sent: Thursday, July 19, 2007 9:05 AM
> To: common-dev
> Subject: [Common-dev] CR: Changes in common/fileio for

> porting Atlas forWindows Mobile 5.0
> 
> Synopsis:
> Multiple changes for porting Atlas onto Windows Mobile
5.0
> Overview:
> 1 In WINCE, we dont want to use _O_BINARY for checking
the 
> Read only, Write only or Read-Write mode
> 2. GetTempPath and SHGetSpecialFolderLocation  is
defined 
> from Windows CE 3.0 onwards so including that
>  
> Files Added:
> None
>  
> Files Modified:
> 
> common/fileio/platform/win/cwin32file.cpp
> 
> common/fileio/platform/win/filespecutils.cpp
>  
> Image Size and Heap Use impact (Client -Only):
> None.
> 
> Platforms and Profiles Affected:
> Platform  : wince-500-ppc-arm
> Profile     : helix-client-wince-wm50 (NEW)
>  
> Distribution Libraries Affected:
> None
> 
> Distribution library impact and planned action:
> None
> 
> Platforms and Profiles Build Verified:
> 
> BIF branch  -> helix_restricted
> Target(s)     -> wince_wm50_play (new)
> Profile         -> helix-client-wince-wm50 (new)
> SYSTEM_ID-> wince-500-ppc-arm
> 
>  
> Branch:
> HEAD
>  
> Files Attached:
> common_fileio.diff.txt
>  
> Thanks & Regards
> Anshuman
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

Ok - these look good for checkin.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: anshuman [mailto:asinghadroit-inc.com] 
> Sent: Friday, July 20, 2007 7:37 AM
> To: ehychereal.com; 'common-dev'
> Subject: Re: [Common-dev] CR: Changes in common/fileio
for 
> porting Atlas forWindows Mobile 5.0
> 
> Hi Eric,
>  
> I have added code in fcntl.h
(common/runtime/pub/hlxclib) 
> under the define WIN32_PLATFORM_PSPC, for changes like
>  
> #if !defined(O_RDONLY)
> #define O_RDONLY _O_RDONLY
> #endif
> 
> Also reverted back the changes from cwin32file.cpp
>  
> Please find the diff attached.
>  
> Till now cwin32file.cpp file is not used for win32
builds and 
> only for wince. The file name is confusing.
>  
> As for WIN32_PLATFORM_PSPC and WIN32_WCE , 
>  
> yes WIN32_PLATFORM_PSPC is defined for PocketPC. 
>  
> _WIN32_WCE - is defined for the CE version 
>  
> For Widnows Mobile 5.0 (for PPC),
> 
> WIN32_PLATFORM_PSPC=310 and _WIN32_WCE=500 
>  
> Thanks & Regards
> Anshuman
>  
> ----- Original Message ----- 
> From: "Eric Hyche" <ehychereal.com
<mailto:ehychereal.com> >
> To: "'anshuman'" <asinghadroit-inc.com 
> <mailto:asinghadroit-inc.com> >;
"'common-dev'" 
> <common-devhelixcommunity.org 
> <mailto:common-devhelixcommunity.org>
>
> Sent: Thursday, July 19, 2007 8:33 PM
> Subject: RE: [Common-dev] CR: Changes in common/fileio
for 
> porting Atlas forWindows Mobile 5.0
> 
> 
> > 
> > 
> > -    if (mode & O_RDONLY)
> > +    if (mode & _O_RDONLY)
> > 
> > So for all these changes, you are sure
> > both O_RDONLY and _O_RDONLY are defined
> > on all versions of Windows? Also, instead
> > of changing it every time it is used, you
> > might just do the following in some header file:
> > 
> > #if defined(_WINCE)
> > 
> > #if !defined(O_RDONLY)
> > #define O_RDONLY _O_RDONLY
> > #endif
> > 
> > #endif
> > 
> > Then you only have to change it once instead
> > of a bunch of places.
> > 
> > +#if !defined(WIN32_PLATFORM_PSPC) || (_WIN32_WCE
>= 211)
> > 
> > Can you refresh my memory on when
WIN32_PLATFORM_PSPC and
> > _WIN32_WCE are defined and what they are defined
as?
> > If I remember correctly, WIN32_PLATFORM_PSPC is
defined
> > when you building for PocketPC (as opposed to
Smartphone,
> > for which there is a different define).
> > 
> > Rest looks good.
> > 
> > Eric
> > 
> > =============================================
> > Eric Hyche (ehychereal.com
<mailto:ehychereal.com> )
> > Technical Lead
> > RealNetworks, Inc.  
> > 
> >> -----Original Message-----
> >> From: common-dev-bounceshelixcommunity.org 
> <mailto:common-dev-bounceshelixcommunity.org>  
> >> [mailto:common-dev-bounceshelixcommunity.org] On Behalf 
> Of anshuman
> >> Sent: Thursday, July 19, 2007 9:05 AM
> >> To: common-dev
> >> Subject: [Common-dev] CR: Changes in
common/fileio for 
> >> porting Atlas forWindows Mobile 5.0
> >> 
> >> Synopsis:
> >> Multiple changes for porting Atlas onto
Windows Mobile 5.0
> >> Overview:
> >> 1 In WINCE, we dont want to use _O_BINARY for
checking the 
> >> Read only, Write only or Read-Write mode
> >> 2. GetTempPath and SHGetSpecialFolderLocation 
is defined 
> >> from Windows CE 3.0 onwards so including that
> >>  
> >> Files Added:
> >> None
> >>  
> >> Files Modified:
> >> 
> >> common/fileio/platform/win/cwin32file.cpp
> >> 
> >> common/fileio/platform/win/filespecutils.cpp
> >>  
> >> Image Size and Heap Use impact (Client
-Only):
> >> None.
> >> 
> >> Platforms and Profiles Affected:
> >> Platform  : wince-500-ppc-arm
> >> Profile     : helix-client-wince-wm50 (NEW)
> >>  
> >> Distribution Libraries Affected:
> >> None
> >> 
> >> Distribution library impact and planned
action:
> >> None
> >> 
> >> Platforms and Profiles Build Verified:
> >> 
> >> BIF branch  -> helix_restricted
> >> Target(s)     -> wince_wm50_play (new)
> >> Profile         -> helix-client-wince-wm50
(new)
> >> SYSTEM_ID-> wince-500-ppc-arm
> >> 
> >>  
> >> Branch:
> >> HEAD
> >>  
> >> Files Attached:
> >> common_fileio.diff.txt
> >>  
> >> Thanks & Regards
> >> Anshuman
> >> 
> > 
> >
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

Thanks Eric,

Changes are checked into HEAD

Thanks & Regards
Anshuman

_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev