Re: CR: Fixing the build buster because of New interfaces

----- Original Message -----

From: real.com href="mailto:pingreal.com">Henry Ping

To: adroit-inc.com href="mailto:asinghadroit-inc.com">'anshuman' ; helixcommunity.org href="mailto:common-devhelixcommunity.org">'common-dev'

Sent: Thursday, October 04, 2007 5:32 AM

Subject: RE: [Common-dev] CR: Fixing the build buster because of New interfaces

Hi, Anshuman

 

I need to back out your changes since it breaks our internal build. You should *directly* add:

"

#include "ihxautoupgrademgr.h"

#include "ihxdownloadmgr.h"

"

to the file where hxpiids.h is included, normally the file that has "#define INITGUID 1"

 

We want to keep the IID definition in ONE header, instead of duplicating it at multiple headers(i.e. in hxpiids.h). We haven't followed this in the past, but moving forward, this is preferred strategy.

Henry

---

From: common-dev-bounceshelixcommunity.org [mailto:common-dev-bounceshelixcommunity.org] On Behalf Of anshuman
Sent: Monday, October 01, 2007 7:12 AM Ping
To: common-dev
Subject: [Common-dev] CR: Fixing the build buster because of New interfaces

Synopsis:
Multiple changes to fix the build buster.

 

Overview:

PPC Player gives linking errors because of 2 new interfaces IHXDownloadManager and IHXAutoUpgradeManager

This changes fixes the issue

 

Files Added:
none

 

Files Modified:

common/include/hxpiids.h

Image Size and Heap Use impact (Client -Only):
None.

Platforms and Profiles Affected:

platform : wince-500-ppc-arm

profile    : helix-client-wince-wm50

 

Distribution Libraries Affected:

None

Distribution library impact and planned action:
None

Platforms and Profiles Build Verified:

BIF branch   -> ;helix_restricted
Target(s)   ;   ->; wince_wm50_play

Profile        ;  -> helix-client-wince-wm50

System ID   -> wince-500-ppc-arm

 

Branch:
HEAD, hxclient_310_atlas

 

Files Attached

hxpiids_h.diff.txt

 

Thanks & Regards
Anshuman

Henry

---

From: anshuman [mailto:asinghadroit-inc.com]
Sent: Thursday, October 04, 2007 5:50 AM Ping
To: Henry Ping
Cc: common-dev
Subject: Re: [Common-dev] CR: Fixing the build buster because of New interfaces

Hi Henry,

 

The changes done in common/include/hxpiids.h are needed for static build and is now wrapped in a define to make it consistent with other definitions in the file. So it should not result in multiple definitions 

 

In client/medpltfm/dlliids.cpp we should include hxpiids.h after

 

#include "ihxautoupgrademgr.h"
#include "ihxdownloadmgr.h"

 

Files attached:

 

1. hxpiids_diff.txt

2. dlliids_diff.txt

 

 

Thanks & Regards
Anshuman

----- Original Message -----

From: real.com href="mailto:pingreal.com">Henry Ping

To: adroit-inc.com href="mailto:asinghadroit-inc.com">'anshuman' ; helixcommunity.org href="mailto:common-devhelixcommunity.org">'common-dev'

Sent: Thursday, October 04, 2007 5:32 AM

Subject: RE: [Common-dev] CR: Fixing the build buster because of New interfaces

Hi, Anshuman

 

I need to back out your changes since it breaks our internal build. You should *directly* add:

"

#include "ihxautoupgrademgr.h"

#include "ihxdownloadmgr.h"

"

to the file where hxpiids.h is included, normally the file that has "#define INITGUID 1"

 

We want to keep the IID definition in ONE header, instead of duplicating it at multiple headers(i.e. in hxpiids.h). We haven't followed this in the past, but moving forward, this is preferred strategy.

Henry

---

From: common-dev-bounceshelixcommunity.org [mailto:common-dev-bounceshelixcommunity.org] On Behalf Of anshuman
Sent: Monday, October 01, 2007 7:12 AM Ping
To: common-dev
Subject: [Common-dev] CR: Fixing the build buster because of New interfaces

Synopsis:
Multiple changes to fix the build buster.

 

Overview:

PPC Player gives linking errors because of 2 new interfaces IHXDownloadManager and IHXAutoUpgradeManager

This changes fixes the issue

 

Files Added:
none

 

Files Modified:

common/include/hxpiids.h

Image Size and Heap Use impact (Client -Only):
None.

Platforms and Profiles Affected:

platform : wince-500-ppc-arm

profile    : helix-client-wince-wm50

 

Distribution Libraries Affected:

None

Distribution library impact and planned action:
None

Platforms and Profiles Build Verified:

BIF branch   -> ;helix_restricted
Target(s)   ;   ->; wince_wm50_play

Profile        ;  -> helix-client-wince-wm50

System ID   -> wince-500-ppc-arm

 

Branch:
HEAD, hxclient_310_atlas

 

Files Attached

hxpiids_h.diff.txt

 

Thanks & Regards
Anshuman