List Info

Thread: Question about the recent changes for hlxosstr.cpp




Question about the recent changes for hlxosstr.cpp
user name
2008-01-15 11:34:30

Hi All

Recently I merged the hlxosstr from the Head to 210Cays. The reason for that is I need the new UTF conversions in the Head and after that the encstr.cpp has dependencies on this newly refactored hlxosstr. Now we have a problem caused by this merge - it breaks the wmrtsp-porting-kit by using the HLXOsStrW class. Also I found that this newly refactored hlxosstr is not in 310Atlas. Is that any reason for that?

If we use wcslen() on the string created by this new HLXOsStrW the length returned is different than the old implementation and it causes problem.

Thanks,
Gang

RE: Question about the recent changes for hlxosstr.cpp
country flaguser name
United States
2008-01-15 12:59:03


=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: common-dev-bounceshelixcommunity.org 
> [mailto:common-dev-bounceshelixcommunity.org] On
Behalf Of 
> Gang.Jianokia.com
> Sent: Tuesday, January 15, 2008 12:34 PM
> To: common-devhelixcommunity.org
> Subject: [Common-dev] Question about the recent changes
for 
> hlxosstr.cpp
> 
> Hi All 
> 
> Recently I merged the hlxosstr from the Head to
210Cays. The 
> reason for that is I need the new UTF conversions in
the Head 
> and after that the encstr.cpp has dependencies on this
newly 
> refactored hlxosstr. Now we have a problem caused by
this 
> merge - it breaks the wmrtsp-porting-kit by using the 
> HLXOsStrW class. Also I found that this newly
refactored 
> hlxosstr is not in 310Atlas. Is that any reason for
that?
> 

Not sure why 310Atlas is different, although I would think
it would fine to merge HEAD -> 310Atlas for hxosstr.cpp.

Eric
> If we use wcslen() on the string created by this new 
> HLXOsStrW the length returned is different than the old

> implementation and it causes problem.
> 
> Thanks, 
> Gang 
> 
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

RE: Question about the recent changes for hlxosstr.cpp
user name
2008-01-15 14:11:44
Hi Eric

Since this merge broke our WM-RTSP streaming and we have a
release today
I want to roll back these 2 files to their previous version.
I will send
a CR separately. Would you please help to approve it today?

Thanks,
Gang 

>-----Original Message-----
>From: ext Eric Hyche [mailto:ehychereal.com]

>Sent: Tuesday, January 15, 2008 12:59 PM
>To: Jia Gang (Nokia-D-MSW/Dallas); common-devhelixcommunity.org
>Subject: RE: [Common-dev] Question about the recent
changes 
>for hlxosstr.cpp
>
>
>
>
>=============================================
>Eric Hyche (ehychereal.com)
>Technical Lead
>RealNetworks, Inc.  
>
>> -----Original Message-----
>> From: common-dev-bounceshelixcommunity.org
>> [mailto:common-dev-bounceshelixcommunity.org] On
Behalf Of 
>> Gang.Jianokia.com
>> Sent: Tuesday, January 15, 2008 12:34 PM
>> To: common-devhelixcommunity.org
>> Subject: [Common-dev] Question about the recent
changes for 
>> hlxosstr.cpp
>> 
>> Hi All
>> 
>> Recently I merged the hlxosstr from the Head to
210Cays. The reason 
>> for that is I need the new UTF conversions in the
Head and 
>after that 
>> the encstr.cpp has dependencies on this newly
refactored 
>hlxosstr. Now 
>> we have a problem caused by this merge - it breaks
the 
>> wmrtsp-porting-kit by using the HLXOsStrW class.
Also I found that 
>> this newly refactored hlxosstr is not in 310Atlas.
Is that 
>any reason 
>> for that?
>> 
>
>Not sure why 310Atlas is different, although I would
think it 
>would fine to merge HEAD -> 310Atlas for
hxosstr.cpp.
>
>Eric
>> If we use wcslen() on the string created by this
new HLXOsStrW the 
>> length returned is different than the old
implementation and 
>it causes 
>> problem.
>> 
>> Thanks,
>> Gang
>> 
>> 
>
>

_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

RE: Question about the recent changes for hlxosstr.cpp
country flaguser name
United States
2008-01-15 14:17:39
Sure - send the CR's and I'll be looking for them.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Gang.Jianokia.com [mailto:Gang.Jianokia.com] 
> Sent: Tuesday, January 15, 2008 3:12 PM
> To: ehychereal.com; common-devhelixcommunity.org
> Subject: RE: [Common-dev] Question about the recent
changes 
> for hlxosstr.cpp
> 
> Hi Eric
> 
> Since this merge broke our WM-RTSP streaming and we
have a 
> release today
> I want to roll back these 2 files to their previous
version. 
> I will send
> a CR separately. Would you please help to approve it
today?
> 
> Thanks,
> Gang 
> 
> >-----Original Message-----
> >From: ext Eric Hyche [mailto:ehychereal.com]

> >Sent: Tuesday, January 15, 2008 12:59 PM
> >To: Jia Gang (Nokia-D-MSW/Dallas); common-devhelixcommunity.org
> >Subject: RE: [Common-dev] Question about the recent
changes 
> >for hlxosstr.cpp
> >
> >
> >
> >
> >=============================================
> >Eric Hyche (ehychereal.com)
> >Technical Lead
> >RealNetworks, Inc.  
> >
> >> -----Original Message-----
> >> From: common-dev-bounceshelixcommunity.org
> >> [mailto:common-dev-bounceshelixcommunity.org] On Behalf Of 
> >> Gang.Jianokia.com
> >> Sent: Tuesday, January 15, 2008 12:34 PM
> >> To: common-devhelixcommunity.org
> >> Subject: [Common-dev] Question about the
recent changes for 
> >> hlxosstr.cpp
> >> 
> >> Hi All
> >> 
> >> Recently I merged the hlxosstr from the Head
to 210Cays. 
> The reason 
> >> for that is I need the new UTF conversions in
the Head and 
> >after that 
> >> the encstr.cpp has dependencies on this newly
refactored 
> >hlxosstr. Now 
> >> we have a problem caused by this merge - it
breaks the 
> >> wmrtsp-porting-kit by using the HLXOsStrW
class. Also I found that 
> >> this newly refactored hlxosstr is not in
310Atlas. Is that 
> >any reason 
> >> for that?
> >> 
> >
> >Not sure why 310Atlas is different, although I
would think it 
> >would fine to merge HEAD -> 310Atlas for
hxosstr.cpp.
> >
> >Eric
> >> If we use wcslen() on the string created by
this new HLXOsStrW the 
> >> length returned is different than the old
implementation and 
> >it causes 
> >> problem.
> >> 
> >> Thanks,
> >> Gang
> >> 
> >> 
> >
> >
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

[1-4]

about | contact  Other archives ( Real Estate discussion Medical topics )