CR: Multiple changes in common/system for porting Atlas for BREW platform

Synopsis:
Multiple changes in common/system for porting Atlas for BREW
3.1.5 

Overview:
- Adding support for BREW for dll path.
- Fixing compilation errors. Using hxclib/.. include paths
- implemented HX_GET_DATETIME() for BREW
- Support for Time and other APIs

Files Added:
common/system/pub/platform/brew/brewasynctimer.h
common/system/platform/brew/brewasynctimer.cpp
common/system/platform/brew/brewtime.cpp
common/system/platform/brew/gettickcount.cpp
common/system/brew.pcf

Files Modified:
common/system/dllpath.cpp
common/system/hxdate.cpp
common/system/hxthread.cpp
common/system/pub/dllacces.h
common/system/pub/hxdate.h
common/system/pub/hxtick.h
common/system/pub/hxtime.h
common/system/pub/microsleep.h

Image Size and Heap Use impact (Client -Only):
None.

Platforms and Profiles Affected:
platform : brew-3.1.5-vc7-emulator (new SystemID)
profile    : helix-client-brewext-wins (new profile)

Distribution Libraries Affected:
None

Distribution library impact and planned action:
None

Platforms and Profiles Build Verified:

BIF branch   -> hxclient_3_1_0_atlas_restricted
Target(s)      -> client_brewext (new target)
Profile          -> helix-client-brewext-wins (new
profile)
System ID   -> brew-3.1.5-vc7-emulator (new SystemID)


Branch:
HEAD,  hxclient_3_1_0_atlas

Files Attached:
common_system.diff.txt

Thanks & Regards
Varun Kathuria
_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

My comments

1) brew.pcf

  
project.AddIncludes("pub/platform/brew",".\&
quot;)

   I don't think you need to add "." to the
include
   path - I think it's always there by default.

2) platform/brew/brewasynctimer.cpp

    m_pAEEcallback = new AEECallback;
	MEMSET(m_pAEEcallback, 0, sizeof(AEECallback));

   We should always check that the return value
   from memory allocations (new's or malloc's) are 
   non-NULL before using them.

   		m_pfExecFunc(NULL, 0, (UINT32) this,
HX_GET_TICKCOUNT());	

   Somewhere we should make sure m_fpExecFunc is non-NULL
   before calling it.

	m_pAEEcallback->pfnCancel(m_pAEEcallback);

   Check for non-NULL.

	HXBrewAsyncTimer* pTimer = (HXBrewAsyncTimer*) pData;
	// schedule again since helix timer is a recurring timer
	// while brew timer is one-shot
	// schedule it before calling the callback so that 
	// the next timer does not get delayed by the time spent in

	// the callback 
	pTimer->ScheduleAndExecuteTimer(TRUE);

   Check for non-NULL.

3) pub/platform/brew/brewasynctimer.h

    HXBrewAsyncTimer();
    HXBrewAsyncTimer( const HXBrewAsyncTimer& it );
    HXBrewAsyncTimer& operator=( const
HXBrewAsyncTimer& it );

   I see these functions listed in the header
   file but I don't see implementations of them. I
understand
   that they are made private so noone can call them
   externally, but we still need to have *some*
implementation
   *somewhere*.

Rest looks good.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: common-dev-bounceshelixcommunity.org 
> [mailto:common-dev-bounceshelixcommunity.org] On
Behalf Of 
> Varun Kathuria
> Sent: Wednesday, January 16, 2008 7:02 AM
> To: common-devhelixcommunity.org
> Subject: [Common-dev] CR: Multiple changes in
common/system 
> for portingAtlas for BREW platform
> 
> 
> Synopsis:
> Multiple changes in common/system for porting Atlas for
BREW 3.1.5 
> 
> Overview:
> - Adding support for BREW for dll path.
> - Fixing compilation errors. Using hxclib/.. include
paths
> - implemented HX_GET_DATETIME() for BREW
> - Support for Time and other APIs
> 
> Files Added:
> common/system/pub/platform/brew/brewasynctimer.h
> common/system/platform/brew/brewasynctimer.cpp
> common/system/platform/brew/brewtime.cpp
> common/system/platform/brew/gettickcount.cpp
> common/system/brew.pcf
> 
> Files Modified:
> common/system/dllpath.cpp
> common/system/hxdate.cpp
> common/system/hxthread.cpp
> common/system/pub/dllacces.h
> common/system/pub/hxdate.h
> common/system/pub/hxtick.h
> common/system/pub/hxtime.h
> common/system/pub/microsleep.h
> 
> Image Size and Heap Use impact (Client -Only):
> None.
> 
> Platforms and Profiles Affected:
> platform : brew-3.1.5-vc7-emulator (new SystemID)
> profile    : helix-client-brewext-wins (new profile)
> 
> Distribution Libraries Affected:
> None
> 
> Distribution library impact and planned action:
> None
> 
> Platforms and Profiles Build Verified:
> 
> BIF branch   -> hxclient_3_1_0_atlas_restricted
> Target(s)      -> client_brewext (new target)
> Profile          -> helix-client-brewext-wins (new
profile)
> System ID   -> brew-3.1.5-vc7-emulator (new
SystemID)
> 
> 
> Branch:
> HEAD,  hxclient_3_1_0_atlas
> 
> Files Attached:
> common_system.diff.txt
> 
> Thanks & Regards
> Varun Kathuria
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

> -----Original Message-----
> From: Varun Kathuria [mailto:vkathuriareal.com]

> Sent: Thursday, January 17, 2008 7:27 AM
> To: ehychereal.com; common-devhelixcommunity.org
> Subject: Re: [Common-dev] CR: Multiple changes in 
> common/system for portingAtlas for BREW platform
> 
> Reply inline.
> 
> ----- Original Message ----- 
> From: "Eric Hyche" <ehychereal.com>
> To: "'Varun Kathuria'" <vkathuriareal.com>; 
> <common-devhelixcommunity.org>
> Sent: Wednesday, January 16, 2008 7:58 PM
> Subject: RE: [Common-dev] CR: Multiple changes in 
> common/system for portingAtlas for BREW platform
> 
> 
> > 
> > My comments
> > 
> > 1) brew.pcf
> > 
> >  
project.AddIncludes("pub/platform/brew",".\&
quot;)
> > 
> >   I don't think you need to add "." to
the include
> >   path - I think it's always there by default.
> 
> RVCT compiler is not taking this by default.
> 

Then probably the best place to put

project.AddIncludes(".")

would be in the .cf file for brew. That way you
don't have to add it in multiple places.

Looks good for checkin.

Eric
> > 2) platform/brew/brewasynctimer.cpp
> > 
> >    m_pAEEcallback = new AEECallback;
> > MEMSET(m_pAEEcallback, 0, sizeof(AEECallback));
> > 
> >   We should always check that the return value
> >   from memory allocations (new's or malloc's) are

> >   non-NULL before using them.
> > 
> >   m_pfExecFunc(NULL, 0, (UINT32) this,
HX_GET_TICKCOUNT()); 
> > 
> >   Somewhere we should make sure m_fpExecFunc is
non-NULL
> >   before calling it.
> > 
> > m_pAEEcallback->pfnCancel(m_pAEEcallback);
> > 
> >   Check for non-NULL.
> > 
> > HXBrewAsyncTimer* pTimer = (HXBrewAsyncTimer*)
pData;
> > // schedule again since helix timer is a recurring
timer
> > // while brew timer is one-shot
> > // schedule it before calling the callback so that

> > // the next timer does not get delayed by the time
spent in 
> > // the callback 
> > pTimer->ScheduleAndExecuteTimer(TRUE);
> > 
> >   Check for non-NULL.
> > 
> > 3) pub/platform/brew/brewasynctimer.h
> > 
> >    HXBrewAsyncTimer();
> >    HXBrewAsyncTimer( const HXBrewAsyncTimer&
it );
> >    HXBrewAsyncTimer& operator=( const
HXBrewAsyncTimer& it );
> Removed the definition of these unused function.
> 
> >   I see these functions listed in the header
> >   file but I don't see implementations of them. I
understand
> >   that they are made private so noone can call
them
> >   externally, but we still need to have *some*
implementation
> >   *somewhere*.
> > 
> > Rest looks good.
> > 
> > Eric
> > 
> > =============================================
> > Eric Hyche (ehychereal.com)
> > Technical Lead
> > RealNetworks, Inc.  
> > 
> >> -----Original Message-----
> >> From: common-dev-bounceshelixcommunity.org 
> >> [mailto:common-dev-bounceshelixcommunity.org] On Behalf Of 
> >> Varun Kathuria
> >> Sent: Wednesday, January 16, 2008 7:02 AM
> >> To: common-devhelixcommunity.org
> >> Subject: [Common-dev] CR: Multiple changes in
common/system 
> >> for portingAtlas for BREW platform
> >> 
> >> 
> >> Synopsis:
> >> Multiple changes in common/system for porting
Atlas for BREW 3.1.5 
> >> 
> >> Overview:
> >> - Adding support for BREW for dll path.
> >> - Fixing compilation errors. Using hxclib/..
include paths
> >> - implemented HX_GET_DATETIME() for BREW
> >> - Support for Time and other APIs
> >> 
> >> Files Added:
> >>
common/system/pub/platform/brew/brewasynctimer.h
> >>
common/system/platform/brew/brewasynctimer.cpp
> >> common/system/platform/brew/brewtime.cpp
> >> common/system/platform/brew/gettickcount.cpp
> >> common/system/brew.pcf
> >> 
> >> Files Modified:
> >> common/system/dllpath.cpp
> >> common/system/hxdate.cpp
> >> common/system/hxthread.cpp
> >> common/system/pub/dllacces.h
> >> common/system/pub/hxdate.h
> >> common/system/pub/hxtick.h
> >> common/system/pub/hxtime.h
> >> common/system/pub/microsleep.h
> >> 
> >> Image Size and Heap Use impact (Client
-Only):
> >> None.
> >> 
> >> Platforms and Profiles Affected:
> >> platform : brew-3.1.5-vc7-emulator (new
SystemID)
> >> profile    : helix-client-brewext-wins (new
profile)
> >> 
> >> Distribution Libraries Affected:
> >> None
> >> 
> >> Distribution library impact and planned
action:
> >> None
> >> 
> >> Platforms and Profiles Build Verified:
> >> 
> >> BIF branch   ->
hxclient_3_1_0_atlas_restricted
> >> Target(s)      -> client_brewext (new
target)
> >> Profile          ->
helix-client-brewext-wins (new profile)
> >> System ID   -> brew-3.1.5-vc7-emulator (new
SystemID)
> >> 
> >> 
> >> Branch:
> >> HEAD,  hxclient_3_1_0_atlas
> >> 
> >> Files Attached:
> >> common_system.diff.txt
> >> 
> >> Thanks & Regards
> >> Varun Kathuria
> >> 
> >
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

Thanks Eric

This has been checked into hxclient_3_1_0_atlas, Head

Thanks & Regards
Varun Kathuria

----- Original Message ----- 
From: "Eric Hyche" <ehychereal.com>
To: "'Varun Kathuria'" <vkathuriareal.com>; <common-devhelixcommunity.org>
Sent: Thursday, January 17, 2008 6:40 PM
Subject: RE: [Common-dev] CR: Multiple changes in
common/system for 
portingAtlas for BREW platform


>
>> -----Original Message-----
>> From: Varun Kathuria [mailto:vkathuriareal.com]
>> Sent: Thursday, January 17, 2008 7:27 AM
>> To: ehychereal.com; common-devhelixcommunity.org
>> Subject: Re: [Common-dev] CR: Multiple changes in
>> common/system for portingAtlas for BREW platform
>>
>> Reply inline.
>>
>> ----- Original Message ----- 
>> From: "Eric Hyche" <ehychereal.com>
>> To: "'Varun Kathuria'" <vkathuriareal.com>;
>> <common-devhelixcommunity.org>
>> Sent: Wednesday, January 16, 2008 7:58 PM
>> Subject: RE: [Common-dev] CR: Multiple changes in
>> common/system for portingAtlas for BREW platform
>>
>>
>> >
>> > My comments
>> >
>> > 1) brew.pcf
>> >
>> >  
project.AddIncludes("pub/platform/brew",".\&
quot;)
>> >
>> >   I don't think you need to add "."
to the include
>> >   path - I think it's always there by
default.
>>
>> RVCT compiler is not taking this by default.
>>
>
> Then probably the best place to put
>
> project.AddIncludes(".")
>
> would be in the .cf file for brew. That way you
> don't have to add it in multiple places.
>
> Looks good for checkin.
>
> Eric
>> > 2) platform/brew/brewasynctimer.cpp
>> >
>> >    m_pAEEcallback = new AEECallback;
>> > MEMSET(m_pAEEcallback, 0,
sizeof(AEECallback));
>> >
>> >   We should always check that the return
value
>> >   from memory allocations (new's or malloc's)
are
>> >   non-NULL before using them.
>> >
>> >   m_pfExecFunc(NULL, 0, (UINT32) this,
HX_GET_TICKCOUNT());
>> >
>> >   Somewhere we should make sure m_fpExecFunc
is non-NULL
>> >   before calling it.
>> >
>> > m_pAEEcallback->pfnCancel(m_pAEEcallback);
>> >
>> >   Check for non-NULL.
>> >
>> > HXBrewAsyncTimer* pTimer = (HXBrewAsyncTimer*)
pData;
>> > // schedule again since helix timer is a
recurring timer
>> > // while brew timer is one-shot
>> > // schedule it before calling the callback so
that
>> > // the next timer does not get delayed by the
time spent in
>> > // the callback
>> > pTimer->ScheduleAndExecuteTimer(TRUE);
>> >
>> >   Check for non-NULL.
>> >
>> > 3) pub/platform/brew/brewasynctimer.h
>> >
>> >    HXBrewAsyncTimer();
>> >    HXBrewAsyncTimer( const
HXBrewAsyncTimer& it );
>> >    HXBrewAsyncTimer& operator=( const
HXBrewAsyncTimer& it );
>> Removed the definition of these unused function.
>>
>> >   I see these functions listed in the header
>> >   file but I don't see implementations of
them. I understand
>> >   that they are made private so noone can call
them
>> >   externally, but we still need to have *some*
implementation
>> >   *somewhere*.
>> >
>> > Rest looks good.
>> >
>> > Eric
>> >
>> > =============================================
>> > Eric Hyche (ehychereal.com)
>> > Technical Lead
>> > RealNetworks, Inc.
>> >
>> >> -----Original Message-----
>> >> From: common-dev-bounceshelixcommunity.org
>> >> [mailto:common-dev-bounceshelixcommunity.org] On Behalf Of
>> >> Varun Kathuria
>> >> Sent: Wednesday, January 16, 2008 7:02 AM
>> >> To: common-devhelixcommunity.org
>> >> Subject: [Common-dev] CR: Multiple changes
in common/system
>> >> for portingAtlas for BREW platform
>> >>
>> >>
>> >> Synopsis:
>> >> Multiple changes in common/system for
porting Atlas for BREW 3.1.5
>> >>
>> >> Overview:
>> >> - Adding support for BREW for dll path.
>> >> - Fixing compilation errors. Using
hxclib/.. include paths
>> >> - implemented HX_GET_DATETIME() for BREW
>> >> - Support for Time and other APIs
>> >>
>> >> Files Added:
>> >>
common/system/pub/platform/brew/brewasynctimer.h
>> >>
common/system/platform/brew/brewasynctimer.cpp
>> >> common/system/platform/brew/brewtime.cpp
>> >>
common/system/platform/brew/gettickcount.cpp
>> >> common/system/brew.pcf
>> >>
>> >> Files Modified:
>> >> common/system/dllpath.cpp
>> >> common/system/hxdate.cpp
>> >> common/system/hxthread.cpp
>> >> common/system/pub/dllacces.h
>> >> common/system/pub/hxdate.h
>> >> common/system/pub/hxtick.h
>> >> common/system/pub/hxtime.h
>> >> common/system/pub/microsleep.h
>> >>
>> >> Image Size and Heap Use impact (Client
-Only):
>> >> None.
>> >>
>> >> Platforms and Profiles Affected:
>> >> platform : brew-3.1.5-vc7-emulator (new
SystemID)
>> >> profile    : helix-client-brewext-wins
(new profile)
>> >>
>> >> Distribution Libraries Affected:
>> >> None
>> >>
>> >> Distribution library impact and planned
action:
>> >> None
>> >>
>> >> Platforms and Profiles Build Verified:
>> >>
>> >> BIF branch   ->
hxclient_3_1_0_atlas_restricted
>> >> Target(s)      -> client_brewext (new
target)
>> >> Profile          ->
helix-client-brewext-wins (new profile)
>> >> System ID   -> brew-3.1.5-vc7-emulator
(new SystemID)
>> >>
>> >>
>> >> Branch:
>> >> HEAD,  hxclient_3_1_0_atlas
>> >>
>> >> Files Attached:
>> >> common_system.diff.txt
>> >>
>> >> Thanks & Regards
>> >> Varun Kathuria
>> >>
>> >
>>
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev