CR: Multiple changes in common/util for porting Atlas for BREW platform

Synopsis:
Multiple changes in common/util for porting Atlas for BREW
3.1.5 

Overview:
- Changes related to OS chars
- Added Hxversion Info for BREW
- Added Prefs for Brew
- Other fixes

Files Added:
common/util/pub/platform/brew/brew_pref.h
common/util/platform/brew/brew_pref.cpp
common/util/brew.pcf


Files Modified:
common/util/chxuuid.cpp
common/util/cookhlpr.cpp
common/util/cookies.cpp
common/util/db_dict.cpp
common/util/hxescapeutil.cpp
common/util/hxsmutil.cpp
common/util/hxurl.cpp
common/util/hxurlutil.cpp
common/util/hxwinver.cpp
common/util/netbyte.cpp
common/util/pref.cpp
common/util/verutil.cpp
common/util/pub/hxwinver.h
common/util/pub/localrep.h
common/util/pub/property.h

Image Size and Heap Use impact (Client -Only):
None.

Platforms and Profiles Affected:
platform : brew-3.1.5-vc7-emulator (new SystemID)
profile    : helix-client-brewext-wins (new profile)

Distribution Libraries Affected:
None

Distribution library impact and planned action:
None

Platforms and Profiles Build Verified:

BIF branch   -> hxclient_3_1_0_atlas_restricted
Target(s)      -> client_brewext (new target)
Profile          -> helix-client-brewext-wins (new
profile)
System ID   -> brew-3.1.5-vc7-emulator (new SystemID)


Branch:
HEAD,  hxclient_3_1_0_atlas

Files Attached:
common_util.diff.txt

Thanks & Regards
Varun Kathuria
_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

My comments:

1) brew.pcf

   - Needs license headers

2) brew_pref.cpp

   This file just looks stubbed out, and not complete.
   Is this an oversight, or did you intend it to
   be this way? 

Rest looks good.

Eric 

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: common-dev-bounceshelixcommunity.org 
> [mailto:common-dev-bounceshelixcommunity.org] On
Behalf Of 
> Varun Kathuria
> Sent: Wednesday, January 16, 2008 7:29 AM
> To: common-devhelixcommunity.org
> Subject: [Common-dev] CR: Multiple changes in
common/util for 
> porting Atlasfor BREW platform
> 
> 
> Synopsis:
> Multiple changes in common/util for porting Atlas for
BREW 3.1.5 
> 
> Overview:
> - Changes related to OS chars
> - Added Hxversion Info for BREW
> - Added Prefs for Brew
> - Other fixes
> 
> Files Added:
> common/util/pub/platform/brew/brew_pref.h
> common/util/platform/brew/brew_pref.cpp
> common/util/brew.pcf
> 
> 
> Files Modified:
> common/util/chxuuid.cpp
> common/util/cookhlpr.cpp
> common/util/cookies.cpp
> common/util/db_dict.cpp
> common/util/hxescapeutil.cpp
> common/util/hxsmutil.cpp
> common/util/hxurl.cpp
> common/util/hxurlutil.cpp
> common/util/hxwinver.cpp
> common/util/netbyte.cpp
> common/util/pref.cpp
> common/util/verutil.cpp
> common/util/pub/hxwinver.h
> common/util/pub/localrep.h
> common/util/pub/property.h
> 
> Image Size and Heap Use impact (Client -Only):
> None.
> 
> Platforms and Profiles Affected:
> platform : brew-3.1.5-vc7-emulator (new SystemID)
> profile    : helix-client-brewext-wins (new profile)
> 
> Distribution Libraries Affected:
> None
> 
> Distribution library impact and planned action:
> None
> 
> Platforms and Profiles Build Verified:
> 
> BIF branch   -> hxclient_3_1_0_atlas_restricted
> Target(s)      -> client_brewext (new target)
> Profile          -> helix-client-brewext-wins (new
profile)
> System ID   -> brew-3.1.5-vc7-emulator (new
SystemID)
> 
> 
> Branch:
> HEAD,  hxclient_3_1_0_atlas
> 
> Files Attached:
> common_util.diff.txt
> 
> Thanks & Regards
> Varun Kathuria
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

Ok - looks good for checkin.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Varun Kathuria [mailto:vkathuriareal.com]

> Sent: Thursday, January 17, 2008 6:53 AM
> To: ehychereal.com; common-devhelixcommunity.org
> Subject: Re: [Common-dev] CR: Multiple changes in
common/util 
> for porting Atlasfor BREW platform
> 
> Reply Inline.
> ----- Original Message ----- 
> From: "Eric Hyche" <ehychereal.com
<mailto:ehychereal.com> >
> To: "'Varun Kathuria'" <vkathuriareal.com

> <mailto:vkathuriareal.com> >;
<common-devhelixcommunity.org 
> <mailto:common-devhelixcommunity.org>
>
> Sent: Wednesday, January 16, 2008 8:08 PM
> Subject: RE: [Common-dev] CR: Multiple changes in
common/util 
> for porting Atlasfor BREW platform
> 
> 
> > 
> > My comments:
> > 
> > 1) brew.pcf
> > 
> >   - Needs license headers
>  Added license header
> 
> > 2) brew_pref.cpp
> > 
> >   This file just looks stubbed out, and not
complete.
> >   Is this an oversight, or did you intend it to
> >   be this way? 
> We are not using preferences at present, thats why a
dummy 
> preference is added.
> 
> > Rest looks good.
> > 
> > Eric 
> > 
> > =============================================
> > Eric Hyche (ehychereal.com
<mailto:ehychereal.com> )
> > Technical Lead
> > RealNetworks, Inc.  
> > 
> >> -----Original Message-----
> >> From: common-dev-bounceshelixcommunity.org 
> <mailto:common-dev-bounceshelixcommunity.org>  
> >> [mailto:common-dev-bounceshelixcommunity.org] On Behalf Of 
> >> Varun Kathuria
> >> Sent: Wednesday, January 16, 2008 7:29 AM
> >> To: common-devhelixcommunity.org 
> <mailto:common-devhelixcommunity.org> 
> >> Subject: [Common-dev] CR: Multiple changes in
common/util for 
> >> porting Atlasfor BREW platform
> >> 
> >> 
> >> Synopsis:
> >> Multiple changes in common/util for porting
Atlas for BREW 3.1.5 
> >> 
> >> Overview:
> >> - Changes related to OS chars
> >> - Added Hxversion Info for BREW
> >> - Added Prefs for Brew
> >> - Other fixes
> >> 
> >> Files Added:
> >> common/util/pub/platform/brew/brew_pref.h
> >> common/util/platform/brew/brew_pref.cpp
> >> common/util/brew.pcf
> >> 
> >> 
> >> Files Modified:
> >> common/util/chxuuid.cpp
> >> common/util/cookhlpr.cpp
> >> common/util/cookies.cpp
> >> common/util/db_dict.cpp
> >> common/util/hxescapeutil.cpp
> >> common/util/hxsmutil.cpp
> >> common/util/hxurl.cpp
> >> common/util/hxurlutil.cpp
> >> common/util/hxwinver.cpp
> >> common/util/netbyte.cpp
> >> common/util/pref.cpp
> >> common/util/verutil.cpp
> >> common/util/pub/hxwinver.h
> >> common/util/pub/localrep.h
> >> common/util/pub/property.h
> >> 
> >> Image Size and Heap Use impact (Client
-Only):
> >> None.
> >> 
> >> Platforms and Profiles Affected:
> >> platform : brew-3.1.5-vc7-emulator (new
SystemID)
> >> profile    : helix-client-brewext-wins (new
profile)
> >> 
> >> Distribution Libraries Affected:
> >> None
> >> 
> >> Distribution library impact and planned
action:
> >> None
> >> 
> >> Platforms and Profiles Build Verified:
> >> 
> >> BIF branch   ->
hxclient_3_1_0_atlas_restricted
> >> Target(s)      -> client_brewext (new
target)
> >> Profile          ->
helix-client-brewext-wins (new profile)
> >> System ID   -> brew-3.1.5-vc7-emulator (new
SystemID)
> >> 
> >> 
> >> Branch:
> >> HEAD,  hxclient_3_1_0_atlas
> >> 
> >> Files Attached:
> >> common_util.diff.txt
> >> 
> >> Thanks & Regards
> >> Varun Kathuria
> >> 
> >
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev

Thanks Eric

This has been checked into hxclient_3_1_0_atlas, Head

Thanks & Regards
Varun Kathuria

----- Original Message ----- 
From: "Eric Hyche" <ehychereal.com>
To: "'Varun Kathuria'" <vkathuriareal.com>; <common-devhelixcommunity.org>
Sent: Thursday, January 17, 2008 6:38 PM
Subject: RE: [Common-dev] CR: Multiple changes in
common/util for porting 
Atlasfor BREW platform


>
> Ok - looks good for checkin.
>
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.
>
>> -----Original Message-----
>> From: Varun Kathuria [mailto:vkathuriareal.com]
>> Sent: Thursday, January 17, 2008 6:53 AM
>> To: ehychereal.com; common-devhelixcommunity.org
>> Subject: Re: [Common-dev] CR: Multiple changes in
common/util
>> for porting Atlasfor BREW platform
>>
>> Reply Inline.
>> ----- Original Message ----- 
>> From: "Eric Hyche" <ehychereal.com
<mailto:ehychereal.com> >
>> To: "'Varun Kathuria'" <vkathuriareal.com
>> <mailto:vkathuriareal.com> >;
<common-devhelixcommunity.org
>> <mailto:common-devhelixcommunity.org>
>
>> Sent: Wednesday, January 16, 2008 8:08 PM
>> Subject: RE: [Common-dev] CR: Multiple changes in
common/util
>> for porting Atlasfor BREW platform
>>
>>
>> >
>> > My comments:
>> >
>> > 1) brew.pcf
>> >
>> >   - Needs license headers
>>  Added license header
>>
>> > 2) brew_pref.cpp
>> >
>> >   This file just looks stubbed out, and not
complete.
>> >   Is this an oversight, or did you intend it
to
>> >   be this way?
>> We are not using preferences at present, thats why
a dummy
>> preference is added.
>>
>> > Rest looks good.
>> >
>> > Eric
>> >
>> > =============================================
>> > Eric Hyche (ehychereal.com
<mailto:ehychereal.com> )
>> > Technical Lead
>> > RealNetworks, Inc.
>> >
>> >> -----Original Message-----
>> >> From: common-dev-bounceshelixcommunity.org
>> <mailto:common-dev-bounceshelixcommunity.org>
>> >> [mailto:common-dev-bounceshelixcommunity.org] On Behalf Of
>> >> Varun Kathuria
>> >> Sent: Wednesday, January 16, 2008 7:29 AM
>> >> To: common-devhelixcommunity.org
>> <mailto:common-devhelixcommunity.org>
>> >> Subject: [Common-dev] CR: Multiple changes
in common/util for
>> >> porting Atlasfor BREW platform
>> >>
>> >>
>> >> Synopsis:
>> >> Multiple changes in common/util for
porting Atlas for BREW 3.1.5
>> >>
>> >> Overview:
>> >> - Changes related to OS chars
>> >> - Added Hxversion Info for BREW
>> >> - Added Prefs for Brew
>> >> - Other fixes
>> >>
>> >> Files Added:
>> >> common/util/pub/platform/brew/brew_pref.h
>> >> common/util/platform/brew/brew_pref.cpp
>> >> common/util/brew.pcf
>> >>
>> >>
>> >> Files Modified:
>> >> common/util/chxuuid.cpp
>> >> common/util/cookhlpr.cpp
>> >> common/util/cookies.cpp
>> >> common/util/db_dict.cpp
>> >> common/util/hxescapeutil.cpp
>> >> common/util/hxsmutil.cpp
>> >> common/util/hxurl.cpp
>> >> common/util/hxurlutil.cpp
>> >> common/util/hxwinver.cpp
>> >> common/util/netbyte.cpp
>> >> common/util/pref.cpp
>> >> common/util/verutil.cpp
>> >> common/util/pub/hxwinver.h
>> >> common/util/pub/localrep.h
>> >> common/util/pub/property.h
>> >>
>> >> Image Size and Heap Use impact (Client
-Only):
>> >> None.
>> >>
>> >> Platforms and Profiles Affected:
>> >> platform : brew-3.1.5-vc7-emulator (new
SystemID)
>> >> profile    : helix-client-brewext-wins
(new profile)
>> >>
>> >> Distribution Libraries Affected:
>> >> None
>> >>
>> >> Distribution library impact and planned
action:
>> >> None
>> >>
>> >> Platforms and Profiles Build Verified:
>> >>
>> >> BIF branch   ->
hxclient_3_1_0_atlas_restricted
>> >> Target(s)      -> client_brewext (new
target)
>> >> Profile          ->
helix-client-brewext-wins (new profile)
>> >> System ID   -> brew-3.1.5-vc7-emulator
(new SystemID)
>> >>
>> >>
>> >> Branch:
>> >> HEAD,  hxclient_3_1_0_atlas
>> >>
>> >> Files Attached:
>> >> common_util.diff.txt
>> >>
>> >> Thanks & Regards
>> >> Varun Kathuria
>> >>
>> >
>>
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev