RE: CR: Mp3 support for helix

Ok - sounds good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Praveen.Thimmashettynokia.com 
> [mailto:Praveen.Thimmashettynokia.com] 
> Sent: Monday, February 04, 2008 3:13 PM
> To: ehychereal.com; datatype-devhelixcommunity.org; 
> common-devhelixcommunity.org
> Subject: RE: [Common-dev] CR: Mp3 support for helix
> 
> Hi Eric,
> 
> Even while HELIX_FEATURE_STATS flag is not defined, we
need to access
> registry.
> Hence making sure registry flag is around before
touching registry.
> 
> Whenever HELIX_FEATURE_STATS flag is defined, then
registry entry for
> title and author field is created by the hxplayer
itself and 
> file format
> can use that entry. If HELIX_FEATURE_STATS flag is not

> defined, then we
> need to create title and author field in registry from
the 
> file format.
>  
> Thanks
> Praveen
> 
> -----Original Message-----
> From: ext Eric Hyche [mailto:ehychereal.com]

> Sent: Monday, February 04, 2008 1:17 PM
> To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
> datatype-devhelixcommunity.org; common-devhelixcommunity.org
> Subject: RE: [Common-dev] CR: Mp3 support for helix
> 
> 
> My comments:
> 
>  -489,6 +489,7 
>      if (pPlayer)
>      {
>  #if defined(HELIX_FEATURE_REGISTRY)
> +#if defined(HELIX_FEATURE_STATS)
>          // Get the player's registry
> 
> Why do we need both REGISTRY and STATS here?
> 
>  -2188,9 +2232,12 
>              return NULL;
>  
>          m_bMetaPacket = 1;
> +        if (!(m_bStreaming && !m_bRtp))
> +        {
>          nSyncSize += m_ulMetaLength;
>          lScan = 0;
>      }
> +    }
> 
> Why is this change needed?
> 
> Rest looks good.
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: common-dev-bounceshelixcommunity.org
> > [mailto:common-dev-bounceshelixcommunity.org] On
Behalf Of 
> > Praveen.Thimmashettynokia.com
> > Sent: Sunday, February 03, 2008 6:58 PM
> > To: datatype-devhelixcommunity.org;
common-devhelixcommunity.org
> > Subject: [Common-dev] CR: Mp3 support for helix
> > 
> > "Nokia submits this code under the terms of a
commercial 
> contribution 
> > agreement with RealNetworks, and I am authorized
to contribute this 
> > code under said agreement."
> > 
> > 	Modified by:  Praveen.Thimmashettynokia.com
> > 
> > 	Reviewed by: 
> > 
> > 	Date: 03-February-2008
> > 
> > 	Project: SymbianMmf
> > 
> >       ErrorId: SUB 409-795
> > 
> > 	            
> > 	Synopsis:  CR: Mp3 support for helix 
> > 	                        Added Support for MP3 in
helix as a part
> of 
> > ARMA.dll. Ported mp3 file format and id3lib to
symbian. Mp3 file 
> > format will add two entry into registry to handle
metadata 
> in case of 
> > shoutcast. Whenever there is a new metadata over
shoutcast 
> stream, mp3
> 
> > file format will update the registry entry with
new metadata.
> > 
> > 	                
> > 
> > 	Root Cause of the problem: New Feature
> > 	  
> > 	Files Modified: 
> > 	datatypemp3fileformatmp3ff.cpp
> > 
> > 
> > 	datatypemp3importid3libid3_field.h 
> > 	datatypemp3importid3libid3_field_binary.cpp 
> >
	datatypemp3importid3libid3_field_string_unicode.cpp 
> > 	datatypemp3importid3libid3_frame_render.cpp 
> > 	datatypemp3importid3libid3_header.cpp 
> > 	datatypemp3importid3libid3_header_frame.cpp 
> > 	datatypemp3importid3libid3_header_tag.cpp 
> > 	datatypemp3importid3libid3_int28.h 
> > 	datatypemp3importid3libid3_misc_support.h 
> > 	datatypemp3importid3libid3_tag.h 
> > 	datatypemp3importid3libid3_tag_file.cpp 
> > 	datatypemp3importid3libid3_tag_parse.cpp 
> >
	datatypemp3importid3libid3_tag_parse_lyrics3.cpp 
> > 	datatypemp3importid3libid3_tag_parse_v1.cpp 
> > 	datatypemp3importid3libid3_tag_render.cpp 
> > 	datatypemp3importid3libid3_types.h
> > 
> > 	
datatypemp4audiomdfplatformsymbianaudioconfigs.cpp 
> > 	
datatypemp4audiomdfpubplatformsymbianaudioconfigs.h 
> > 	 datatypemp4audiorenderermdfswdecinfo.cpp 
> > 	 datatypemp4audiorenderermdfswdecinfo.h 
> > 	 datatypemp4audiorenderermp3decinfo.h
> > 	  
> > 	 commonruntimepubhlxclibwchar.h
> > 
> > 
> > 	New files added: None
> > 
> > 
> > 	Image Size and Heap Use impact: no major impact
(added
> > mp3fformat.dll(37k) )
> > 
> > 	Module Release testing (STIF) :  Passed. 
> > 
> > 	Test case(s) Added  :  No. 
> > 
> > 	Memory leak check performed : Yes.  No new leaks
introduced. 
> > 
> > 	Platforms and Profiles Build Verified: 
> > helix-client-s60-32-mmf-mdf-arm
> > 
> > 	Platforms and Profiles Functionality verified:
armv5,winscw
> > 
> >       Branch: Head & 210CayS
> > <<diff.txt>>
<<source_datatype.zip>>
> > 
> > 
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev