RE: CR: Multiple changes in common/fileio forporting Atlas on BREW 3.1.5

This looks good to me.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Varun Kathuria [mailto:vkathuriareal.com]

> Sent: Tuesday, February 12, 2008 7:13 AM
> To: ehychereal.com; common-devhelixcommunity.org
> Subject: Re: [Common-dev] [RESEND] CR: Multiple changes
in 
> common/fileio forporting Atlas on BREW 3.1.5 
> 
> Hi Eric,
> The common/fileio changes has already been checked in.
> I have made some changes in common/fileio as per your
suggestions.
> 
> 1) In CBrewIHXDataFile, all the class members are
initialized in the 
> constructor.
> 2) CHXPathParser and CHXFileSpecifier for brew are same
as other 
> platforms.So we have used windows filespec.cpp file.
> 
> Attached is the diff where you can review these
changes.
> I will be checking in these modifications after your
review.
> 
> Thanks & Regards
> Varun Kathuria
> 
> ----- Original Message ----- 
> From: "Eric Hyche" <ehychereal.com>
> To: "'Varun Kathuria'" <vkathuriareal.com>; 
> <common-devhelixcommunity.org>
> Sent: Friday, February 08, 2008 8:13 PM
> Subject: RE: [Common-dev] [RESEND] CR: Multiple changes
in 
> common/fileio 
> forporting Atlas on BREW 3.1.5
> 
> 
> >
> > My comments:
> >
> > 1) IN CBrewIHXDataFile, all the class members
should
> >   be initialized in the constructor. For
instance,
> >   if the class was created and then immediately
destructed,
> >   then m_pIfileMgr would likely crash, since it
gets
> >   released in the destructor but is never
initialized
> >   in the constructor.
> >
> > 2) CHXPathParser and CHXFileSpecifier look like
pretty
> >   cross-platform code. What is Brew-specific about
them?
> >
> > Rest looks good.
> >
> > =============================================
> > Eric Hyche (ehychereal.com)
> > Technical Lead
> > RealNetworks, Inc.
> >
> >> -----Original Message-----
> >> From: common-dev-bounceshelixcommunity.org
> >> [mailto:common-dev-bounceshelixcommunity.org] On Behalf Of
> >> Varun Kathuria
> >> Sent: Wednesday, January 30, 2008 4:05 AM
> >> To: common-devhelixcommunity.org
> >> Subject: [Common-dev] [RESEND] CR: Multiple
changes in
> >> common/fileio forporting Atlas on BREW 3.1.5
> >>
> >>
> >> Synopsis:
> >> Multiple changes for porting Atlas for BREW
3.1.5
> >>
> >> Overview:
> >> - Adding support for BREW.
> >> - Fixing compilation errors. Using hlxclib/..
include paths
> >> - Added file related functions.
> >>
> >> Files Added:
> >> commonfileiopubplatformbrewhxdir.h
> >>
commonfileiopubplatformbrewfilespecbrew.h
> >> commonfileiopubplatformbrewcbrewf.h
> >>
commonfileiopubplatformbrewbrewihxdataf.h
> >> commonfileioplatformbrewhxdir.cpp
> >> commonfileioplatformbrewfilespecutils.cpp
> >> commonfileioplatformbrewfilespec.cpp
> >> commonfileioplatformbrewcbrewf.cpp
> >> commonfileioplatformbrewbrewihxdataf.cpp
> >> brew.pcf
> >>
> >> Files Modified:
> >> common/fileio/Umakefil
> >> common/fileio/chunkres.cpp
> >> common/fileio/chxdfmem.cpp
> >> common/fileio/datffact.cpp
> >> common/fileio/findfile.cpp
> >> common/fileio/fsio.cpp
> >> common/fileio/hxxfile.cpp
> >> common/fileio/pub/filespec.h
> >> common/fileio/pub/hxdir.h
> >>
> >> Image Size and Heap Use impact (Client
-Only):
> >> None.
> >>
> >> Platforms and Profiles Affected:
> >> platform : brew-3.1.5-vc7-emulator (new
SystemID)
> >> profile    : helix-client-brewext-wins (new
profile)
> >>
> >> Distribution Libraries Affected:
> >> None
> >>
> >> Distribution library impact and planned
action:
> >> None
> >>
> >> Platforms and Profiles Build Verified:
> >>
> >> BIF branch ->
hxclient_3_1_0_atlas_restricted
> >> Target(s)    -> client_brewext (new
target)
> >> Profile        -> helix-client-brewext-wins
(new profile)
> >> System ID  -> brew-3.1.5-vc7-emulator (new
SystemID)
> >>
> >> Branch:
> >> HEAD,  hxclient_3_1_0_atlas
> >>
> >> Files Attached:
> >> common_fileio.diff.txt
> >> hxdir.h
> >> filespecbrew.h
> >> cbrewf.h
> >> brewihxdataf.h
> >> hxdir.cpp
> >> filespecutils.cpp
> >> filespec.cpp
> >> cbrewf.cpp
> >> brewihxdataf.cpp
> >> brew.pcf
> >>
> >> Thanks & Regards
> >> Varun Kathuria
> >>
> >>
> >>
> >>
> > 
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev