RE: CR: Change system time has impact on Helix playback onSymbian

Gang,

Change looks good, but instead of blowing away the
gettimeofday() implementation, I think I would make
it compile-time or run-time switchable.

The reason is that this HXScheduler and GetTickCount()
changes will affect a LOT of places in Helix as a whole.
If bugs pop up that may be timing-related, then it would
be good to easily be able to revert back to gettimeofday()
and make sure the new GetTickCount() implementation is
not the cause.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: common-dev-bounceshelixcommunity.org 
> [mailto:common-dev-bounceshelixcommunity.org] On
Behalf Of 
> Gang.Jianokia.com
> Sent: Wednesday, March 26, 2008 10:53 AM
> To: common-devhelixcommunity.org
> Cc: nokia-private-devhelixcommunity.org
> Subject: [Common-dev] CR: Change system time has impact
on 
> Helix playback onSymbian
> 
> "Nokia submits this code under the terms of a
commercial 
> contribution agreement with RealNetworks, 
> and I am authorized to contribute this code under said
agreement." 
> 
> Modified by:  Gang.Jianokia.com 
> 
> Reviewed by: 
> 
> Date: 3/25/2007 
> 
> Project: SymbianMmf_rel 
> 
> ErrorId:  ECZU-7AJDAB 
> 
> Synopsis: CR: Change system time has impact on Helix
playback 
> on Symbian 
> 
> Overview: On Symbian platform the GetTickCount() uses 
> gettimeofday() to get the tick count. That 
> introduces the impact of the system clock and system
clock 
> time can be changed in cases like 
> daylight saving time change. The solution is to use a
real 
> tick counter in Symbian - 
> User::NTickCount(). Normally it will give 1ms time
resolution 
> on hardware and 5ms on the emulator. 
> 
> 
> Root Cause of the problem:  Implementation. 
> 
> Files Added:   None. 
> 
> Files Modified: 
> /build/umakecf/symbian.cf 
> /client/common/system/hxsched.cpp 
> /common/system/platform/symbian/gettickcount.c 
> 
> Image Size and Heap Use impact: no major impact 
> 
> Module Release testing (STIF) :  Passed. 
> 
> Test case(s) Added  :  N/A. 
> 
> Memory leak check performed : Yes. No new leaks
introduced 
> 
> Platforms and Profiles Build Verified: 
> helix-client-s60-50-mmf-mdf-arm 
> 
> Platforms and Profiles Functionality verified: armv5
& winscw 
> 
> Branch: 210CayS & Head 
> 
> <<diff.txt>> 
> 
> 


_______________________________________________
Common-dev mailing list
Common-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/comm
on-dev