CN-Client: Cookie Improvement

 

Couple improvement in Helix DNA Client cookies support:

 

1. Allow the caller to select which browsers’ cookie we will use by setting a new preference: “ExternalCookies”. The preference of browsers are set using bitmask. This is necessary so that when Helix DNA Client is run inside Firefox, we won’t send cookies from IE’s.

 

If this new preference is not set, then we will keep the current behavior which use all available browsers installed on user’;s box. For example, we load both FF and IE cookies DB if both are installed on user’s box.

 

Also re-organized the PrepareCookiesPath(), instead of a gigantic function which prepares the cookies for all types of browsers, it’s broken down to sub-routines based on the browser types:

 

+    HX_RESULT       _prepareRMCookies(void);

+    HX_RESULT      ; _prepareIECookies(void);

+    HX_RESULT      ; _prepareNSCookies(void);

+    HX_RESULT      ; _prepareFFCookies(void);

+    HX_RESULT      ; _prepareSFCookies(void);

 

2. Added logic to detect whether cookies is disabled in FF. If it’s disabled, then we won’t use it. Prior to this, we always load FF’s cookie DB even though it can be disabled by the user in FF.

 

For IE, we’re using system APIs to read cookies from the browser so the API will fail if user disables the cookies inside IE.

 

For Safari, it’s not implemented but will use webkit APIs. A separate work item is scheduled for this.

 

For Netscape, it’s not implemented and probably won’t be since the Netscape browsers’ install base is negligible.

 

Diffs:

Attached

 

Branches:

HEAD & Atlas310

 

Henry