Eric Hyche wrote:
> Richard,
>
> Officially, we don't support VC6 on the HEAD anymore.
> However, it does look like that "goto exit"
is causing
> problems for VC6. Can you try VC7 and see if it has
> the same problems with it? I don't think it does,
> since I believe our nightly VC7 builds have been
> succeeding.
We should never skip variable decls with goto's. I have
to fix those all the time for our other compilers. I will
go ahead and check in this fix here:
Index: shim_net_services.cpp
============================================================
=======
RCS file:
/cvsroot/client/common/netio/shim_net_services.cpp,v
retrieving revision 1.10
diff -u -w -r1.10 shim_net_services.cpp
--- shim_net_services.cpp 20 Apr 2006 23:49:11 -0000
1.10
+++ shim_net_services.cpp 5 Jul 2006 18:40:08 -0000
 -86,6
+86,7
{
HX_RESULT hr = HXR_OK;
HXNetworkServices* pOldNetServices = NULL;
+ IHXPreferences* pPrefs = NULL;
HX_ASSERT(pIContext);
if (!pIContext)
-121,7
+122,6
}
// Get the IHXPreferences interface
- IHXPreferences* pPrefs = NULL;
m_punkContext->QueryInterface(IID_IHXPreferences,
(void**) &pPrefs);
HX_ASSERT(pPrefs);
if (pPrefs)
--greg.
>
> Eric
>
>> -----Original Message-----
>> From: datatype-dev-bounceshelixcommunity.org
>> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of
>> Richard Poirier
>> Sent: Tuesday, July 04, 2006 4:43 PM
>> To: datatype-devhelixcommunity.org
>> Subject: RE: [datatype-dev] Checking-in AMR-WB+ in
Helix
>>
>>
>> I checked out a fresh copy of the head branch and
I'm trying to build
>> with the following settings:
>>
>> SYSTEM_ID=win32-i386-vc6
>>
>> Build System Menu
>> Ribosome v2.4
>> -> Current Directory: c:\_Helix\source\head
>> [0] Set BIF branch (helix)
>> [1] Set Target(s) (splay)
>> [2] Set Profile
>>
(C:/_Helix/source/build\umakepf\helix-client-all-defines)
>> [3] run: build
>> [4] Toggle make depend & makefiles (-e -n)
>> [5] Toggle release (-trelease)
>> [6] Toggle 'make clean' (-c)
>> [7] Toggle clobber (Dangerous!) (-C)
>> [8] Toggle halt-on-error (-p green)
>> [9] Toggle verbose mode (-v)
>> [10] Toggle static build (-tnodll)
>> [11] Checkout source for selected target now
>> [12] Set Tag/Branch/Timestamp
>> [13] Help Page (full help in build/doc/index.html)
>> [14] run history: build
>> [Q] Quit
>>
>> When I build I get the following 5 failures. 3 of
them seem to be
>> related to
..\..\client\common\netio\dbg32\netioclntlib.lib.
>> Here are a
>> few snippets of build.out:
>>
>> ####### FAILURE #1 ########
>> shim_net_services.cpp(164) : error C2362:
initialization of
>> 'pPrefs' is
>> skipped by 'goto exit'
>> shim_net_services.cpp(124) : see
declaration of 'pPrefs'
>> NMAKE : fatal error U1077: 'cl' : return code
'0x2'
>> Stop.
>> Time used: 2.67 seconds
>> ERROR: WinCompile(client/common/netio) ERROR: Make
failed.
>>
>> --- Build System Error
------------------------------------
>> Make failed.
>>
>> ####### FAILURE #2 ########
>> WinCompile(protocol/rtsp): making copy
>> nmake /nologo copy
>> nmake SUBMAKEFLAGS="" -nologo -f
rtsplib.mak copy
>> nmake SUBMAKEFLAGS="" -nologo -f
rtspclntdll.mak copy
>> NMAKE : fatal error U1073: don't know how to make
>>
'..\..\client\common\netio\dbg32\netioclntlib.lib'
>> Stop.
>> NMAKE : fatal error U1077: '"c:\Program
Files\Microsoft Visual
>> Studio\VC98\bin\NMAKE.EXE"' : return code
'0x2'
>> Stop.
>> Time used: 0.31 seconds
>> ERROR: WinCompile(protocol/rtsp) ERROR: Make
failed.
>>
>> --- Build System Error
------------------------------------
>> Make failed.
>>
-----------------------------------------------------------
>>
>> ####### FAILURE #3 ########
>> See attached .txt file.
>>
>> Are my profile, target and system ID correct for
this branch?
>>
>> Any insight is appreciated. Thank you.
>>
>> Richard
>>
>>
>> -----Original Message-----
>> From: Eric Hyche [mailto:ehychereal.com]
>> Sent: 20 juin 2006 09:36
>> To: Richard Poirier; datatype-devhelixcommunity.org
>> Subject: RE: [datatype-dev] Checking-in AMR-WB+ in
Helix
>>
>>
>> Richard,
>>
>> See my replies inline below...
>>
>>> -----Original Message-----
>>> From: datatype-dev-bounceshelixcommunity.org
>>> [mailto:datatype-dev-bounceshelixcommunity.org] On Behalf Of
>>> Richard Poirier
>>> Sent: Tuesday, June 20, 2006 7:45 AM
>>> To: datatype-devhelixcommunity.org
>>> Subject: [datatype-dev] Checking-in AMR-WB+ in
Helix
>>>
>>>
>>> We have added the AMR-WB+ codec support in
datatype for the
>> client and
>>> for the server and would like to check in the
code back in the CVS
>>> repository.
>>>
>>> The client had been worked on using the cayenne
1.5.0 branch
>>> with VC6.0
>>> whereas the current (head) branch with VC7.0
was used for
>> the server.
>>> Our intention is to follow these steps:
>>>
>>> 1 - Sync-up with the head branch on our server
development station.
>>>
>>> 2 - Merge the client modifications such that we
end up with a set of
>>> code from head that supports both the client
and server.
>>>
>>> 3 - Follow the steps on that url to check-in
head.
>>> https:/
/common.helixcommunity.org/2005/patch/
>>>
>>>
>>> Question: Is there any benefit to:
>>>
>>> - Sync-up with the cayenne 1.5.0 branch on our
client dev station?
>>>
>>> - Check-in cayenne 1.5.0 branch?
>>>
>> It's not clear that we would necessarily need this
on the
>> hxclient_1_5_0_cayenne branch at this time. So in
my opinion,
>> there's no need to worry about syncing up with
that branch.
>> I think the steps you list above are sufficient.
>>
>> Eric
>>
>>
>>> Thanks,
>>>
>>> Richard
>>>
>>> VoiceAge Corporation
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Datatype-dev mailing list
>>> Datatype-devhelixcommunity.org
>>> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
>>>
>>
>
>
> _______________________________________________
> Datatype-dev mailing list
> Datatype-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
>
_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
|