These changes look good to me.
Eric
==============================================
Eric Hyche (ehyche real.com)
Technical Lead
Embedded Player and Technologies
RealNetworks, Inc.
> -----Original Message-----
> From: john.wei nokia.com [mailto:john.wei nokia.com]
> Sent: Wednesday, July 05, 2006 6:21 PM
> To: datatype-dev helixcommunity.org
> Cc: gwright real.com; ehyche real.com
> Subject: CR: MDF Video Renderer - Delay Depacktizing
Till Needed
>
>
> "Nokia submits this code under the terms of a
commercial contribution
> agreement with Real Networks, and I am authorized to
contribute this
> code under said agreement."
>
> Modified by: John Wei
>
> Reviewed by:
>
> Date: 12-06-2006.
>
> Error ID: JWEI-6QPN7B
>
> Project: Helix plugin for Symbian
>
> Synopsis: MDF Video Renderer - Delay Depacktizing Till
Needed
>
> This CR proposes following error corrections or/and
improvements:
> 1) In the current codes, whenever MDF renderer gets a
packet
> from Helix
> core by function call OnPacket(), it will depacktize it
and put the
> frame data into a queue for decoding and blitting. This
scheme affects
> the startup time since renderer needs to depacktize 3-5
second
> prerolling frames before it could start the video play.
>
> In order to shorten the startup time, this CR proposes
to queue the
> packets into a queue without depacktizing. When MDF's
decoder asks for
> new frame data, renderer then will depacktize the
packet and
> give it to
> decoder. Since decoder has its internal buffer, it is
not
> expected that
> this change will result in dry run. The saved startup
time is
> around 131
> ms.
>
> Please note that there are not much "new"
codes in the CR. Many codes
> related to CPayloadFormatPluginDevice are shuffled
around from
> CMdfVideoRenderer to CMdfVideoAdapter since
CMdfVideoRenderer is no
> longer in control of CPayloadFormatPluginDevice.
>
> Files Modified:
> /cvsroot/datatype/mdf/video/renderer/pub/mdfvidrend.h
>
/cvsroot/datatype/mdf/video/renderer/pub/mdfvideoadapter.h
> /cvsroot/datatype/mdf/video/renderer/mdfvidrend.cpp.cpp
>
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp
>
>
> Image Size and Heap Use impact: minor
>
> Platforms and Profiles Build Verified:
helix-client-s60-mmf-mdf-dsp,
> armv5
>
> Platforms and Profiles Functionality verified: armv5
>
> Branch: hxclient_2_1_0_cayennes_restricted
>
_______________________________________________
Datatype-dev mailing list
Datatype-dev helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
|