Resend - CR: MDF Video Renderer - Set SynchronizeDecoding() to be true

"Nokia submits this code under the terms of a
commercial contribution
agreement with Real Networks, and I am authorized to
contribute this
code under said agreement."

Modified by:  John Wei

Reviewed by: 

Date: 25-09-2006.

Error ID: KJOS-6TJUH5

Project: Helix plugin for Symbian

Synopsis: MDF Video Renderer - Set SynchronizeDecoding() to
be true

This CR proposes following error corrections or/and
improvements:

1) Since some decoders support synchroize decoding, renderer
should set
SynchronizeDecoding() to be true. This setting does not
impact those
decoders who do not support this feature.

Files Modified:
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp

Index: mdfvideoadapter.cpp
============================================================
=======
RCS file:
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
retrieving revision 1.3.2.36
diff -u -w -b -r1.3.2.36 mdfvideoadapter.cpp
--- mdfvideoadapter.cpp	7 Sep 2006 15:31:10 -0000	1.3.2.36
+++ mdfvideoadapter.cpp	25 Sep 2006 20:11:25 -0000
 -405,7
+405,7 
 
         CleanupStack::PopAndDestroy( &aVideoFormat );
 
-        m_pDevVideoPlay->SynchronizeDecoding(EFalse);
+        m_pDevVideoPlay->SynchronizeDecoding( ETrue );
 
         CMMFDevVideoPlay::TBufferOptions bufferOptions;
         bufferOptions.iMaxInputBufferSize = (352*288);

Image Size and Heap Use impact: minor

Platforms and Profiles Build Verified:
helix-client-s60-mmf-mdf-arm

Platforms and Profiles Functionality verified: winscw, armv5

Branch: hxclient_2_1_0_cayennes_restricted

_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

Looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: john.weinokia.com [mailto:john.weinokia.com] 
> Sent: Thursday, September 28, 2006 11:25 AM
> To: datatype-devhelixcommunity.org
> Cc: gwrightreal.com; ehychereal.com
> Subject: Resend - CR: MDF Video Renderer - Set 
> SynchronizeDecoding() to be true
> 
> 
> "Nokia submits this code under the terms of a
commercial contribution
> agreement with Real Networks, and I am authorized to
contribute this
> code under said agreement."
> 
> Modified by:  John Wei
> 
> Reviewed by: 
> 
> Date: 25-09-2006.
> 
> Error ID: KJOS-6TJUH5
> 
> Project: Helix plugin for Symbian
> 
> Synopsis: MDF Video Renderer - Set
SynchronizeDecoding() to be true
> 
> This CR proposes following error corrections or/and
improvements:
> 
> 1) Since some decoders support synchroize decoding,
renderer 
> should set
> SynchronizeDecoding() to be true. This setting does not
impact those
> decoders who do not support this feature.
> 
> Files Modified:
>
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp
> 
> Index: mdfvideoadapter.cpp
>
============================================================
=======
> RCS file:
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
> retrieving revision 1.3.2.36
> diff -u -w -b -r1.3.2.36 mdfvideoadapter.cpp
> --- mdfvideoadapter.cpp	7 Sep 2006 15:31:10
-0000	1.3.2.36
> +++ mdfvideoadapter.cpp	25 Sep 2006 20:11:25 -0000
>  -405,7 +405,7 
>  
>          CleanupStack::PopAndDestroy( &aVideoFormat
);
>  
> -       
m_pDevVideoPlay->SynchronizeDecoding(EFalse);
> +        m_pDevVideoPlay->SynchronizeDecoding( ETrue
);
>  
>          CMMFDevVideoPlay::TBufferOptions
bufferOptions;
>          bufferOptions.iMaxInputBufferSize = (352*288);
> 
> Image Size and Heap Use impact: minor
> 
> Platforms and Profiles Build Verified:
helix-client-s60-mmf-mdf-arm
> 
> Platforms and Profiles Functionality verified: winscw,
armv5
> 
> Branch: hxclient_2_1_0_cayennes_restricted
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev