|
List Info
Thread: CR: Memory leak for codec configuration
|
|
| CR: Memory leak for codec configuration |
|
2007-03-12 16:15:05 |
"Nokia submits this code under the terms of a
commercial contribution
agreement with RealNetworks, and I am authorized to
contribute this code
under said agreement."
Modified by: Junhong.Liu nokia.com
Reviewed by:
Date: 03-11-2007
Error ID: NRRR-6Z3HHP
Project: Helix plugin for Symbian
Synopsis: Memory leak for codec configuration
This CR is to fix memory leak when codec configurations are
not empty.
Root Cause of the problem: Implementation.
Files Modified:
datatype/mdf/video/renderer/mdfvideoadapter.cpp
Image Size and Heap Use impact: No.
Module Release testing (STIF): All local cases pass on
Rosetta.
Test case(s) Added: No.
Memory leak check performed: Yes. No memory leaks are
introduced by this
CR.
Platforms and Profiles Build Verified:
helix-client-s60-mmf-mdf-arm
Platforms and Profiles Functionality Verified: armv5,
winscw
Branch:
HEAD and Hxclient_2_1_0_cayennes
? Makefile
? Umakefil.upp
? armv5-rel32
? diff.txt
? mdfvidrender.def
? mdfvidrender.uid.cpp
? mdfvidrender_dll_stub.c
? mdfvidrender_ordinal.dat
? mdfvidrender.def
? ribosome_logs
? umakedll.mak
? umakedll.upp
? umakelib.mak
? umakelib.upp
? winscw-dbg32
? winscw-rel32
? pub/diff.txt
Index: mdfclocksource.cpp
============================================================
=======
RCS file:
/cvsroot/datatype/mdf/video/renderer/mdfclocksource.cpp,v
retrieving revision 1.3.2.5
diff -w -u -r1.3.2.5 mdfclocksource.cpp
Index: mdfvideoadapter.cpp
============================================================
=======
RCS file:
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
retrieving revision 1.3.2.56
diff -w -u -r1.3.2.56 mdfvideoadapter.cpp
--- mdfvideoadapter.cpp 22 Feb 2007 16:03:43 -0000 1.3.2.56
+++ mdfvideoadapter.cpp 12 Mar 2007 21:07:17 -0000
-2068,3
+2068,14
return ulCurrTime;
}
+
+CMdfVideoAdapter::CodecConfigRule::CodecConfigRule()
+{
+}
+
+CMdfVideoAdapter::CodecConfigRule::~CodecConfigRule()
+{
+ HX_DELETE( pMimeType );
+ HX_DELETE( pProfile );
+}
+
Index: pub/mdfvideoadapter.h
============================================================
=======
RCS file:
/cvsroot/datatype/mdf/video/renderer/pub/mdfvideoadapter.h,v
retrieving revision 1.3.2.22
diff -w -u -r1.3.2.22 mdfvideoadapter.h
--- pub/mdfvideoadapter.h 10 Jan 2007 16:16:19
-0000 1.3.2.22
+++ pub/mdfvideoadapter.h 12 Mar 2007 21:07:17 -0000
-195,8
+195,13
EInitializedFailed
};
- typedef struct _CodecConfigRule
+
+ class CodecConfigRule : public CBase
{
+ public:
+ CodecConfigRule();
+ virtual ~CodecConfigRule();
+
HBufC8* pMimeType;
HBufC8* pProfile;
UINT32 ulFrameResolution;
-204,7
+209,7
TUid PostProcessorUid;
TUid DefaultDecoderUid;
TUid DefaultPostProcUid;
- } CodecConfigRule;
+ };
private:
IHXSite* m_pSite;
_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
|
|
| Re: CR: Memory leak for codec
configuration |
 
United States |
2007-03-12 16:17:17 |
Looks good.
--greg.
Junhong.Liunokia.com wrote:
> "Nokia submits this code under the terms of a
commercial contribution
> agreement with RealNetworks, and I am authorized to
contribute this code
> under said agreement."
>
> Modified by: Junhong.Liunokia.com
>
> Reviewed by:
>
> Date: 03-11-2007
>
> Error ID: NRRR-6Z3HHP
>
> Project: Helix plugin for Symbian
>
> Synopsis: Memory leak for codec configuration
>
> This CR is to fix memory leak when codec configurations
are not empty.
>
> Root Cause of the problem: Implementation.
>
> Files Modified:
>
> datatype/mdf/video/renderer/mdfvideoadapter.cpp
>
> Image Size and Heap Use impact: No.
>
> Module Release testing (STIF): All local cases pass on
Rosetta.
>
> Test case(s) Added: No.
>
> Memory leak check performed: Yes. No memory leaks are
introduced by this
> CR.
>
> Platforms and Profiles Build Verified:
helix-client-s60-mmf-mdf-arm
>
> Platforms and Profiles Functionality Verified: armv5,
winscw
>
> Branch:
>
> HEAD and Hxclient_2_1_0_cayennes
>
> ? Makefile
> ? Umakefil.upp
> ? armv5-rel32
> ? diff.txt
> ? mdfvidrender.def
> ? mdfvidrender.uid.cpp
> ? mdfvidrender_dll_stub.c
> ? mdfvidrender_ordinal.dat
> ? mdfvidrender.def
> ? ribosome_logs
> ? umakedll.mak
> ? umakedll.upp
> ? umakelib.mak
> ? umakelib.upp
> ? winscw-dbg32
> ? winscw-rel32
> ? pub/diff.txt
> Index: mdfclocksource.cpp
>
============================================================
=======
> RCS file:
/cvsroot/datatype/mdf/video/renderer/mdfclocksource.cpp,v
> retrieving revision 1.3.2.5
> diff -w -u -r1.3.2.5 mdfclocksource.cpp
> Index: mdfvideoadapter.cpp
>
============================================================
=======
> RCS file:
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
> retrieving revision 1.3.2.56
> diff -w -u -r1.3.2.56 mdfvideoadapter.cpp
> --- mdfvideoadapter.cpp 22 Feb 2007 16:03:43
-0000 1.3.2.56
> +++ mdfvideoadapter.cpp 12 Mar 2007 21:07:17 -0000
> -2068,3 +2068,14
>
> return ulCurrTime;
> }
> +
> +CMdfVideoAdapter::CodecConfigRule::CodecConfigRule()
> +{
> +}
> +
> +CMdfVideoAdapter::CodecConfigRule::~CodecConfigRule()
> +{
> + HX_DELETE( pMimeType );
> + HX_DELETE( pProfile );
> +}
> +
> Index: pub/mdfvideoadapter.h
>
============================================================
=======
> RCS file:
/cvsroot/datatype/mdf/video/renderer/pub/mdfvideoadapter.h,v
> retrieving revision 1.3.2.22
> diff -w -u -r1.3.2.22 mdfvideoadapter.h
> --- pub/mdfvideoadapter.h 10 Jan 2007 16:16:19
-0000 1.3.2.22
> +++ pub/mdfvideoadapter.h 12 Mar 2007 21:07:17 -0000
> -195,8 +195,13
> EInitializedFailed
> };
>
> - typedef struct _CodecConfigRule
> +
> + class CodecConfigRule : public CBase
> {
> + public:
> + CodecConfigRule();
> + virtual ~CodecConfigRule();
> +
> HBufC8* pMimeType;
> HBufC8* pProfile;
> UINT32 ulFrameResolution;
> -204,7 +209,7
> TUid PostProcessorUid;
> TUid DefaultDecoderUid;
> TUid DefaultPostProcUid;
> - } CodecConfigRule;
> + };
>
> private:
> IHXSite* m_pSite;
>
> _______________________________________________
> Datatype-dev mailing list
> Datatype-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
|
|
| RE: CR: Memory leak for codec
configuration |
|
2007-03-12 16:24:43 |
Thanks Greg !
The changes have been committed to Head and 210CayS.
Junhong
>-----Original Message-----
>From: ext Greg Wright [mailto:gwrightreal.com]
>Sent: Monday, March 12, 2007 3:17 PM
>To: Liu Junhong (Nokia-TP-MSW/Dallas)
>Cc: datatype-devhelixcommunity.org
>Subject: Re: [datatype-dev] CR: Memory leak for codec
configuration
>
>Looks good.
>
>--greg.
>
>Junhong.Liunokia.com wrote:
>> "Nokia submits this code under the terms of a
commercial
>contribution
>> agreement with RealNetworks, and I am authorized to
contribute this
>> code under said agreement."
>>
>> Modified by: Junhong.Liunokia.com
>>
>> Reviewed by:
>>
>> Date: 03-11-2007
>>
>> Error ID: NRRR-6Z3HHP
>>
>> Project: Helix plugin for Symbian
>>
>> Synopsis: Memory leak for codec configuration
>>
>> This CR is to fix memory leak when codec
configurations are
>not empty.
>>
>> Root Cause of the problem: Implementation.
>>
>> Files Modified:
>>
>> datatype/mdf/video/renderer/mdfvideoadapter.cpp
>>
>> Image Size and Heap Use impact: No.
>>
>> Module Release testing (STIF): All local cases pass
on Rosetta.
>>
>> Test case(s) Added: No.
>>
>> Memory leak check performed: Yes. No memory leaks
are introduced by
>> this CR.
>>
>> Platforms and Profiles Build Verified:
helix-client-s60-mmf-mdf-arm
>>
>> Platforms and Profiles Functionality Verified:
armv5, winscw
>>
>> Branch:
>>
>> HEAD and Hxclient_2_1_0_cayennes
>>
>> ? Makefile
>> ? Umakefil.upp
>> ? armv5-rel32
>> ? diff.txt
>> ? mdfvidrender.def
>> ? mdfvidrender.uid.cpp
>> ? mdfvidrender_dll_stub.c
>> ? mdfvidrender_ordinal.dat
>> ? mdfvidrender.def
>> ? ribosome_logs
>> ? umakedll.mak
>> ? umakedll.upp
>> ? umakelib.mak
>> ? umakelib.upp
>> ? winscw-dbg32
>> ? winscw-rel32
>> ? pub/diff.txt
>> Index: mdfclocksource.cpp
>>
============================================================
=======
>> RCS file:
/cvsroot/datatype/mdf/video/renderer/mdfclocksource.cpp,v
>> retrieving revision 1.3.2.5
>> diff -w -u -r1.3.2.5 mdfclocksource.cpp
>> Index: mdfvideoadapter.cpp
>>
============================================================
=======
>> RCS file:
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
>> retrieving revision 1.3.2.56
>> diff -w -u -r1.3.2.56 mdfvideoadapter.cpp
>> --- mdfvideoadapter.cpp 22 Feb 2007 16:03:43
-0000 1.3.2.56
>> +++ mdfvideoadapter.cpp 12 Mar 2007 21:07:17 -0000
>> -2068,3 +2068,14
>>
>> return ulCurrTime;
>> }
>> +
>>
+CMdfVideoAdapter::CodecConfigRule::CodecConfigRule()
>> +{
>> +}
>> +
>>
+CMdfVideoAdapter::CodecConfigRule::~CodecConfigRule()
>> +{
>> + HX_DELETE( pMimeType );
>> + HX_DELETE( pProfile );
>> +}
>> +
>> Index: pub/mdfvideoadapter.h
>>
============================================================
=======
>> RCS file:
>/cvsroot/datatype/mdf/video/renderer/pub/mdfvideoadapter
.h,v
>> retrieving revision 1.3.2.22
>> diff -w -u -r1.3.2.22 mdfvideoadapter.h
>> --- pub/mdfvideoadapter.h 10 Jan 2007 16:16:19
-0000 1.3.2.22
>> +++ pub/mdfvideoadapter.h 12 Mar 2007 21:07:17
-0000
>> -195,8 +195,13
>> EInitializedFailed
>> };
>>
>> - typedef struct _CodecConfigRule
>> +
>> + class CodecConfigRule : public CBase
>> {
>> + public:
>> + CodecConfigRule();
>> + virtual ~CodecConfigRule();
>> +
>> HBufC8* pMimeType;
>> HBufC8* pProfile;
>> UINT32 ulFrameResolution;
>> -204,7 +209,7
>> TUid PostProcessorUid;
>> TUid DefaultDecoderUid;
>> TUid DefaultPostProcUid;
>> - } CodecConfigRule;
>> + };
>>
>> private:
>> IHXSite* m_pSite;
>>
>> _______________________________________________
>> Datatype-dev mailing list
>> Datatype-devhelixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
>
>
_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
|
|
[1-3]
|
|
|
about | contact Other archives ( Real Estate discussion Medical topics )
|