CR: Minimum Contrast Value not working in Emulator

Looks good.
--greg.

Shy.Wardnokia.com wrote:
> "Nokia submits this code under the terms of a
commercial contribution
> agreement with RealNetworks, and I am authorized to
contribute this code
> under said agreement."
>  
> Modified by:  shy.wardnokia.com
>  
> Reviewed by: 
>  
> Date: 5/1/2007
>  
> Project: SymbianMmf
>  
> ErrorId:  EHPE-725LHK
>  
> Synopsis: The minimum contrast setting would not take
effect in the
> emulator. This was due to the contrast variable being
initialized to
> zero. Zero is also the same setting for minimum
contrast. Checking in
> the code for redundant sets would cause this call to
fail since they
> were both zero. The variable is now initialized to an
invalid number of
> -1 assuring the correct value will be used during
initialization.
> 
>     
> Root Cause of the problem: Implementation 
>  
> 
> Files Modified:
> datatype/mdf/video/renderer/mdfvideoadapter.cpp
> 
> Files Added: 
>  
>  
> Image Size and Heap Use impact: None
> 
> Module Release testing (STIF) : Yes, Local Test Cases
> 
> Test case(s) Added  :  N/A 
>   
> Memory leak check performed : Yes, no new leaks have
been introduced
> 
> Additional Notes on Testing: I tested this fix on
hardware but due to
> the incorrect Display Post in the image contrast does
not work
> correctly.
> I verfied that the correct value is set in the config
file.
>   
> Platforms and Profiles Build Verified:
helix-client-s60-32-mmf-mdf-arm
> 
> Platforms and Profiles Functionality verified: armv5,
winscw 
>   
> Branch: Head & 210CayS
> 
> Index: mdfvideoadapter.cpp
>
============================================================
=======
> RCS file:
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
> retrieving revision 1.3.2.61
> diff -w -u -b -r1.3.2.61 mdfvideoadapter.cpp
> --- mdfvideoadapter.cpp 27 Apr 2007 15:37:26 -0000     
1.3.2.61
> +++ mdfvideoadapter.cpp 30 Apr 2007 18:04:43 -0000
>  -162,7 +162,7 
>    m_fWidthPerc( 100.0 ),
>    m_bIsScalingCalcNeeded( FALSE ),
>    m_bIsDSAStartedFromClient( FALSE ),
> -  m_ulContrast( 0 ),
> +  m_ulContrast( -1 ),
>    m_pPluginPackage( NULL ),
>    m_CodecConfigRuleArray(
CODECCONFIGRULE_ARRAY_GRANULARITY ),
>    m_pPluginManager( pluginManager ),
> 
> 
> 
> 
> 
>
------------------------------------------------------------
------------
> 
> _______________________________________________
> Datatype-dev mailing list
> Datatype-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev