|
List Info
Thread: CR-Client: fix bug in FLV meta data parsing
|
|
| CR-Client: fix bug in FLV meta data
parsing |
 
United States |
2007-06-11 12:42:02 |
Description
-------------------------------------------
When parsing FLV meta-data array objects, there is no
indicator in this object type how many array entries there
are. In all of the files I have encountered up until now,
these
objects tended to fall at the end of the meta-data packet,
so they
were limited by the overall length of the data packet.
However,
now after looking at some FLV files from www.eyespot.com,
I'm seeing FLV meta-data array objects which do not fall
at the end of the packet, and therefore have to be
terminated
by an end-of-object marker (0x09). This change enables
this support.
Files Modified
----------------------------------------------
datatype/flash/flv/common/flvparse.cpp
Branches
----------------------------------------------
HEAD, 150Cay, 204Cay
Testing
----------------------------------------------
After this change, I can now parse meta-data on
FLV files from www.eyespot.com.
Index: flvparse.cpp
============================================================
=======
RCS file: /cvsroot/datatype/flash/flv/common/flvparse.cpp,v
retrieving revision 1.3
diff -u -w -r1.3 flvparse.cpp
--- flvparse.cpp 26 Feb 2007 22:11:21 -0000 1.3
+++ flvparse.cpp 11 Jun 2007 17:37:06 -0000
 -426,6
+426,13
{
// Increment the
number we've parsed
i++;
+ // Check to see if
we got an end-of-object
+ // for the value.
If so, then we need to
+ // break out of
parsing.
+ if
(pValue[i-1].GetDataType() ==
HX_FLV_META_AMF_TYPE_ENDOFOBJECT)
+ {
+ break;
+ }
}
}
}
=====================================
Eric Hyche, Technical Lead
RealNetworks, Inc.
ehychereal.com
_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
|
|
| Re: CR-Client: fix bug in FLV meta data
parsing |
United States |
2007-06-11 12:47:59 |
Looks good.
--greg.
Eric Hyche wrote:
> Description
> -------------------------------------------
> When parsing FLV meta-data array objects, there is no
> indicator in this object type how many array entries
there
> are. In all of the files I have encountered up until
now, these
> objects tended to fall at the end of the meta-data
packet, so they
> were limited by the overall length of the data packet.
However,
> now after looking at some FLV files from
www.eyespot.com,
> I'm seeing FLV meta-data array objects which do not
fall
> at the end of the packet, and therefore have to be
terminated
> by an end-of-object marker (0x09). This change enables
> this support.
>
> Files Modified
> ----------------------------------------------
> datatype/flash/flv/common/flvparse.cpp
>
> Branches
> ----------------------------------------------
> HEAD, 150Cay, 204Cay
>
> Testing
> ----------------------------------------------
> After this change, I can now parse meta-data on
> FLV files from www.eyespot.com.
>
> Index: flvparse.cpp
>
============================================================
=======
> RCS file:
/cvsroot/datatype/flash/flv/common/flvparse.cpp,v
> retrieving revision 1.3
> diff -u -w -r1.3 flvparse.cpp
> --- flvparse.cpp 26 Feb 2007 22:11:21 -0000
1.3
> +++ flvparse.cpp 11 Jun 2007 17:37:06 -0000
> -426,6 +426,13
> {
> // Increment
the number we've parsed
> i++;
> + // Check to
see if we got an end-of-object
> + // for the
value. If so, then we need to
> + // break out
of parsing.
> + if
(pValue[i-1].GetDataType() ==
HX_FLV_META_AMF_TYPE_ENDOFOBJECT)
> + {
> + break;
> + }
> }
> }
> }
>
>
>
> =====================================
> Eric Hyche, Technical Lead
> RealNetworks, Inc.
> ehychereal.com
>
>
> _______________________________________________
> Datatype-dev mailing list
> Datatype-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
|
|
| CN-Client: fix bug in FLV meta data
parsing |
United States |
2007-06-11 13:24:49 |
This is now checked into HEAD, 150Cay, and 204Cay.
=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: Greg Wright [mailto:gwrightreal.com]
> Sent: Monday, June 11, 2007 1:48 PM
> To: ehychereal.com
> Cc: datatype-devlists.helixcommunity.org
> Subject: Re: [datatype-dev] CR-Client: fix bug in FLV
meta
> data parsing
>
> Looks good.
> --greg.
>
>
> Eric Hyche wrote:
> > Description
> > -------------------------------------------
> > When parsing FLV meta-data array objects, there is
no
> > indicator in this object type how many array
entries there
> > are. In all of the files I have encountered up
until now, these
> > objects tended to fall at the end of the meta-data
packet, so they
> > were limited by the overall length of the data
packet. However,
> > now after looking at some FLV files from
www.eyespot.com,
> > I'm seeing FLV meta-data array objects which do
not fall
> > at the end of the packet, and therefore have to be
terminated
> > by an end-of-object marker (0x09). This change
enables
> > this support.
> >
> > Files Modified
> > ----------------------------------------------
> > datatype/flash/flv/common/flvparse.cpp
> >
> > Branches
> > ----------------------------------------------
> > HEAD, 150Cay, 204Cay
> >
> > Testing
> > ----------------------------------------------
> > After this change, I can now parse meta-data on
> > FLV files from www.eyespot.com.
> >
> > Index: flvparse.cpp
> >
============================================================
=======
> > RCS file:
/cvsroot/datatype/flash/flv/common/flvparse.cpp,v
> > retrieving revision 1.3
> > diff -u -w -r1.3 flvparse.cpp
> > --- flvparse.cpp 26 Feb 2007 22:11:21 -0000
1.3
> > +++ flvparse.cpp 11 Jun 2007 17:37:06
-0000
> > -426,6 +426,13
> > {
> > //
Increment the
> number we've parsed
> > i++;
> > + // Check
to see if
> we got an end-of-object
> > + // for
the value.
> If so, then we need to
> > + // break
out of parsing.
> > + if
> (pValue[i-1].GetDataType() ==
HX_FLV_META_AMF_TYPE_ENDOFOBJECT)
> > + {
> > +
break;
> > + }
> > }
> > }
> > }
> >
> >
> >
> > =====================================
> > Eric Hyche, Technical Lead
> > RealNetworks, Inc.
> > ehychereal.com
> >
> >
> > _______________________________________________
> > Datatype-dev mailing list
> > Datatype-devhelixcommunity.org
> > http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
>
_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
|
|
[1-3]
|
|