List Info

Thread: Re: CR: Fix for PR: 196039: J-Stream:Server stops sending post-seek packets of spars
Re: CR: Fix for PR: 196039: J-Stream:Server stops sending post-seek packets of spars
country flaguser name
United States		 2007-06-27 14:19:30 

  


  

    
It is not a good practice to carry stream characteristic with each
packet.  This is not proper location for this type of
information.

This information can be deduced from the stream header and be remembered
per stream.



Follow how audio and image map streams have been detected in
crealmed.cpp::
CRealMedia::add_header():

...


     ;   

        
      ;  
 ;       
       ; 
  ;      if

((memcmp(media->mime_type,REALIMAGEMAP_MIME_TYPE,media->mime_type_size)
== 0) ||

        
     ;   

        
      ;  
 ;       
       ;   
(memcmp(media>mime_type,REALIMAGEMAP_ENCRYPTED_MIME_TYPE,media->mime_type_size)
== 0))

        ;
   ;     
        
    ;    
        
     ;   {

       ; 
  ;      
        ;
   ;     
        
    ;    
        m_bHasImageMap =
TRUE;


        
    ;    
        
     ;   

        
      ;  
 ;       
m_nImageMapStreamNum = media->stream_number;

        
     ;   

        
      ;  
 ;       
       ; }


..


This also isolates the changes to crealmed.cpp .


Test the produced content index table by inspection in binary
editor.


Thanks,

Milko


At 09:08 AM 6/27/2007, Krishnendu Bagchi wrote:


Content-Type: text/plain;
charset=iso-8859-1

Content-Transfer-Encoding: 7bit

X-Mime-Autoconverted: from 8bit to 7bit by courier 0.53


Synopsis

========


This CR includes fix for PR 196039: J-Stream:Server stops sending

post-seek packets of sparse data streams (timestampdelivery
ones)


Quick link to the PR :


https://bugs.dev.prognet.com/show_bug.cgi?id=196039


Branch : PRODUCER_11_DOT_1, toolstall

Suggested Reviewer : Milko


Description

=========

Customer is facing a problem while seeking content with events. After
the

seek, the event whose start time is before the seek point and end time
is


after the seek point is not firing. For example, if there is an
event

starting at 1:00 and ending at 1:50 and if the seek happens from
0:30

to 1:30, then this particular event is not triggering.


Fix:


====


[Milko] File-writing section of code that needs to be corrected

(special


consideration must be given to sparse streams - image maps and
events).

[Kris]So I have modified the code such that it makes as many entries
to

the index table of the media file as many events are there.


Files Affected


==============

datatype-restrictedrmtoolsfilecrealmed.h

datatype-restrictedrmtoolsfilecrealmed.cpp

producersdk_rncommonrmtoolsrmevnts1.cpp

producersdk_rncommonrmtoolsrmevnts2.cpp


Testing Performed

=================

Unit Tests:


As there is no definite way to check the fix, we have to rely on the

developer and reviewer of the code. In case you identify some method
to

test the expected behavior of the fix, do feel free to report
immediately.

I tried to search a lot, but didn't find any way to dump the index
table

of a media file.


QA Hints

=======

Not sure. Please refer to the last section of the mail.


-- 

Thanks & Regards,


Kris

Content-Type: text/plain; name=";diff_196039_1.txt";
charset=iso-8859-1

Content-Transfer-Encoding: 7bit

Content-Disposition: attachment;
filename="diff_196039_1.txt"

X-Mime-Autoconverted: from 8bit to 7bit by courier 0.53


Content-Type: text/plain; name=";diff_196039_2.txt";
charset=iso-8859-1

Content-Transfer-Encoding: 7bit

Content-Disposition: attachment;
filename="diff_196039_2.txt"

X-Mime-Autoconverted: from 8bit to 7bit by courier 0.53



  

  
  
   
     
    






 [1]











   
 





about | contact  Other archives ( Real Estate discussion Medical topics )