List Info

Thread: CR: Fixed the build depedency (bif) and streamtype mismatch fo




CR: Fixed the build depedency (bif) and streamtype mismatch fo
country flaguser name
United States
2007-09-14 08:44:11
Looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Zhao, Halley [mailto:halley.zhaointel.com] 
> Sent: Thursday, September 13, 2007 10:50 PM
> To: ehychereal.com; datatype-dev
> Cc: helix-client-devhelixcommunity.org
> Subject: RE: [Helix-client-dev] CR: Fixed the build
depedency 
> (bif) and streamtype mismatch for avi fileformat
plugin
> 
> $B!!!!(BRe-send diff file with acceptation of Eric's
correction.
> $B!!!!(B
> $B!!!!(BIt needs "#if
defined(HELIX_FEATURE_SERVER)" to pass 
> compile for JPEGPayloadFormat.
> $B!!!!(B
> $B!!!!(BPass Test.
> $B!!!!(B
> $B!!!!(B
> $B!!!!(B>-----Original Message-----
> $B!!!!(B>From: Eric Hyche [mailto:ehychereal.com]
> $B!!!!(B>Sent: 2007$BG/(B9$B7n(B13$BF|(B
21:29
> $B!!!!(B>To: Zhao, Halley; 'datatype-dev'
> $B!!!!(B>Cc: helix-client-devhelixcommunity.org
> $B!!!!(B>Subject: RE: [Helix-client-dev] CR: Fixed
the build 
> depedency (bif) and
> $B!!!!(B>streamtype mismatch for avi fileformat
plugin
> $B!!!!(B>
> $B!!!!(B>
> $B!!!!(B>My comments on these changes:
> $B!!!!(B>
> $B!!!!(B> if
project.IsDefined("HELIX_FEATURE_SERVER"):
> $B!!!!(B>-   
MultiTargetMake("aviffdll")
> $B!!!!(B>+   
MultiTargetMake("avifflib","aviffdll")
> $B!!!!(B>
> $B!!!!(B>No need to change if HELIX_FEATURE_SERVER
is defined -
> $B!!!!(B>this does not affect the client, and we
should not
> $B!!!!(B>change the server builds.
> $B!!!!(B>
> $B!!!!(B>-#if 0 // JPEGPayloadFormat not supported
(yet)
> $B!!!!(B>+// #if 0 // JPEGPayloadFormat not
supported (yet)
> $B!!!!(B>
> $B!!!!(B>No need to keep this - just remove it.
> $B!!!!(B>
> $B!!!!(B>                         if
(!m_bLocalPlayback)
> $B!!!!(B>                         {
> $B!!!!(B>+                            //
ASSERT(0);
> $B!!!!(B>+#if 0 // JPEGPayloadFormat not supported
(yet)
> $B!!!!(B>
> $B!!!!(B>                            
m_pPayloadFormatter = new
> $B!!!!(B>JPEGPayloadFormat();
> $B!!!!(B>
> $B!!!!(B>This should not be ifdef'd out. if
(!m_bLocalPlayback)
> $B!!!!(B>means that this will only get executed
when running on
> $B!!!!(B>the server, so it should never get
executed on the client.
> $B!!!!(B>If there is a compilation issue with
JPEGPayloadFormat,
> $B!!!!(B>then the whole if (!m_bLocalPlayback)
clause should be
> $B!!!!(B>put inside #if
defined(HELIX_FEATURE_SERVER).
> $B!!!!(B>
> $B!!!!(B>-#endif // 0
> $B!!!!(B>+//#endif // 0
> $B!!!!(B>
> $B!!!!(B>Again, no reason to keep this.
> $B!!!!(B>
> $B!!!!(B>
> $B!!!!(B>Rest looks good.
> $B!!!!(B>
> $B!!!!(B>Eric
> $B!!!!(B>
>
$B!!!!(B>=============================================
> $B!!!!(B>Eric Hyche (ehychereal.com)
> $B!!!!(B>Technical Lead
> $B!!!!(B>RealNetworks, Inc.
> $B!!!!(B>
> $B!!!!(B>> -----Original Message-----
> $B!!!!(B>> From: helix-client-dev-bounceshelixcommunity.org
> $B!!!!(B>> [mailto:helix-client-dev-bounceshelixcommunity.org] On
> $B!!!!(B>> Behalf Of Zhao, Halley
> $B!!!!(B>> Sent: Thursday, September 13, 2007
3:06 AM
> $B!!!!(B>> To: datatype-dev
> $B!!!!(B>> Cc: helix-client-devhelixcommunity.org
> $B!!!!(B>> Subject: [Helix-client-dev] CR:
Fixed the build depedency
> $B!!!!(B>> (bif) and streamtype mismatch for
avi fileformat plugin
> $B!!!!(B>>
> $B!!!!(B>> Bug Number:
> $B!!!!(B>>
> $B!!!!(B>>     7204
> $B!!!!(B>>
> $B!!!!(B>> Bug URL:
> $B!!!!(B>>
> $B!!!!(B>>     
https://bugs.helixcommunity.org/show_bug.cgi?id=7204
> $B!!!!(B>>
> $B!!!!(B>> Synopsis:
> $B!!!!(B>>
> $B!!!!(B>>     fix a bug for endian type
mismatch of avi file format module.
> $B!!!!(B>>
> $B!!!!(B>> Overview:
> $B!!!!(B>>
> $B!!!!(B>>     1.  Add  module dependlist in
hxclient_3_1_0_atlas.bif
> $B!!!!(B>> for avi fileformat target.
> $B!!!!(B>>
> $B!!!!(B>>     2.  avifformat.so plugin can't
parse a valid avi stream ;
> $B!!!!(B>> some confliction for little endian
or big endian.
> $B!!!!(B>>
> $B!!!!(B>>     For 4-characters stream type
string, such as "AVI
> $B!!!!(B>>
","MJPEG","H263", helix transform
it to an integer value,.
> $B!!!!(B>> however sometimes it check the
endian type of platform,
> $B!!!!(B>> sometimes it use MACRO HX_MAKE4CC
regardless endian type of
> $B!!!!(B>> platform. it will cause mismatch.
> $B!!!!(B>>
> $B!!!!(B>>         a.  in aviffpln.cpp, there
is check of the media stream:
> $B!!!!(B>>
> $B!!!!(B>>             if
(m_pGeneralReader->FileSubtype() !=
> $B!!!!(B>> HX_MAKE4CC('A', 'V', 'I', ' '))
> $B!!!!(B>>
> $B!!!!(B>>             FileSubtype defined in
common module, it uses
> $B!!!!(B>> platform dependent endian type, but
HX_Make4CC use fixed
> $B!!!!(B>> little endian. I think it's better
to change to:
> $B!!!!(B>>
> $B!!!!(B>>             if
(m_pGeneralReader->FileSubtype() !=
> $B!!!!(B>>
m_pGeneralReader->GetLong("AVI "))
> $B!!!!(B>>
> $B!!!!(B>>             FileSubtype() and
GetLong() is both defined in
> $B!!!!(B>> common module, and have the same
endian type.
> $B!!!!(B>>
> $B!!!!(B>>         b.  avistrm.cpp
> $B!!!!(B>>
> $B!!!!(B>>             m_header.ulType         
       =
> $B!!!!(B>> LE32_TO_HOST(*(UINT32*)
&buf[0])
> $B!!!!(B>>
> $B!!!!(B>>             LE32_TO_HOST depend on
platfrom's endian type,
> $B!!!!(B>> AVI_VIDS_TYPE, AVI_AUDS_TYPE,
AVI_MJPG_VIDEO are defined by
> $B!!!!(B>> HX_MAKE4CC regardless of endian
type. there will be mismatch
> $B!!!!(B>> when compare them.
> $B!!!!(B>>
> $B!!!!(B>>             the absolute value of
ulType is not important, we
> $B!!!!(B>> can modify as following to make them
be consistent with 
> each other.
> $B!!!!(B>>
> $B!!!!(B>>             m_header.ulType =
HX_MAKE4CC( buf[0], buf[1],
> $B!!!!(B>> buf[2], buf[3])
> $B!!!!(B>>
> $B!!!!(B>>         c). mjpeg is supported by
helix community now
> $B!!!!(B>>
> $B!!!!(B>>             Change the #if defined
to enable mjpeg support.
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>> Files Added:
> $B!!!!(B>>
> $B!!!!(B>>        No file added
> $B!!!!(B>>
> $B!!!!(B>> Files Modified:
> $B!!!!(B>>
> $B!!!!(B>>     aviffpln.cpp:
(datatype/avi/fileformat/aviffpln.cpp)
> $B!!!!(B>>
> $B!!!!(B>>         when compare with
FileSubtype which defined in common
> $B!!!!(B>> module, use GetLong (which also
defined in common module) to
> $B!!!!(B>> transform media type string to
integer.
> $B!!!!(B>>
> $B!!!!(B>>     avistrm:   
(datatype/avi/fileformat/avistrm.cpp)
> $B!!!!(B>>
> $B!!!!(B>>         use HX_MAKE4CC() to get
ulType from media type
> $B!!!!(B>> string, since it used inside
avistrm.cpp only, and
> $B!!!!(B>> AVI_VIDS_TYPE, AVI_AUDS_TYPE,
AVI_MJPG_VIDEO are defined by
> $B!!!!(B>> HX_MAKE4CC().
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>>         another solution is to
redefine AVI_VIDS_TYPE,
> $B!!!!(B>> AVI_AUDS_TYPE, AVI_MJPG_VIDEO by
LE32_TO_HOST.
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>> Image Size and Heap Use impact
(Client -Only):
> $B!!!!(B>>
> $B!!!!(B>>     little
> $B!!!!(B>>
> $B!!!!(B>> Platforms and Profiles Affected:
> $B!!!!(B>>
> $B!!!!(B>>     platform:  
linux-2.2-libc6-gcc32-i586
> $B!!!!(B>>
> $B!!!!(B>>     profile:   
helix-client-all-defines
> $B!!!!(B>>
> $B!!!!(B>> Distribution Libraries Affected:
> $B!!!!(B>>
> $B!!!!(B>>     avifformat.so
> $B!!!!(B>>
> $B!!!!(B>> Distribution library impact and
planned action:
> $B!!!!(B>>
> $B!!!!(B>>     None
> $B!!!!(B>>
> $B!!!!(B>> Platforms and Profiles Build
Verified:
> $B!!!!(B>>
> $B!!!!(B>>     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> $B!!!!(B>>
> $B!!!!(B>>     Set Target(s)   ->
datatype_avi_fileformat
> $B!!!!(B>>
> $B!!!!(B>>     Set Profile     ->
helix-client-all-defines
> $B!!!!(B>>
> $B!!!!(B>>     System ID       ->
linux-2.2-libc6-gcc32-i586
> $B!!!!(B>>
> $B!!!!(B>> Branch:
> $B!!!!(B>>
> $B!!!!(B>>     HEAD, hxclient_3_1_0_atlas
> $B!!!!(B>>
> $B!!!!(B>> Copyright assignment: <MUST be
one of the following statements >
> $B!!!!(B>>
> $B!!!!(B>>    3.      My company (company name
here) submits this code
> $B!!!!(B>> under the terms
> $B!!!!(B>>
> $B!!!!(B>>            of a commercial
contribution agreement with 
> RealNetworks,
> $B!!!!(B>>
> $B!!!!(B>>            and I am authorized to
contribute this code under
> $B!!!!(B>> said agreement.
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>> Files Attached:
> $B!!!!(B>>
> $B!!!!(B>>     datatype-avi.diff
> $B!!!!(B>>
> $B!!!!(B>>     bif-avi.diff
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>> ZHAO, Halley (Aihua)
> $B!!!!(B>>
> $B!!!!(B>> Email: halley.zhaointel.com
<mailto:aihua.zhaointel.com>
> $B!!!!(B>>
> $B!!!!(B>> Tel: +86(21)61166476
> $B!!!!(B>>
> $B!!!!(B>> iNet: 8821-6476
> $B!!!!(B>>
> $B!!!!(B>> SSG/OTC/UMD
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>>
> $B!!!!(B>>
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

CN: Fixed the build depedency (bif) and streamtype mismatch fo
user name
2007-09-19 00:54:32
  	Thanks, 
  Commit to HEAD and hxclient_3_1_0_atlas branch.
  
  >-----Original Message-----
  >From: Eric Hyche [mailto:ehychereal.com]
  >Sent: 2007定9埖14晩 21:44
  >To: Zhao, Halley; 'datatype-dev'
  >Cc: helix-client-devhelixcommunity.org
  >Subject: RE: [Helix-client-dev] CR: Fixed the build
depedency (bif) and
  >streamtype mismatch for avi fileformat plugin
  >
  >
  >Looks good.
  >
  >=============================================
  >Eric Hyche (ehychereal.com)
  >Technical Lead
  >RealNetworks, Inc.
  >
  >> -----Original Message-----
  >> From: Zhao, Halley [mailto:halley.zhaointel.com]
  >> Sent: Thursday, September 13, 2007 10:50 PM
  >> To: ehychereal.com; datatype-dev
  >> Cc: helix-client-devhelixcommunity.org
  >> Subject: RE: [Helix-client-dev] CR: Fixed the
build depedency
  >> (bif) and streamtype mismatch for avi
fileformat plugin
  >>
  >>   Re-send diff file with acceptation of
Eric's correction.
  >>
  >>   It needs "#if
defined(HELIX_FEATURE_SERVER)" to pass
  >> compile for JPEGPayloadFormat.
  >>
  >>   Pass Test.
  >>
  >>
  >>   >-----Original Message-----
  >>   >From: Eric Hyche [mailto:ehychereal.com]
  >>   >Sent: 2007定9埖13晩 21:29
  >>   >To: Zhao, Halley; 'datatype-dev'
  >>   >Cc: helix-client-devhelixcommunity.org
  >>   >Subject: RE: [Helix-client-dev] CR:
Fixed the build
  >> depedency (bif) and
  >>   >streamtype mismatch for avi fileformat
plugin
  >>   >
  >>   >
  >>   >My comments on these changes:
  >>   >
  >>   > if
project.IsDefined("HELIX_FEATURE_SERVER"):
  >>   >-   
MultiTargetMake("aviffdll")
  >>   >+   
MultiTargetMake("avifflib","aviffdll")
  >>   >
  >>   >No need to change if
HELIX_FEATURE_SERVER is defined -
  >>   >this does not affect the client, and we
should not
  >>   >change the server builds.
  >>   >
  >>   >-#if 0 // JPEGPayloadFormat not
supported (yet)
  >>   >+// #if 0 // JPEGPayloadFormat not
supported (yet)
  >>   >
  >>   >No need to keep this - just remove it.
  >>   >
  >>   >                         if
(!m_bLocalPlayback)
  >>   >                         {
  >>   >+                            //
ASSERT(0);
  >>   >+#if 0 // JPEGPayloadFormat not
supported (yet)
  >>   >
  >>   >                            
m_pPayloadFormatter = new
  >>   >JPEGPayloadFormat();
  >>   >
  >>   >This should not be ifdef'd out. if
(!m_bLocalPlayback)
  >>   >means that this will only get executed
when running on
  >>   >the server, so it should never get
executed on the client.
  >>   >If there is a compilation issue with
JPEGPayloadFormat,
  >>   >then the whole if (!m_bLocalPlayback)
clause should be
  >>   >put inside #if
defined(HELIX_FEATURE_SERVER).
  >>   >
  >>   >-#endif // 0
  >>   >+//#endif // 0
  >>   >
  >>   >Again, no reason to keep this.
  >>   >
  >>   >
  >>   >Rest looks good.
  >>   >
  >>   >Eric
  >>   >
  >>
  >=============================================
  >>   >Eric Hyche (ehychereal.com)
  >>   >Technical Lead
  >>   >RealNetworks, Inc.
  >>   >
  >>   >> -----Original Message-----
  >>   >> From: helix-client-dev-bounceshelixcommunity.org
  >>   >>
[mailto:helix-client-dev-bounceshelixcommunity.org] On
  >>   >> Behalf Of Zhao, Halley
  >>   >> Sent: Thursday, September 13, 2007
3:06 AM
  >>   >> To: datatype-dev
  >>   >> Cc: helix-client-devhelixcommunity.org
  >>   >> Subject: [Helix-client-dev] CR:
Fixed the build depedency
  >>   >> (bif) and streamtype mismatch for
avi fileformat plugin
  >>   >>
  >>   >> Bug Number:
  >>   >>
  >>   >>     7204
  >>   >>
  >>   >> Bug URL:
  >>   >>
  >>   >>     
https://bugs.helixcommunity.org/show_bug.cgi?id=7204
  >>   >>
  >>   >> Synopsis:
  >>   >>
  >>   >>     fix a bug for endian type
mismatch of avi file format module.
  >>   >>
  >>   >> Overview:
  >>   >>
  >>   >>     1.  Add  module dependlist in
hxclient_3_1_0_atlas.bif
  >>   >> for avi fileformat target.
  >>   >>
  >>   >>     2.  avifformat.so plugin can't
parse a valid avi stream ;
  >>   >> some confliction for little endian
or big endian.
  >>   >>
  >>   >>     For 4-characters stream type
string, such as "AVI
  >>   >>
","MJPEG","H263", helix transform
it to an integer value,.
  >>   >> however sometimes it check the
endian type of platform,
  >>   >> sometimes it use MACRO HX_MAKE4CC
regardless endian type of
  >>   >> platform. it will cause mismatch.
  >>   >>
  >>   >>         a.  in aviffpln.cpp, there
is check of the media stream:
  >>   >>
  >>   >>             if
(m_pGeneralReader->FileSubtype() !=
  >>   >> HX_MAKE4CC('A', 'V', 'I', ' '))
  >>   >>
  >>   >>             FileSubtype defined in
common module, it uses
  >>   >> platform dependent endian type,
but HX_Make4CC use fixed
  >>   >> little endian. I think it's better
to change to:
  >>   >>
  >>   >>             if
(m_pGeneralReader->FileSubtype() !=
  >>   >>
m_pGeneralReader->GetLong("AVI "))
  >>   >>
  >>   >>             FileSubtype() and
GetLong() is both defined in
  >>   >> common module, and have the same
endian type.
  >>   >>
  >>   >>         b.  avistrm.cpp
  >>   >>
  >>   >>             m_header.ulType       
         =
  >>   >> LE32_TO_HOST(*(UINT32*)
&buf[0])
  >>   >>
  >>   >>             LE32_TO_HOST depend on
platfrom's endian type,
  >>   >> AVI_VIDS_TYPE, AVI_AUDS_TYPE,
AVI_MJPG_VIDEO are defined by
  >>   >> HX_MAKE4CC regardless of endian
type. there will be mismatch
  >>   >> when compare them.
  >>   >>
  >>   >>             the absolute value of
ulType is not important, we
  >>   >> can modify as following to make
them be consistent with
  >> each other.
  >>   >>
  >>   >>             m_header.ulType =
HX_MAKE4CC( buf[0], buf[1],
  >>   >> buf[2], buf[3])
  >>   >>
  >>   >>         c). mjpeg is supported by
helix community now
  >>   >>
  >>   >>             Change the #if defined
to enable mjpeg support.
  >>   >>
  >>   >>
  >>   >>
  >>   >> Files Added:
  >>   >>
  >>   >>        No file added
  >>   >>
  >>   >> Files Modified:
  >>   >>
  >>   >>     aviffpln.cpp:
(datatype/avi/fileformat/aviffpln.cpp)
  >>   >>
  >>   >>         when compare with
FileSubtype which defined in common
  >>   >> module, use GetLong (which also
defined in common module) to
  >>   >> transform media type string to
integer.
  >>   >>
  >>   >>     avistrm:   
(datatype/avi/fileformat/avistrm.cpp)
  >>   >>
  >>   >>         use HX_MAKE4CC() to get
ulType from media type
  >>   >> string, since it used inside
avistrm.cpp only, and
  >>   >> AVI_VIDS_TYPE, AVI_AUDS_TYPE,
AVI_MJPG_VIDEO are defined by
  >>   >> HX_MAKE4CC().
  >>   >>
  >>   >>
  >>   >>
  >>   >>         another solution is to
redefine AVI_VIDS_TYPE,
  >>   >> AVI_AUDS_TYPE, AVI_MJPG_VIDEO by
LE32_TO_HOST.
  >>   >>
  >>   >>
  >>   >>
  >>   >> Image Size and Heap Use impact
(Client -Only):
  >>   >>
  >>   >>     little
  >>   >>
  >>   >> Platforms and Profiles Affected:
  >>   >>
  >>   >>     platform:  
linux-2.2-libc6-gcc32-i586
  >>   >>
  >>   >>     profile:   
helix-client-all-defines
  >>   >>
  >>   >> Distribution Libraries Affected:
  >>   >>
  >>   >>     avifformat.so
  >>   >>
  >>   >> Distribution library impact and
planned action:
  >>   >>
  >>   >>     None
  >>   >>
  >>   >> Platforms and Profiles Build
Verified:
  >>   >>
  >>   >>     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
  >>   >>
  >>   >>     Set Target(s)   ->
datatype_avi_fileformat
  >>   >>
  >>   >>     Set Profile     ->
helix-client-all-defines
  >>   >>
  >>   >>     System ID       ->
linux-2.2-libc6-gcc32-i586
  >>   >>
  >>   >> Branch:
  >>   >>
  >>   >>     HEAD, hxclient_3_1_0_atlas
  >>   >>
  >>   >> Copyright assignment: <MUST be
one of the following statements >
  >>   >>
  >>   >>    3.      My company (company
name here) submits this code
  >>   >> under the terms
  >>   >>
  >>   >>            of a commercial
contribution agreement with
  >> RealNetworks,
  >>   >>
  >>   >>            and I am authorized to
contribute this code under
  >>   >> said agreement.
  >>   >>
  >>   >>
  >>   >>
  >>   >> Files Attached:
  >>   >>
  >>   >>     datatype-avi.diff
  >>   >>
  >>   >>     bif-avi.diff
  >>   >>
  >>   >>
  >>   >>
  >>   >> ZHAO, Halley (Aihua)
  >>   >>
  >>   >> Email: halley.zhaointel.com
<mailto:aihua.zhaointel.com>
  >>   >>
  >>   >> Tel: +86(21)61166476
  >>   >>
  >>   >> iNet: 8821-6476
  >>   >>
  >>   >> SSG/OTC/UMD
  >>   >>
  >>   >>
  >>   >>
  >>   >>
  >>

_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )