CR: PR 206976 - Incorrect channel count advertised for mono AAC content

Synopsis
========
Fixes PR 206976

Branches: SERVER_BORABORA, HEAD (SERVER_CURRENT)
Suggested Reviewer: anyone
(Already checked in on borabora)

Description
===========
We cannot trust the channel count parsed from the MP4A
sample
descriptor. This value is only defined as the number of
channels
for QuickTime files. For mp4 and 3gp content, it is
reserved
bytes spec'd to always to contain 2. So we will ignore this
value a
nd parse the correct channel count from the
AudioSpecificConfig and
set that for sdp creation.

Also fixes a bug where we were attempting to dereference a
NULL
pointer with non-SBR content.


Files Affected
==============
datatype/mp4/fileformat/qtpacketizerfct.cpp
datatype/mp4/payload/latmpacketizer.cpp
datatype/mp4/payload/pub/latmpacketizer.h


Testing Performed
=================
Unit Tests:

Integration Tests:
* Verified correct channel count in mono SDP
* Verified correct channel count in stereo SDP
* Verified playback of AAC and AAC+, mono and stereo with
RealPlayer and
QT Player

Leak Tests:

Performance Tests:

Platforms Tested: win32-i386-vc7
Build verified: win32-i386-vc7


QA Hints
===============





_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

With diff!

Jamie Gordon wrote:
> Synopsis
> ========
> Fixes PR 206976
> 
> Branches: SERVER_BORABORA, HEAD (SERVER_CURRENT)
> Suggested Reviewer: anyone
> (Already checked in on borabora)
> 
> Description
> ===========
> We cannot trust the channel count parsed from the MP4A
sample
> descriptor. This value is only defined as the number of
channels
> for QuickTime files. For mp4 and 3gp content, it is
reserved
> bytes spec'd to always to contain 2. So we will ignore
this value a
> nd parse the correct channel count from the
AudioSpecificConfig and
> set that for sdp creation.
> 
> Also fixes a bug where we were attempting to
dereference a NULL
> pointer with non-SBR content.
> 
> 
> Files Affected
> ==============
> datatype/mp4/fileformat/qtpacketizerfct.cpp
> datatype/mp4/payload/latmpacketizer.cpp
> datatype/mp4/payload/pub/latmpacketizer.h
> 
> 
> Testing Performed
> =================
> Unit Tests:
> 
> Integration Tests:
> * Verified correct channel count in mono SDP
> * Verified correct channel count in stereo SDP
> * Verified playback of AAC and AAC+, mono and stereo
with RealPlayer and
> QT Player
> 
> Leak Tests:
> 
> Performance Tests:
> 
> Platforms Tested: win32-i386-vc7
> Build verified: win32-i386-vc7
> 
> 
> QA Hints
> ===============
> 
> 
> 
> 
> 
> _______________________________________________
> Datatype-dev mailing list
> Datatype-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

Looks good to me.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounceshelixcommunity.org 
> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> Jamie Gordon
> Sent: Thursday, November 01, 2007 6:49 PM
> To: datatype-devhelixcommunity.org
> Subject: Re: [datatype-dev] CR: PR 206976 - Incorrect
channel 
> count advertisedfor mono AAC content
> 
> With diff!
> 
> Jamie Gordon wrote:
> > Synopsis
> > ========
> > Fixes PR 206976
> > 
> > Branches: SERVER_BORABORA, HEAD (SERVER_CURRENT)
> > Suggested Reviewer: anyone
> > (Already checked in on borabora)
> > 
> > Description
> > ===========
> > We cannot trust the channel count parsed from the
MP4A sample
> > descriptor. This value is only defined as the
number of channels
> > for QuickTime files. For mp4 and 3gp content, it
is reserved
> > bytes spec'd to always to contain 2. So we will
ignore this value a
> > nd parse the correct channel count from the
AudioSpecificConfig and
> > set that for sdp creation.
> > 
> > Also fixes a bug where we were attempting to
dereference a NULL
> > pointer with non-SBR content.
> > 
> > 
> > Files Affected
> > ==============
> > datatype/mp4/fileformat/qtpacketizerfct.cpp
> > datatype/mp4/payload/latmpacketizer.cpp
> > datatype/mp4/payload/pub/latmpacketizer.h
> > 
> > 
> > Testing Performed
> > =================
> > Unit Tests:
> > 
> > Integration Tests:
> > * Verified correct channel count in mono SDP
> > * Verified correct channel count in stereo SDP
> > * Verified playback of AAC and AAC+, mono and
stereo with 
> RealPlayer and
> > QT Player
> > 
> > Leak Tests:
> > 
> > Performance Tests:
> > 
> > Platforms Tested: win32-i386-vc7
> > Build verified: win32-i386-vc7
> > 
> > 
> > QA Hints
> > ===============
> > 
> > 
> > 
> > 
> > 
> > _______________________________________________
> > Datatype-dev mailing list
> > Datatype-devhelixcommunity.org
> > http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev