CR needed: eACC+ Error Concealment Activation

Looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounceshelixcommunity.org 
> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> Sunitha.Ramakrishnanokia.com
> Sent: Friday, January 11, 2008 5:14 PM
> To: datatype-devhelixcommunity.org
> Subject: [datatype-dev] CR needed: eACC+ Error
Concealment Activation
> 
> "Nokia submits this code under the terms of a
commercial 
> contribution agreement with RealNetworks, and I am
authorized 
> to contribute this code under said agreement."
> 
>   
> Modified by:  sunitha.ramakrishnanokia.com 
>   
> Reviewed by: 
>   
> Date: 01/011/2008 
>   
> Project: SymbianMmf_rel 
>   
> ErrorId: SRAA-7ARTMS 
>   
> Synopsis: Enable eAAC+ error concealmeant 
> 
> Overview: While streaming eAAC+ clips with hardware 
> accelerated codecs, missing frames would cause problems
since 
> error concealmeant was not being activated.
> 
> Solution:  Add eAAC+ FourCCCode to HandleMissingFrames

> 
> Files modified: 
> /datatype/mdf/audio/dsp/mdfdevsound.cpp 
> /datatype/mdf/audio/dsp/mdfaudfmt.h 
> /datatype/mdf/audio/dsp/mdfaudfmt.cpp 
> 
> 
> Files added: 
> None. 
> 
> Image Size and Heap Use impact: minor. 
> 
> Module Release testing (STIF) : Yes, Passed 
> 
> Test case(s) Added  : No 
>   
> Memory leak check performed : Yes. No new memory leaks
introduced. 
>   
> Platforms and Profiles Build Verified: 
> helix-client-s60-32-mmf-mdf-dsp 
> 
> Platforms and Profiles Functionality verified: armv5 
>   
> Branch: Head & 210CayS 
> 
> 
> Index: mdfaudfmt.cpp 
>
============================================================
======= 
> RCS file:
/cvsroot/datatype/mdf/audio/dsp/mdfaudfmt.cpp,v 
> retrieving revision 1.1.2.8 
> diff -w -u -b -r1.1.2.8 mdfaudfmt.cpp 
> --- mdfaudfmt.cpp       3 Jul 2007 19:06:00 -0000      
1.1.2.8 
> +++ mdfaudfmt.cpp       11 Jan 2008 22:01:43 -0000 
>  -211,7 +211,6  
>  #define SBR_DOWNSAMPLE_CUTOFF_RATE      24000 
>  #define MAX_SBR_OUT_SAMPLE_RATE         48000 
>   
> -#define KMMFFourCCCodeEAACP             0x43414520  //
' ' 
> 'E' 'A' 'C' 
>   
>  HXMDFAudioAac::HXMDFAudioAac(): 
>  m_ulObjectType(0)  
> 
> 
>               
> Index: mdfaudfmt.h 
>
============================================================
======= 
> RCS file: /cvsroot/datatype/mdf/audio/dsp/mdfaudfmt.h,v

> retrieving revision 1.1.2.5 
> diff -w -u -b -r1.1.2.5 mdfaudfmt.h 
> --- mdfaudfmt.h 7 Jun 2007 18:59:14 -0000       1.1.2.5

> +++ mdfaudfmt.h 11 Jan 2008 22:01:43 -0000 
>  -63,6 +63,7  
>   
>  #include "gaconfig.h" 
>   
> +#define KMMFFourCCCodeEAACP             0x43414520  //
' ' 
> 'E' 'A' 'C' 
>   
>  class HXMDFAudioFormat 
>  { 
> 
> 
> 
> 
> Index: mdfdevsound.cpp 
>
============================================================
======= 
> RCS file:
/cvsroot/datatype/mdf/audio/dsp/mdfdevsound.cpp,v 
> retrieving revision 1.1.2.16 
> diff -w -u -b -r1.1.2.16 mdfdevsound.cpp 
> --- mdfdevsound.cpp     16 May 2007 22:10:34 -0000     
1.1.2.16 
> +++ mdfdevsound.cpp     11 Jan 2008 22:01:43 -0000 
>  -65,6 +65,7  
>  #include "mdfdebug.h" 
>  #include "CHXMMFDevSound.h" 
>   
> +#include "mdfaudfmt.h" 
>  inline 
>  TUint SamplesToMS(TUint count, TUint rate) 
>  { 
>  -666,7 +667,8  
>      if(m_fourCC == KMMFFourCCCodeAMR    || 
>          m_fourCC == KMMFFourCCCodeAAC   || 
>          m_fourCC == KMMFFourCCCodeAWB   || 
> -        m_fourCC ==  KMMFFourCCCodeAMRW ) 
> +        m_fourCC ==  KMMFFourCCCodeAMRW  || 
> +        m_fourCC ==  KMMFFourCCCodeEAACP) 
>      { 
>          CErrorConcealmentIntfc *ErrCI = 0; 
>          TRAPD(err, (ErrCI = 
> CErrorConcealmentIntfc::NewL(*m_pDevSound))); 
> 
> 
> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev