CR: Add AC3 soft switch for mpgfformat plugin

Hi, eric
ReadPrefBOOL also needs a handle, either IUnknown or
IHXPreferences.
So, I need to add a member variable, and init it inside
InitPlugin.
This time I added an IUnknown and use ReadPrefBOOL to
replace IHXPreferences->ReadPref.
Please see my new diff file.
Thanks for advice.


Best Regards, Zheng, Huan(ZBT)
OTC/SSD/SSG
Intel Aisa-Pacific Research & Developement Ltd
Tel: 021-6116 6435
Inet: 8821 6435
Cub: 3W035
-----Original Message-----
From: Eric Hyche [mailto:ehychereal.com] 
Sent: 2008年3月24日 22:03
To: Zheng, Huan; datatype-devhelixcommunity.org
Cc: helix-client-devhelixcommunity.org; Guo, Young; Shen,
Cathy; Zhao, Halley
Subject: RE: Add AC3 soft switch for mpgfformat plugin


My comments:

+    if (m_pPrefs)
+    {
+        IHXBuffer* pBuffer = NULL;
+        m_pPrefs->ReadPref("AC3Support",
pBuffer);
+        if (pBuffer)
+        {
+            if
(!strcmp("1",pBuffer->GetBuffer()))
+            {

Please use the helper functions in
common/util/hxprefutil.cpp
for this. So you would use ReadPrefBOOL.

 -149,6
+149,7 
       m_pStreamSource (NULL),
       m_pUpgradeCol   (NULL),
       m_pStreamHdrObj (NULL),
+      m_pPrefs        (NULL),
       m_StrmHdrResult (HXR_OK),
       m_State         (Ready),
       m_dNextPts(0.0),
 -270,6
+271,7 
 STDMETHODIMP
 CRnMpgFmt::InitPlugin(IUnknown* pHXCore)
 {
+    pHXCore->QueryInterface(IID_IHXPreferences,
(void**)&m_pPrefs);

The ReadPrefBOOL function takes an Iunknown* context,
so you should not need to provide an IHXPreferences.

 -232,6
+232,7 
 
     UCHAR                   m_bRtp,         // Are we using
rtp transport
                             m_bGetHeader;   // Get the
other stream header        
+    IHXPreferences          *m_pPrefs;

Same comment here: you should not need a IHXPreferences,
since ReadPrefBOOL takes care of QI'ing the context
for IHXPreferences.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Zheng, Huan [mailto:huan.zhengintel.com] 
> Sent: Friday, March 21, 2008 3:16 AM
> To: datatype-devhelixcommunity.org; Eric Hyche
> Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> Cathy; Zhao, Halley; Zheng, Huan
> Subject: CR: Add AC3 soft switch for mpgfformat plugin
> 
> Synopsis:
> 
> Add soft switch for AC3 Support for mpgfformat plugin
> 
> Overview: 
> 
> Currently for mpgfformat.so, there is a hard switch(by
define 
> AC3 or not in rmpgff.cpp) to support AC3 or not.
> 
> Since there is no AC3 codec from helix community, this
switch 
> is off by default.
> 
> But we may have some AC3 codec from 3rd party, so this
soft 
> switch is added to get the on/off state by
ReadPreference interface.
> 
> Files Added:                                    
> 
>     None
> 
> Files Modified:
> 
>     rmpgff.cpp (mpgfformat/mpg/fileformat/rmpgff.cpp)
> 
>     rmpgff.h (mpgfformat/mpg/fileformat/rmpgff.h)
> 
> Image Size and Heap Use impact (Client -Only):
> 
>     little
> 
> Platforms and Profiles Affected:
> 
>     platform:   linux-2.2-libc6-gcc32-i586
> 
>     profile:    helix-client-all-defines
> 
> Distribution Libraries Affected:
> 
>     <mpgfformat.so>
> 
> Distribution library impact and planned action:
> 
>     <None>
> 
> Platforms and Profiles Build Verified:
> 
>     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> 
>     Set Target(s)   -> datatype_mpg_fileformat
> 
>     Set Profile     -> helix-client-all-defines
> 
>     System ID       -> linux-2.2-libc6-gcc32-i586
> 
> Branch: 
> 
>     HEAD, hxclient_3_1_0_atlas
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>   2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>            agreement was received. 
> 
> Files Attached:
> 
> AC3switch.diff
> 
>  
> 
>  
> 
> Best Regards, Zheng, Huan(ZBT)
> 
> OTC/SSD/SSG
> 
> Intel Aisa-Pacific Research & Developement Ltd
> 
> Tel: 021-6116 6435
> 
> Inet: 8821 6435
> 
> Cub: 3W035
> 
>  
> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

My comments:

+    if (m_pPrefs)
+    {
+        IHXBuffer* pBuffer = NULL;
+        m_pPrefs->ReadPref("AC3Support",
pBuffer);
+        if (pBuffer)
+        {
+            if
(!strcmp("1",pBuffer->GetBuffer()))
+            {

Please use the helper functions in
common/util/hxprefutil.cpp
for this. So you would use ReadPrefBOOL.

 -149,6
+149,7 
       m_pStreamSource (NULL),
       m_pUpgradeCol   (NULL),
       m_pStreamHdrObj (NULL),
+      m_pPrefs        (NULL),
       m_StrmHdrResult (HXR_OK),
       m_State         (Ready),
       m_dNextPts(0.0),
 -270,6
+271,7 
 STDMETHODIMP
 CRnMpgFmt::InitPlugin(IUnknown* pHXCore)
 {
+    pHXCore->QueryInterface(IID_IHXPreferences,
(void**)&m_pPrefs);

The ReadPrefBOOL function takes an Iunknown* context,
so you should not need to provide an IHXPreferences.

 -232,6
+232,7 
 
     UCHAR                   m_bRtp,         // Are we using
rtp transport
                             m_bGetHeader;   // Get the
other stream header        
+    IHXPreferences          *m_pPrefs;

Same comment here: you should not need a IHXPreferences,
since ReadPrefBOOL takes care of QI'ing the context
for IHXPreferences.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Zheng, Huan [mailto:huan.zhengintel.com] 
> Sent: Friday, March 21, 2008 3:16 AM
> To: datatype-devhelixcommunity.org; Eric Hyche
> Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> Cathy; Zhao, Halley; Zheng, Huan
> Subject: CR: Add AC3 soft switch for mpgfformat plugin
> 
> Synopsis:
> 
> Add soft switch for AC3 Support for mpgfformat plugin
> 
> Overview: 
> 
> Currently for mpgfformat.so, there is a hard switch(by
define 
> AC3 or not in rmpgff.cpp) to support AC3 or not.
> 
> Since there is no AC3 codec from helix community, this
switch 
> is off by default.
> 
> But we may have some AC3 codec from 3rd party, so this
soft 
> switch is added to get the on/off state by
ReadPreference interface.
> 
> Files Added:                                    
> 
>     None
> 
> Files Modified:
> 
>     rmpgff.cpp (mpgfformat/mpg/fileformat/rmpgff.cpp)
> 
>     rmpgff.h (mpgfformat/mpg/fileformat/rmpgff.h)
> 
> Image Size and Heap Use impact (Client -Only):
> 
>     little
> 
> Platforms and Profiles Affected:
> 
>     platform:   linux-2.2-libc6-gcc32-i586
> 
>     profile:    helix-client-all-defines
> 
> Distribution Libraries Affected:
> 
>     <mpgfformat.so>
> 
> Distribution library impact and planned action:
> 
>     <None>
> 
> Platforms and Profiles Build Verified:
> 
>     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> 
>     Set Target(s)   -> datatype_mpg_fileformat
> 
>     Set Profile     -> helix-client-all-defines
> 
>     System ID       -> linux-2.2-libc6-gcc32-i586
> 
> Branch: 
> 
>     HEAD, hxclient_3_1_0_atlas
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>   2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>            agreement was received. 
> 
> Files Attached:
> 
> AC3switch.diff
> 
>  
> 
>  
> 
> Best Regards, Zheng, Huan(ZBT)
> 
> OTC/SSD/SSG
> 
> Intel Aisa-Pacific Research & Developement Ltd
> 
> Tel: 021-6116 6435
> 
> Inet: 8821 6435
> 
> Cub: 3W035
> 
>  
> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

My comments below...

   -2618,16 +2620,24 
     if (!m_aInfo[FILE_STREAM].ulBitRate)
         return (UINT16)-1;
 
-#if !defined(AC3) &&
!defined(HELIX_FEATURE_MPGFF_LPCM)
+
+    
     // We will not produce AC3, DTS, or LPCM streams now
since we do not
     // have a renderer that supports them.  Keep the stream
stats
     // around since we need them for duration/bitrate.
+    if (m_pContext)
+    {
+        HXBOOL ac3_switch;
+        ReadPrefBOOL(m_pContext, "AC3Support",
ac3_switch);
+        if (ac3_switch)
+        {
     if (eHXMPEG != m_aInfo[AUDIO_STREAM].eAudio)
     {
         //m_aInfo[AUDIO_STREAM].eType = eHXUnknown;
         --m_wStreamCount;
     }
-#endif
+        }
+    }

Please follow coding guidelines in naming variable. So 
"ac3_switch" should probably become
"bAC3Support".
Also, it should be initialized to FALSE, so that it is only
turned on IF the "AC3Support" pref is present AND
set to 1.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Zheng, Huan [mailto:huan.zhengintel.com] 
> Sent: Tuesday, March 25, 2008 10:23 PM
> To: ehychereal.com; datatype-devhelixcommunity.org
> Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> Cathy; Zhao, Halley
> Subject: RE: Add AC3 soft switch for mpgfformat plugin
> 
> Hi, eric
> ReadPrefBOOL also needs a handle, either IUnknown or
IHXPreferences.
> So, I need to add a member variable, and init it inside
InitPlugin.
> This time I added an IUnknown and use ReadPrefBOOL to
replace 
> IHXPreferences->ReadPref.
> Please see my new diff file.
> Thanks for advice.
> 
> 
> Best Regards, Zheng, Huan(ZBT)
> OTC/SSD/SSG
> Intel Aisa-Pacific Research & Developement Ltd
> Tel: 021-6116 6435
> Inet: 8821 6435
> Cub: 3W035
> -----Original Message-----
> From: Eric Hyche [mailto:ehychereal.com] 
> Sent: 2008$BG/(B3$B7n(B24$BF|(B 22:03
> To: Zheng, Huan; datatype-devhelixcommunity.org
> Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> Cathy; Zhao, Halley
> Subject: RE: Add AC3 soft switch for mpgfformat plugin
> 
> 
> My comments:
> 
> +    if (m_pPrefs)
> +    {
> +        IHXBuffer* pBuffer = NULL;
> +        m_pPrefs->ReadPref("AC3Support",
pBuffer);
> +        if (pBuffer)
> +        {
> +            if
(!strcmp("1",pBuffer->GetBuffer()))
> +            {
> 
> Please use the helper functions in
common/util/hxprefutil.cpp
> for this. So you would use ReadPrefBOOL.
> 
>  -149,6 +149,7 
>        m_pStreamSource (NULL),
>        m_pUpgradeCol   (NULL),
>        m_pStreamHdrObj (NULL),
> +      m_pPrefs        (NULL),
>        m_StrmHdrResult (HXR_OK),
>        m_State         (Ready),
>        m_dNextPts(0.0),
>  -270,6 +271,7 
>  STDMETHODIMP
>  CRnMpgFmt::InitPlugin(IUnknown* pHXCore)
>  {
> +    pHXCore->QueryInterface(IID_IHXPreferences,
(void**)&m_pPrefs);
> 
> The ReadPrefBOOL function takes an Iunknown* context,
> so you should not need to provide an IHXPreferences.
> 
>  -232,6 +232,7 
>  
>      UCHAR                   m_bRtp,         // Are we
using 
> rtp transport
>                              m_bGetHeader;   // Get the
other 
> stream header        
> +    IHXPreferences          *m_pPrefs;
> 
> Same comment here: you should not need a
IHXPreferences,
> since ReadPrefBOOL takes care of QI'ing the context
> for IHXPreferences.
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: Zheng, Huan [mailto:huan.zhengintel.com] 
> > Sent: Friday, March 21, 2008 3:16 AM
> > To: datatype-devhelixcommunity.org; Eric
Hyche
> > Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> > Cathy; Zhao, Halley; Zheng, Huan
> > Subject: CR: Add AC3 soft switch for mpgfformat
plugin
> > 
> > Synopsis:
> > 
> > Add soft switch for AC3 Support for mpgfformat
plugin
> > 
> > Overview: 
> > 
> > Currently for mpgfformat.so, there is a hard
switch(by define 
> > AC3 or not in rmpgff.cpp) to support AC3 or not.
> > 
> > Since there is no AC3 codec from helix community,
this switch 
> > is off by default.
> > 
> > But we may have some AC3 codec from 3rd party, so
this soft 
> > switch is added to get the on/off state by
ReadPreference interface.
> > 
> > Files Added:                                    
> > 
> >     None
> > 
> > Files Modified:
> > 
> >     rmpgff.cpp
(mpgfformat/mpg/fileformat/rmpgff.cpp)
> > 
> >     rmpgff.h (mpgfformat/mpg/fileformat/rmpgff.h)
> > 
> > Image Size and Heap Use impact (Client -Only):
> > 
> >     little
> > 
> > Platforms and Profiles Affected:
> > 
> >     platform:   linux-2.2-libc6-gcc32-i586
> > 
> >     profile:    helix-client-all-defines
> > 
> > Distribution Libraries Affected:
> > 
> >     <mpgfformat.so>
> > 
> > Distribution library impact and planned action:
> > 
> >     <None>
> > 
> > Platforms and Profiles Build Verified:
> > 
> >     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> > 
> >     Set Target(s)   -> datatype_mpg_fileformat
> > 
> >     Set Profile     ->
helix-client-all-defines
> > 
> >     System ID       ->
linux-2.2-libc6-gcc32-i586
> > 
> > Branch: 
> > 
> >     HEAD, hxclient_3_1_0_atlas
> > 
> > Copyright assignment: <MUST be one of the
following statements >
> > 
> >   2.      Intel has signed and delivered a Joint
Copyright 
> Assignment
> > 
> >            to RealNetworks, and received
acknowledgment that the 
> > 
> >            agreement was received. 
> > 
> > Files Attached:
> > 
> > AC3switch.diff
> > 
> >  
> > 
> >  
> > 
> > Best Regards, Zheng, Huan(ZBT)
> > 
> > OTC/SSD/SSG
> > 
> > Intel Aisa-Pacific Research & Developement
Ltd
> > 
> > Tel: 021-6116 6435
> > 
> > Inet: 8821 6435
> > 
> > Cub: 3W035
> > 
> >  
> > 
> > 
> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

Changed and committed to atlas.
Thanks for advice!

Best Regards, Zheng, Huan(ZBT)
OTC/SSD/SSG
Intel Aisa-Pacific Research & Developement Ltd
Tel: 021-6116 6435
Inet: 8821 6435
Cub: 3W035
-----Original Message-----
From: Eric Hyche [mailto:ehychereal.com] 
Sent: 2008年3月26日 23:43
To: Zheng, Huan; datatype-devhelixcommunity.org
Cc: helix-client-devhelixcommunity.org; Guo, Young; Shen,
Cathy; Zhao, Halley
Subject: RE: Add AC3 soft switch for mpgfformat plugin


My comments below...

   -2618,16 +2620,24 
     if (!m_aInfo[FILE_STREAM].ulBitRate)
         return (UINT16)-1;
 
-#if !defined(AC3) &&
!defined(HELIX_FEATURE_MPGFF_LPCM)
+
+    
     // We will not produce AC3, DTS, or LPCM streams now
since we do not
     // have a renderer that supports them.  Keep the stream
stats
     // around since we need them for duration/bitrate.
+    if (m_pContext)
+    {
+        HXBOOL ac3_switch;
+        ReadPrefBOOL(m_pContext, "AC3Support",
ac3_switch);
+        if (ac3_switch)
+        {
     if (eHXMPEG != m_aInfo[AUDIO_STREAM].eAudio)
     {
         //m_aInfo[AUDIO_STREAM].eType = eHXUnknown;
         --m_wStreamCount;
     }
-#endif
+        }
+    }

Please follow coding guidelines in naming variable. So 
"ac3_switch" should probably become
"bAC3Support".
Also, it should be initialized to FALSE, so that it is only
turned on IF the "AC3Support" pref is present AND
set to 1.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Zheng, Huan [mailto:huan.zhengintel.com] 
> Sent: Tuesday, March 25, 2008 10:23 PM
> To: ehychereal.com; datatype-devhelixcommunity.org
> Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> Cathy; Zhao, Halley
> Subject: RE: Add AC3 soft switch for mpgfformat plugin
> 
> Hi, eric
> ReadPrefBOOL also needs a handle, either IUnknown or
IHXPreferences.
> So, I need to add a member variable, and init it inside
InitPlugin.
> This time I added an IUnknown and use ReadPrefBOOL to
replace 
> IHXPreferences->ReadPref.
> Please see my new diff file.
> Thanks for advice.
> 
> 
> Best Regards, Zheng, Huan(ZBT)
> OTC/SSD/SSG
> Intel Aisa-Pacific Research & Developement Ltd
> Tel: 021-6116 6435
> Inet: 8821 6435
> Cub: 3W035
> -----Original Message-----
> From: Eric Hyche [mailto:ehychereal.com] 
> Sent: 2008年3月24日 22:03
> To: Zheng, Huan; datatype-devhelixcommunity.org
> Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> Cathy; Zhao, Halley
> Subject: RE: Add AC3 soft switch for mpgfformat plugin
> 
> 
> My comments:
> 
> +    if (m_pPrefs)
> +    {
> +        IHXBuffer* pBuffer = NULL;
> +        m_pPrefs->ReadPref("AC3Support",
pBuffer);
> +        if (pBuffer)
> +        {
> +            if
(!strcmp("1",pBuffer->GetBuffer()))
> +            {
> 
> Please use the helper functions in
common/util/hxprefutil.cpp
> for this. So you would use ReadPrefBOOL.
> 
>  -149,6 +149,7 
>        m_pStreamSource (NULL),
>        m_pUpgradeCol   (NULL),
>        m_pStreamHdrObj (NULL),
> +      m_pPrefs        (NULL),
>        m_StrmHdrResult (HXR_OK),
>        m_State         (Ready),
>        m_dNextPts(0.0),
>  -270,6 +271,7 
>  STDMETHODIMP
>  CRnMpgFmt::InitPlugin(IUnknown* pHXCore)
>  {
> +    pHXCore->QueryInterface(IID_IHXPreferences,
(void**)&m_pPrefs);
> 
> The ReadPrefBOOL function takes an Iunknown* context,
> so you should not need to provide an IHXPreferences.
> 
>  -232,6 +232,7 
>  
>      UCHAR                   m_bRtp,         // Are we
using 
> rtp transport
>                              m_bGetHeader;   // Get the
other 
> stream header        
> +    IHXPreferences          *m_pPrefs;
> 
> Same comment here: you should not need a
IHXPreferences,
> since ReadPrefBOOL takes care of QI'ing the context
> for IHXPreferences.
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: Zheng, Huan [mailto:huan.zhengintel.com] 
> > Sent: Friday, March 21, 2008 3:16 AM
> > To: datatype-devhelixcommunity.org; Eric
Hyche
> > Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> > Cathy; Zhao, Halley; Zheng, Huan
> > Subject: CR: Add AC3 soft switch for mpgfformat
plugin
> > 
> > Synopsis:
> > 
> > Add soft switch for AC3 Support for mpgfformat
plugin
> > 
> > Overview: 
> > 
> > Currently for mpgfformat.so, there is a hard
switch(by define 
> > AC3 or not in rmpgff.cpp) to support AC3 or not.
> > 
> > Since there is no AC3 codec from helix community,
this switch 
> > is off by default.
> > 
> > But we may have some AC3 codec from 3rd party, so
this soft 
> > switch is added to get the on/off state by
ReadPreference interface.
> > 
> > Files Added:                                    
> > 
> >     None
> > 
> > Files Modified:
> > 
> >     rmpgff.cpp
(mpgfformat/mpg/fileformat/rmpgff.cpp)
> > 
> >     rmpgff.h (mpgfformat/mpg/fileformat/rmpgff.h)
> > 
> > Image Size and Heap Use impact (Client -Only):
> > 
> >     little
> > 
> > Platforms and Profiles Affected:
> > 
> >     platform:   linux-2.2-libc6-gcc32-i586
> > 
> >     profile:    helix-client-all-defines
> > 
> > Distribution Libraries Affected:
> > 
> >     <mpgfformat.so>
> > 
> > Distribution library impact and planned action:
> > 
> >     <None>
> > 
> > Platforms and Profiles Build Verified:
> > 
> >     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> > 
> >     Set Target(s)   -> datatype_mpg_fileformat
> > 
> >     Set Profile     ->
helix-client-all-defines
> > 
> >     System ID       ->
linux-2.2-libc6-gcc32-i586
> > 
> > Branch: 
> > 
> >     HEAD, hxclient_3_1_0_atlas
> > 
> > Copyright assignment: <MUST be one of the
following statements >
> > 
> >   2.      Intel has signed and delivered a Joint
Copyright 
> Assignment
> > 
> >            to RealNetworks, and received
acknowledgment that the 
> > 
> >            agreement was received. 
> > 
> > Files Attached:
> > 
> > AC3switch.diff
> > 
> >  
> > 
> >  
> > 
> > Best Regards, Zheng, Huan(ZBT)
> > 
> > OTC/SSD/SSG
> > 
> > Intel Aisa-Pacific Research & Developement
Ltd
> > 
> > Tel: 021-6116 6435
> > 
> > Inet: 8821 6435
> > 
> > Cub: 3W035
> > 
> >  
> > 
> > 
> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

This also should be checked into HEAD as well, if 
you have not already done so.

Thanks,

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Zheng, Huan [mailto:huan.zhengintel.com] 
> Sent: Wednesday, March 26, 2008 9:21 PM
> To: ehychereal.com; datatype-devhelixcommunity.org
> Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> Cathy; Zhao, Halley
> Subject: CN: Add AC3 soft switch for mpgfformat plugin
> 
> Changed and committed to atlas.
> Thanks for advice!
> 
> Best Regards, Zheng, Huan(ZBT)
> OTC/SSD/SSG
> Intel Aisa-Pacific Research & Developement Ltd
> Tel: 021-6116 6435
> Inet: 8821 6435
> Cub: 3W035
> -----Original Message-----
> From: Eric Hyche [mailto:ehychereal.com] 
> Sent: 2008$BG/(B3$B7n(B26$BF|(B 23:43
> To: Zheng, Huan; datatype-devhelixcommunity.org
> Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> Cathy; Zhao, Halley
> Subject: RE: Add AC3 soft switch for mpgfformat plugin
> 
> 
> My comments below...
> 
>    -2618,16 +2620,24 
>      if (!m_aInfo[FILE_STREAM].ulBitRate)
>          return (UINT16)-1;
>  
> -#if !defined(AC3) &&
!defined(HELIX_FEATURE_MPGFF_LPCM)
> +
> +    
>      // We will not produce AC3, DTS, or LPCM streams
now 
> since we do not
>      // have a renderer that supports them.  Keep the
stream stats
>      // around since we need them for
duration/bitrate.
> +    if (m_pContext)
> +    {
> +        HXBOOL ac3_switch;
> +        ReadPrefBOOL(m_pContext,
"AC3Support", ac3_switch);
> +        if (ac3_switch)
> +        {
>      if (eHXMPEG != m_aInfo[AUDIO_STREAM].eAudio)
>      {
>          //m_aInfo[AUDIO_STREAM].eType = eHXUnknown;
>          --m_wStreamCount;
>      }
> -#endif
> +        }
> +    }
> 
> Please follow coding guidelines in naming variable. So

> "ac3_switch" should probably become
"bAC3Support".
> Also, it should be initialized to FALSE, so that it is
only
> turned on IF the "AC3Support" pref is present
AND
> set to 1.
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: Zheng, Huan [mailto:huan.zhengintel.com] 
> > Sent: Tuesday, March 25, 2008 10:23 PM
> > To: ehychereal.com; datatype-devhelixcommunity.org
> > Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> > Cathy; Zhao, Halley
> > Subject: RE: Add AC3 soft switch for mpgfformat
plugin
> > 
> > Hi, eric
> > ReadPrefBOOL also needs a handle, either IUnknown
or IHXPreferences.
> > So, I need to add a member variable, and init it
inside InitPlugin.
> > This time I added an IUnknown and use ReadPrefBOOL
to replace 
> > IHXPreferences->ReadPref.
> > Please see my new diff file.
> > Thanks for advice.
> > 
> > 
> > Best Regards, Zheng, Huan(ZBT)
> > OTC/SSD/SSG
> > Intel Aisa-Pacific Research & Developement
Ltd
> > Tel: 021-6116 6435
> > Inet: 8821 6435
> > Cub: 3W035
> > -----Original Message-----
> > From: Eric Hyche [mailto:ehychereal.com]

> > Sent: 2008$BG/(B3$B7n(B24$BF|(B 22:03
> > To: Zheng, Huan; datatype-devhelixcommunity.org
> > Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> > Cathy; Zhao, Halley
> > Subject: RE: Add AC3 soft switch for mpgfformat
plugin
> > 
> > 
> > My comments:
> > 
> > +    if (m_pPrefs)
> > +    {
> > +        IHXBuffer* pBuffer = NULL;
> > +       
m_pPrefs->ReadPref("AC3Support", pBuffer);
> > +        if (pBuffer)
> > +        {
> > +            if
(!strcmp("1",pBuffer->GetBuffer()))
> > +            {
> > 
> > Please use the helper functions in
common/util/hxprefutil.cpp
> > for this. So you would use ReadPrefBOOL.
> > 
> >  -149,6 +149,7 
> >        m_pStreamSource (NULL),
> >        m_pUpgradeCol   (NULL),
> >        m_pStreamHdrObj (NULL),
> > +      m_pPrefs        (NULL),
> >        m_StrmHdrResult (HXR_OK),
> >        m_State         (Ready),
> >        m_dNextPts(0.0),
> >  -270,6 +271,7 
> >  STDMETHODIMP
> >  CRnMpgFmt::InitPlugin(IUnknown* pHXCore)
> >  {
> > +   
pHXCore->QueryInterface(IID_IHXPreferences,
(void**)&m_pPrefs);
> > 
> > The ReadPrefBOOL function takes an Iunknown*
context,
> > so you should not need to provide an
IHXPreferences.
> > 
> >  -232,6 +232,7 
> >  
> >      UCHAR                   m_bRtp,         //
Are we using 
> > rtp transport
> >                              m_bGetHeader;   //
Get the other 
> > stream header        
> > +    IHXPreferences          *m_pPrefs;
> > 
> > Same comment here: you should not need a
IHXPreferences,
> > since ReadPrefBOOL takes care of QI'ing the
context
> > for IHXPreferences.
> > 
> > Eric
> > 
> > =============================================
> > Eric Hyche (ehychereal.com)
> > Technical Lead
> > RealNetworks, Inc.  
> > 
> > > -----Original Message-----
> > > From: Zheng, Huan [mailto:huan.zhengintel.com] 
> > > Sent: Friday, March 21, 2008 3:16 AM
> > > To: datatype-devhelixcommunity.org; Eric
Hyche
> > > Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> > > Cathy; Zhao, Halley; Zheng, Huan
> > > Subject: CR: Add AC3 soft switch for
mpgfformat plugin
> > > 
> > > Synopsis:
> > > 
> > > Add soft switch for AC3 Support for
mpgfformat plugin
> > > 
> > > Overview: 
> > > 
> > > Currently for mpgfformat.so, there is a hard
switch(by define 
> > > AC3 or not in rmpgff.cpp) to support AC3 or
not.
> > > 
> > > Since there is no AC3 codec from helix
community, this switch 
> > > is off by default.
> > > 
> > > But we may have some AC3 codec from 3rd
party, so this soft 
> > > switch is added to get the on/off state by
ReadPreference 
> interface.
> > > 
> > > Files Added:                                 
  
> > > 
> > >     None
> > > 
> > > Files Modified:
> > > 
> > >     rmpgff.cpp
(mpgfformat/mpg/fileformat/rmpgff.cpp)
> > > 
> > >     rmpgff.h
(mpgfformat/mpg/fileformat/rmpgff.h)
> > > 
> > > Image Size and Heap Use impact (Client
-Only):
> > > 
> > >     little
> > > 
> > > Platforms and Profiles Affected:
> > > 
> > >     platform:   linux-2.2-libc6-gcc32-i586
> > > 
> > >     profile:    helix-client-all-defines
> > > 
> > > Distribution Libraries Affected:
> > > 
> > >     <mpgfformat.so>
> > > 
> > > Distribution library impact and planned
action:
> > > 
> > >     <None>
> > > 
> > > Platforms and Profiles Build Verified:
> > > 
> > >     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> > > 
> > >     Set Target(s)   ->
datatype_mpg_fileformat
> > > 
> > >     Set Profile     ->
helix-client-all-defines
> > > 
> > >     System ID       ->
linux-2.2-libc6-gcc32-i586
> > > 
> > > Branch: 
> > > 
> > >     HEAD, hxclient_3_1_0_atlas
> > > 
> > > Copyright assignment: <MUST be one of the
following statements >
> > > 
> > >   2.      Intel has signed and delivered a
Joint Copyright 
> > Assignment
> > > 
> > >            to RealNetworks, and received
acknowledgment that the 
> > > 
> > >            agreement was received. 
> > > 
> > > Files Attached:
> > > 
> > > AC3switch.diff
> > > 
> > >  
> > > 
> > >  
> > > 
> > > Best Regards, Zheng, Huan(ZBT)
> > > 
> > > OTC/SSD/SSG
> > > 
> > > Intel Aisa-Pacific Research &
Developement Ltd
> > > 
> > > Tel: 021-6116 6435
> > > 
> > > Inet: 8821 6435
> > > 
> > > Cub: 3W035
> > > 
> > >  
> > > 
> > > 
> > 
> > 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

Head is also committed.

Best Regards, Zheng, Huan(ZBT)
OTC/SSD/SSG
Intel Aisa-Pacific Research & Developement Ltd
Tel: 021-6116 6435
Inet: 8821 6435
Cub: 3W035

-----Original Message-----
From: Eric Hyche [mailto:ehychereal.com] 
Sent: 2008年3月27日 20:35
To: Zheng, Huan; datatype-devhelixcommunity.org
Cc: helix-client-devhelixcommunity.org; Guo, Young; Shen,
Cathy; Zhao, Halley
Subject: RE: Add AC3 soft switch for mpgfformat plugin


This also should be checked into HEAD as well, if 
you have not already done so.

Thanks,

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Zheng, Huan [mailto:huan.zhengintel.com] 
> Sent: Wednesday, March 26, 2008 9:21 PM
> To: ehychereal.com; datatype-devhelixcommunity.org
> Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> Cathy; Zhao, Halley
> Subject: CN: Add AC3 soft switch for mpgfformat plugin
> 
> Changed and committed to atlas.
> Thanks for advice!
> 
> Best Regards, Zheng, Huan(ZBT)
> OTC/SSD/SSG
> Intel Aisa-Pacific Research & Developement Ltd
> Tel: 021-6116 6435
> Inet: 8821 6435
> Cub: 3W035
> -----Original Message-----
> From: Eric Hyche [mailto:ehychereal.com] 
> Sent: 2008年3月26日 23:43
> To: Zheng, Huan; datatype-devhelixcommunity.org
> Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> Cathy; Zhao, Halley
> Subject: RE: Add AC3 soft switch for mpgfformat plugin
> 
> 
> My comments below...
> 
>    -2618,16 +2620,24 
>      if (!m_aInfo[FILE_STREAM].ulBitRate)
>          return (UINT16)-1;
>  
> -#if !defined(AC3) &&
!defined(HELIX_FEATURE_MPGFF_LPCM)
> +
> +    
>      // We will not produce AC3, DTS, or LPCM streams
now 
> since we do not
>      // have a renderer that supports them.  Keep the
stream stats
>      // around since we need them for
duration/bitrate.
> +    if (m_pContext)
> +    {
> +        HXBOOL ac3_switch;
> +        ReadPrefBOOL(m_pContext,
"AC3Support", ac3_switch);
> +        if (ac3_switch)
> +        {
>      if (eHXMPEG != m_aInfo[AUDIO_STREAM].eAudio)
>      {
>          //m_aInfo[AUDIO_STREAM].eType = eHXUnknown;
>          --m_wStreamCount;
>      }
> -#endif
> +        }
> +    }
> 
> Please follow coding guidelines in naming variable. So

> "ac3_switch" should probably become
"bAC3Support".
> Also, it should be initialized to FALSE, so that it is
only
> turned on IF the "AC3Support" pref is present
AND
> set to 1.
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: Zheng, Huan [mailto:huan.zhengintel.com] 
> > Sent: Tuesday, March 25, 2008 10:23 PM
> > To: ehychereal.com; datatype-devhelixcommunity.org
> > Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> > Cathy; Zhao, Halley
> > Subject: RE: Add AC3 soft switch for mpgfformat
plugin
> > 
> > Hi, eric
> > ReadPrefBOOL also needs a handle, either IUnknown
or IHXPreferences.
> > So, I need to add a member variable, and init it
inside InitPlugin.
> > This time I added an IUnknown and use ReadPrefBOOL
to replace 
> > IHXPreferences->ReadPref.
> > Please see my new diff file.
> > Thanks for advice.
> > 
> > 
> > Best Regards, Zheng, Huan(ZBT)
> > OTC/SSD/SSG
> > Intel Aisa-Pacific Research & Developement
Ltd
> > Tel: 021-6116 6435
> > Inet: 8821 6435
> > Cub: 3W035
> > -----Original Message-----
> > From: Eric Hyche [mailto:ehychereal.com]

> > Sent: 2008年3月24日 22:03
> > To: Zheng, Huan; datatype-devhelixcommunity.org
> > Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> > Cathy; Zhao, Halley
> > Subject: RE: Add AC3 soft switch for mpgfformat
plugin
> > 
> > 
> > My comments:
> > 
> > +    if (m_pPrefs)
> > +    {
> > +        IHXBuffer* pBuffer = NULL;
> > +       
m_pPrefs->ReadPref("AC3Support", pBuffer);
> > +        if (pBuffer)
> > +        {
> > +            if
(!strcmp("1",pBuffer->GetBuffer()))
> > +            {
> > 
> > Please use the helper functions in
common/util/hxprefutil.cpp
> > for this. So you would use ReadPrefBOOL.
> > 
> >  -149,6 +149,7 
> >        m_pStreamSource (NULL),
> >        m_pUpgradeCol   (NULL),
> >        m_pStreamHdrObj (NULL),
> > +      m_pPrefs        (NULL),
> >        m_StrmHdrResult (HXR_OK),
> >        m_State         (Ready),
> >        m_dNextPts(0.0),
> >  -270,6 +271,7 
> >  STDMETHODIMP
> >  CRnMpgFmt::InitPlugin(IUnknown* pHXCore)
> >  {
> > +   
pHXCore->QueryInterface(IID_IHXPreferences,
(void**)&m_pPrefs);
> > 
> > The ReadPrefBOOL function takes an Iunknown*
context,
> > so you should not need to provide an
IHXPreferences.
> > 
> >  -232,6 +232,7 
> >  
> >      UCHAR                   m_bRtp,         //
Are we using 
> > rtp transport
> >                              m_bGetHeader;   //
Get the other 
> > stream header        
> > +    IHXPreferences          *m_pPrefs;
> > 
> > Same comment here: you should not need a
IHXPreferences,
> > since ReadPrefBOOL takes care of QI'ing the
context
> > for IHXPreferences.
> > 
> > Eric
> > 
> > =============================================
> > Eric Hyche (ehychereal.com)
> > Technical Lead
> > RealNetworks, Inc.  
> > 
> > > -----Original Message-----
> > > From: Zheng, Huan [mailto:huan.zhengintel.com] 
> > > Sent: Friday, March 21, 2008 3:16 AM
> > > To: datatype-devhelixcommunity.org; Eric
Hyche
> > > Cc: helix-client-devhelixcommunity.org; Guo,
Young; Shen, 
> > > Cathy; Zhao, Halley; Zheng, Huan
> > > Subject: CR: Add AC3 soft switch for
mpgfformat plugin
> > > 
> > > Synopsis:
> > > 
> > > Add soft switch for AC3 Support for
mpgfformat plugin
> > > 
> > > Overview: 
> > > 
> > > Currently for mpgfformat.so, there is a hard
switch(by define 
> > > AC3 or not in rmpgff.cpp) to support AC3 or
not.
> > > 
> > > Since there is no AC3 codec from helix
community, this switch 
> > > is off by default.
> > > 
> > > But we may have some AC3 codec from 3rd
party, so this soft 
> > > switch is added to get the on/off state by
ReadPreference 
> interface.
> > > 
> > > Files Added:                                 
  
> > > 
> > >     None
> > > 
> > > Files Modified:
> > > 
> > >     rmpgff.cpp
(mpgfformat/mpg/fileformat/rmpgff.cpp)
> > > 
> > >     rmpgff.h
(mpgfformat/mpg/fileformat/rmpgff.h)
> > > 
> > > Image Size and Heap Use impact (Client
-Only):
> > > 
> > >     little
> > > 
> > > Platforms and Profiles Affected:
> > > 
> > >     platform:   linux-2.2-libc6-gcc32-i586
> > > 
> > >     profile:    helix-client-all-defines
> > > 
> > > Distribution Libraries Affected:
> > > 
> > >     <mpgfformat.so>
> > > 
> > > Distribution library impact and planned
action:
> > > 
> > >     <None>
> > > 
> > > Platforms and Profiles Build Verified:
> > > 
> > >     Set BIF branch  ->
hxclient_3_1_0_atlas_restricted
> > > 
> > >     Set Target(s)   ->
datatype_mpg_fileformat
> > > 
> > >     Set Profile     ->
helix-client-all-defines
> > > 
> > >     System ID       ->
linux-2.2-libc6-gcc32-i586
> > > 
> > > Branch: 
> > > 
> > >     HEAD, hxclient_3_1_0_atlas
> > > 
> > > Copyright assignment: <MUST be one of the
following statements >
> > > 
> > >   2.      Intel has signed and delivered a
Joint Copyright 
> > Assignment
> > > 
> > >            to RealNetworks, and received
acknowledgment that the 
> > > 
> > >            agreement was received. 
> > > 
> > > Files Attached:
> > > 
> > > AC3switch.diff
> > > 
> > >  
> > > 
> > >  
> > > 
> > > Best Regards, Zheng, Huan(ZBT)
> > > 
> > > OTC/SSD/SSG
> > > 
> > > Intel Aisa-Pacific Research &
Developement Ltd
> > > 
> > > Tel: 021-6116 6435
> > > 
> > > Inet: 8821 6435
> > > 
> > > Cub: 3W035
> > > 
> > >  
> > > 
> > > 
> > 
> > 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev