RE: CR: RESEND symbian mmp build fix

Looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounceshelixcommunity.org 
> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> Ashish.As.Guptanokia.com
> Sent: Tuesday, April 08, 2008 10:20 AM
> To: Ashish.As.Guptanokia.com; datatype-devhelixcommunity.org
> Subject: RE: [datatype-dev] CR: RESEND symbian mmp
build fix
> 
>  
> 
> ________________________________
> 
> From: datatype-dev-bounceshelixcommunity.org 
> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> ext Ashish.As.Guptanokia.com
> Sent: Monday, April 07, 2008 10:32 AM
> To: datatype-devhelixcommunity.org
> Subject: [datatype-dev] CR: symbian mmp build fix
> 
> 
> Symbian MMP build break.
>  
> Nokia submits this code under the terms of a commercial

> contribution agreement with RealNetworks, and I am
authorized 
> to contribute this code under said agreement."
>  
> Modified by: ashish.as.guptanokia.com
>  
> Reviewed by: 
>  
> Date: 07-Apr-2008
>  
> Project: SymbianMmf_wm
>  
> TSW-Id: SUB 409-795
>  
> Synopsis: 
>  
> MMP build breaks due to absense of HXEXPORT macro.
>  
> Files Modified:
>  
> datatype/aac/fileformat/aacffdll.cpp
>  
> Image Size and Heap Use impact: none
>  
> Module Release testing (STIF): Yes.
>  
> Test case(s) Added: none
>  
> Memory leak check performed: Yes, no new leaks
introduced.
>  
> Platforms and Profiles Build Verified: 
>  
> armv5 / helix-client-s60-50-mmf-mdf-arm
>  
> winscw / helix-client-s60-50-mmf-mdf-arm
>  
> Platforms and Profiles Functionality verified: 
>  
> armv5 / helix-client-s60-50-mmf-mdf-arm
>  
> winscw / helix-client-s60-50-mmf-mdf-arm
>  
> Branch: 
>  
> HEAD, hxclient_2_1_0_cayennes
>  
> cvs diff: Diffing .
>  
> Index: aacffdll.cpp
>  
>
============================================================
=======
>  
> RCS file:
/cvsroot/datatype/aac/fileformat/aacffdll.cpp,v
>  
> retrieving revision 1.6
>  
> diff -u -w -r1.6 aacffdll.cpp
>  
> --- aacffdll.cpp 14 Feb 2005 15:07:40 -0000 1.6
>  
> +++ aacffdll.cpp 7 Apr 2008 15:08:59 -0000
>  
>  -59,12 +59,12 
>  
> static const char HX_THIS_FILE[] = __FILE__;
>  
> #endif
>  
> -STDAPI ENTRYPOINT(HXCREATEINSTANCE)(IUnknown**
ppIUnknown)
>  
> +STDAPI HXEXPORT
ENTRYPOINT(HXCREATEINSTANCE)(IUnknown** ppIUnknown)
>  
> {
>  
> return CAACFileFormat::HXCreateInstance(ppIUnknown);
>  
> }
>  
> -STDAPI ENTRYPOINT(CanUnload)(void)
>  
> +STDAPI HXEXPORT ENTRYPOINT(CanUnload)(void)
>  
> {
>  
> return (CHXBaseCountingObject::ObjectsActive() > 0 ?
HXR_FAIL 
> : HXR_OK);
>  
> }
>  
> cvs diff: Diffing platform
>  
> cvs diff: Diffing platform/win32
>  
> cvs diff: Diffing pub
> 
> 

_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

RE: CR: RESEND symbian mmp build fix

Thread: RE: CR: RESEND symbian mmp build fix