CR: QT_MAX_SEEK_SKIPBACK_TIME_CLIENT constant changed to a smaller value to avoid out

Looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: nokia-private-dev-bounceshelixcommunity.org 
> [mailto:nokia-private-dev-bounceshelixcommunity.org] On 
> Behalf Of saleem.adookkattilnokia.com
> Sent: Tuesday, April 15, 2008 1:14 PM
> To: datatype-devhelixcommunity.org; 
> nokia-private-devhelixcommunity.org
> Subject: [Nokia-private-dev] CR: 
> QT_MAX_SEEK_SKIPBACK_TIME_CLIENT constantchanged to a
smaller 
> value to avoid out of memory failure onlow memory
devices
> 
> "Nokia submits this code under the terms of a
commercial 
> contribution agreement 
> with RealNetworks, and I am authorized to contribute
this 
> code under said agreement." 
> 
> Modified by: saleem.adookkattilnokia.com 
>   
> Reviewed by:  
> 
> Date: 15-April-2008 
>   
> Project: SymbianMmf_Rel 
> 
> TSW: ESNG-7CVPFE 
> 
> Synopsis: QT_MAX_SEEK_SKIPBACK_TIME_CLIENT constant
changed 
> to a smaller value to avoid out of memory failure on
low 
> memory devices.
> 
> Overview: Current 300000 milliseconds value of 
> QT_MAX_SEEK_SKIPBACK_TIME_CLIENT constant needs memory
to 
> buffer 300000 milliseconds of video before start
rendering 
> it. It causes out of memory failure on low memory
devices.  
> Modified below specified file as given in the diff file
to 
> set a smaller value (20000 milliseconds) to 
> QT_MAX_SEEK_SKIPBACK_TIME_CLIENT.
> 
>   
> Files Modified: 
>   
> /cvsroot/datatype/mp4/fileformat/qttrack.cpp 
> 
> Image Size and Heap Use impact: None 
>   
> Module Release testing (STIF) : Pass 
>   
> Test case(s) Added  :  No 
> 
> Memory leak check performed : No new leaks introduced. 

> 
> Platforms and Profiles Build Verified: 
> Profile -> helix-client-s60-32-mmf-mdf-arm 
> BIF branch  -> helix_restricted 
> SYSTEM_ID -> symbian-91-armv5 
> Target -> symbianMmf_rel 
>   
> Platforms and Profiles Functionality verified: armv5,
winscw 
>   
> Branch: 221CayS, 210CayS &  head 
> 
> Index: qttrack.cpp 
>
============================================================
======= 
> RCS file:
/cvsroot/datatype/mp4/fileformat/qttrack.cpp,v 
> retrieving revision 1.27.2.2 
> diff -u -w -r1.27.2.2 qttrack.cpp 
> --- qttrack.cpp 22 Nov 2007 01:29:24 -0000     
1.27.2.2 
> +++ qttrack.cpp 15 Apr 2008 17:12:17 -0000 
>  -39,7 +39,11  
>  // #define _LOG_DATA_ACCESS 
>  #define QTTRACKCACHE_PAGE_SIZE 0x0000FFFF 
>   
> +#ifdef HELIX_FEATURE_MIN_HEAP 
> +#define QT_MAX_SEEK_SKIPBACK_TIME_CLIENT       20000  
// 
> milliseconds 
> +#else 
>  #define QT_MAX_SEEK_SKIPBACK_TIME_CLIENT       300000 
 // 
> milliseconds 
> +#endif 
>  #define QT_MAX_SEEK_SKIPBACKAHEAD_RATIO_CLIENT 20 
>  #define QT_MAX_SEEK_SKIPBACK_TIME_SERVER       10000  
// 
> milliseconds 
>  #define QT_MAX_SEEK_SKIPBACKAHEAD_RATIO_SERVER 5      

> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev