CR: mpeg2 layer 3 audio support in mp4 splitter

This change look good. Ok for checkin
to HEAD and hxclient_3_1_0_atlas.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounceshelixcommunity.org 
> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> Chen, Weian
> Sent: Wednesday, April 16, 2008 8:38 AM
> To: datatype-devhelixcommunity.org
> Cc: Shen, Cathy
> Subject: [datatype-dev] CR: mpeg2 layer 3 audio support
in 
> mp4 splitter
> 
> Synopsis: 
> 
>   Mpeg2 layer 3 audio support in mp4 splitter
> 
>  
> 
> Overview: 
> 
>   When the audio profile object indication is 
> MP4OBJ_AUDIO_ISO_IEC_13818_3, it can not be handled by
mp4 
> splitter, and the default audio mime type 
> audio/X-RN-MP4-RAWAU is assigned to the audio stream,
but 
> actually it is an mpeg2 audio, which makes the player 
> crashed. And here when we find the audio profile object

> indication is MP4OBJ_AUDIO_ISO_IEC_13818_3, we set its
mime 
> type with value audio/MPEG-ELEMENTARY, and then the
stream 
> can be played back successfully.
> 
>  
> 
> Files Added:
> 
>   None
> 
>  
> 
> Files Modified:
> 
>   datatype/mp4/fileformat/qtatmmgs.cpp
> 
>  
> 
> Image Size and Heap Use impact (Client -Only):
> 
>   Little
> 
>  
> 
> Platforms and Profiles Affected:
> 
>   platform:   linux-2.2-libc6-gcc32-i586
> 
>   profile:      helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>   <mp4fformat.so>
> 
>  
> 
> Distribution library impact and planned action:
> 
>   <None>
> 
>  
> 
> Platforms and Profiles Build Verified:
> 
>   Set BIF branch    ->
hxclient_3_1_0_atlas_restricted
> 
>   Set Target(s)      -> datatype_mp4_fileformat
> 
>   Set Profile        -> helix-client-all-defines
> 
>   System ID        -> linux-2.2-libc6-gcc32-i586
> 
>  
> 
> Branch: 
> 
>   HEAD, hxclient_3_1_0_atlas
> 
>  
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>  
> 
> 2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>  
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>  
> 
>            agreement was received. 
> 
>  
> 
> Files Attached:
> 
>   datatype-mp4splitter-audio-qtatmmgs.diff
> 
>  
> 
> Weian
> 
>  
> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

Commit to HEAD and hxclient_3_1_0_atlas branch.

Weian
-----Original Message-----
From: Eric Hyche [mailto:ehychereal.com] 
Sent: 2008年4月16日 20:52
To: Chen, Weian; datatype-devhelixcommunity.org
Cc: Shen, Cathy
Subject: RE: [datatype-dev] CR: mpeg2 layer 3 audio support
in mp4 splitter


This change look good. Ok for checkin
to HEAD and hxclient_3_1_0_atlas.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: datatype-dev-bounceshelixcommunity.org 
> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> Chen, Weian
> Sent: Wednesday, April 16, 2008 8:38 AM
> To: datatype-devhelixcommunity.org
> Cc: Shen, Cathy
> Subject: [datatype-dev] CR: mpeg2 layer 3 audio support
in 
> mp4 splitter
> 
> Synopsis: 
> 
>   Mpeg2 layer 3 audio support in mp4 splitter
> 
>  
> 
> Overview: 
> 
>   When the audio profile object indication is 
> MP4OBJ_AUDIO_ISO_IEC_13818_3, it can not be handled by
mp4 
> splitter, and the default audio mime type 
> audio/X-RN-MP4-RAWAU is assigned to the audio stream,
but 
> actually it is an mpeg2 audio, which makes the player 
> crashed. And here when we find the audio profile object

> indication is MP4OBJ_AUDIO_ISO_IEC_13818_3, we set its
mime 
> type with value audio/MPEG-ELEMENTARY, and then the
stream 
> can be played back successfully.
> 
>  
> 
> Files Added:
> 
>   None
> 
>  
> 
> Files Modified:
> 
>   datatype/mp4/fileformat/qtatmmgs.cpp
> 
>  
> 
> Image Size and Heap Use impact (Client -Only):
> 
>   Little
> 
>  
> 
> Platforms and Profiles Affected:
> 
>   platform:   linux-2.2-libc6-gcc32-i586
> 
>   profile:      helix-client-all-defines
> 
>  
> 
> Distribution Libraries Affected:
> 
>   <mp4fformat.so>
> 
>  
> 
> Distribution library impact and planned action:
> 
>   <None>
> 
>  
> 
> Platforms and Profiles Build Verified:
> 
>   Set BIF branch    ->
hxclient_3_1_0_atlas_restricted
> 
>   Set Target(s)      -> datatype_mp4_fileformat
> 
>   Set Profile        -> helix-client-all-defines
> 
>   System ID        -> linux-2.2-libc6-gcc32-i586
> 
>  
> 
> Branch: 
> 
>   HEAD, hxclient_3_1_0_atlas
> 
>  
> 
> Copyright assignment: <MUST be one of the following
statements >
> 
>  
> 
> 2.      Intel has signed and delivered a Joint
Copyright Assignment
> 
>  
> 
>            to RealNetworks, and received acknowledgment
that the 
> 
>  
> 
>            agreement was received. 
> 
>  
> 
> Files Attached:
> 
>   datatype-mp4splitter-audio-qtatmmgs.diff
> 
>  
> 
> Weian
> 
>  
> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

Weian,

Does this fix any of the filed bugs in the midplayer-private
project?

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Chen, Weian [mailto:weian.chenintel.com] 
> Sent: Wednesday, April 16, 2008 9:44 AM
> To: ehychereal.com; datatype-devhelixcommunity.org
> Cc: Guo, Young; Shen, Cathy; Mei, Jianfeng
> Subject: [datatype-dev] CN: mpeg2 layer 3 audio support
in 
> mp4 splitter
> 
> 
> Commit to HEAD and hxclient_3_1_0_atlas branch.
> 
> Weian
> -----Original Message-----
> From: Eric Hyche [mailto:ehychereal.com] 
> Sent: 2008$BG/(B4$B7n(B16$BF|(B 20:52
> To: Chen, Weian; datatype-devhelixcommunity.org
> Cc: Shen, Cathy
> Subject: RE: [datatype-dev] CR: mpeg2 layer 3 audio
support 
> in mp4 splitter
> 
> 
> This change look good. Ok for checkin
> to HEAD and hxclient_3_1_0_atlas.
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: datatype-dev-bounceshelixcommunity.org 
> > [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> > Chen, Weian
> > Sent: Wednesday, April 16, 2008 8:38 AM
> > To: datatype-devhelixcommunity.org
> > Cc: Shen, Cathy
> > Subject: [datatype-dev] CR: mpeg2 layer 3 audio
support in 
> > mp4 splitter
> > 
> > Synopsis: 
> > 
> >   Mpeg2 layer 3 audio support in mp4 splitter
> > 
> >  
> > 
> > Overview: 
> > 
> >   When the audio profile object indication is 
> > MP4OBJ_AUDIO_ISO_IEC_13818_3, it can not be
handled by mp4 
> > splitter, and the default audio mime type 
> > audio/X-RN-MP4-RAWAU is assigned to the audio
stream, but 
> > actually it is an mpeg2 audio, which makes the
player 
> > crashed. And here when we find the audio profile
object 
> > indication is MP4OBJ_AUDIO_ISO_IEC_13818_3, we set
its mime 
> > type with value audio/MPEG-ELEMENTARY, and then
the stream 
> > can be played back successfully.
> > 
> >  
> > 
> > Files Added:
> > 
> >   None
> > 
> >  
> > 
> > Files Modified:
> > 
> >   datatype/mp4/fileformat/qtatmmgs.cpp
> > 
> >  
> > 
> > Image Size and Heap Use impact (Client -Only):
> > 
> >   Little
> > 
> >  
> > 
> > Platforms and Profiles Affected:
> > 
> >   platform:   linux-2.2-libc6-gcc32-i586
> > 
> >   profile:      helix-client-all-defines
> > 
> >  
> > 
> > Distribution Libraries Affected:
> > 
> >   <mp4fformat.so>
> > 
> >  
> > 
> > Distribution library impact and planned action:
> > 
> >   <None>
> > 
> >  
> > 
> > Platforms and Profiles Build Verified:
> > 
> >   Set BIF branch    ->
hxclient_3_1_0_atlas_restricted
> > 
> >   Set Target(s)      ->
datatype_mp4_fileformat
> > 
> >   Set Profile        ->
helix-client-all-defines
> > 
> >   System ID        ->
linux-2.2-libc6-gcc32-i586
> > 
> >  
> > 
> > Branch: 
> > 
> >   HEAD, hxclient_3_1_0_atlas
> > 
> >  
> > 
> > Copyright assignment: <MUST be one of the
following statements >
> > 
> >  
> > 
> > 2.      Intel has signed and delivered a Joint
Copyright Assignment
> > 
> >  
> > 
> >            to RealNetworks, and received
acknowledgment that the 
> > 
> >  
> > 
> >            agreement was received. 
> > 
> >  
> > 
> > Files Attached:
> > 
> >   datatype-mp4splitter-audio-qtatmmgs.diff
> > 
> >  
> > 
> > Weian
> > 
> >  
> > 
> > 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev

Eric:

Part of bug https://bugs.helixcommunity.org/show_bug.cgi?id=7
975&link=0 is fixed (The MPEG4 splitter incorrectly
recognize MP3 as AAC sometime), and I am investigating on
the rest part.

Thanks!
Weian
-----Original Message-----
From: Eric Hyche [mailto:ehychereal.com] 
Sent: 2008年4月16日 23:00
To: Chen, Weian; datatype-devhelixcommunity.org
Cc: Guo, Young; Shen, Cathy; Mei, Jianfeng
Subject: RE: [datatype-dev] CN: mpeg2 layer 3 audio support
in mp4 splitter


Weian,

Does this fix any of the filed bugs in the midplayer-private
project?

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Chen, Weian [mailto:weian.chenintel.com] 
> Sent: Wednesday, April 16, 2008 9:44 AM
> To: ehychereal.com; datatype-devhelixcommunity.org
> Cc: Guo, Young; Shen, Cathy; Mei, Jianfeng
> Subject: [datatype-dev] CN: mpeg2 layer 3 audio support
in 
> mp4 splitter
> 
> 
> Commit to HEAD and hxclient_3_1_0_atlas branch.
> 
> Weian
> -----Original Message-----
> From: Eric Hyche [mailto:ehychereal.com] 
> Sent: 2008年4月16日 20:52
> To: Chen, Weian; datatype-devhelixcommunity.org
> Cc: Shen, Cathy
> Subject: RE: [datatype-dev] CR: mpeg2 layer 3 audio
support 
> in mp4 splitter
> 
> 
> This change look good. Ok for checkin
> to HEAD and hxclient_3_1_0_atlas.
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: datatype-dev-bounceshelixcommunity.org 
> > [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of 
> > Chen, Weian
> > Sent: Wednesday, April 16, 2008 8:38 AM
> > To: datatype-devhelixcommunity.org
> > Cc: Shen, Cathy
> > Subject: [datatype-dev] CR: mpeg2 layer 3 audio
support in 
> > mp4 splitter
> > 
> > Synopsis: 
> > 
> >   Mpeg2 layer 3 audio support in mp4 splitter
> > 
> >  
> > 
> > Overview: 
> > 
> >   When the audio profile object indication is 
> > MP4OBJ_AUDIO_ISO_IEC_13818_3, it can not be
handled by mp4 
> > splitter, and the default audio mime type 
> > audio/X-RN-MP4-RAWAU is assigned to the audio
stream, but 
> > actually it is an mpeg2 audio, which makes the
player 
> > crashed. And here when we find the audio profile
object 
> > indication is MP4OBJ_AUDIO_ISO_IEC_13818_3, we set
its mime 
> > type with value audio/MPEG-ELEMENTARY, and then
the stream 
> > can be played back successfully.
> > 
> >  
> > 
> > Files Added:
> > 
> >   None
> > 
> >  
> > 
> > Files Modified:
> > 
> >   datatype/mp4/fileformat/qtatmmgs.cpp
> > 
> >  
> > 
> > Image Size and Heap Use impact (Client -Only):
> > 
> >   Little
> > 
> >  
> > 
> > Platforms and Profiles Affected:
> > 
> >   platform:   linux-2.2-libc6-gcc32-i586
> > 
> >   profile:      helix-client-all-defines
> > 
> >  
> > 
> > Distribution Libraries Affected:
> > 
> >   <mp4fformat.so>
> > 
> >  
> > 
> > Distribution library impact and planned action:
> > 
> >   <None>
> > 
> >  
> > 
> > Platforms and Profiles Build Verified:
> > 
> >   Set BIF branch    ->
hxclient_3_1_0_atlas_restricted
> > 
> >   Set Target(s)      ->
datatype_mp4_fileformat
> > 
> >   Set Profile        ->
helix-client-all-defines
> > 
> >   System ID        ->
linux-2.2-libc6-gcc32-i586
> > 
> >  
> > 
> > Branch: 
> > 
> >   HEAD, hxclient_3_1_0_atlas
> > 
> >  
> > 
> > Copyright assignment: <MUST be one of the
following statements >
> > 
> >  
> > 
> > 2.      Intel has signed and delivered a Joint
Copyright Assignment
> > 
> >  
> > 
> >            to RealNetworks, and received
acknowledgment that the 
> > 
> >  
> > 
> >            agreement was received. 
> > 
> >  
> > 
> > Files Attached:
> > 
> >   datatype-mp4splitter-audio-qtatmmgs.diff
> > 
> >  
> > 
> > Weian
> > 
> >  
> > 
> > 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev