Thanks Eric,
Changes are checked into Head, Atlas_310 and Cayennes_210
after
incorporating the change suggested by you.
Thanks,
Anshuman
----- Original Message -----
From: "Eric Hyche" <ehyche real.com>
To: "'Anshuman Singh'" <asinghreal.com>; "'datatype-dev'"
<datatype-devhelixcommunity.org>
Sent: Friday, May 02, 2008 3:42 AM
Subject: RE: RESEND: [datatype-dev] CR: Changes in
datatype/wm/common to
fixesthecrashof Helix while trying to play WM files
onSymbianplatformwith
realignment checking ON
>
> + memcpy((BYTE*) pTmpWChar, *ppBuf,
ulNumWideChar*2);
>
> I think this should be ulNumWideChar * sizeof(wchar_t)
instead
> of ulNumWideChar*2. The size of wchar_t is not always 2
bytes.
> It's actually 4 bytes on Linux.
>
> Rest looks good.
>
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.
>
>> -----Original Message-----
>> From: datatype-dev-bounceshelixcommunity.org
>> [mailto:datatype-dev-bounceshelixcommunity.org] On
Behalf Of
>> Anshuman Singh
>> Sent: Wednesday, April 30, 2008 8:56 AM
>> To: 'datatype-dev'
>> Subject: RESEND: [datatype-dev] CR: Changes in
>> datatype/wm/common to fixes thecrashof Helix while
trying to
>> play WM files on Symbianplatformwith realignment
checking ON
>>
>> Synopsis:
>> This change fixes the crash of Helix while trying
to play WM
>> files on Symbian based platforms with realignment
checking ON.
>>
>> Overview:
>> Using wide character pointer instead of BYTE
pointer fixes
>> the issue as it allows only even addesses to be
assigned to
>> metadata string pointer.
>>
>> Files Added:
>> none
>>
>> Files Modified:
>> datatype/wm/common/parse_asf_objects.cpp
>>
>> Image Size and Heap Use impact (Client -Only):
>> None.
>>
>> Platforms and Profiles Affected:
>> platform : win32-i386-vc7
>> profile : helix-client-all-defines
>>
>> Distribution Libraries Affected:
>> None
>>
>> Distribution library impact and planned action:
>> None
>>
>> Platforms and Profiles Build Verified:
>>
>> BIF branch ->
hxclient_3_1_0_atlas_restricted,
>> hxclient_2_1_0_cayennes
>> Target(s) -> splay
>> Profile -> helix-client-all-defines
>> System ID -> win32-i386-vc7
>>
>> Note: Branch:
>> Atlas310
>>
>> Files Attached:
>> parse_asf_objects.cpp_diff.txt
>>
>> Thanks & Regards
>> Anshuman
>>
>> ________________________________
>>
>> _______________________________________________
>> Datatype-dev mailing list
>> Datatype-devhelixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
>>
>>
>
>
> _______________________________________________
> Datatype-dev mailing list
> Datatype-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
_______________________________________________
Datatype-dev mailing list
Datatype-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/da
tatype-dev
|
