Re: Re: CR: Fix for PR: 182453 [Server HBF when sending a SETUP request with x-wap-

Looks good to me too with Jamie's comment.

--greg.


Jamie Gordon wrote:
> Oops, attaching original CR.
> 
> Jamie Gordon wrote:
>> [Forwarding to filesystem-dev as Vijendra's having
trouble posting to
>> this list]
>>
>> This looks fine to me, with one minor change:
>>
>>  > -
>>  > +    HX_UNLOCK(m_pMutex);
>>  >      _DoSomeReadingFromSocket(TRUE);
>>  > +    HX_LOCK(m_pMutex);
>>  >
>>  >      HX_UNLOCK(m_pMutex);
>>  >      HX_RESULT ReadErr =
ProcessPendingReads();
>>
>> No point locking on one line and unlocking the
next, you should just
>> remove that unlock rather than adding a lock.
>>
>> Jamie
>>
>> vijendrakrishnaareal.com wrote:
>>
>>>
>>> Synopsis
>>> ---------
>>>
>>>
>>> This CR includes fix for PR: 182453: Server HBF
when sending a SETUP
>>> request with x-wap-profile headers.
>>>
>>> Quick links to the PR:
>>> https://bugs.dev.prognet.com/show_bug.cgi?id=18245
3&link=0
>>>
>>> Branch:  HEAD
>>>
>>> Suggested Reviewer: Darrick
>>>
>>> Description
>>> ------------
>>>
>>> The problem is coming when we are sending
x-wap-profile header in setup
>>> request. This time it takes the URL specified
in request and tries to
>>> download the file. This is an HTTP URL.
>>>
>>> The problem is that the server blocking
indefinitely. I found the 
>>> problem
>>> is in _doSomeReadingFromSocket () function of
httpfsys.cpp file. Here it
>>> tries to lock the mutex which was previously
locked by the caller of 
>>> this
>>> function. So it was waiting indefinitely to get
lock on mutex which 
>>> result
>>> in server giving HBF.
>>>
>>>
>>> Fix
>>> -------
>>>
>>> Unlock the lock on mutex before calling
_doSomeReadingFromSocket () and
>>> lock it again after called. Changes done at all
places wherever
>>> _doSomeReadingFromSocket () get called.
>>>
>>>
>>> Files Affected
>>> -----------------
>>>
>>> filesystem/http/httpfsys.cpp
>>>
>>> Testing Performed
>>> -------------------
>>>
>>>
>>> Functional Tests:
>>> ------------------
>>>
>>> - Verified by sending setup request with
x-wap-profile and getting
>>> response back and server not giving HBF.
>>>
>>>
>>> Integration Tests:
>>> - None
>>>
>>>
>>> Leak Tests:
>>> - None
>>>
>>> Performance Tests:
>>>
>>> - None
>>>
>>>
>>> Build Verified:
>>> ---------------
>>> win32-i386-vc7
>>> linux-rhel4-i686
>>> sunos-5.10-sparc-server
>>>
>>>
>>> Platform Tested:
>>> ----------------
>>> win32-i386-vc7
>>> linux-rhel4-i686
>>>
>>> QA hints
>>> --------
>>>
>>> - None.
>>>
>>> Thanks
>>>
>>> Vijendra.
>>
>>
>> _______________________________________________
>> Filesystem-dev mailing list
>> Filesystem-devhelixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev
> 
>
------------------------------------------------------------
------------
> 
> _______________________________________________
> Filesystem-dev mailing list
> Filesystem-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev