These changes look good.
=============================================
Eric Hyche (ehyche real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: common-dev-bounceshelixcommunity.org
> [mailto:common-dev-bounceshelixcommunity.org] On
Behalf Of
> Jamie Gordon
> Sent: Friday, July 13, 2007 2:06 PM
> To: common-devhelixcommunity.org;
> filesystem-devhelixcommunity.org; Vijendra
> Subject: [Common-dev] [Fwd: CR:Fix for PR: 195696: CA
on
> linux and HBF on solaris when retrieving invalid HTTP
URL
>
> Forwarding CR from Vijendra
>
>
>
> Synopsis
> ---------
>
>
> This CR includes fix for PR: 195696: Server gives CA on
linux
> and HBF on
> solaris when retrieving invalid HTTP URL
>
> Branch: HEAD
>
> Suggested Reviewer: Anyone
>
> Description
> ------------
> 1. I send a setup request with x-wap-profile contain
invalid URL.
>
> It tries to connect to web server. But as URL is wrong
it is
> not able to
> connect. In solaris case in method hx_connect
(netdrv.cpp) it returns
> connection refused as error so returning -1 from
hx_connect
> While in win
> and on linux it return wouldblock, returning 1 from
hx_connect.
>
> This stack of hx_connect is : sockimp.cpp:
AttempConnect
> sockimp.cpp: ConnecToOne
> netdrv.cpp:hx_connect
>
> In case of failure ConnectToOne method returns an error
to
> AttemptConnect.
> AttempConnect method checks its return type. if error
then it goes to
> FinishEnumeration function passing status as HXR_OK to
it.
> That?s wrong.
> It should return the status got from hx_connect.
>
>
> 2. If I send a valid url in x-wap-porfile then too
server is
> not sending
> any response in case of solaris.
> I found the problem is in _WriteRequestChunk method of
> httpfsys.cpp file.
> There it was trying to find the total size of request
which
> it was getting
> zero.
>
> Fix
> -------
>
> 1. Assign the status return from ConnectToOne to status
variable.
> 2. Move the line calculating the totalRequestSize in
BeginGet
> function of
> httpfsys.cpp.
>
> Files Affected
> -----------------
>
> filesystem/http/httpfsys.cpp
> common/netio/platform/posix/sockimp.cpp
>
>
> Testing Performed
> -------------------
>
>
> Functional Tests:
> ------------------
>
> - Verified by sending setup request with invalid url to
> x-wap-profile and
> getting response back and server not giving HBF.
>
> - Verified by sending setup request with valid url to
> x-wap-profile and
> getting response back and server not giving HBF.
>
> Integration Tests:
> - None
>
>
> Leak Tests:
> - None
>
> Performance Tests:
>
> - None
>
>
> Build Verified:
> ---------------
> win32-i386-vc7
> linux-rhel4-i686
> sunos-5.10-sparc-server
>
>
> Platform Tested:
> ----------------
> sunos-5.10-sparc-server
>
> QA hints
> --------
>
> - None.
>
> Thanks
>
> Vijendra.
>
>
>
_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev
|
