List Info

Thread: CR: Fix to distinguish user forced stop and normal playback complete(clip played ti




CR: Fix to distinguish user forced stop and normal playback complete(clip played ti
user name
2007-08-31 18:02:25

"Nokia submits this code under the terms of a commercial contribution agreement with RealNetworks, and I am authorized to contribute this code under said agreement."

    Modified by:  Praveen.Thimmashettynokia.com

    Reviewed by:

    Date: 31-August-2007

    Project: SymbianMmf

      ErrorId: TBD

               ;
    Synopsis:  CR: Fix to distinguish user forced stop and normal playback complete (clip played till the end) for Enhanced media client case in helix audio controller.

    There is a need to distinguish user forced stop and normal playback complete (clip played till the end) for Enhanced media client case in helix audio controller.

    Enhanced media client wants to perform certain set of functions based on these distinction.

    When stop is called by EMC, since helix audio controller treat it as pause to engine, we get a paused event from engine.

    We need to have necessary check during on pause event from engine at helix controller level, to return appropriate event to EMC.

    If pause was called due to user forced stop, then we have to return Stopped event back to EMC.

    Whenever seek call on Multimedia Data Source fails, method has to leave with error code that received from Multimedia Data Source. 

    Updated ReadDone method, to fix multiple release of the same buffer on error case in minifileobj.cpp.

    Root Cause of the problem: Implementation
     
    Files Modified:
    clientapps/symbianMmf/audiocontroller/hxmmfaudioctrl.cpp
    clientapps/symbianMmf/common/hxmmfbasectrl.cpp
    clientapps/symbianMmf/common/hxmmfbasectrl.h
    common/fileio/platform/symbian/HxMMDataSource.cpp
    filesystem/local/mini/minifileobj.cpp

    Image Size and Heap Use impact: no major impact

    Module Release testing (STIF) :  Passed.

    Test case(s) Added ; :  No.

    Memory leak check performed : Yes.  No new leaks introduced.

    Platforms and Profiles Build Verified: helix-client-s60-32-mmf-mdf-arm

    Platforms and Profiles Functionality verified: armv5,winscw

      Branch: Head & 210CayS
<<diff.txt>&gt;

  
CR: Fix to distinguish user forced stop and normalplayback complet
country flaguser name
United States
2007-09-10 08:51:54
Looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: common-dev-bounceshelixcommunity.org 
> [mailto:common-dev-bounceshelixcommunity.org] On
Behalf Of 
> Praveen.Thimmashettynokia.com
> Sent: Friday, August 31, 2007 7:02 PM
> To: clientapps-devhelixcommunity.org; 
> common-devhelixcommunity.org; filesystem-devhelixcommunity.org
> Subject: [Common-dev] CR: Fix to distinguish user
forced stop 
> and normalplayback complete(clip played till the end)
for 
> Enhancedmedia client case in helix audio controller
> 
> 
> "Nokia submits this code under the terms of a
commercial 
> contribution agreement with RealNetworks, and I am
authorized 
> to contribute this code under said agreement."
> 
> 	Modified by:  Praveen.Thimmashettynokia.com

> 
> 	Reviewed by: 
> 
> 	Date: 31-August-2007 
> 
> 	Project: SymbianMmf 
> 
>       ErrorId: TBD 
> 
> 	            
> 	Synopsis:  CR: Fix to distinguish user forced stop and

> normal playback complete (clip played till the end) for

> Enhanced media client case in helix audio controller.
> 
> 	There is a need to distinguish user forced stop and 
> normal playback complete (clip played till the end) for

> Enhanced media client case in helix audio controller.
> 
> 	Enhanced media client wants to perform certain set of

> functions based on these distinction. 
> 
> 	When stop is called by EMC, since helix audio 
> controller treat it as pause to engine, we get a paused
event 
> from engine. 
> 
> 	We need to have necessary check during on pause event

> from engine at helix controller level, to return
appropriate 
> event to EMC.
> 
> 	If pause was called due to user forced stop, then we 
> have to return Stopped event back to EMC. 
> 
> 	Whenever seek call on Multimedia Data Source fails, 
> method has to leave with error code that received from

> Multimedia Data Source.  
> 
> 	Updated ReadDone method, to fix multiple release of
the 
> same buffer on error case in minifileobj.cpp. 
> 
> 	Root Cause of the problem: Implementation 
> 	  
> 	Files Modified: 
>
	clientapps/symbianMmf/audiocontroller/hxmmfaudioctrl.cpp 
> 	clientapps/symbianMmf/common/hxmmfbasectrl.cpp 
> 	clientapps/symbianMmf/common/hxmmfbasectrl.h 
> 	common/fileio/platform/symbian/HxMMDataSource.cpp 
> 	filesystem/local/mini/minifileobj.cpp 
> 
> 	Image Size and Heap Use impact: no major impact 
> 
> 	Module Release testing (STIF) :  Passed. 
> 
> 	Test case(s) Added  :  No. 
> 
> 	Memory leak check performed : Yes.  No new leaks
introduced. 
> 
> 	Platforms and Profiles Build Verified: 
> helix-client-s60-32-mmf-mdf-arm 
> 
> 	Platforms and Profiles Functionality verified:
armv5,winscw 
> 
>       Branch: Head & 210CayS 
> <<diff.txt>> 
> 
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )