CR: http filesys - Part 2 - Handling of Resource Map

Shouldn't your change be inside if
defined(HELIX_CONFIG_NOSTATICS)
like below?

 -475,6
+475,12 
 
 CHTTPFileSystem::~CHTTPFileSystem()
 {
+if defined(HELIX_CONFIG_NOSTATICS)
+    CChunkyResMap *pChunkyResMap  =
GetGlobalCChunkyResMap();
+	if ( pChunkyResMap )
+	{
+		delete pChunkyResMap;
+	}
+#endif

     HX_RELEASE(m_pContext);
     HX_RELEASE(m_pOptions);
 }


=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: filesystem-dev-bounceshelixcommunity.org 
> [mailto:filesystem-dev-bounceshelixcommunity.org] On
Behalf 
> Of Praveen.Thimmashettynokia.com
> Sent: Thursday, February 14, 2008 6:55 PM
> To: filesystem-devhelixcommunity.org
> Subject: [Filesystem-dev] CR: http filesys - Part 2 - 
> Handling of ResourceMap
> 
> "Nokia submits this code under the terms of a
commercial 
> contribution agreement with RealNetworks, and I am
authorized 
> to contribute this code under said agreement."
> 
> 	Modified by:  Praveen.Thimmashettynokia.com

> 
> 	Reviewed by: 
> 
> 	Date: 14-February-2008 
> 
> 	Project: SymbianMmf 
> 
>       ErrorId: SUB 409-795 
> 
> 	            
> 	Synopsis:  CR: http filesys - Part 2 - Handling of
Resource Map 
> 	                        Handling of resource map
added. 
> 	                                        
> 	Root Cause of the problem: New Feature 
> 	  
> 	Files Modified: 
> 	filesystemhttphttpfsys.cpp 
> 
> 
> 	New files added: 
> 	None. 
> 
> 
> 	Image Size and Heap Use impact: no major impact 
> 
> 	Module Release testing (STIF) :  Passed. 
> 
> 	Test case(s) Added  :  No. 
> 
> 	Memory leak check performed : Yes.  No new leaks
introduced. 
> 
> 	Platforms and Profiles Build Verified: 
> helix-client-s60-50-mmf-mdf-arm 
> 
> 	Platforms and Profiles Functionality verified:
armv5,winscw 
> 
>       Branch: Head & 210cays 
> <<diff.txt>> 
> 
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

Hi Eric,
I will make the changes you suggested and check it in.

Thanks
Praveen 

-----Original Message-----
From: ext Eric Hyche [mailto:ehychereal.com] 
Sent: Friday, February 15, 2008 9:31 AM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-devhelixcommunity.org
Subject: RE: [Filesystem-dev] CR: http filesys - Part 2 -
Handling of
ResourceMap


Shouldn't your change be inside if
defined(HELIX_CONFIG_NOSTATICS) like
below?

 -475,6
+475,12 
 
 CHTTPFileSystem::~CHTTPFileSystem()
 {
+if defined(HELIX_CONFIG_NOSTATICS)
+    CChunkyResMap *pChunkyResMap  =
GetGlobalCChunkyResMap();
+	if ( pChunkyResMap )
+	{
+		delete pChunkyResMap;
+	}
+#endif

     HX_RELEASE(m_pContext);
     HX_RELEASE(m_pOptions);
 }


=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: filesystem-dev-bounceshelixcommunity.org
> [mailto:filesystem-dev-bounceshelixcommunity.org] On
Behalf Of 
> Praveen.Thimmashettynokia.com
> Sent: Thursday, February 14, 2008 6:55 PM
> To: filesystem-devhelixcommunity.org
> Subject: [Filesystem-dev] CR: http filesys - Part 2 -
Handling of 
> ResourceMap
> 
> "Nokia submits this code under the terms of a
commercial contribution 
> agreement with RealNetworks, and I am authorized to
contribute this 
> code under said agreement."
> 
> 	Modified by:  Praveen.Thimmashettynokia.com
> 
> 	Reviewed by: 
> 
> 	Date: 14-February-2008
> 
> 	Project: SymbianMmf
> 
>       ErrorId: SUB 409-795
> 
> 	            
> 	Synopsis:  CR: http filesys - Part 2 - Handling of
Resource Map 
> 	                        Handling of resource map
added. 
> 	                                        
> 	Root Cause of the problem: New Feature
> 	  
> 	Files Modified: 
> 	filesystemhttphttpfsys.cpp
> 
> 
> 	New files added: 
> 	None. 
> 
> 
> 	Image Size and Heap Use impact: no major impact
> 
> 	Module Release testing (STIF) :  Passed. 
> 
> 	Test case(s) Added  :  No. 
> 
> 	Memory leak check performed : Yes.  No new leaks
introduced. 
> 
> 	Platforms and Profiles Build Verified: 
> helix-client-s60-50-mmf-mdf-arm
> 
> 	Platforms and Profiles Functionality verified:
armv5,winscw
> 
>       Branch: Head & 210cays
> <<diff.txt>>
> 
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev