List Info

Thread: CR: Filesystem changes for eAAC+ Support for Internet Radio




CR: Filesystem changes for eAAC+ Support for Internet Radio
user name
2008-03-21 16:37:05

"Nokia submits this code under the terms of a commercial contribution agreement with RealNetworks, and I am authorized to contribute this code under said agreement."

    Modified by:  Praveen.Thimmashettynokia.com

    Reviewed by:

    Date: 21-March-2008

    Project: SymbianMmf

      ErrorId: SUB 409-795

               ;
    Synopsis:  CR: File system changes for eAAC+ Support for Internet Radio

    Updated HTTP file system to support metadata handling for eAAC+ shoutcast streams.

        ;           
    Root Cause of the problem: New Feature
     
    Files Modified:

    Commonutildbcs.cpp
    Commonutilpubdbcs.h
    Filesystemhttpfactory.cpp
    Filesystemhttphttpfsys.cpp
    Filesystemhttphttpfsys.h

    New files added:
    None.


    Image Size and Heap Use impact: no major impact

    Module Release testing (STIF) :  Passed.

    Test case(s) Added ; :  No.

    Memory leak check performed : Yes.  No new leaks introduced.

    Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-arm

    Platforms and Profiles Functionality verified: armv5,winscw

      Branch: 210CayS, Head
<<filesystem_diff.txt>&gt;


  
CN: CR: Filesystem changes for eAAC+ SupportforInternet Radio
user name
2008-03-25 15:44:06
Hi Eric,

I have checked into head and 210CayS.
I did add if check.

Thanks
Praveen 

Index: hxmmfstatectrl.cpp
============================================================
=======
RCS file:
/cvsroot/clientapps/symbianMmf/hxmmfstatectrl.cpp,v
retrieving revision 1.28
diff -w -u -b -r1.28 hxmmfstatectrl.cpp
 -319,14
+319,7 
         
         ShutDownAP();
         HX_RELEASE(m_pCCF);
+        if(m_pTitleChangeObs)
+        {
           
m_pTitleChangeObs->ClearWatchByName("Title");
+        }
+        if(m_pAuthorChangeObs)
+        {            
           
m_pAuthorChangeObs->ClearWatchByName("Author");

+        }


-----Original Message-----
From: ext Eric Hyche [mailto:ehychereal.com] 
Sent: Tuesday, March 25, 2008 9:22 AM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-devhelixcommunity.org
Subject: RE: [Filesystem-dev] CR: Filesystem changes for
eAAC+
SupportforInternet Radio


Looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Praveen.Thimmashettynokia.com
> [mailto:Praveen.Thimmashettynokia.com]
> Sent: Monday, March 24, 2008 7:14 PM
> To: ehychereal.com; filesystem-devhelixcommunity.org
> Subject: RE: [Filesystem-dev] CR: Filesystem changes
for
> eAAC+ SupportforInternet Radio
> 
> Hi Eric,
> 
> Please find the updated diff file, I have used 
> CStatisticEntry for cases
> while HELIX_FEATURE_STATS flag is not defined.
> 
> Thanks
> Praveen  
> 
> -----Original Message-----
> From: filesystem-dev-bounceshelixcommunity.org
> [mailto:filesystem-dev-bounceshelixcommunity.org] 
> Sent: Monday, March 24, 2008 11:30 AM
> To: ehychereal.com; filesystem-devhelixcommunity.org
> Subject: RE: [Filesystem-dev] CR: Filesystem changes
for eAAC+
> SupportforInternet Radio
> 
> Hi Eric,
> We are indeed making use of PLAYER_STATS for the
statinfo.cpp while
> HELIX_FEATURE_STATS flag is enabled. Whenever we do not
have
> HELIX_FEATURE_STATS flag around, all we need is two
entry in registry.
> For this case, We can still have two member variable of
type
> CStatisticEntry for each entry in the registry. This
will add one more
> level of wrapper to registry operations. 
> 
> Let me know your thoughts on this.
> 
> Thanks
> Praveen
> 
> 
> -----Original Message-----
> From: ext Eric Hyche [mailto:ehychereal.com]
> Sent: Monday, March 24, 2008 9:45 AM
> To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
> filesystem-devhelixcommunity.org
> Subject: RE: [Filesystem-dev] CR: Filesystem changes
for eAAC+ Support
> forInternet Radio
> 
> 
> Can you re-use SOURCE_STATS in
commoncontainerstatinfo.cpp or
> CStatisticEntry in the same file?
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: filesystem-dev-bounceshelixcommunity.org
> > [mailto:filesystem-dev-bounceshelixcommunity.org] On Behalf Of 
> > Praveen.Thimmashettynokia.com
> > Sent: Friday, March 21, 2008 5:37 PM
> > To: filesystem-devhelixcommunity.org
> > Subject: [Filesystem-dev] CR: Filesystem changes
for eAAC+ Support 
> > forInternet Radio
> > 
> > "Nokia submits this code under the terms of a
commercial 
> contribution 
> > agreement with RealNetworks, and I am authorized
to contribute this 
> > code under said agreement."
> > 
> > 	Modified by:  Praveen.Thimmashettynokia.com
> > 
> > 	Reviewed by: 
> > 
> > 	Date: 21-March-2008
> > 
> > 	Project: SymbianMmf
> > 
> >       ErrorId: SUB 409-795
> > 
> > 	            
> > 	Synopsis:  CR: File system changes for eAAC+
Support for
> Internet 
> > Radio
> > 
> > 	Updated HTTP file system to support metadata
handling for eAAC+ 
> > shoutcast streams.
> > 
> > 	                
> > 	Root Cause of the problem: New Feature
> > 	  
> > 	Files Modified: 
> > 
> > 	Commonutildbcs.cpp 
> > 	Commonutilpubdbcs.h 
> > 	Filesystemhttpfactory.cpp 
> > 	Filesystemhttphttpfsys.cpp 
> > 	Filesystemhttphttpfsys.h
> > 
> > 	New files added: 
> > 	None. 
> > 
> > 
> > 	Image Size and Heap Use impact: no major impact
> > 
> > 	Module Release testing (STIF) :  Passed. 
> > 
> > 	Test case(s) Added  :  No. 
> > 
> > 	Memory leak check performed : Yes.  No new leaks
introduced. 
> > 
> > 	Platforms and Profiles Build Verified: 
> > helix-client-s60-50-mmf-mdf-arm
> > 
> > 	Platforms and Profiles Functionality verified:
armv5,winscw
> > 
> >       Branch: 210CayS, Head
> > <<filesystem_diff.txt>>
> > 
> > 
> > 
> 
> 
> _______________________________________________
> Filesystem-dev mailing list
> Filesystem-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

RE: CR: Filesystem changes for eAAC+ Support forInternet Radio
country flaguser name
United States
2008-03-24 09:45:06
Can you re-use SOURCE_STATS in
commoncontainerstatinfo.cpp
or CStatisticEntry in the same file?

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: filesystem-dev-bounceshelixcommunity.org 
> [mailto:filesystem-dev-bounceshelixcommunity.org] On
Behalf 
> Of Praveen.Thimmashettynokia.com
> Sent: Friday, March 21, 2008 5:37 PM
> To: filesystem-devhelixcommunity.org
> Subject: [Filesystem-dev] CR: Filesystem changes for
eAAC+ 
> Support forInternet Radio
> 
> "Nokia submits this code under the terms of a
commercial 
> contribution agreement with RealNetworks, and I am
authorized 
> to contribute this code under said agreement."
> 
> 	Modified by:  Praveen.Thimmashettynokia.com

> 
> 	Reviewed by: 
> 
> 	Date: 21-March-2008 
> 
> 	Project: SymbianMmf 
> 
>       ErrorId: SUB 409-795 
> 
> 	            
> 	Synopsis:  CR: File system changes for eAAC+ Support 
> for Internet Radio 
> 
> 	Updated HTTP file system to support metadata handling

> for eAAC+ shoutcast streams. 
> 
> 	                
> 	Root Cause of the problem: New Feature 
> 	  
> 	Files Modified: 
> 
> 	Commonutildbcs.cpp 
> 	Commonutilpubdbcs.h 
> 	Filesystemhttpfactory.cpp 
> 	Filesystemhttphttpfsys.cpp 
> 	Filesystemhttphttpfsys.h 
> 
> 	New files added: 
> 	None. 
> 
> 
> 	Image Size and Heap Use impact: no major impact 
> 
> 	Module Release testing (STIF) :  Passed. 
> 
> 	Test case(s) Added  :  No. 
> 
> 	Memory leak check performed : Yes.  No new leaks
introduced. 
> 
> 	Platforms and Profiles Build Verified: 
> helix-client-s60-50-mmf-mdf-arm 
> 
> 	Platforms and Profiles Functionality verified:
armv5,winscw 
> 
>       Branch: 210CayS, Head 
> <<filesystem_diff.txt>> 
> 
> 
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

RE: CR: Filesystem changes for eAAC+ SupportforInternet Radio
user name
2008-03-24 18:13:31
Hi Eric,

Please find the updated diff file, I have used
CStatisticEntry for cases
while HELIX_FEATURE_STATS flag is not defined.

Thanks
Praveen  

-----Original Message-----
From: filesystem-dev-bounceshelixcommunity.org
[mailto:filesystem-dev-bounceshelixcommunity.org] 
Sent: Monday, March 24, 2008 11:30 AM
To: ehychereal.com; filesystem-devhelixcommunity.org
Subject: RE: [Filesystem-dev] CR: Filesystem changes for
eAAC+
SupportforInternet Radio

Hi Eric,
We are indeed making use of PLAYER_STATS for the
statinfo.cpp while
HELIX_FEATURE_STATS flag is enabled. Whenever we do not
have
HELIX_FEATURE_STATS flag around, all we need is two entry in
registry.
For this case, We can still have two member variable of
type
CStatisticEntry for each entry in the registry. This will
add one more
level of wrapper to registry operations. 

Let me know your thoughts on this.

Thanks
Praveen


-----Original Message-----
From: ext Eric Hyche [mailto:ehychereal.com]
Sent: Monday, March 24, 2008 9:45 AM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-devhelixcommunity.org
Subject: RE: [Filesystem-dev] CR: Filesystem changes for
eAAC+ Support
forInternet Radio


Can you re-use SOURCE_STATS in commoncontainerstatinfo.cpp
or
CStatisticEntry in the same file?

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: filesystem-dev-bounceshelixcommunity.org
> [mailto:filesystem-dev-bounceshelixcommunity.org] On
Behalf Of 
> Praveen.Thimmashettynokia.com
> Sent: Friday, March 21, 2008 5:37 PM
> To: filesystem-devhelixcommunity.org
> Subject: [Filesystem-dev] CR: Filesystem changes for
eAAC+ Support 
> forInternet Radio
> 
> "Nokia submits this code under the terms of a
commercial contribution 
> agreement with RealNetworks, and I am authorized to
contribute this 
> code under said agreement."
> 
> 	Modified by:  Praveen.Thimmashettynokia.com
> 
> 	Reviewed by: 
> 
> 	Date: 21-March-2008
> 
> 	Project: SymbianMmf
> 
>       ErrorId: SUB 409-795
> 
> 	            
> 	Synopsis:  CR: File system changes for eAAC+ Support
for
Internet 
> Radio
> 
> 	Updated HTTP file system to support metadata handling
for eAAC+ 
> shoutcast streams.
> 
> 	                
> 	Root Cause of the problem: New Feature
> 	  
> 	Files Modified: 
> 
> 	Commonutildbcs.cpp 
> 	Commonutilpubdbcs.h 
> 	Filesystemhttpfactory.cpp 
> 	Filesystemhttphttpfsys.cpp 
> 	Filesystemhttphttpfsys.h
> 
> 	New files added: 
> 	None. 
> 
> 
> 	Image Size and Heap Use impact: no major impact
> 
> 	Module Release testing (STIF) :  Passed. 
> 
> 	Test case(s) Added  :  No. 
> 
> 	Memory leak check performed : Yes.  No new leaks
introduced. 
> 
> 	Platforms and Profiles Build Verified: 
> helix-client-s60-50-mmf-mdf-arm
> 
> 	Platforms and Profiles Functionality verified:
armv5,winscw
> 
>       Branch: 210CayS, Head
> <<filesystem_diff.txt>>
> 
> 
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

  
RE: CR: Filesystem changes for eAAC+ SupportforInternet Radio
user name
2008-03-24 18:30:23
Hi Eric,

Please find the updated diff file, I have used
CStatisticEntry for cases
while HELIX_FEATURE_STATS flag is not defined.

Thanks
Praveen
 

-----Original Message-----
From: filesystem-dev-bounceshelixcommunity.org
[mailto:filesystem-dev-bounceshelixcommunity.org] 
Sent: Monday, March 24, 2008 11:30 AM
To: ehychereal.com; filesystem-devhelixcommunity.org
Subject: RE: [Filesystem-dev] CR: Filesystem changes for
eAAC+
SupportforInternet Radio

Hi Eric,
We are indeed making use of PLAYER_STATS for the
statinfo.cpp while
HELIX_FEATURE_STATS flag is enabled. Whenever we do not
have
HELIX_FEATURE_STATS flag around, all we need is two entry in
registry.
For this case, We can still have two member variable of
type
CStatisticEntry for each entry in the registry. This will
add one more
level of wrapper to registry operations. 

Let me know your thoughts on this.

Thanks
Praveen


-----Original Message-----
From: ext Eric Hyche [mailto:ehychereal.com]
Sent: Monday, March 24, 2008 9:45 AM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-devhelixcommunity.org
Subject: RE: [Filesystem-dev] CR: Filesystem changes for
eAAC+ Support
forInternet Radio


Can you re-use SOURCE_STATS in commoncontainerstatinfo.cpp
or
CStatisticEntry in the same file?

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: filesystem-dev-bounceshelixcommunity.org
> [mailto:filesystem-dev-bounceshelixcommunity.org] On
Behalf Of 
> Praveen.Thimmashettynokia.com
> Sent: Friday, March 21, 2008 5:37 PM
> To: filesystem-devhelixcommunity.org
> Subject: [Filesystem-dev] CR: Filesystem changes for
eAAC+ Support 
> forInternet Radio
> 
> "Nokia submits this code under the terms of a
commercial contribution 
> agreement with RealNetworks, and I am authorized to
contribute this 
> code under said agreement."
> 
> 	Modified by:  Praveen.Thimmashettynokia.com
> 
> 	Reviewed by: 
> 
> 	Date: 21-March-2008
> 
> 	Project: SymbianMmf
> 
>       ErrorId: SUB 409-795
> 
> 	            
> 	Synopsis:  CR: File system changes for eAAC+ Support
for
Internet 
> Radio
> 
> 	Updated HTTP file system to support metadata handling
for eAAC+ 
> shoutcast streams.
> 
> 	                
> 	Root Cause of the problem: New Feature
> 	  
> 	Files Modified: 
> 
> 	Commonutildbcs.cpp 
> 	Commonutilpubdbcs.h 
> 	Filesystemhttpfactory.cpp 
> 	Filesystemhttphttpfsys.cpp 
> 	Filesystemhttphttpfsys.h
> 
> 	New files added: 
> 	None. 
> 
> 
> 	Image Size and Heap Use impact: no major impact
> 
> 	Module Release testing (STIF) :  Passed. 
> 
> 	Test case(s) Added  :  No. 
> 
> 	Memory leak check performed : Yes.  No new leaks
introduced. 
> 
> 	Platforms and Profiles Build Verified: 
> helix-client-s60-50-mmf-mdf-arm
> 
> 	Platforms and Profiles Functionality verified:
armv5,winscw
> 
>       Branch: 210CayS, Head
> <<filesystem_diff.txt>>
> 
> 
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

  
RE: CR: Filesystem changes for eAAC+ Support forInternet Radio
country flaguser name
United States
2008-03-24 11:41:19
I think it would be good to re-use CStatisticEntry whenever
possible.

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Praveen.Thimmashettynokia.com 
> [mailto:Praveen.Thimmashettynokia.com] 
> Sent: Monday, March 24, 2008 12:30 PM
> To: ehychereal.com; filesystem-devhelixcommunity.org
> Subject: RE: [Filesystem-dev] CR: Filesystem changes
for 
> eAAC+ Support forInternet Radio
> 
> Hi Eric,
> We are indeed making use of PLAYER_STATS for the
statinfo.cpp while
> HELIX_FEATURE_STATS flag is enabled. Whenever we do not
have
> HELIX_FEATURE_STATS flag around, all we need is two
entry in registry.
> For this case, We can still have two member variable of
type
> CStatisticEntry for each entry in the registry. This
will add one more
> level of wrapper to registry operations. 
> 
> Let me know your thoughts on this.
> 
> Thanks
> Praveen
> 
> 
> -----Original Message-----
> From: ext Eric Hyche [mailto:ehychereal.com]

> Sent: Monday, March 24, 2008 9:45 AM
> To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
> filesystem-devhelixcommunity.org
> Subject: RE: [Filesystem-dev] CR: Filesystem changes
for eAAC+ Support
> forInternet Radio
> 
> 
> Can you re-use SOURCE_STATS in
commoncontainerstatinfo.cpp or
> CStatisticEntry in the same file?
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: filesystem-dev-bounceshelixcommunity.org
> > [mailto:filesystem-dev-bounceshelixcommunity.org] On Behalf Of 
> > Praveen.Thimmashettynokia.com
> > Sent: Friday, March 21, 2008 5:37 PM
> > To: filesystem-devhelixcommunity.org
> > Subject: [Filesystem-dev] CR: Filesystem changes
for eAAC+ Support 
> > forInternet Radio
> > 
> > "Nokia submits this code under the terms of a
commercial 
> contribution 
> > agreement with RealNetworks, and I am authorized
to contribute this 
> > code under said agreement."
> > 
> > 	Modified by:  Praveen.Thimmashettynokia.com
> > 
> > 	Reviewed by: 
> > 
> > 	Date: 21-March-2008
> > 
> > 	Project: SymbianMmf
> > 
> >       ErrorId: SUB 409-795
> > 
> > 	            
> > 	Synopsis:  CR: File system changes for eAAC+
Support for
> Internet 
> > Radio
> > 
> > 	Updated HTTP file system to support metadata
handling for eAAC+ 
> > shoutcast streams.
> > 
> > 	                
> > 	Root Cause of the problem: New Feature
> > 	  
> > 	Files Modified: 
> > 
> > 	Commonutildbcs.cpp 
> > 	Commonutilpubdbcs.h 
> > 	Filesystemhttpfactory.cpp 
> > 	Filesystemhttphttpfsys.cpp 
> > 	Filesystemhttphttpfsys.h
> > 
> > 	New files added: 
> > 	None. 
> > 
> > 
> > 	Image Size and Heap Use impact: no major impact
> > 
> > 	Module Release testing (STIF) :  Passed. 
> > 
> > 	Test case(s) Added  :  No. 
> > 
> > 	Memory leak check performed : Yes.  No new leaks
introduced. 
> > 
> > 	Platforms and Profiles Build Verified: 
> > helix-client-s60-50-mmf-mdf-arm
> > 
> > 	Platforms and Profiles Functionality verified:
armv5,winscw
> > 
> >       Branch: 210CayS, Head
> > <<filesystem_diff.txt>>
> > 
> > 
> > 
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

RE: CR: Filesystem changes for eAAC+ Support forInternet Radio
user name
2008-03-24 11:29:58
Hi Eric,
We are indeed making use of PLAYER_STATS for the
statinfo.cpp while
HELIX_FEATURE_STATS flag is enabled. Whenever we do not
have
HELIX_FEATURE_STATS flag around, all we need is two entry in
registry.
For this case, We can still have two member variable of
type
CStatisticEntry for each entry in the registry. This will
add one more
level of wrapper to registry operations. 

Let me know your thoughts on this.

Thanks
Praveen


-----Original Message-----
From: ext Eric Hyche [mailto:ehychereal.com] 
Sent: Monday, March 24, 2008 9:45 AM
To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
filesystem-devhelixcommunity.org
Subject: RE: [Filesystem-dev] CR: Filesystem changes for
eAAC+ Support
forInternet Radio


Can you re-use SOURCE_STATS in commoncontainerstatinfo.cpp
or
CStatisticEntry in the same file?

Eric

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: filesystem-dev-bounceshelixcommunity.org
> [mailto:filesystem-dev-bounceshelixcommunity.org] On
Behalf Of 
> Praveen.Thimmashettynokia.com
> Sent: Friday, March 21, 2008 5:37 PM
> To: filesystem-devhelixcommunity.org
> Subject: [Filesystem-dev] CR: Filesystem changes for
eAAC+ Support 
> forInternet Radio
> 
> "Nokia submits this code under the terms of a
commercial contribution 
> agreement with RealNetworks, and I am authorized to
contribute this 
> code under said agreement."
> 
> 	Modified by:  Praveen.Thimmashettynokia.com
> 
> 	Reviewed by: 
> 
> 	Date: 21-March-2008
> 
> 	Project: SymbianMmf
> 
>       ErrorId: SUB 409-795
> 
> 	            
> 	Synopsis:  CR: File system changes for eAAC+ Support
for
Internet 
> Radio
> 
> 	Updated HTTP file system to support metadata handling
for eAAC+ 
> shoutcast streams.
> 
> 	                
> 	Root Cause of the problem: New Feature
> 	  
> 	Files Modified: 
> 
> 	Commonutildbcs.cpp 
> 	Commonutilpubdbcs.h 
> 	Filesystemhttpfactory.cpp 
> 	Filesystemhttphttpfsys.cpp 
> 	Filesystemhttphttpfsys.h
> 
> 	New files added: 
> 	None. 
> 
> 
> 	Image Size and Heap Use impact: no major impact
> 
> 	Module Release testing (STIF) :  Passed. 
> 
> 	Test case(s) Added  :  No. 
> 
> 	Memory leak check performed : Yes.  No new leaks
introduced. 
> 
> 	Platforms and Profiles Build Verified: 
> helix-client-s60-50-mmf-mdf-arm
> 
> 	Platforms and Profiles Functionality verified:
armv5,winscw
> 
>       Branch: 210CayS, Head
> <<filesystem_diff.txt>>
> 
> 
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

RE: CR: Filesystem changes for eAAC+ SupportforInternet Radio
country flaguser name
United States
2008-03-25 09:21:40
Looks good.

=============================================
Eric Hyche (ehychereal.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Praveen.Thimmashettynokia.com 
> [mailto:Praveen.Thimmashettynokia.com] 
> Sent: Monday, March 24, 2008 7:14 PM
> To: ehychereal.com; filesystem-devhelixcommunity.org
> Subject: RE: [Filesystem-dev] CR: Filesystem changes
for 
> eAAC+ SupportforInternet Radio
> 
> Hi Eric,
> 
> Please find the updated diff file, I have used 
> CStatisticEntry for cases
> while HELIX_FEATURE_STATS flag is not defined.
> 
> Thanks
> Praveen  
> 
> -----Original Message-----
> From: filesystem-dev-bounceshelixcommunity.org
> [mailto:filesystem-dev-bounceshelixcommunity.org] 
> Sent: Monday, March 24, 2008 11:30 AM
> To: ehychereal.com; filesystem-devhelixcommunity.org
> Subject: RE: [Filesystem-dev] CR: Filesystem changes
for eAAC+
> SupportforInternet Radio
> 
> Hi Eric,
> We are indeed making use of PLAYER_STATS for the
statinfo.cpp while
> HELIX_FEATURE_STATS flag is enabled. Whenever we do not
have
> HELIX_FEATURE_STATS flag around, all we need is two
entry in registry.
> For this case, We can still have two member variable of
type
> CStatisticEntry for each entry in the registry. This
will add one more
> level of wrapper to registry operations. 
> 
> Let me know your thoughts on this.
> 
> Thanks
> Praveen
> 
> 
> -----Original Message-----
> From: ext Eric Hyche [mailto:ehychereal.com]
> Sent: Monday, March 24, 2008 9:45 AM
> To: Thimmashetty Praveen (Nokia-D-MSW/Dallas);
> filesystem-devhelixcommunity.org
> Subject: RE: [Filesystem-dev] CR: Filesystem changes
for eAAC+ Support
> forInternet Radio
> 
> 
> Can you re-use SOURCE_STATS in
commoncontainerstatinfo.cpp or
> CStatisticEntry in the same file?
> 
> Eric
> 
> =============================================
> Eric Hyche (ehychereal.com)
> Technical Lead
> RealNetworks, Inc.  
> 
> > -----Original Message-----
> > From: filesystem-dev-bounceshelixcommunity.org
> > [mailto:filesystem-dev-bounceshelixcommunity.org] On Behalf Of 
> > Praveen.Thimmashettynokia.com
> > Sent: Friday, March 21, 2008 5:37 PM
> > To: filesystem-devhelixcommunity.org
> > Subject: [Filesystem-dev] CR: Filesystem changes
for eAAC+ Support 
> > forInternet Radio
> > 
> > "Nokia submits this code under the terms of a
commercial 
> contribution 
> > agreement with RealNetworks, and I am authorized
to contribute this 
> > code under said agreement."
> > 
> > 	Modified by:  Praveen.Thimmashettynokia.com
> > 
> > 	Reviewed by: 
> > 
> > 	Date: 21-March-2008
> > 
> > 	Project: SymbianMmf
> > 
> >       ErrorId: SUB 409-795
> > 
> > 	            
> > 	Synopsis:  CR: File system changes for eAAC+
Support for
> Internet 
> > Radio
> > 
> > 	Updated HTTP file system to support metadata
handling for eAAC+ 
> > shoutcast streams.
> > 
> > 	                
> > 	Root Cause of the problem: New Feature
> > 	  
> > 	Files Modified: 
> > 
> > 	Commonutildbcs.cpp 
> > 	Commonutilpubdbcs.h 
> > 	Filesystemhttpfactory.cpp 
> > 	Filesystemhttphttpfsys.cpp 
> > 	Filesystemhttphttpfsys.h
> > 
> > 	New files added: 
> > 	None. 
> > 
> > 
> > 	Image Size and Heap Use impact: no major impact
> > 
> > 	Module Release testing (STIF) :  Passed. 
> > 
> > 	Test case(s) Added  :  No. 
> > 
> > 	Memory leak check performed : Yes.  No new leaks
introduced. 
> > 
> > 	Platforms and Profiles Build Verified: 
> > helix-client-s60-50-mmf-mdf-arm
> > 
> > 	Platforms and Profiles Functionality verified:
armv5,winscw
> > 
> >       Branch: 210CayS, Head
> > <<filesystem_diff.txt>>
> > 
> > 
> > 
> 
> 
> _______________________________________________
> Filesystem-dev mailing list
> Filesystem-devhelixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev

[1-8]

about | contact  Other archives ( Real Estate discussion Medical topics )