Committed to Cays210, and HEAD
Thanks
Yury
>-----Original Message-----
>From: ext Eric Hyche [mailto:ehyche real.com]
>Sent: Monday, March 24, 2008 9:46 AM
>To: Ramanovich Yury (Nokia-D-MSW/Dallas);
>filesystem-devhelixcommunity.org
>Cc: nokia-private-devhelixcommunity.org
>Subject: RE: [Nokia-private-dev] CR needed: ELBA -
7CPFA9 -
>crash happens whenrestarting rtsp video streaming after
stop.
>
>
>Looks good.
>
>=============================================
>Eric Hyche (ehychereal.com)
>Technical Lead
>RealNetworks, Inc.
>
>> -----Original Message-----
>> From: nokia-private-dev-bounceshelixcommunity.org
>> [mailto:nokia-private-dev-bounceshelixcommunity.org] On Behalf Of
>> Yury.Ramanovichnokia.com
>> Sent: Friday, March 21, 2008 7:19 PM
>> To: filesystem-devhelixcommunity.org
>> Cc: nokia-private-devhelixcommunity.org
>> Subject: [Nokia-private-dev] CR needed: ELBA -
7CPFA9 -
>crash happens
>> whenrestarting rtsp video streaming after stop.
>>
>>
>> "Nokia submits this code under the terms of a
commercial
>contribution
>> agreement with RealNetworks, and I am authorized to
contribute this
>> code under said agreement."
>>
>>
>> Modified by: yury.ramanovichnokia.com
>>
>> Reviewed by:
>>
>> Date: 03/21/2008
>>
>> Project: SymbianMmf_wm
>>
>> ErrorId: ELBA - 7CPFA9
>>
>> Synopsis: crash happens when restarting rtsp video
streaming after
>> stop.
>> Overview: global ptr to pChunkyResMap was not
properly deleted in
>> CHTTPFileSystem() destructor.
>> Solution: now GetGlobalCChunkyResMap() function
returns reference to
>> global ptr
>>
>> Files modified:
>> /filesystem/http/httpfsys.cpp
>> Files added:
>> None.
>>
>> Image Size and Heap Use impact: minor.
>> Module Release testing (STIF) : Yes, Passed Test
case(s) Added : No
>>
>> Memory leak check performed : Yes. No new memory
leaks introduced.
>>
>> Platforms and Profiles Build Verified:
>> helix-client-s60-50-mmf-mdf-arm
>> Platforms and Profiles Functionality verified:
armv5, winscw
>>
>> Branch: HEAD,210CayS,221CayS
>>
>> Index: httpfsys.cpp
>>
============================================================
=======
>> RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
>> retrieving revision 1.88.2.5
>> diff -u -w -r1.88.2.5 httpfsys.cpp
>> --- httpfsys.cpp 15 Feb 2008 16:57:31 -0000
1.88.2.5
>> +++ httpfsys.cpp 21 Mar 2008 22:51:00 -0000
>> -290,7 +290,7
>> #endif
>>
>> #if defined(HELIX_CONFIG_NOSTATICS)
>> -static CChunkyResMap* GetGlobalCChunkyResMap()
>> +static CChunkyResMap*&
GetGlobalCChunkyResMap()
>> {
>>
>> static const int key = 0; // address of static
var (we
>> hope) comprises unique key id
>> -476,10 +476,10
>> CHTTPFileSystem::~CHTTPFileSystem()
>> {
>> #if defined(HELIX_CONFIG_NOSTATICS)
>> - CChunkyResMap *pChunkyResMap =
GetGlobalCChunkyResMap();
>> + CChunkyResMap*& pChunkyResMap =
GetGlobalCChunkyResMap();
>> if ( pChunkyResMap )
>> {
>> - delete pChunkyResMap;
>> + HX_DELETE(pChunkyResMap);
>> }
>> #endif
>> HX_RELEASE(m_pContext);
>>
>>
>
>
_______________________________________________
Filesystem-dev mailing list
Filesystem-devhelixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/
filesystem-dev
|