FW: Patch for recurrence on Sync4j.php

The attached file apparently didn't go through, so here it
is pasted to the
mail:

--- Sync4j.php.bak      2007-03-23 04:41:54.000000000 +0100
+++ Sync4j.php  2007-03-23 06:10:45.000000000 +0100
 -331,7
+331,14 
             switch ($a['RecurrenceType']) {
             case 0:
                 /* olDaily */
-                $freq = 'DAILY';
+                if (!empty($a['DayOfWeekMask']))
+                {//"Daily, every weekday" item
from a WM client.
+                    $freq = 'WEEKLY';
+                }
+                else
+                {
+                    $freq = 'DAILY';
+                }
                 $interval = ';INTERVAL=' . $a['Interval'];
                 break;
             case 1:

-----Oorspronkelijk bericht-----
Van: jochemmondrian-it.nl [mailto:jochemmondrian-it.nl] 
Verzonden: donderdag 22 maart 2007 14:50
Aan: synclists.horde.org
Onderwerp: [sync] Patch for recurrence on Sync4j.php

The last couple of days, I've been testing my Windows Mobile
PDA against the
horde syncml backend using the latest funambol plugin. I've
noticed that
recurrence of the type 'daily, every weekday' in WM is
handled differently
from kronolith. Kronolith assumes a daily item is supposed
to happen every
day, whereas WM/Funambol/vCard assume a daily item works
every day _unless_
the BYDAY or DayOfWeekMask values are set.

This means that when the WM recurtype 'daily, every weekday'
was used,
kronolith also displayed it's items on Saturday and Sunday.
This is ofcourse
not desirable.

I've been working with recurrence in Kronolith and vCal
format for a
separate project of mine, and have come up with the attached
patch to
SyncML/Devices/Sync4j.php to fix this bug.

I've tested this patch with both regular daily and
weekday-daily recurrence,
and so far have not been able to break the new
functionality.

Regards,

Jochem


-- 
sync mailing list - Join the hunt: http://horde.org/boun
ties/#sync
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: sync-unsubscribelists.horde.org

Quoting jochemmondrian-it.nl:

> The attached file apparently didn't go through, so here
it is pasted to the
> mail:

Can you attach this to the ticket, please?

Thanks!
-chuck

-- 
"we are plastered to the windshield of the bus that is
time." - Chris
-- 
sync mailing list - Join the hunt: http://horde.org/boun
ties/#sync
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: sync-unsubscribelists.horde.org