List Info

Thread: Some patches for the Io VM




Some patches for the Io VM
country flaguser name
Germany
2007-09-10 13:06:21

Hi everybody, esp. Steve,

as there seemingly hasn't been much development on Io lately, I thought
it might be a good time to kindly ask for inclusion of the following
patches:

1. IoObject_dealloc(): pass address of free'd object to listeners
instead of NULL
This is a bugfix. Deallocation listeners where passed a NULL value
as an argument when instead they should at least know which object
was deallocated.
2. Add IoState_addValueIfNecessary_ and modify IOCLONE to use it
Currently, when calling IoState_retain_ on an object from inside
its clone function, terrible things happen: IoState_retain will
add the object to the garbage collector. IOCLONE will call
IoState_addValue_ which will add it again, putting it inside the
garbage collector's white list. This makes the object subject to
collection!
This patch will make IoState_addValue_ detect if the object has
already been registered with the garbage collector.
3. "Tagless" functions as used by Object can be added with
IoObject_addTaglessMethodTable_
This patch adds the notion of "tagless" functions.
Currently, "Object" is the only Io object which doesn't complain
when its methods are called on an object with another "tag", or
type. This makes them every object's base functionality.
The patch opens the possibility to create other objects offering
such base functionality.

Easiest way to apply is with git-am *.patch

If you're unhappy with the way these changes were done, I will gladly
change them to suit your needs. It is very important for me to get these
changes (or equivalent ones) into the tree, as currently I am forced to
maintain a fork of Io for my game.

Cheers,
Jonas

__._,_.___
.

__,_._,___
  
  
  
Re: Some patches for the Io VM
country flaguser name
United States
2007-09-10 21:52:37


On 10 Sep 2007, at 11:06 am, Jonas Eschenburg wrote:
> Easiest way to apply is with git-am *.patch

Thanks for the patch. When I do:

git-am j.patch

I get:

"previous dotest directory .dotest still exists but mbox given."

Suggestions?

__._,_.___
.

__,_._,___
Re: Some patches for the Io VM
country flaguser name
Germany
2007-09-11 03:47:30



Steve Dekorte schrieb:
> I get:
>;
> "previous dotest directory .dotest still exists but mbox given."
>
> Suggestions?
>
The .dotest directory is where git-am saves its state when applying a
patch fails. You can then resolve the issue manually and call "git-am
--resolved" our skip the current patch and call "git-am --skip".

There is probably something from a previous batch hanging around. Have a
look at the contents.

__._,_.___
.

__,_._,___
[1-3]

about | contact  Other archives ( Real Estate discussion Medical topics )